- 13 May, 2014 40 commits
-
-
alemate@chromium.org authored
Debug messages were added in r267040 to diagnose failures. They are not needed anymore. BUG=362847 Review URL: https://codereview.chromium.org/279703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270080 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270079 0039d316-1c4b-4281-b951-d872f2087c98
-
rmcilroy@chromium.org authored
Roll android_tools, includes the following CLs: - Update ndk_experimental with latest NDK platform updates. - Remove resources for languages not supported by Chrome BUG=354405,346626 Review URL: https://codereview.chromium.org/286643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270078 0039d316-1c4b-4281-b951-d872f2087c98
-
bokan@chromium.org authored
Should be fixed by r173871 http://crrev.com/280473002 TBR=zhaoqin@chromium.org BUG=372226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269775 Review URL: https://codereview.chromium.org/276403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270077 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=318769 Review URL: https://codereview.chromium.org/270883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270076 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
Page cycler are considering page loads and not interaction with the page, so the power metric must take the page load into account. R=tonyg@chromium.org BUG=361491 Review URL: https://codereview.chromium.org/281553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270075 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
This will specifically allow screen readers to query the accessible object for the main window and quickly get a list of an alerts that are visible - for example infobars, bubbles, and the Chrome menu itself if it has an alert icon in it. BUG=369903 Review URL: https://codereview.chromium.org/266963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270074 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
NOTRY=true BUG= Review URL: https://codereview.chromium.org/289443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270073 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/283763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270071 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
BUG=354046 Review URL: https://codereview.chromium.org/251603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270070 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
These were added in http://crrev.com/218723 but without a histograms change in src/tools/metrics/histograms or src-internal/tools/histograms. The values cover the gap in measurement between when the app launcher view is created and when it actually gets painted. Similar to Startup.BrowserWindowDisplay. BUG=274049 Review URL: https://codereview.chromium.org/283603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270069 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
TBR=boliu@chromium.org NOTRY=true NOTREECHECKS=true BUG=372748 Review URL: https://codereview.chromium.org/285673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270068 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270067 0039d316-1c4b-4281-b951-d872f2087c98
-
perkj@chromium.org authored
TBR=mallinath Review URL: https://codereview.chromium.org/271703009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270066 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
Remove unnecessary special case for supervised users in browser_options_handler.cc. Make clear that some supervised user code in browser_options.js applies only to ChromeOS. BUG=372381 Review URL: https://codereview.chromium.org/279243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270064 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Not sure if this file is still used for size tracking (looks like "no"?), but seems like a good thing to do regardless. BUG=370672 TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/287603006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270063 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270062 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
r1919: ninja/mac: Update libtool noise filter for Xcode 5. BUG=372716 R=senorblanco@chromium.org TBR=senorblanco@chromium.org Review URL: https://codereview.chromium.org/276843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270061 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Review URL: https://codereview.chromium.org/271623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270060 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
Previously the test system cannot obtain the name of test cases because they are anonymous inline functions. And it causes a log like "[SUCCESS] undefined". BUG=372683 TEST=run the tests Review URL: https://codereview.chromium.org/288513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270058 0039d316-1c4b-4281-b951-d872f2087c98
-
zerny@chromium.org authored
Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDispatch. BUG=334149 R=wibling@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/278523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270057 0039d316-1c4b-4281-b951-d872f2087c98
-
hjd@google.com authored
BUG=369496 Review URL: https://codereview.chromium.org/261883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270056 0039d316-1c4b-4281-b951-d872f2087c98
-
merkulova@chromium.org authored
BUG=363836 NOTRY=true TBR=ygorshenin@chromium.org, antrim@chromium.org Review URL: https://codereview.chromium.org/273643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270055 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=370692 Review URL: https://codereview.chromium.org/287613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270053 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
BUG=347425 Review URL: https://codereview.chromium.org/268413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270052 0039d316-1c4b-4281-b951-d872f2087c98
-
kkinnunen@nvidia.com authored
Before, the Function objects (roughly corresponding to the commands being generated) would construct itself based on the function info object, parsed properties and many argument lists. The argument lists themselves were also constructed out of function info object and the parsed properties. Try to clarify this by following changes. Define that function info object is first parsed from the cmd_buffer_functions.txt file. Then the function info is possibly augmented by the optional object for the function info object table (_FUNCTION_INFO). Function objects are created solely on the function info object. Function constructor parses the function info object and constructs the needed properties, such as function type handlers, argument arrays and return value types. Function provides simple initialization function that the immediate and bucket subclasses can use to construct specialized versions of the command buffer command argument lists. Review URL: https://codereview.chromium.org/276873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270051 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
BUG=369895 Review URL: https://codereview.chromium.org/274243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270050 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
Will create a PrerenderCookieStore for each prerender, retaining all cookie operations of a prerender until the prerender is shown to the user. Forces prerenders to be in a new render process by themselves for this to work. This is a resubmission of https://codereview.chromium.org/233353003, which had to be reverted due to build breaks. See LGTM's there. BUG=371003 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/280403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270049 0039d316-1c4b-4281-b951-d872f2087c98
-
perkj@chromium.org authored
This change so that WebRtcVideoCapturerAdapter receives video frames on libjingle worker thread instead of the IO-thread. BUG= 371711, 350111 Review URL: https://codereview.chromium.org/282523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270048 0039d316-1c4b-4281-b951-d872f2087c98
-
horo@chromium.org authored
The DevToolsManagerDelegate will be used to open DevToolsWindow from ServiceWorkerInternalsUI(chrome://serviceworker-internals/). BUG=358657 Review URL: https://codereview.chromium.org/251653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270047 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
Fix a flaky EndToEndTest where packet loss is possible with a large buffer that may overrun. Merge internal change: 66821654 https://codereview.chromium.org/280383003/ QUIC change to invoke SetNotPending for retransmissions in MarkForRetransmission and a minor cleanup in UnackedPacketMap. Merge internal change: 66729074 https://codereview.chromium.org/278823005/ Remove unused IsHandshake argument to QuicConnection::OnCanWrite. Merge internal change: 66652078 https://codereview.chromium.org/286563003/ Revert of Fix a bug where if a crypto packet is spuriously retransmitted and thenneutered, it remains in missing_packets until the end of the connection. Reverted chromium cl: https://codereview.chromium.org/270213002/ Rollback of Merge internal change: 66262890. *** Reason for rollback *** This appears to have caused a major QUIC loadtest regression on internal server. Additionally, it's wrong in some other subtle ways, so rolling it back and trying a new approach. *** Original change description *** Fix a bug where if a crypto packet is spuriously retransmitted and then neutered, it remains in missing_packets until the end of the connection. *** Merge internal change: 66615668 https://codereview.chromium.org/287583002/ Revert of Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and NeuterPacket into RemoveOrNeuterPacket. Rollback of merge internal change: 66306887 Rollback of Chromium's CL https://codereview.chromium.org/271443008/ *** Reason for rollback *** After further issues with the QUIC handshake packets, rolling back this change in favor of a different approach. *** Original change description *** Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and NeuterPacket into RemoveOrNeuterPacket. This prevents potential bugs where a packet can be set not pending, then neuter'd, which cuases the packet to never be removed from the unacked packet map. *** Merge internal change: 66573334 https://codereview.chromium.org/280753002/ Merging end_to_end_test.cc with the internal source tree. + Fixed comments (MB for megabytes and 256KB per sec instead of 1Mbit). + Made LargePostWithPacketLossAndBlockedSocket and LargePostNoPacketLossWithDelayAndReordering to be in the same order as the internal source tree. Merge internal change: 66556306 https://codereview.chromium.org/283683002/ Allows QUIC connections to remain established even though the peer's port has changed. Should make things a bit better for clients experiencing NAT rebindign while talking QUIC to Bandaid. QUIC connection port migration. Protected behind FLAGS_quic_allow_port_migration Merge internal change: 66523001 https://codereview.chromium.org/279453004/ Remove unnecessary methods from QuicUnackedPacketMap and a minor QuicSentPacketManagerTest fix as a result. Merge internal change: 66427453 https://codereview.chromium.org/287443003/ R=rch@chromium.org Review URL: https://codereview.chromium.org/283693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270046 0039d316-1c4b-4281-b951-d872f2087c98
-
tmdiep@chromium.org authored
If the alwaysOnTop property is enabled, but the app.window.alwaysOnTop permission is not specified in the manifest, app window creation will now fail with an error. BUG=371213 TEST=browser_tests (PlatformAppBrowserTest.WindowsApiAlwaysOnTopNoPermissions) Review URL: https://codereview.chromium.org/274123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270045 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270044 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173886:173932&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/270583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270043 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@google.com authored
There was a small regression in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929 in the range r270006-r270012 which seems to be normal growth. This updates expectations as per http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs?pli=1#TOC-Updating-Performance-Expectations This is a followup to http://src.chromium.org/viewvc/chrome?revision=270015&view=revision which fixed linux-64 BUG=none TBR=bokan@chromium.org,qyearsley@chromium.org Review URL: https://codereview.chromium.org/282803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270042 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Previously it has shown vendor-name + volume-name + device-id where the last part does not mean anything for the end users. BUG=370692 Review URL: https://codereview.chromium.org/289443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270041 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch adds support to opening a file. It is currently no-op, and it is not yet bound to fileapi. In order to bound it to fileapi::AsyncFileUtil, we need to implement closing operation, and reading operations first. Otherwise, creating a snapshot (required by fileapi::AsyncFileUtil) is not possible. TEST=unit_tests: *FileSystemProvider*OpenFile* BUG=248427 Review URL: https://codereview.chromium.org/284443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270040 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
The perfect hash table containing all registry controlled domains is replaced by a compact graph (a dafsa) to reduce binary size and PSS of the running process. Size of the new structure is about 33kB compared to 380kB for the perfect hash table. Patch by Olle Liljenzin <ollel@opera.com>, originally at https://codereview.chromium.org/197183002/ BUG=370672 R=brettw@chromium.org Review URL: https://codereview.chromium.org/270363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270039 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
This may have caused indexed_db layout tests to start failing. > Add most of the metadata-handling code for blobs. It's not quite all there, but > this is the biggest chunk I can pull out vaguely cleanly. It does contain a > couple of fake calls to keep the compiler happy. > This CL also makes SetUpMetadata a member in order to ease testing in a later CL. > > This depends on https://codereview.chromium.org/261843004/. > > BUG=108012 > > Review URL: https://codereview.chromium.org/266333002 TBR=ericu@chromium.org Review URL: https://codereview.chromium.org/281623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270038 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering(). (https://codereview.chromium.org/277123002/) Reason for revert: This seems to have broken NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0 Linux Tests (dbg)(2) and Win7 Tests (dbg)(1). Will provide links and stdio on the new CL. This is speculative, if the issue won't go away, the revert will be reverted. Original issue's description: > Rename AudioRenderer::Play/Pause() to Start/StopRendering(). > > This makes a clearer separation between methods for controlling the > actual rendering of audio versus methods for controlling the state of the > renderer (i.e,. flushing and seeking). > > Consequently, clean up AudioRendererImpl to reflect the separation > between rendering methods and state change methods. > > BUG=370634 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270017 TBR=dalecurtis@chromium.org,xhwang@google.com,scherkus@chromium.org NOTREECHECKS=true NOTRY=true BUG=370634 Review URL: https://codereview.chromium.org/274443006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270037 0039d316-1c4b-4281-b951-d872f2087c98
-