GitLab

This CL checks VEA flush behavior by adding two states: CS_FLUSHING
and CS_FLUSHED. Now the encoding flow becomes:

- Set state from CS_ENCODING to CS_FLUSHING
  when the client sends the last frame and calls VEA::Flush(flush_cb)
- Set state from CS_FLUSHING to CS_FINISHED
  when the client receives the last encoded frame
- Set state from CS_FINISHED to CS_FLUSHED
  when flush_cb(success=true) is called
- Set state to CS_ERROR if either of situation is true:
  - flush_cb(success=false) is called before last encoded frame is
    received
  - flush_cb(success=true) is not called in a period of time
    (e.g 200 ms) from VEA::Flush() is called.

BUG=chromium:820313
TEST=Run video_encode_accelerator_unittest at scarlet device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a83b0e7f902575b084ae4ccf85f3ba7d5f74819
Reviewed-on: https://chromium-review.googlesource.com/908370Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548288}

Notifications can be disabled for a number of
reasons. This logs those reasons with UMA.

This is a retry of my earlier CL, but does
not abort if getting settings failed (not
a fatal failure anyway).

Bug: 734095
Change-Id: I9a04f666e8181d87fd945fcdcac0c3a0371aa2f0
Reviewed-on: https://chromium-review.googlesource.com/995536Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548287}

In https://chromium-review.googlesource.com/c/chromium/src/+/957645, I
accidentally introduced a crash (crbug/828814) which could occur if
content verification was running as Chrome was shutting down.

According to |KeyedServiceBaseFactory::AssertContextWasntDestroyed|,
service getting (ExtensionRegistry is a service) should only be done on
the main thread.

This CL stores the data which was read from the extensionregistry
(the extension's background scripts, page and content script file_paths)
in the ContentVerifierIOData instead.

Bug: 828814,809088
Change-Id: I7d2a326c5ea609f996bd0af2a6d490108a99e772
Reviewed-on: https://chromium-review.googlesource.com/996489
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548286}

When panning, rather than only waiting for a mouse move event before
switching to the hand cursor, check for middle mouse up/down events in
non-link areas and switch from/to the hand cursor immediately.

BUG=234933

Change-Id: I29661a7f60ccafdc710c639ab1206a566705272e
Reviewed-on: https://chromium-review.googlesource.com/996384Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548285}

After the user clicks on details on the page info dialog always dismiss
the page info dialog. By doing so, the dialog disappears in VR before
showing the user the exit VR request. That is consistent with what
happens when the user clicks the site settings button.

Bug: 829043
Change-Id: Id51477f08cf693107d11044c7ca2ec477c0118f8
Reviewed-on: https://chromium-review.googlesource.com/996305
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548284}

ExtensionTestMessageListener::WaitUntilSatisfied() is used to wait for
a specific message from an extension and return a result.
WaitUntilSatisfied() returns a bool indicating success, but this can be
false (i.e., failure) in certain circumstances. Add WARN_UNUSED_RESULT
so that callers must handle the returned bool, rather than only waiting
for the listener to be satisfied.

Bug: None
TBR=benwells@chromium.org (apps/, c/b/apps/)
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/ash/launcher/)

Change-Id: Ied7b2cd5e5006531a117158812dad5d39b673786
Reviewed-on: https://chromium-review.googlesource.com/989278
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548283}

On all other platforms //device/usb uses a custom backend. This patch
ensures that we are not including libusb in unexpected build
configurations.

Change-Id: Ia1b68e86048af7ed98d27b19f46f74ceba50097b
Reviewed-on: https://chromium-review.googlesource.com/996407Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548282}

Also, dropped the word "container" from AXPosition::Create...PositionInContainerObject for better readability and faster typing.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 639340
Change-Id: I75c10bb35435a7cad9988e30a54af60f525bb29c
Reviewed-on: https://chromium-review.googlesource.com/995639
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548281}

This relaxes the check for the Samsung workaround landed in
http://crrev/c/924115, so that the workaround applies for Samsung's
other mail app which also reproduces this behavior.

Although the other mail app is referred to as
"com.samsung.android.email.provider" in our communication with them, its
implementation is actually split among 5 different APKs, and it is
"*.composer" which actually exhibits the bug.

As it turns out, the bug reproduces under the exact same sequence of
URL navigations as the other app (a file:// URL followed by
loadDataWithBaseURL("email://")).

As with http://crrev/c/924115, this is also meant as a temporary
workaround.

Bug: 781535
Test: Use both Samsung apps, test the 3 repro conditions listed in b/70696775.
Change-Id: Ic897a33dc52b78e83eaada5b4b66c555a0eb3679
Reviewed-on: https://chromium-review.googlesource.com/981691
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548280}

This allows a target to include private headers it wouldn't otherwise be
able to include. A target can provide a list of patterns of friend
targets that allow dependent targets to bypass public header checking.

A proper dependency path is still required, this applies only to the
concept of public/private headers on a target. Without this, it's
difficult to make a target be explicit about its public headers while
also allowing that target's own tests to use internal headers.

BUG=732993

Change-Id: I1cb94c7ac0db6f74cdcd49d08bcabedf70ea3eb0
Reviewed-on: https://chromium-review.googlesource.com/994453
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548279}

https://chromium-review.googlesource.com/c/chromium/src/+/681850 changed
the default run loop on Mac, which broke our capturer (it started
returning zero-size frames for all but the initial capture). I'm not
sure what our dependency on MessagePumpCFRunLoop is, but switching to a
UI thread means that the capturer has access to one again.

Change-Id: I9ac8ac19f325f88f9e758613f50ac2a2a00dc01d
Bug: 827300
Reviewed-on: https://chromium-review.googlesource.com/996296Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548278}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/68c9ef31..447b127a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I709a3df80d9fd16893c40a1cbeddf8cf39bf9432
Reviewed-on: https://chromium-review.googlesource.com/996037Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548277}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/5baad932589a..dee930847568

$ git log 5baad9325..dee930847 --date=short --no-merges --format='%ad %ae %s'
2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build

Created with:
  roll-dep src/third_party/ffmpeg

Bug: 812974
Change-Id: I28381804667b9b6a2fd085545db6bf3c80cd3009
Reviewed-on: https://chromium-review.googlesource.com/996474Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548276}

Cleanup: there is no logic changes in this CL.

I tried making an edit in this file and found there were many small
style issues*. These changes, done separately, can keep my other CL
cleaner:
- fix use of NULL instead of nullptr
- fix lines over 80 chars long
- fix 3 space indenting
- fix 1 space indent on eol comments
- fix use of assert true for comparison
- fix suggetion to suggestion

*Which create a big list of warnings, making it hard to see if I've
introduced new issues.

TBR=mpearson@chromium.org

Bug: None
Change-Id: I4252ea4c62f33ff201ee80179150c7f10b13084f
Reviewed-on: https://chromium-review.googlesource.com/996752
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548275}

This adds VrPopupWindow to VrUiWidgetFactory. As a result, if the
web content asks for a autofill popup, the Vr compatible one will
show.

Bug: 819881
Change-Id: Ia0ef837eaf4fea744472337feeb1b658d3cfb24d
Reviewed-on: https://chromium-review.googlesource.com/986887
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548274}

Bug: 812974
Change-Id: If3b39236ddc753f8ef3f8caab4b8c2a5b12497fd
Reviewed-on: https://chromium-review.googlesource.com/988799
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548273}

Bug: 793301
Change-Id: I439f64d2c68c965881ab69b297b0bbabfd68b31d
Reviewed-on: https://chromium-review.googlesource.com/986053
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548272}

BUG=none
TEST=none
TBR=rjkroege@chromium.org

Change-Id: Ic63d88124d37c50f6bea881b5afcd888c7fc4fca
Reviewed-on: https://chromium-review.googlesource.com/996808
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548271}

Added a "MacViewsAutofillPopup" feature flag and
--mac-views-autofill-popup switch. If it's enabled,
show the Autofill popup view using toolkit instead of
cocoa.

Removed AutofillPopupBaseView FocusManager accelerator code.
The code is no longer necessary since it was added for a now
obsolete rAc dialog. The autofill popup will get dismissed by
the web contents, which listens for the accelerators.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/889983

The CL was reverted because of a crash (https://crbug.com/809830)
which was caused by the popup's container view's window set to
nil.

Bug: 728182
Change-Id: I02f74b5627e6559c4e4dd77a35860e77d000a0d5
Reviewed-on: https://chromium-review.googlesource.com/974106Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548270}

When an extension is granted tab permission using activeTab (in response to say
clicking on its browser action), the extension is granted permission to the
tab's origin for the duration of the tab lifetime.

When this happens for a tab with a file url loaded, the extension gets
permission to the file scheme on the tab. This allows, for example, the
extension to read the contents of the page using apis like
chrome.tabs.executeScript. For file urls, this is not ideal since this does not
respect the "Allow access to file URLs" extension setting.

This CL changes this behavior, gating the access to the file scheme on the tab,
on the extension having explicit file access. This CL also adds extensive test
coverage for the behavior of tabs.executeScript on pages with file urls loaded
into them.

BUG=816685

Change-Id: I9175bb1883006fe594a93262c6825a962c285037
Reviewed-on: https://chromium-review.googlesource.com/994264
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548269}

Instead of writing base::Version(version_info::GetVersionNumber()).

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0a2c0826ffced29d22151bac51537da227b6dd95
Reviewed-on: https://chromium-review.googlesource.com/989092Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548268}

Users of AGSA have long had feedback that the download complete notification
resulting from CCT usage is incongruent with the perceived usage of AGSA
instead of Chrome. This attempts to fix it by suppressing the download complete
notification for versions of AGSA that support issuing their own notification

Bug: 812022
Change-Id: I099e8a3db0bb4984cfd2782d5442cffabbacf765
Reviewed-on: https://chromium-review.googlesource.com/952025
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548267}

When calling the build/android/tombstones.py script, used to
extract tombstones and properly resolve symbols for Chromium
libraries, 'aapt dump badging' is called repeatedly on all
files matching $CHROMIUM_OUTPUT_DIR/apks/*.apk, in order to
extract their package names.

This patch helps speed up this process considerably by caching
the result for each APK (hence each file will be read only once
now).

Time comparison for the following command (for an Android/x86 build).

  third_party/android_platform/development/scripts/stack.py \
      --arch x86 \
      --output-directory out/Emulator \
      --more-info \
      /tmp/tombstone_08

Before: 1m 48s  -->  After: 23s    (same results)

+ Rename symbols.GetAapt() to _GetAapt() to make it private,
  and use constants.ANDROID_SDK_TOOLS to find the location of
  the 'aapt' binary used to extract package names. Note that
  the use of the SDK_HOME environment is preserved unchanged
  at the moment (though is probably not needed).

+ Rename GetApkPackageName() to _GetApkPackageName() and
  remove its 'aapt' parameter and speed it with a small
  cache.

+ Rename GetCandidateApks() to _GetCandidateApks() and
  use a small cache to avoid hitting the filesystem everytime
  this is called, since the result will not change between
  invokations.

+ Simplify GetMatchingApks() implementation.

+ Fix minor typos.

NOTE: There are still many many things that are really wrong
      in this script. In particular, it cannot work properly
      with component builds, and will fail to work in the
      future when Chromium will be installed as a set of
      APK splits. Another point is the reliance on the global
      ARCH variable which is liberally modified directly by
      other Python scripts all over the place (ugh...).

      These will be addressed in future CLs.

BUG=774267
R=agrieve@chromium.org,hzl@chromium.org, jbudorick@chromium.org, mattcary@chromium.org

Change-Id: If130a668dd592b682d7fa98012745704a74fb850
Reviewed-on: https://chromium-review.googlesource.com/995932
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548266}

Bug: 826773
Change-Id: Iae8f5732fcfad8fbe81c9b9dab36cdcd9679c1dd
Reviewed-on: https://chromium-review.googlesource.com/990975
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548265}

Builder was renamed in
https://chromium-review.googlesource.com/c/chromium/tools/build/+/988819,
but I forgot to apply that rename in
https://chromium-review.googlesource.com/c/chromium/src/+/988816

TBR=nodir,dpranke

NOTRY=true

Bug: 782863
Change-Id: I35a74f670ebcc3ae266086eba800d41fe95b77e3
Reviewed-on: https://chromium-review.googlesource.com/993976
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548264}

Centrally set up a temp directory to be used as download directory.
Remove lots of ad-hoc code in individual tests doing the same. While
this is a nice cleanup in itself, the main motivation is the plan to
restrict download location to only specifically whitelisted directory
subtrees on Chrome OS in a subsequent code change without all the
existing tests having to worry about that detail.

BUG=chromium:818138
TEST=Compiles and passes tests.

Change-Id: I88bd945d544c7536c3e1a884928c3e72200efc9d
Reviewed-on: https://chromium-review.googlesource.com/953942Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548263}

Bug: None
Change-Id: I5d24ad95d415a665e5317a803f3b05efff603429
TBR: rsesek
Reviewed-on: https://chromium-review.googlesource.com/996578Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548262}

Enters splitview when focus is on transient child. Use
MruWindowListForCycle instead of MruWindowList because the latter counts
transient child as well, which would give a wrong limit when checking
the minimum amount of windows to open splitview.

Test: ash_unittests SplitViewControllerTest.*
Bug: 827245
Change-Id: Ibe7985fa52f5d4a03b033311540c8385d01b53ee
Reviewed-on: https://chromium-review.googlesource.com/985901Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548261}

Reland of the original CL with fix on Mac.

Original CL Description:

This is a ServiceTest tha runs CdmService in-process (packaged) which
covers some basic interaction between CdmService and CdmFactoryImpl.

TBR=jrummell@chromium.org,tsepez@chromium.org

Bug: 826039
Test: Adds new tests to media_service_unittests
Change-Id: Ieb087d7d4690d80965b4c2d3b04d7c497bf9560b
Reviewed-on: https://chromium-review.googlesource.com/994460Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548260}

Adjust padding and sizing for KeywordHintView in touch mode.

Screenshots -
https://drive.google.com/file/d/1DGPFQ1tJUyJPbZ_ncrI8Ny06skmNdJck/view?usp=sharing

Bug: 801583
Change-Id: I972705e816ed43db39117c7dc58d1fdbd2dbd517
Reviewed-on: https://chromium-review.googlesource.com/942642
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548259}

This is largely a copy-and-paste from GLES2DecoderImpl, with some minor
cleanup.

- added a vertex array manager to RasterDecoderImpl and copied
  associated boilerplate because it was required by
  CopyTextureCHROMIUMResourceManager

- copied GLES2DecoderImpl::CopySubTextureHelper as
  RasterDecoderImpl::CopySubTexture with very minor modification
  (e.g. raster is given a destination texture ID instead of the target
  that GLES2 takes)

- added a unittest to verify that source and destination textures are
  cleared appropriately

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1eb50e43cc52ee9931a483ab89f9cdbdf47e2332
Reviewed-on: https://chromium-review.googlesource.com/993763
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548258}

The GroupCoordinator will be used in the new Audio Service loopback and
muting features. It tracks one or more audio outputs that are members of
the same group, and notifies interested entities (e.g., a muter, a
loopback mixer, etc.) of membership changes to the group.

Bug: 824019
Change-Id: I9b8b1564e8fa7977d2d8dd21c466c7cbf5cdd3f2
Reviewed-on: https://chromium-review.googlesource.com/987093Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548257}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie30ec32ff379dca98f964e2a0de0e786eec8026f
Reviewed-on: https://chromium-review.googlesource.com/994498Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548256}

Offline pages need a custom version of the menu items shown by CCT. This
change creates a custom UI type for presenting offline pages that
properly configures the menu and also disables the "powered by Chrome"
footer.

Bug: 824807
Change-Id: Ic20f03ee152b8f538161810e87bc0e514886a3e7
Reviewed-on: https://chromium-review.googlesource.com/996395Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548255}

This came up as part of an effort to switch |is_posix| to false in Fuchsia.

Bug: 812974
Change-Id: Ic8d4b745e4e88620d6ad598223d41d0b3ca08a3f
Reviewed-on: https://chromium-review.googlesource.com/988850Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548254}

This brings it up to revision 6aa3b57955fed5e137d0306478e1a4b424a6d392, which includes the following two changes:

* Support for reversed dates in timeRange() and dateRange():
  https://hg.mozilla.org/mozilla-central/rev/cd913073f87c
* Additional validation of IP(v4) literals in isInNet:
  https://hg.mozilla.org/mozilla-central/rev/dd66d01e757c

Bug: 827292
Change-Id: I3d6670c7ceed0fc1bc453d6892922ffb047ab2bc
Reviewed-on: https://chromium-review.googlesource.com/986949
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548253}

Bug: 829092
Change-Id: Ibfe49a09148cfcd7b6fb489eadfbc5b43bb682ec
Reviewed-on: https://chromium-review.googlesource.com/996570Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548252}

Replacing tdresser@

Change-Id: I74625e1844b5403fc63a7d20d98aaaff1529f6a6
Reviewed-on: https://chromium-review.googlesource.com/993397Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548251}

CRWWebController removes WKWebView when the web process is evicted
(crbug/815248). This leaves WKBasedNavigationManager in an inconsistent
state as previous_item_index_ may not be -1, but GetItemCount() is 0.
This causes a crash in OnNavigationItemCommitted() when user starts a
new navigation by typing into the omnibox.

Fix the crash by guarding the pointer dereference with a nullptr check.

Bug: 797756
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie553efbe7bb558a8af955ca6f64e2b8aea58aacd
Reviewed-on: https://chromium-review.googlesource.com/996436Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548250}

This reverts commit ef18e86a.

Reason for revert: Make sure apk_merger.py works with and without the
unwind file, till downstream cl lands. Also rebase on:
https://chromium-review.googlesource.com/c/chromium/src/+/994545
and remove workaround for crbug/828528.

Original change's description:
> Revert "Enable extracting unwind table on official builds without channel"
>
> This reverts commit 16e808d7.
>
> Reason for revert: Merge step still failing.
>
> Original change's description:
> > Enable extracting unwind table on official builds without channel
> >
> > The original cl was here:
> > https://chromium-review.googlesource.com/c/chromium/src/+/990092
> > This CL fixes the following problems with the original CL:
> > 1. The apk_merger script fails because the unwind tables were only added
> >    in 32-bit apk. The merger script expects all the files to be same and
> >    the ones different should be checked.
> >  1a. The resources.arsc is non-hermetic and ordering is affected by
> >      adding file to only one apk. As a workaround for crbug/828528,
> >      add an empty (valid) unwind table file to the 64 bit monochrome
> >      apk to make the resource.arsc consistent.
> >  1b. The merger script simply adds all the files in apk which are not
> >      same. To keep the script simple and functional, the unwind resource
> >      is renamed to unwind_cfi_32 and unwind_cfi_empty in respective
> >      builds and the app_merger is updated to specify this file is
> >      expected to be different and included. This causes an extra file
> >      (4 byte) in the merged apk.
> >
> > 2. The unwind tables were always generated for "libchrome.so" for all
> >    chrome apks. The different chrome_apk(s) have different shared
> >    libraries like libchromefortest, etc.. So, update the unwind asset to
> >    get unwind table for the right library for each apk. Only adds assets
> >    to *_public_apk(s).
> >
> > 3. The monochrome_apk_checker was failing because the unwind file
> >    included was different in chrome_apk and monochrome_apk. This CL adds
> >    the asset to all apk at the same time and adds exception for this
> >    file.
> >
> > BUG=819888
> > TBR=dpranke@chromium.org
> >
> > Change-Id: Ibceeeacc19fa424d519891b8c17e349ee6c2dfd6
> > Reviewed-on: https://chromium-review.googlesource.com/991236
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547993}
>
> TBR=boliu@chromium.org,dpranke@chromium.org,mariakhomenko@chromium.org,changwan@chromium.org,ssid@chromium.org,agrieve@chromium.org
>
> Change-Id: I0a96e213133b6cb21c36db365b7c72f0f4642c8e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819888
> Bug: 828879
> Reviewed-on: https://chromium-review.googlesource.com/995697
> Reviewed-by: Anthony Berent <aberent@chromium.org>
> Commit-Queue: Anthony Berent <aberent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548066}

TBR=dpranke@chromium.org,mariakhomenko@chromium.org

Bug: 819888, 828879
Change-Id: I2eba81de32632bea90171ece4cba1a4144c55d25
Reviewed-on: https://chromium-review.googlesource.com/996272
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548249}