- 28 Sep, 2018 40 commits
-
-
Joel Einbinder authored
Bug: 875173 Change-Id: Ifd08a9fe6c6ba08af9f98f92570f523987959e5a Reviewed-on: https://chromium-review.googlesource.com/1250170Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#595158}
-
Manas Verma authored
This is a reland of d54e0de4 Original change's description: > [Autofill] Browser Tests for Sign-in After Local Save. > > Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt. > > Bug: 855186 > Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7 > Reviewed-on: https://chromium-review.googlesource.com/1196918 > Commit-Queue: Manas Verma <manasverma@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592227} Bug: 855186 Change-Id: Id7258331f021a1f69dd84f7f6e6fc77b01f0885d Reviewed-on: https://chromium-review.googlesource.com/1241558Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#595157}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6ff2f64702dc..f0aa6f4e3a57 git log 6ff2f64702dc..f0aa6f4e3a57 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 jaebaek@google.com Fixed Validator adjacency bug for OpPhi (#1922) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f0aa6f4e3a57 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78346971e87db385689ea12bb6666c6d5f9c5b9f Reviewed-on: https://chromium-review.googlesource.com/1251983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8241a7599974..82b404766db2 git log 8241a7599974..82b404766db2 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 chowes@google.com Fix symlink to build_dlc script 2018-09-28 saklein@chromium.org cros_choose_profile: remove unused argument 2018-09-28 saklein@chromium.org build_stages.InitSDKStage: update chroot Created with: gclient setdep -r src/third_party/chromite@82b404766db2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6e27b62cb504b4ab991850a84fb9d308a4eaa9c1 Reviewed-on: https://chromium-review.googlesource.com/1251986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595155}
-
John Z Wu authored
Additional ones to follow. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2181ea6891f17692d74765ff7f806420b43e8983 Reviewed-on: https://chromium-review.googlesource.com/1226368 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#595154}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/fb86b888ef1c1265719208fd6c27a53ceb4920f7..13fd627449cefbae7576d4b145cb24fac303fc7d BUG=890115 Change-Id: Id0a70faca0e68750a73551abf2ab79dc09a970e4 Reviewed-on: https://chromium-review.googlesource.com/1251333 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#595153}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id72e1a333e00d9bc21dfdbdcce9bde2928b5aa1a Reviewed-on: https://chromium-review.googlesource.com/1252082 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595152}
-
Rune Lillesveen authored
Change-Id: I83b5fb8ff7219d5846d85ebd3f8e1e9ba695b6c5 Reviewed-on: https://chromium-review.googlesource.com/1251381Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595151}
-
Tetsui Ohkubo authored
According to spec, network's tray icon size changed from 16dip to 20dip, and we no longer have 2dip padding around network icons. Also, because of that, new we can remove 1dip y-axis adjustment of |top_left| badge e.g. "LTE" for cellular network. For detail, see the screenshot in the bug. TEST=manual BUG=889589 Change-Id: Ib5eee3d05116e9deff936e6cb5287de9ac68a2de Reviewed-on: https://chromium-review.googlesource.com/1250381Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595150}
-
Devlin Cronin authored
Move the musicManagerPrivate API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. TBR=gab@chromium.org (comment update in chrome_pref_service_factory.cc) Bug: 877240 Change-Id: Id4bec073d3f9698682f40720852843fa03347900 Reviewed-on: https://chromium-review.googlesource.com/1220326 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#595149}
-
Bailey Berro authored
- Adds the correct link for the network file shares help page. The content on the target page is still being updated. Bug: chromium:889830 Change-Id: I583ed05c144d5938c4c9acdadb4515e1828bc8f3 Reviewed-on: https://chromium-review.googlesource.com/1249824Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#595148}
-
Eugene But authored
From https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL: The URL.createObjectURL() static method creates a DOMString containing a URL representing the object given in the parameter. The URL lifetime is tied to the document in the window on which it was created. The new object URL represents the specified File object or Blob object. These URLs have blob: scheme. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6da3069663e735ce89977b15cfee7933a3c20ea1 Reviewed-on: https://chromium-review.googlesource.com/1250163Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#595147}
-
Mike Klein authored
This will guard https://skia-review.googlesource.com/c/skia/+/157522 for layout test changes. They should be many but all tiny. Change-Id: I6cd7785227ac04ea6a921e9fb4bc119b1e94ae4f Reviewed-on: https://chromium-review.googlesource.com/1251540 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#595146}
-
Matthew Jones authored
Bug: 887502 Change-Id: Ic6fd77dc9b067aabfbb22e50519e756fe1caa51f Reviewed-on: https://chromium-review.googlesource.com/1252001Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#595145}
-
Olivier Robin authored
This should return nullptr (and not DCHECK). Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/1249207 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id0635b701ea491e15a7240d2c639ae8ddd001086 Reviewed-on: https://chromium-review.googlesource.com/1251462 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#595144}
-
chaopeng authored
This test failing is because: 1. In cc gen property tree, we create non-scrollable scroll node for scrollbar and set it as child of a no scrollable scroll node. 2. In LayerTreeHostImpl::IsInitialScrollHitTestReliable, we return false (fallback to main thread scroll) when it does not have a closest_scroll_node (scroll node and it's ancestor nodes do not scrollable). 3. In blink gen property tree, we do not create the scroll node for scrollbar so closest_scroll_node is the scroll node of scrollable which owns the scrollbar. Then the scrolling process in impl thread and scroll on the scrollable. In this patch we return scroll fallback to main thread with scrollbar scrolling reason if the scroll hit testing layer is scrollbar and from touch before LayerTreeHostImpl::IsInitialScrollHitTestReliable. Bug: 884846 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia1b2bb996879b4de75b5f84a7a94c73676bbcb23 Reviewed-on: https://chromium-review.googlesource.com/1243164Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595143}
-
Sergio Villar Senin authored
It should not get the primary account as argument but instead, directly retrieve it from the SigninManagerFactory. It's being done in preparation for the migration to IdentityManager in https://crrev.com/c/1245784. Apart from that it was decided to rename the API to GetSecondaryAccountsForSignedInProfile in order to better reflect the fact that the profile must be signed in. Change-Id: Ib897c8d9a2cc585fb442c4ae7aff62455b381339 Reviewed-on: https://chromium-review.googlesource.com/1248742Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#595142}
-
Philip Jägenstedt authored
Brings in changes in wpt/tools/ in this range: https://github.com/web-platform-tests/wpt/compare/ab64b78a8f...c757432db5 Change-Id: Id7dd54c33be9db5478d1278a5c96d735f7aebc2e Reviewed-on: https://chromium-review.googlesource.com/1249141 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#595141}
-
Yue Li authored
Bug: b/115843337 Test: Manual Test Change-Id: Ifd96410a48e85345cb77c6ef1b967df03b0f06ad Reviewed-on: https://chromium-review.googlesource.com/1237514Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#595140}
-
Tatiana Buldina authored
Bug: chromedriver:1998 Change-Id: I6ae25aaff9bb6a5811fed81c858250f2fbc34472 Reviewed-on: https://chromium-review.googlesource.com/1244615Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595139}
-
Ben Pastene authored
With this, any changes to the filesystem a test makes will only last for as long as the VM is alive. Since we launch+shutdown for every test, this perfectly isolates consecutive tests from one another. No more out-of-disk errors! Bug: 887753 Change-Id: Ifdf4af22e288583135cfe99d363eb3e79045e08d Reviewed-on: https://chromium-review.googlesource.com/1252005Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595138}
-
Vaclav Brozek authored
This enum was used in a metric which have been removed for some time now. Bug: 456119 Change-Id: I9483787580dd86c5eb494febac049bc1aca342b8 Reviewed-on: https://chromium-review.googlesource.com/1251583Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595137}
-
Matthew Jones authored
Bug: 884144 Change-Id: Idf9634bd70ce37fb8b0dfdc51e5c2a5aa3d3847d Reviewed-on: https://chromium-review.googlesource.com/1251767Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#595136}
-
Xiyuan Xia authored
CrostiniAppIconLoader should use the passed-in icon size instead of from AppListConfig. Bug: 880979 Change-Id: I20840e4eced66ea2320149c57ebda4a9c8226341 Reviewed-on: https://chromium-review.googlesource.com/1251961Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce4c48bb2fa0..928526013073 Created with: gclient setdep -r src-internal@928526013073 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9b352590ed3f948be6c0ca284fcffda323b80d4d Reviewed-on: https://chromium-review.googlesource.com/1250953Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595134}
-
Mario Sanchez Prada authored
Replace instance of SigninManagerBase with one of IdentityManager and update calls accordingly. Bug: 889882 Change-Id: I4e76d223a1b8a6bc328cb97e1624d2c4d7532fae Reviewed-on: https://chromium-review.googlesource.com/1251532Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595133}
-
Boris Sazonov authored
This CL adds TextAppearance.UpdateMenuItem and replaces hardcoded textColor and textSize values in update_menu_item.xml. Bug: 727723 Change-Id: I1b085d973502143e9a4a44dcbd1013d20386f01c Reviewed-on: https://chromium-review.googlesource.com/1251539Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595132}
-
Jonathan Metzman authored
Remove redundant check for "use_libfuzzer" introduced in 6376140d. This check is redundant and causes build failures because it stops /OPT:NOLLDTAILMERGE from being used. Bug: 884545 Change-Id: Ifb665751ff568ff557c4a896aca2d3b3f7a97dd3 Reviewed-on: https://chromium-review.googlesource.com/1249734Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595131}
-
Christopher Cameron authored
This is to * Clarify what code exists in the app shim side, and what code exists on the browser side. * Ensure (via include rules) that the app shim side not call back into any ui/views code (that is, that it always goes through appropriate interfaces). R=ellyjones TBR=bsalomon (skia/OWNERship) Bug: 821561 Change-Id: I4b3d48dac707507bc1881f9a1a0478ac1d15355c Reviewed-on: https://chromium-review.googlesource.com/1247526 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#595130}
-
Abhishek Arya authored
ninja runs gen_fuzzer_owners.py from build directory and not chromium source root. This causes script to fail to find owners since it checks source file from incorrect relative location. This regressed in https://chromium.googlesource.com/chromium/src/+/3fb53cf0d187b9537160ad967975f17641d59c1f R=mmoroz@chromium.org Bug: 890352 Change-Id: Ib14884f294eadeaa87d08cd57062bf41d63f002e Reviewed-on: https://chromium-review.googlesource.com/1252003Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595129}
-
Charlie Harrison authored
See spec: https://w3c.github.io/speech-api/#speechsynthesiserrorevent and discussion on i2s on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8_H3FUZm23g Previously, errors were just going through as SpeechSynthesisEvents. This CL now dispatches errors as SpeechSynthesisErrorEvents with an empty "error" method. This CL also adds constructors on both SpeechSynthesisEvent and SpeechSynthesisErrorEvent. Bug: 885297 Change-Id: I70ba998182943a50e17f2fc11eb7e163d8289e94 Reviewed-on: https://chromium-review.googlesource.com/1231839 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#595128}
-
Hongchan Choi authored
This is a fix suggested by dcheng@ at: https://bugs.chromium.org/p/chromium/issues/detail?id=888366#c12 Locally confirmed the change stops the crash. Bug: 888366 Test: The CL build does not crash on the repro case anymore. Change-Id: I4b56228589b4c71f1191fb82e849240f39c938ed Reviewed-on: https://chromium-review.googlesource.com/1246945 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595127}
-
Vladislav Kuzkokov authored
Bug: 853877 Change-Id: I9441f6b95fec76c5f50b9aa25e7695878983ac52 Reviewed-on: https://chromium-review.googlesource.com/1251531Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595126}
-
Lei Zhang authored
Move the function from PrintPreviewMessageHandler in chrome/ to PageSetup in printing/, so it can be used by printing code outside of chrome/, e.g. in pdf/. BUG=890058 Change-Id: Icb5969e8a948373056df00d06cdb2b002ce201c1 Reviewed-on: https://chromium-review.googlesource.com/1250129Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595125}
-
Yuly Novikov authored
TBR=kbr@chromium.org Bug: 869558 Change-Id: Ia49d751aff97a8b3e67fb0aa7c453b66d11f9b0a Reviewed-on: https://chromium-review.googlesource.com/1246148 Commit-Queue: Yuly Novikov <ynovikov@google.com> Reviewed-by:
Yuly Novikov <ynovikov@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595124}
-
Torne (Richard Coles) authored
This defines basic build targets for a Trichrome build using the upstream package names/configuration. The shared library APK contains the 32-bit version of libmonochrome.so and a few autogenerated Java pieces only at this stage, which means the total size of the three APKs is significantly larger than Monochrome at present. Reland fixes a conflict with another CL that went through the CL in parallel, and fixes an issue where gn generation failed when is_official_build=true. Bug: 887078 Change-Id: I86082eeffef53c018ccdc13a3122ff72fed5f5e6 Reviewed-on: https://chromium-review.googlesource.com/1246728Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595123}
-
Troy Hildebrandt authored
This CL breaks up many larger tests into smaller tests that are less likely to time out. Also reduced the amount of work particular tests perform to further ensure no timeouts. TBR=nyquist@chromium.org Bug: 879922 Change-Id: I9591c9bd4f4308ce9eb183289d5c49c98df72b32 Reviewed-on: https://chromium-review.googlesource.com/1240127 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595122}
-
Wei Li authored
Our dev tools used '0.0.0.0' as client address which doesn't work on Windows. See some silimar discussion at https://github.com/senecajs/seneca-transport/issues/37. Since we don't have any remote server discovery in place, it would be sufficient to use local host address '127.0.0.1' for showing the local client address on chrome://inspect page. Thus this CL fixes the client address by replacing with local host address. BUG=750191 Change-Id: Ife011e59316b472af3e56036d539282dd6667247 Reviewed-on: https://chromium-review.googlesource.com/1249271Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#595121}
-
Camille Lamy authored
They are taking too long to run and timeout when run with MSan. TBR=jam@chromium.org Bug: 890313 Change-Id: Ib7d1f3d6edcb62adcddbc54a0c636a9aae37d002 Reviewed-on: https://chromium-review.googlesource.com/1251453Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595120}
-
Valeriya Sinevich authored
Set listAccounts result stale to true on Multilogin finished. iOS fully working. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id24213b3c2ab8000bbcc6170140de50bcd84986c Reviewed-on: https://chromium-review.googlesource.com/1245707 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#595119}
-