- 21 Jul, 2020 40 commits
-
-
Ewann authored
Bug: 1073831 Change-Id: Ib4d61f98b55ab6c2311cd1627ce12391d0c97e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279974Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#790286}
-
Benoit Lize authored
This significantly shortens the fast path in the allocator: See the annotated assembly dump below for the fast path (release build, x86_64): - Before: 5 tests (and branches, shown with "***"), epilogue at offset 0x8c - After: 3 tests, epilogue at 0x46 BEFORE: 0000000000d385c0 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)>: [...] // Prologue d385c7: 48 83 ec 10 sub $0x10,%rsp d385cb: 41 89 d6 mov %edx,%r14d d385ce: c6 45 ef 00 movb $0x0,-0x11(%rbp) d385d2: 48 8b 16 mov (%rsi),%rdx d385d5: 48 8b 1a mov (%rdx),%rbx *** d385d8: 48 85 db test %rbx,%rbx d385db: 74 7b je d38658 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x98> d385dd: 48 8b 03 mov (%rbx),%rax d385e0: 48 0f c8 bswap %rax d385e3: 48 89 02 mov %rax,(%rdx) d385e6: 66 83 42 18 01 addw $0x1,0x18(%rdx) *** d385eb: 48 85 db test %rbx,%rbx d385ee: 74 5c je d3864c <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x8c> d385f0: 48 89 d9 mov %rbx,%rcx d385f3: 48 81 e1 00 00 e0 ff and $0xffffffffffe00000,%rcx d385fa: 48 89 da mov %rbx,%rdx d385fd: 48 c1 ea 09 shr $0x9,%rdx d38601: 81 e2 e0 0f 00 00 and $0xfe0,%edx d38607: 48 8d 04 11 lea (%rcx,%rdx,1),%rax d3860b: 48 05 00 10 00 00 add $0x1000,%rax d38611: 0f b7 8c 11 1c 10 00 movzwl 0x101c(%rcx,%rdx,1),%ecx d38618: 00 d38619: 48 c1 e1 05 shl $0x5,%rcx d3861d: 48 89 c2 mov %rax,%rdx d38620: 48 29 ca sub %rcx,%rdx d38623: 48 8b 52 10 mov 0x10(%rdx),%rdx d38627: 8b 72 18 mov 0x18(%rdx),%esi *** d3862a: 48 81 fe 01 00 01 00 cmp $0x10001,%rsi d38631: 73 48 jae d3867b <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0xbb> d38633: 48 89 f2 mov %rsi,%rdx *** d38636: 41 f6 c6 02 test $0x2,%r14b d3863a: 74 10 je d3864c <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x8c> *** d3863c: 80 7d ef 00 cmpb $0x0,-0x11(%rbp) d38640: 75 0a jne d3864c <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x8c> d38642: 48 89 df mov %rbx,%rdi d38645: 31 f6 xor %esi,%esi d38647: e8 54 e2 43 00 callq 11768a0 <memset@plt> d3864c: 48 89 d8 mov %rbx,%rax [...] // Epilogue d38657: c3 retq AFTER: 0000000000d385c0 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)>: [...] // Prologue d385ca: 49 89 cf mov %rcx,%r15 d385cd: 41 89 d6 mov %edx,%r14d d385d0: c6 45 e7 00 movb $0x0,-0x19(%rbp) d385d4: 48 8b 0e mov (%rsi),%rcx d385d7: 48 8b 19 mov (%rcx),%rbx *** d385da: 48 85 db test %rbx,%rbx d385dd: 74 35 je d38614 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x54> d385df: 8b 56 18 mov 0x18(%rsi),%edx d385e2: 48 8b 03 mov (%rbx),%rax d385e5: 48 0f c8 bswap %rax d385e8: 48 89 01 mov %rax,(%rcx) d385eb: 66 83 41 18 01 addw $0x1,0x18(%rcx) *** d385f0: 41 f6 c6 02 test $0x2,%r14b d385f4: 74 10 je d38606 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x46> *** d385f6: 80 7d e7 00 cmpb $0x0,-0x19(%rbp) d385fa: 75 0a jne d38606 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x46> d385fc: 48 89 df mov %rbx,%rdi d385ff: 31 f6 xor %esi,%esi d38601: e8 9a e2 43 00 callq 11768a0 <memset@plt> d38606: 48 89 d8 mov %rbx,%rax [...] // Epilogue d38613: c3 retq Bug: 998048 Change-Id: Ib9698e635b459b90c86a2dabadb3e4536f1d2219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307333Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790285}
-
Hiroki Nakagawa authored
WebSharedWorkerImpl accesses WorkerScheduler from the main thread to take a task runner, and then dispatches a connect event to SharedWorkerGlobalScope using the task runner. This causes a race condition if close() is called on the global scope on the worker thread while the task runner is being taken on the main thread: close() call disposes of WorkerScheduler, and accessing the scheduler after that is not allowed. See the issue for details. To fix this, this CL makes WebSharedWorkerImpl capture the task runner between starting a worker thread (initializing WorkerScheduler) and posting a task to evaluate worker scripts that may call close(). This ensures that WebSharedWorkerImpl accesses WorkerScheduler before the scheduler is disposed of. Bug: 1104046 Change-Id: I145cd39f706019c33220fcb01ed81f76963ffff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308550 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790284}
-
Christopher Cameron authored
Now that most of the functional changes are done, the classes that have been accumulating together can get separate files. TBR=geofflang Bug: 1092155 Change-Id: Ic9f31557cbd2144bf4de643640ae05be3a60ae10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309130 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#790283}
-
Boris Sazonov authored
No behavior change. This is a follow-up to https://crrev.com/c/2289972 that clarifies a comment in AndroidSyncSettingsTestUtils. Bug: 1093998 Change-Id: I5eba992467c15e26de67cd5ea4f411ddb033be9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308151 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790282}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595267899-0b639e1a830eedc083c30d777051dfd02b3a214f.profdata to chrome-mac-master-1595289228-e5c2a2241b190531533d778f2dcf9ff98ced1901.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae181e1b932ea5d3cbcbeec4534de1076c99a238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790281}
-
sandromaggi authored
With crrev/c/2296080 the |Controller| is no longer destroyed on error, this means we can re-use the |DidStartNavigation| events from there and do not have to re-implement it in the |UiControllerAndroid|. Bug: b/2296080 Bug: b/159977785 Change-Id: Ia40c7ec49c50f8a38698445808464588b0036221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307292Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#790280}
-
Fergal Daly authored
TBR=rakina@chromium.org Bug: 1107722 Change-Id: I871b63ca0e0301ba2734150584ebb2a5b5d7dbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309472 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790279}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I245a9959bf812dc9d73cd29b0ecf549da72ddc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309042Reviewed-by:
-
Dale Curtis authored
This modifies the ImageDecodeCache and TileManager to use RGBA_F16 when the raster color space is HDR. The raster color space will be set to HDR when the display color space is HDR and HDR content is detected during metadata collection. Bug: 960620, 1076568 Test: Updated unittests. Change-Id: Ida51852661aa51ec8506bf276f2d4929706e6006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270844 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Jing Wang authored
1. When emoji suggestion pop up, pressing "up" won't enter browsing mode, this is now the same as personal info suggester. 2. Allow number input after entering browsing mode, pressing "down" is not required as the previous action 3. Unify some naming fashion in two suggesters. 4. In emoji suggester, change the way of managing highlight buttons, now it's the same as in personal info suggester 5. Removed some unnecessary functions. 6. Updated tests. Test: tested with Chrome on Linux. Bug: NOBUG=refactor Change-Id: I91828526f0ecaaac3380764ab430e2c6f07d0417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303931 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#790276}
-
Reilly Grant authored
This change adds metrics for when users grant or revoke permissions to access a serial port. Bug: 998180 Change-Id: If19ddef97d2e9694588686f17613298c23a98f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305509 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790275}
-
Xinghui Lu authored
Add EnhancedProtectionSettingsFragment and StandardProtectionSettingsFragment. They are launched when the expand arrows on the Safe Browsing radio buttons are clicked. Add an interface named FragmentSettingsLauncher, which is used to inject an instance of SettingsLauncher to SecuritySettingsFragment. Enhanced protection screenshot: http://screen/QvKbx401JAE Standard protection screenshot: http://screen/KdwYdsgcUf5 Bug: 1097310 Fixed: 1072800 Change-Id: I4316e261d85d8e12cd8dd40199c86cd318aed7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298727 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#790274}
-
Andrey Kosyakov authored
This includes a fix for Array<Binary> https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2309330 TBR: pfeldman@chromium.org Change-Id: I42d4a7ff37933dc27e0f0e88b74de3a2c9e7f91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309429Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#790273}
-
Ben Mason authored
Test was passing in debug because of fieldtrial config. It's not read in release as per: https://source.chromium.org/chromium/chromium/src/+/master:testing/variations/README.md?originalUrl=https:%2F%2Fcs.chromium.org%2F Enable commandline flag: IPH_TabGroupsDragAndDrop and parameters. Bug: 1104279 Change-Id: If808af9f027b6c4c294a4d9c7950cbdba01db687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302833Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#790272}
-
Noel Gordon authored
Searchbox activity can send requests to the location line breadcrumb to display a root "/" path, when the current directory entry is a Recents, a Fake entry, a mounted Zip file viz., all special directories that are rooted according to the directory model API directoryModel.getCurrentDirEntry(); However, root paths have no path components and cause the location line show() code to throw an exception accessing components[0].name, causing files app to become totally unresponsive to user input. Change location line to ignore requests to show a root (empty) path and no JS exceptions is the result. Bug: 1107391 Change-Id: I74523e94ec29f65342b393c2b176f8f4771e838d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308613Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790271}
-
Min Qin authored
The prototype server is subject to client and qps limits Change-Id: I8e74f659be37df9bf5edf621e991f7d7e7465800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308989 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790270}
-
K. Moon authored
Now that crbug.com/989095 has been fixed, converts all uses of the legacy MOCK_METHOD*() macros to use the modern MOCK_METHOD() instead. Change-Id: Id22b3b4e8a0176ac17d9ef263ebe9eb87f558a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934608 Auto-Submit: K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790269}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3ed44f56c5bf..c4cebc7efae1 2020-07-20 rharrison@chromium.org Roll 5 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I464c88a309b68edbf2f03f57d3ea621b8aa89866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309211Reviewed-by:
-
Karandeep Bhatia authored
The test CrSettingsClearBrowsingDataV3Test.ClearBrowsingDataAllPlatforms is flaky on Mac. Disable it. BUG=1107652 TBR=dpapad@chromium.org Change-Id: Idbfe7608e8b547c976623d17a8997c954eb2ee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309037Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790267}
-
Jia authored
Bug: 1090132 Change-Id: Ie61df11e6d051452ae70a13eb04022523938b23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309309Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790266}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-017.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I2c2dd53c870a03f7b109ee5fa743e0c692019084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309490 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790265}
-
Yoshifumi Inoue authored
This patch removes useless test "move-nodes-001.html", which was introduced for verifies |appendChild()|[1], because of we have tests for |appendChild()|, for ease of maintenance. [1] https://b.webkit.org/show_bug.cgi?id=5629 - REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination Change-Id: I0a7a39865f5db5bc32fe5a0dd3bbac334e3bee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309315 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49108a1283c3..cd5489ad46bd 2020-07-20 syoussefi@chromium.org Vulkan: Faster FramebufferDesc compare 2020-07-20 cclao@google.com Vulkan: Move mEmptyBuffer from program to ContextVk 2020-07-20 ianelliott@google.com Vulkan: Optimize changing texture max level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: NBA 2K20 game play Change-Id: I73571695a9cf809674c1da4e0cd3d12f611e1945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309144Reviewed-by:
-
Mei Liang authored
This reverts commit 126a5760. Reason for revert: This test should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/2305374 Original change's description: > Disable failing test TabStripTest#testSelectWithManyTabs > > Failing on L/M Tablet bots. > > BUG=1107395 > TBR=dtrainor@chromium.org > > Change-Id: Icfc80b3973bb70bdb5eaedf93e4a784584170208 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307223 > Reviewed-by: Tim Volodine <timvolodine@chromium.org> > Commit-Queue: Tim Volodine <timvolodine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789978} TBR=dtrainor@chromium.org,timvolodine@chromium.org Change-Id: I9bebeed4455314237d1c4df59bd245da80dd50a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309751Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790262}
-
Mei Liang authored
This reverts commit 011a35b6. Reason for revert: These tests should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/2305374 Original change's description: > Disable all failing TabStripTest tests > > Disable the following tests because they are failing on > L/M Tablet Tester bots: > > TabStripTest#testCloseAllIncognitoTabsFromTabMenu > TabStripTest#testCloseLastIncognitoTab > TabStripTest#testCloseTabWithManyTabs > TabStripTest#testNewIncognitoTabFromMenuAtNormalStrip > TabStripTest#testSwitchStripStackersWithIncognito > TabStripTest#testTabSelectionViewDoesNotBreakModelSwitch > TabStripTest#testToggleIncognitoMode > > Note: > TabStripTest#testSelectWithManyTabs was disabled in > crbug.com/1107395. > > BUG=1107543,1107395 > TBR=dtrainor@chromium.org > > Change-Id: I638033bf1f9b12e009dfbd2ff8b2e2128d000373 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308469 > Reviewed-by: Tim Volodine <timvolodine@chromium.org> > Commit-Queue: Tim Volodine <timvolodine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790095} TBR=dtrainor@chromium.org,timvolodine@chromium.org Change-Id: I6ac4a86a451aa839672fed129e95b097ddcc7db9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107543 Bug: 1107395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309750Reviewed-by:
-
Fergal Daly authored
This reverts commit dca0464f. Reason for revert: Breaks msan tests. https://crbug.com/1107714 Original change's description: > Update Crashpad to 070b18d326b6d77a19db527dc71708458303bac4 > > 498c36b82a03 mac arm64: Provide something more useful from > SystemSnapshot::CPURevison > e3c94b87f0ef [fuchsia] Move //zircon/system/ulib/fdio to //sdk/lib/fdio > fd001f792eb7 build: Make crashpad_dependencies="external" work in the GN > build > ef8a063055c6 Fuchsia: Propagate failure to initialize exception snapshot > 06a688ddc1bc linux: setup a signal stack > 9f66d569fb87 linux: put test attachment in temp directory > 070b18d326b6 linux: fix alt-stack tests with asan > > Change-Id: Idcc5fd3ec95619844c36a505f4e2bafa6b13dcfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308850 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790155} BUG=1107714 TBR=jperaza@chromium.org,mark@chromium.org Change-Id: I36856f2c89d1b3cd33227cdb28b7bd646447aa08 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308620Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790260}
-
Melissa Zhang authored
This CL gets ShareActions from the ShareActionCache and plums them through to the Sharesheet bubble. It also adds a Share label to the bubble. Bug: 1097623 Change-Id: I98d17217f5b0fd1790c9866bb8bed4fc5a05bfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301262Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790259}
-
Kenichi Ishibashi authored
Resource readers/writers defined in the header file are replaced with mojo version of readers/writers. Remove service_worker_disk_cache.h includes as these aren't needed anymore. Bug: 1055677 Change-Id: I01dcaf6b8b4b675748d3fe170343aa1c83d7be1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309489Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790258}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If870135287374ce8163351260c0d2b5e29ba955b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308996Reviewed-by:
-
Sophie Chang authored
Bug: 1106895 Change-Id: I151a84c9bfb63ef84b2016348f05299dc2ad2820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308994 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-016.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I7ecc87274a67dad77e1433ad1abcc99cc1db6c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309610 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Lei Zhang authored
Like the //pdf:pdf build target change in https://crrev.com/c/2309135, it also needs to be a static library to avoid ODR violations in component builds. Bug: 1107602 Change-Id: I50e941d1bb0eedd23ddb42f0a75af705a52079c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308941Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790254}
-
Chris Thompson authored
This adds a SCT auditing cache to the NetworkService, and integrates it with TransportSecurityState so that new SCT reports are sent to the cache during CT policy verification. This also adds feature flags and params to control SCT auditing behavior, and unit tests covering the cache implementation. Bug: 1082860 Change-Id: I24b53c655d960390089e7746e116c9978a4b3a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248862Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790253}
-
Liquan (Max) Gu authored
In order to share the PRImpl logic for WebLayer, the class dependencies of PRImpl should be moved into //components. The moved classes include: * PaymentAppFactoryParams * PaymentManifestWebDataService * SslValidityChecker * SupportedDelegations Bug: 1102522 Change-Id: I9d2732b547a4532a9cb88104bca51b544d675613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307812 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790252}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-015.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I21610ac3f25936f3bd0f9e651fa822848c0c8690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308556 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Jiewei Qian authored
This CL adds SchemeType::SCHEME_DEVTOOLS to ContentSettingsPattern, so it's easier to handle auto-granted permissions registered with WebUIAllowlist in site settings. This is a followup based on discussions in https://crrev.com/c/2262758. Fixed: 1101889 Change-Id: I761a8df60f4fc05c1f92e0ca9761be749b29b88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279346Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#790250}
-
Fan Yang authored
Change-Id: I01d2cdcbbe12e4980415e2f04f61352b74f0a44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308135Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790249}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d71ded6e61c7..97f9923235cf 2020-07-20 mark@chromium.org Fix macOS arm64 GN build by building llvm RWMutex.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1107585 Tbr: swiftshader-team+autoroll@google.com Change-Id: If8caef964bbf0fd7b9ca1ca5b06439e83f4ea769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309270Reviewed-by:
-
Rakina Zata Amni authored
Some tests are failing after we split proactive BI swap check and BFCache check. Bug: 1102629 Change-Id: I37db349cb94c1f249ec49ebea01def98ca8beb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297206Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#790247}
-
