- 26 Feb, 2020 40 commits
-
-
Parastoo Geranmayeh authored
flaky test. TBR="xiyuan@chromium.org, tbarzic@chromium.org" Bug: 1056302 Change-Id: I65cbd1acadb5e68e3394f7cfeb7fa491f8c0abf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076377Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#744805}
-
Kramer Ge authored
The purpose is to indicate where (0,0) is in an output surface. Originally boolean value flipped_output_surface was not descriptive. This CL adds SurfaceOrigin components/viz. Because GLSurface exposes FlipsVertically() this enum is expected to move to ui/gfx Bug: 1051970 Change-Id: I8ba63ea08c4bb6d0b8faf1a49c3d2e417f7c6ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067350 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744804}
-
Sammie Quon authored
The back gesture will now have special behaviour for ARC apps. The first swipe will animate in the shelf and hotseat, and the second swipe will send a back event. I changed the container the back affordance is in because: 1) AlwaysOnTop container is watched by the workspace, which means adding/removing/hiding/etc the affordance window will trigger backdrop/shelf/etc updates. 2) AlwaysOnTop container is underneath the shelf container, which would make it tricky the part with the second swipe without the shelf pre event handler eating the event and hiding the shelf. 3) AlwaysOnTop container is still underneath a lot of things. I spoke with Ben and he seems to want sometime that is even above the power menu button. I think maybe we'll have our own GesturesContainer but for now the OverlayContainer (autoclick, laser) should work fine. The affordance was also creating a renderpass at the end which I removed. It was small, but should help out with the large minimize animation that commonly follows. Test: manual Bug: 1031268 Change-Id: I4f3be651604ac91cf0d2a07a24aa0f51efd44023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073199Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#744803}
-
Mustaq Ahmed authored
A past fix for activation propagation from an extension button to extension script seems to have added additional user activation propagation path from tab-strip to all installed extensions: https://chromiumcodereview.appspot.com/10821120/ This crack caused every tab-switching to activate /all/ installed extensions, which seems bad. Because of this, we encountered a security issue with unintended top frame navigation from an iframe. (Luckily only tab switching was affected, not tab clicking.) A user interaction with the tab-strip is different from an interaction with extension buttons. Tab-strip interactions are similar to those on any browser-provided UI element like top menu: they don't at all indicate the user's intention to interact with any extension or website. Therefore, like clicks on top-menu and unlike clicks on extension buttons, tab-switching should suppress activating any background script thus prevent access to use user-activation gated APIs like popup, fullscreen, navigation, etc. Bug: 957633, 1035315 Change-Id: I8d56e02a3a2966521b7bbc4f4efadf67e1acc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072654Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744802}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3621dca1542..4d40271e3f09 git log e3621dca1542..4d40271e3f09 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 amaiorano@google.com Subzero: add support for large stacks on Windows Created with: gclient setdep -r src/third_party/swiftshader@4d40271e3f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0261aea1960262f4018b31fb43eddf4341fa58fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744801}
-
Denis Kuznetsov authored
Bug: 1054935 Change-Id: I2da8e4c8240647614728c21e351a6b2e940aaae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074882Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL fixes the VaapiVideoDecodeAccelerator to advertise the visible size as the coded size for decoded video frames. Here's the background: CL:2011583 changed the VA-API decoding pipeline so that the EGLImage backing a VideoFrame's service-side texture is created using the visible size instead of the coded size. This is correct because the graphics API does not care about the non-visible area. This was done to avoid a green line error: making the size of the EGLImage equal to the visible size allows the texture sampler to not sample beyond the visible area, so the green line (part of the non-visible area) is avoided. The problem is that the coded size of the VideoFrame sent to the client still contained the non-visible area. This is arguably strange because as far as the client is concerned, this non-visible area does not exist. This was also causing problems when PaintCanvasVideoRenderer requested a copy from the VideoFrame's texture: the coded size was bigger than the visible size used to create the EGLImage. This caused black images to be displayed some times (e.g., thumbnails of videos in the Camera Capture App) because the GL commands sent from the client didn't pass validation in the service side (e.g., "GL ERROR :GL_INVALID_VALUE : glCopySubTextureCHROMIUM: source texture bad dimensions"). This CL changes VaapiVideoDecodeAccelerator so that the coded size of the VideoFrame only includes visible data. Additionally, it is possible for a decoded frame to end up as an overlay plane. In that case, the size of the DRM framebuffer should match the visible area of the frame. This is important so that the non-visible area doesn't appear in the overlay path. Therefore, this CL plumbs the desired framebuffer size all the way through Ozone. There is a caveat, however: there is an unusual corner case where an H.264 video includes information about a visible rectangle whose origin is not at (0, 0). Therefore some of the top and left parts of the video should not be displayed. However, Chrome does not currently deal well with this case, and this CL doesn't change that (i.e., those non-visible areas are still displayed). Note: follow-up CLs will deal with V4L2 and the VideoDecoder interface variations. Bug: 1045597 Test: Record video in nocturne's CCA and inspect thumbnail. Change-Id: I7076b66bfa7cb2284f6a5431968e98053f9b8103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056285 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744799}
-
Mohamed Heikal authored
Change-Id: I654b012aa61ba9c782c22e2a8fe2ade32186a7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076100 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744798}
-
James Cook authored
I missed a couple of references to identity service code when I migrated the assistant to the in-process IdentityManager. Original migration CL: https://chromium-review.googlesource.com/c/chromium/src/+/2033572 Bug: none Change-Id: Ic9226edf99e08657cdae6c4fd58cd4fd64abf933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071048Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#744797}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8995c0468a44..9bda3eea9509 git log 8995c0468a44..9bda3eea9509 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 rsavitski@google.com Merge "traced_perf: bump fd timeout and add more cts logging" Created with: gclient setdep -r src/third_party/perfetto@9bda3eea9509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie2e28bd8ae02712223d16b32a6d9d52fce1a906b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075447Reviewed-by:
-
Stefan Zager authored
The root cause of the linked bug is that IntersectionObserverController continues to track an observer after the observer's root element is deleted. This CL tightens up the conditions for which objects are tracked: - Explicit root observers with observations, if the root is connected - Implicit root observations, if the target is connected BUG=1046897 R=vmpstr@chromium.org Change-Id: Ib98a0dd3c948e61200cd270011cfe18b8776d7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068860Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#744795}
-
Xiao Yang authored
1. Added null check for submenu Host in RenderViewContextMenuViews:: Show() to avoid crash. Bug: 1054962 Change-Id: Iff52355a89c64038dd3f7828a638b804563d4ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070960Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Xiao Yang <yanxiao@google.com> Cr-Commit-Position: refs/heads/master@{#744794}
-
Evan Stade authored
The flake seems to occur when the touch is handled by selecting text on the page, so switch to a page that doesn't have text in the way of the touch. This also puts a timeout on each CountDownLatch since an unbounded await() leads to very unhelpful (i.e. non-existent) error output. Bug: 1052802 Change-Id: I44393c4a821413e626eb3a5ef4c2e16609022040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074812 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744793}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py 61f538d37b80eb589f8990f0b4513d702704ea38`. Bug: 1051578 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ibc750b521a92fe46f5298983d384f0f9670159b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074698Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#744792}
-
Shawn Gallea authored
This is needed for CastContentWindow to receive backgesture support notifications Merge-With: eureka-internal/367600 Bug: Internal b/149740737 Test: Build cast_shell Change-Id: Iacde9b0687106b1093572fa0b2f8339a2d7b5bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071015Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#744791}
-
Andrew Luo authored
Change-Id: I5d81e5569a061d0e4609449c49835e61a810bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073120 Auto-Submit: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744790}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f9fdd5a2a7e..97edc4e61387 Created with: gclient setdep -r src-internal@97edc4e61387 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I98bd4cad411ad05182b07b596f1a2474b4993a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744789}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b9b4569b9b76..8aea6d5a87b8 git log b9b4569b9b76..8aea6d5a87b8 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 b.schade@samsung.com glslang: enforce initialize and release as once per process Created with: gclient setdep -r src/third_party/angle@8aea6d5a87b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I41d3e754757fe0eb61596d72247b1fe8eac3b97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075444Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/68e2a460..f8918f99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I27224878ba8ac5ac61192513e613c062b21c77d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744787}
-
Andrey Kosyakov authored
Also, disable glib explicitly for headless. Change-Id: I10c4d46e623b9a5b563067e51ba9daf1646369a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075084Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744786}
-
Sean Gilhuly authored
The new Dawn swapchain API is not implemented yet. Use the old swapchain path by passing a null wgpu::Surface to CreateSwapChain(). The bug for implementing the new API is https://crbug.com/dawn/269. Bug: 1021566 Change-Id: I76306856cca919a4e2ef131087163204f41f91ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075458Reviewed-by:
-
Will Harris authored
This is a reland of a8a9ff46 Only change from original CL is to remove the macOS sandbox changes. Original change's description: > Run v8 in proxy resolver in jitless mode. > > This allows MITIGATION_DYNAMIC_CODE_DISABLE to be enabled for the > process on Windows, and moves PAC resolver from the Renderer helper > variant to the Default helper variant on macOS. > > BUG=961831,961592 > > Change-Id: I90f9dc69fa5ebf43f71b0395d7d2217fc24181b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051153 > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741531} Bug: 961831, 961592, 1052853 Change-Id: I847f3987ca2c21cd4999bd9c226261223ef045d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064588Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744784}
-
Peng Huang authored
Bug: None Change-Id: Id4ef48633b81f575ff0fb863bbc34fdd929be880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075048Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744783}
-
Etienne Bergeron authored
This CL is fixing a source of flakiness we observed acrross different computer. The gfx_unittests are using SetGlyphWidth to avoid relying on the underlying font information for testing some API. Unfortunately, we often ovserved inconsistency accross different platform and blocked many CL on incorrect behavior based on the following bug: Within the ShapeRunWithFont(...) code, the x_offset may not be 0 even if the glyph size is zero. It can also be negative for some fonts. Looking to the failing bot, we got these values: Font: ".SF NS Text" Offset: is -0.0952148 Glyph: 1216 To fix the issue, we proposed to keep the x_offset to zero when a glyph_size is used. This only affects tests, otherwise no functionnal change. Bug: 1056220 Change-Id: I486722a5e64c1e4ee85aa373343a19c1a1ac1331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075079Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c310889ec791..9731a14ff8ec git log c310889ec791..9731a14ff8ec --date=short --first-parent --format='%ad %ae %s' 2020-02-26 brandtr@webrtc.org Improve logging for UpdateActiveSimulcastLayers. 2020-02-26 mirtad@webrtc.org Report available instead of encoding bitrate to VideoEncoderSelector. 2020-02-26 phoglund@webrtc.org Whitespace change to kick bots. 2020-02-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 159524df..0bba1cec (744393:744590) Created with: gclient setdep -r src/third_party/webrtc@9731a14ff8ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I061653cdaa571acf086f694f20ccece83b954e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075439Reviewed-by:
-
Etienne Pierre-doray authored
https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/42c8c62f292a..acf93761dc00 $ git log 42c8c62f2..acf93761d --date=short --no-merges --format='%ad %ae %s' 2020-02-19 etiennep [Clank SSM]: Update BUILD visibility and cflags. 2019-11-05 charliea Add sources.py `prune` subcommand to prune unrequired sources 2019-11-05 charliea Fixes a bug causing sources to appear multiple times in sources.py 2019-11-01 charliea Create a tool to list source file dependencies for libunwindstack Created with: roll-dep src/third_party/libunwindstack Bug: 989102 Change-Id: I46753ac81b11e96267e5bdb62fde483545f9596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074919Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#744780}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/17f4e8b9da14..e93f058d4492 git log 17f4e8b9da14..e93f058d4492 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 oksamyt@chromium.org [WebView] Set the correct target_os for WebView browsers Created with: gclient setdep -r src/third_party/catapult@e93f058d4492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050599 Tbr: sadrul@google.com Change-Id: I2bf50087a2f2e7d4a83f40164573a4ea4bf9dac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074596Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1020124 Change-Id: I4fb22f80440e7f5cdf6489b3ac9e4c2c4f0ed580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892776Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744778}
-
Dmitry Gozman authored
When passing clip (which translates to viewport override), we use it as a visible rect override. Clip/viewport in the protocol uses document coordinates (relative to the 0;0 of the document), but visible rect is relative to the frame. For clipping to work, we should translate the coordinates. This bug does not usually manifest due to kPixelDistanceToRecord inflation of the interesting rect (see composited_layer_mapping.cc), which paints interesetings rect +4000px in every direction. If scroll position is no more than 4000, this compensates for the wrong visible rect override. Bug: none Change-Id: I9c994c08da379c76c56523969f27c049be77d9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068890Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744777}
-
Mila Green authored
Bug: 1055876 Change-Id: I5ffb6614730422b3ef98ea8d02cefd94581e1449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072661 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#744776}
-
Sigurd Schneider authored
Bug: chromium:1056284 Also-by: janscheffler@chromium.org Change-Id: I65832e22730f98609be3213c8847fcaab47ced88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075378 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/65314c068c43..b01f8fe7eb22 git log 65314c068c43..b01f8fe7eb22 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 pfaffe@chromium.org Add wasm sourcemap testcase 2020-02-26 jacktfranklin@chromium.org TypeCheck Common/TextDictionary.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@b01f8fe7eb22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1054664 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib34daa9fa7de077eaf86350dcf7434e950f29b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075443Reviewed-by:
-
Joshua Peraza authored
Change-Id: Ifd7e98467fc83c7341cc96c273062add52c98e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072668Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Ben Pastene authored
Needs crrev.com/c/2070324 landed & deployed to staging before this can land. Bug: 812428 Change-Id: I06d240b78dfcb8d7b5e735a5c67498c55041c9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057783Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Ben Joyce authored
This will take the higher version rather than the lower. Add ability to exclude libraries from taking the higher version. Want to take the lower for guava_listenable_future as the higher version is an empty set that was added as a workaround. Bug: 1040958 Change-Id: I01e554e7e764686d01fdf724bd18653cfb7808c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067646Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#744771}
-
Gauthier Ambard authored
Bug: none Change-Id: Id47a70da1b939512fe893c64819daac7545f28e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074440 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
jonross authored
Some tests were recently re-enabled in the default configuration. But they failed under SkiaRenderer and were marked for triage. These tests are showing small variance when ran with --enable-gpu-rasterization, software SkiaRenderer is fine. So I've updated the FlagExpectations for them. I've also marked associated to the bug tracking the need for flag specific baseline variations. Bug: 1052768, 993384 TEST= skia_renderer_*_blink_web_tests TBR=backer@chromium.org Change-Id: I7de40a09381b91a755263a4c46558b27d12a9019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072859Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#744769}
-
Peng Huang authored
If Vulkan doesn't support VK_KHR_external_semaphore_fd or VK_KHR_external_memory_fd, ExternalVkSharedImage will fallback to use pixel copy. Bug: 1049864 Change-Id: I6ec7787ed55311ba43989c3c61aa773abfb50385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074797 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e0fbe99. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ida885dd0df211a3f8f980899ff58e0ef11bbc197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074755Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744767}
-
Steven Bennetts authored
While slightly less readable, this formats the UI logs consistently with other logs (net.log, messages), making it easier to identify coincident events and to integrate with tooling. Note: This only affects logs in Feedback reports, not in chrome://device-log (at least for now). Bug: 1054951 Change-Id: I7c5cca90aba840e45e9320d2130b0ffb42356dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072593 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#744766}
-
