- 06 Feb, 2015 40 commits
-
-
mmeade authored
This cl contains the base code plus a "simple" hello world example test. BUG=453679 Review URL: https://codereview.chromium.org/890773003 Cr-Commit-Position: refs/heads/master@{#315080}
-
Daniel Cheng authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=timvolodine@chromium.org Review URL: https://codereview.chromium.org/902973002 Cr-Commit-Position: refs/heads/master@{#315079}
-
michaelpg authored
The latest <paper-toggle-button> matches the Material Design spec. The MD-Settings page will make use of this button in a follow-up CL. Since paper-toggle-button isn't currently used in Chromium there shouldn't be any side effects for this change. R=rsadam@chromium.org Review URL: https://codereview.chromium.org/899383002 Cr-Commit-Position: refs/heads/master@{#315078}
-
rdevlin.cronin authored
Review URL: https://codereview.chromium.org/884903003 Cr-Commit-Position: refs/heads/master@{#315077}
-
vitalybuka authored
Code is not used after we Chrome stopped generation of EMF inside render. Review URL: https://codereview.chromium.org/900683004 Cr-Commit-Position: refs/heads/master@{#315076}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/7e38934..ea6ed3c31 TBR=apavlov@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/894373003 Cr-Commit-Position: refs/heads/master@{#315075}
-
tbarzic authored
BUG=455999 TEST=Chrome does not crash when changing selected printer in print preview opened in an incognito window Review URL: https://codereview.chromium.org/903123002 Cr-Commit-Position: refs/heads/master@{#315074}
-
xunjieli authored
BUG=398997 Review URL: https://codereview.chromium.org/885783008 Cr-Commit-Position: refs/heads/master@{#315073}
-
pkotwicz authored
BUG=None TEST=None R=sadrul TBR=oshima Review URL: https://codereview.chromium.org/904733002 Cr-Commit-Position: refs/heads/master@{#315072}
-
mikecase authored
This change will allow Googlers to bisect over Android builds at a finer grain than what is currently possible (currently can only bisect over official builds for Android). BUG= Review URL: https://codereview.chromium.org/851333004 Cr-Commit-Position: refs/heads/master@{#315071}
-
quiche authored
Add tests which exercise wifi_sync's ability to add networks. These tests add a network to the platform wifi config, and then verify that the new network appears in other sync clients. BUG=chromium:431435 TEST=sync_integration_tests --gtest_filter="*Wifi*" Review URL: https://codereview.chromium.org/843483004 Cr-Commit-Position: refs/heads/master@{#315070}
-
sullivan authored
Loosen the parsing of CDB output in windows; it can start with at least 'ChildEBP' or 'Child-SP', and the extra output probably isn't much if those are not found. BUG=433966 Review URL: https://codereview.chromium.org/904063002 Cr-Commit-Position: refs/heads/master@{#315069}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/50785a3..02c8fd0 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/904913002 Cr-Commit-Position: refs/heads/master@{#315068}
-
jamescook authored
* Fix dependency issues in //extensions * Make protobuf library add the "src" directory to the compiler's include directory list, otherwise it tries to use /usr/include/google/protobuf which has incompatible headers. BUG=455919 TEST=compiles and links in both component and non-component builds Review URL: https://codereview.chromium.org/889253004 Cr-Commit-Position: refs/heads/master@{#315067}
-
tommi authored
WebRTC 8220:8272 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cfe4b49..0506804 Libjingle 8221:8270 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/18f533d..184c120 TBR=magjed@chromium.org Review URL: https://codereview.chromium.org/902183002 Cr-Commit-Position: refs/heads/master@{#315066}
-
creis authored
Revert of Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation (patchset #1 id:1 of https://codereview.chromium.org/905463004/) Reason for revert: Test fixed in https://codereview.chromium.org/904673004/, https://crrev.com/315063. Original issue's description: > Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation > > This test fails within the WebContentsObserverSanityChecker, since no IPC > for RenderFrameCreated is sent. Disable while we find a good way to make > the sanity checker play nicely within the unit test framework running in > --site-per-process > > BUG=417518 > > Committed: https://crrev.com/33e0ed259a19bc6c918fa11fcacffdf709440447 > Cr-Commit-Position: refs/heads/master@{#314960} TBR=alexmos@chromium.org,jam@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=417518 Review URL: https://codereview.chromium.org/870653006 Cr-Commit-Position: refs/heads/master@{#315065}
-
michaelpg authored
Also remove unused and outdated 'domui_options' Review URL: https://codereview.chromium.org/900773005 Cr-Commit-Position: refs/heads/master@{#315064}
-
carlosk authored
Test NavigatorTestWithBrowserSideNavigation.BeginNavigation was broken due to the way the subframe used was added to the tree. By directly calling FrameTree::AddFrame the proper observer notifications were not being executed and triggered a sanity check. It was replaced with the already test-tailored TestRenderFrameHost::AppendChild. BUG=455484 Review URL: https://codereview.chromium.org/904673004 Cr-Commit-Position: refs/heads/master@{#315063}
-
sergiyb authored
Downloaded by: https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/util/cloud_storage.py&l=86 BUG=456091 R=sullivan@chromium.org Review URL: https://codereview.chromium.org/888883004 Cr-Commit-Position: refs/heads/master@{#315062}
-
andresantoso authored
Follow up to https://codereview.chromium.org/900613003/. Make NewTabButton and TabStripBackgroundView adopt ThemedWindowDrawing. BUG=455955,453996 Review URL: https://codereview.chromium.org/904503003 Cr-Commit-Position: refs/heads/master@{#315061}
-
avi authored
BUG=453708 TEST=as in bug Review URL: https://codereview.chromium.org/902083002 Cr-Commit-Position: refs/heads/master@{#315060}
-
glider authored
According to issue 444835 there were at least two problems with debug info on the swarming bots: - the .dSYM bundles for the test binaries and other applications weren't uploaded to swarming servers; - for some binaries (e.g. Chromium Framework) their names were replaced with SHA-1 hashes that confused llvm-symbolizer and made finding the .dSYM bundles impossible. This CL adds the necessary .dSYM paths to .isolate files for the tests currently being ran on swarming bots (for other tests their .dSYM paths will be added as needed). It also extends tools/valgrind/asan/asan_symbolize.py with a binary name filter that replaces the hashes with the corresponding file names in the product directory. BUG=444835 R=earthdok@chromium.org,maruel@chromium.org,csharp@chromium.org Review URL: https://codereview.chromium.org/859293002 Cr-Commit-Position: refs/heads/master@{#315059}
-
kkimlabs authored
We needed this flag to fix HostDriven_SearchByImageTest.testSearchByImageTest. BUG=455653 Review URL: https://codereview.chromium.org/903983002 Cr-Commit-Position: refs/heads/master@{#315058}
-
aberent authored
Revert of Roll android_tools f6e2370:2a860d8 (patchset #2 id:20001 of https://codereview.chromium.org/900273003/) Reason for revert: Some builders apparently don't yet have Google Play Services installed. Original issue's description: > Roll android_tools f6e2370:2a860d8 > > This rolls in an update to android_tools.gyp that provides targets for > Google Play Sevices libraries. > > BUG=450675 > > Committed: https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d > Cr-Commit-Position: refs/heads/master@{#315037} TBR=mcilroy@chromium.org,rmcilroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450675 Review URL: https://codereview.chromium.org/889603009 Cr-Commit-Position: refs/heads/master@{#315057}
-
alemate authored
This reverts commit 44036d05 From review: https://codereview.chromium.org/899113002 Original issue's description: > This CL makes "timezone auto update" feature available (but switched off by > default) to users. And adds flag to disable this feature. > > BUG=416494 > TEST=manual > > Review URL: https://codereview.chromium.org/898503002 TBR=stevenjb@chromium.org,dpolukhin@chromium.org,isherman@chromium.org BUG=416494 Review URL: https://codereview.chromium.org/909453002 Cr-Commit-Position: refs/heads/master@{#315056}
-
benwells authored
The heuristic ensures that the user is not prompted too much, and is only prompted after showing sustained engagement with a site. BUG=452825 Review URL: https://codereview.chromium.org/886643003 Cr-Commit-Position: refs/heads/master@{#315055}
-
shrike authored
Replaced occurrences of [HyperlinkTextView setMessageAndLink:withLink: atOffset:font:messageColor:linkColor:] with [HyperLinkTextView setMessage:withFont:messageColor] and [HyperLinkTextView addLinkRange:withName:linkColor:]. Removed the [HyperLinkTextView setMessageAndLink:withLink:...] method. BUG=253755 TEST=it's very difficult to produce test sequences for most of these changes. Here is the one sequence I do have: for sad_tab_view_cocoa.mm: Launch Chrome, run ps augx | grep “Chrome Helper” in a Terminal window, create a new tab and go to some page, run the ps... commands again and figure out the process number of the new Chrome Helper (the one that wasn’t there before). In a Terminal window type kill -9 <XXX> where <XXX> is the process id of the new Chrome Helper. Confirm the new tab now shows the sad tab page and that the last line of text reads, “If you're seeing this frequently, try these suggestions.” with the word “suggestions” as a clickable link that takes you to the “Aw, Snap!” Chrome help page. Review URL: https://codereview.chromium.org/887823002 Cr-Commit-Position: refs/heads/master@{#315054}
-
dvadym authored
1.Parallelizing run of tests 2.All options were moved from command line args to config 3.Introducing possibility to avoid writing to sheet BUG=435249 Review URL: https://codereview.chromium.org/903763003 Cr-Commit-Position: refs/heads/master@{#315053}
-
battre authored
BUG=432398 Review URL: https://codereview.chromium.org/892413007 Cr-Commit-Position: refs/heads/master@{#315052}
-
boliu authored
detachGLFunctor is called every time the webview is detached (ie when hardware acceleration is torn down and cleaned up). This can happen many times since webview can be attached and detached many times. However the implementation in the glue layer only does something on the first call. Also in general, it's a bad pattern for CleanupReference to have strong java refs. It's not necessary to call detachGLFunctor on gc; detach is enough. So move all that code out of the DestroyRunnable of the CleanupReference. This is a long standing bug since the first release of chromium webview. BUG= Review URL: https://codereview.chromium.org/872403006 Cr-Commit-Position: refs/heads/master@{#315051}
-
mseaborn authored
This will allow the ResolveFileToken field to be removed from NaClValidationCache on the NaCl side. Chromium no longer uses the NaCl side's ability to call back to ResolveFileToken(). File tokens are handled entirely on the Chromium side. Removing this is safe because the NaCl side doesn't call ResolveFileToken() if the NaClDesc doesn't have a file token associated with it, or if ResolveFileToken is NULL (and we're setting it to NULL using memset()). BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073 TEST=browser_tests Review URL: https://codereview.chromium.org/897353002 Cr-Commit-Position: refs/heads/master@{#315050}
-
mseaborn authored
Use the API that's defined in native_client/src/public/. That is already used by nacl_listener.cc, but the code in nacl_ipc_adapter.cc was written earlier, before the API in public/ was added. NaClDescCreateWithFilePathMetadata() does the same as the code we're replacing here. BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073 TEST=browser_tests Review URL: https://codereview.chromium.org/897363002 Cr-Commit-Position: refs/heads/master@{#315049}
-
vmiura authored
Implements a GPU Channel level command buffer barrier, which ensures ordering between channels, without immediately notifying the GPU service. Multiple Ordering Barriers can be combined into single IPCs to the GPU service, thus this API can be used in place of ShallowFlushCHROMIUM, to reduce IPC count and GPU service overhead. BUG=454500 Review URL: https://codereview.chromium.org/896723008 Cr-Commit-Position: refs/heads/master@{#315048}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/055aa2d..7e38934 TBR=apavlov@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/909513002 Cr-Commit-Position: refs/heads/master@{#315047}
-
igsolla authored
Ensure that the android_webview_locales_rename_paks action is not executed when building downstream. Review URL: https://codereview.chromium.org/881623003 Cr-Commit-Position: refs/heads/master@{#315046}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/5245cb4..50785a3 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/872893005 Cr-Commit-Position: refs/heads/master@{#315045}
-
skyostil authored
BUG=455796 Review URL: https://codereview.chromium.org/893843005 Cr-Commit-Position: refs/heads/master@{#315044}
-
noms authored
BUG=447311 TEST=Start Chrome with --enable-fast-user-switching. In the avatar bubble, any profiles with default avatar should display the low res, transparent background images (i.e. not the high res images with the grey background) Review URL: https://codereview.chromium.org/900223004 Cr-Commit-Position: refs/heads/master@{#315043}
-
rmcilroy authored
Adds a deadline overrun step to the RendererSchedulerIdlePeriod trace event to make it obvious when an idle period lasts longer than its deadline. Also adds a TRACE_EVENT_ASYNC_STEP_INTO_WITH_TIMESTAMP0 which is required to add the step at the appropriate time. BUG=455713 Review URL: https://codereview.chromium.org/908473002 Cr-Commit-Position: refs/heads/master@{#315042}
-
jochen authored
This is to rule out the (unlikely) case that we're sending idle notifications to a disposed isolate BUG=425035 R=dcarney@chromium.org Review URL: https://codereview.chromium.org/873723008 Cr-Commit-Position: refs/heads/master@{#315041}
-