GitLab

This didn't show up as slow in any traces (I didn't even look). Just
came upon this micro-optimization when trying to learn what happens
during normal start-up.

Should be faster just by virtue of referencing fewer classes, and
avoiding a reflective call made by isVrEnabled().

Change-Id: I2256be591079917018037bb5881bee1a5c8888da
Reviewed-on: https://chromium-review.googlesource.com/766949Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516315}

The comment refers to code in Browser::ActiveTabChanged, not
BrowserView::OnTabChanged. See code block below

https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?type=cs&q=Browser+ActiveTabChanged&sq=package:chromium&l=1064-1067

This is particularly misleading as one might try to find
the reference in BrowserView::OnActiveTabChanged, which has no
direct reference to the comment in OmniboxViewViews::OnTabChanged.

Change-Id: I71e79e3fe6e874b569e9d4b6da122852eccd3d37
Reviewed-on: https://chromium-review.googlesource.com/767367
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516314}

It seems like on iOS 11 the autoresize masks don't work well when the
device is rotated. Since suggestions rows don't really need the mask
since the frame of each view is exactly calculated and set every time it
changes the size, remove the use of autoresize masks.

including long and short suggestions, answers; specifically verify that
text is not clipped in unexpected ways even when rotating to landscape
and back.

Bug: 768374
Test: Please test by displaying all possible suggestions in omnibox,
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia00b60187b3d99e7e09dcd82d107c6a809492316
Reviewed-on: https://chromium-review.googlesource.com/760937
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516313}

Convert FaviconWebStateDispatcherTest to directly track
registration with the observed WebState instead of relying
on the deprecated code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I40a70007d5dfab9c13439daf40bf361145bb830c
Reviewed-on: https://chromium-review.googlesource.com/766790
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516312}

This reverts commit a270ee75.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add aura::WindowOcclusionTracker.
> 
> aura::WindowOcclusionTracker notifies interested windows
> when their occlusion state change.
> 
> This will be used to release resources and throttle execution
> of occluded tabs.
> 
> Time to recompute occlusion on a Samsung Chromebook Pro:
>  100 partially occluded windows*: 108us
>  50 partially occluded windows*: 50us
> * window 0 at position (x=0;y=0), window 1 at position (x=1;y=1),
>   window 2 at position (x=2;y=2), etc.
> Benchmark code:
> https://chromium-review.googlesource.com/c/chromium/src/+/718979
> 
> 
> Bug: 738387
> Change-Id: I65e9e3eb58461e14eda280a133f0acb23a9f1c40
> Reviewed-on: https://chromium-review.googlesource.com/679206
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516293}

TBR=sadrul@chromium.org,fdoray@chromium.org

Change-Id: Ib9d0056b520f8fef13d97f0736dbde197c14882d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 784879
Reviewed-on: https://chromium-review.googlesource.com/768168Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516311}

Test:
  ninja -C out\debug
  python content\shell\tools\breakpad_integration_test.py ^
      --build-dir=out\debug ^
      --binary=out\debug\content_shell.exe

Bug: 466890
Change-Id: I76bf5c3e165d450d401aa3ac689cb0b5b49f3511
Reviewed-on: https://chromium-review.googlesource.com/760549Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516310}

ExtensionEnableFlow tries to re-enable a disabled extension, but did not
account for extensions that cannot be re-enabled by enterprise policy.
This would result in the ExtensionEnableFlow trying to re-enable the
extension (which would fail), and then notifying the delegate that the
re-enable was successful (which it wasn't).

This could lead to an infinite loop in the app list, where an
ExtensionAppItem would try to launch, see the extension needed to be
re-enabled, try to re-enable the extension through the
ExtensionEnableFlow, see that it was successful, and try to launch.

Fix this by checking if the extension must remain disabled in the
ExtensionEnableFlow and responding appropriately. Add a regression test
for the same.

Bug: 783831

Change-Id: I53cddecc895a9602f0884fa022b68ea7a6c2d667
Reviewed-on: https://chromium-review.googlesource.com/764851
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516309}

Any custom View may provide ThemeProvider. TypographyProvider
implementation should have possibility to consult the ThemeProvider in
similar way NativeTheme can be consulted.

Bug: 691891
Change-Id: I4d67dfa870d9c439292f74c96e408bb7a9471059
Reviewed-on: https://chromium-review.googlesource.com/730583
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516308}

MediaRouterMojoImpl::JoinRoute() requires that we find the MediaRouteProvider associated with a presentation ID.
By associating each MediaRoute with a presentation ID, we can look up the associated MRP.
The change to add presentation ID to MediaRoute on the component extension side has landed as cl/173960916.

Bug: 779155, 761493
Change-Id: I4bf7d6fb3a832ef4720bfc1952198fd2036350b2
Reviewed-on: https://chromium-review.googlesource.com/757796Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516307}

https://skia.googlesource.com/skia.git/+log/5b65a84b990e..1662257bdaaa

$ git log 5b65a84b9..1662257bd --date=short --no-merges --format='%ad %ae %s'
2017-11-10 bungeman Alloc glyph image correctly for SkMask::k3D_Format.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I89bd7e88b9f3c4fe934a3bcddfe1c86f661d144c
Reviewed-on: https://chromium-review.googlesource.com/768470Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516306}

This reverts commit 0a8e88e5.

Reason for revert: Broke build.
https://luci-milo.appspot.com/buildbot/internal.client.clank_tot/clang-clankium-tot-builder/52982

Original change's description:
> [Payments] Capability matching for payment handlers on desktop.
> 
> Before this patch, payment handlers for "basic-card" would always be
> shown in desktop payments UI, even if their "capabilities" field did not
> match the merchant's request.
> 
> This patch sends the full PaymentMethodData array to the
> ServiceWorkerPaymentAppFactory, so the factory can compare the
> "capabilities" of payment handlers for "basic-card" to the merchant's
> requested PaymentMethodData. The factory compares the capabilities only
> for "basic-card".
> 
> After this patch, a payment handler for "basic-card" shows up in desktop
> payments UI only if its "capabilities" field matches the merchant
> request.
> 
> Bug: 777470
> Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278
> Reviewed-on: https://chromium-review.googlesource.com/744541
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Commit-Queue: Mathieu Perreault <mathp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516295}

TBR=rouslan@chromium.org,mathp@chromium.org,gogerald@chromium.org

Change-Id: I25260d461ebd180c817c5cf2943faaaee74245f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 777470
Reviewed-on: https://chromium-review.googlesource.com/768604Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516305}

This CL cleans up code in ChildAccountService and related classes
without any changes to the behavior:
1. Use lambdas instead of anonymous classes.
2. Remove unused parameters.

Bug: None
Change-Id: If6a19bfb8b8cde27d35986325d218740e9337d52
Reviewed-on: https://chromium-review.googlesource.com/766968Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516304}

Is currently failing on the Android WebView L/M bots.

BUG=784868
TBR=wychen@chromium.org
NOTRY=true

Change-Id: I061577724093cae3ab1d3440ffa93757cf556ec5
Reviewed-on: https://chromium-review.googlesource.com/768721Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516303}

R=haraken@chromium.org

Change-Id: Ia88e4aefd42f295a0768dd9ae68e6b2f822d84ed
Reviewed-on: https://chromium-review.googlesource.com/766794
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516302}

This CL doesn't bring any functionality changes. It just aligns
the *Fullscreen word with other code around chromium.

TBR=rjkroege@chromium.org

Bug: 666958
Change-Id: I8c3937a5221641750846738c93f46496c00551b8
Reviewed-on: https://chromium-review.googlesource.com/768741
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#516301}

Ensure we mask on the current keyboard modifer state so that all
modifier keys can be detected.

BUG=783793

Change-Id: I0dd0cfaabc32f6a8df0cbea793bbac43dbe3dcb6
Reviewed-on: https://chromium-review.googlesource.com/766667Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516300}

Convert PasswordTabHelper to directly track registration with
the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iab720008b6da7df451da230628f3a5c75fb72da0
Reviewed-on: https://chromium-review.googlesource.com/766789
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516299}

The change these were introduced to track was over 1.5 years ago. We
collected the necessary data and the deprecation workaround was removed
a year ago, so its time for these counters to be removed.

Bug: 601672
Change-Id: I64f0e78152068000622421111765678b6ce798d7
Reviewed-on: https://chromium-review.googlesource.com/767056Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516298}

This reverts commit 7860090b.

Reason for revert: Likely cause of ANR / DCHECK

Original change's description:
> [Android O] Clean up notification settings on channel migration
> 
> - Previously when migrating to channels, the content settings were
> simply copied over to the NotificationChannelsProviderAndroid from
> the PrefProvider.
> 
> - Now they are deleted from the PrefProvider as they are copied over
> to the NCPA.
> 
> - This avoids old content settings hanging around and getting
> reinstated on channel deletion.
> 
> Bug: 781524
> Change-Id: Ic00ddd4996e8a17775678193b6ffdb0b4d62d5fa
> Reviewed-on: https://chromium-review.googlesource.com/760936
> Reviewed-by: Raymes Khoury <raymes@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Commit-Queue: Anita Woodruff <awdf@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515538}

TBR=raymes@chromium.org,peter@chromium.org,awdf@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 781524,784823
Change-Id: I53d19029118bbd0c907ad1317f744e3e6e0a80c3
Reviewed-on: https://chromium-review.googlesource.com/768787Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516297}

Convert InfoBarManagerImpl to directly track registration with
the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Remove unused method InfoBarManagerImpl::WebStateFromInfoBar
as it accessed deprecated web_state() method.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I55574e425107a3306bc0ba2085d699d4008c3f44
Reviewed-on: https://chromium-review.googlesource.com/766750
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516296}

Before this patch, payment handlers for "basic-card" would always be
shown in desktop payments UI, even if their "capabilities" field did not
match the merchant's request.

This patch sends the full PaymentMethodData array to the
ServiceWorkerPaymentAppFactory, so the factory can compare the
"capabilities" of payment handlers for "basic-card" to the merchant's
requested PaymentMethodData. The factory compares the capabilities only
for "basic-card".

After this patch, a payment handler for "basic-card" shows up in desktop
payments UI only if its "capabilities" field matches the merchant
request.

Bug: 777470
Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278
Reviewed-on: https://chromium-review.googlesource.com/744541Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516295}

BUG=b/67617383

Change-Id: I0a8308d96e84256e363ce8127da7720b04e2aea6
Reviewed-on: https://chromium-review.googlesource.com/768493Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516294}

aura::WindowOcclusionTracker notifies interested windows
when their occlusion state change.

This will be used to release resources and throttle execution
of occluded tabs.

Time to recompute occlusion on a Samsung Chromebook Pro:
 100 partially occluded windows*: 108us
 50 partially occluded windows*: 50us
* window 0 at position (x=0;y=0), window 1 at position (x=1;y=1),
  window 2 at position (x=2;y=2), etc.
Benchmark code:
https://chromium-review.googlesource.com/c/chromium/src/+/718979


Bug: 738387
Change-Id: I65e9e3eb58461e14eda280a133f0acb23a9f1c40
Reviewed-on: https://chromium-review.googlesource.com/679206
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516293}

Convert HistoryTabHelper to directly track registration with
the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0b3f3b63e599ad2327df155a75549248b8db9b1b
Reviewed-on: https://chromium-review.googlesource.com/766749
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516292}

Convert FindTabHelper to directly track registration with the
observed WebState instead of relying on the deprecated code in
WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I69071028a6f8476734d19da1eeaa92e7e9751b6d
Reviewed-on: https://chromium-review.googlesource.com/766748
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516291}

https://skia.googlesource.com/skia.git/+log/74c8436f2c34..5b65a84b990e

$ git log 74c8436f2..5b65a84b9 --date=short --no-merges --format='%ad %ae %s'
2017-11-13 robertphillips Resolve GrSurface/GrSurfaceProxy ref counting issue in GrResourceAllocator

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Iaabd39e651032547bdad75f188c2cabda7139094
Reviewed-on: https://chromium-review.googlesource.com/768548Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516290}

Bug: 
Change-Id: If3c10d6225fb36f9b4e1f032b55fcddbf0bae572
Reviewed-on: https://chromium-review.googlesource.com/768675Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516289}

Setup work to change the welcome page visuals based on the DICE status
of the profile. The new_welcome* files are exact copies of the original in this CL
and there will be follow-up CLs to iterate on them.

Bug: 782155
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If620f91b4b30b70ca34ac9db5fd1f27c893bd189
Reviewed-on: https://chromium-review.googlesource.com/751461
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516288}

Add a new DatabaseTask, GetDeveloperIdsTask which reads the
developer_ids from the database.

To avoid multiple database look ups or hacks like encoding the key into
the data, add a new method to ServiceWorkerContextWrapper,
GetRegistrationUserKeysAndDataByKeyPrefix, that returns a map of the
keys and their values.

Also fix method description for ReadUserDataByKeyPrefix to say it
returns STATUS_OK if no records are found in an otherwise successful
read since that's what the code does. Add a unit test for
ReadUserDataByKeyPrefix that verifies that the above comment change is
correct.

Bug: 757760
Change-Id: I40baa5e1a9997cd2c7ed7b7f0094156b515127cd
Reviewed-on: https://chromium-review.googlesource.com/764127
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516287}

Convert FormSuggestionTabHelper to directly track registration
with the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib6af771e783285a8efd6b6b640a38b76b4c7caac
Reviewed-on: https://chromium-review.googlesource.com/766788
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516286}

BUG=739343

Change-Id: I5d22b76b8a321eccb82a1811ea1a906a93435ac4
Reviewed-on: https://chromium-review.googlesource.com/768730Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516285}

This CL adds the Toolbar objects (coordinator/mediator/ViewController)
created in ios/clean in ios/chrome/browser/ui/toolbar/clean.
It will allow to modify and use them in chrome. For now those objects
are not used in ios/chrome, to allow an easier review.
All the content specific to ios/clean is removed, except the dispatcher
protocols which are adapted to the ones used in ios/chrome.

The classes are duplicated, with the one in ios/clean prefixed with
"Clean". The constants and other utility files are moved.

Having this code checkout in ios/chrome will allow to work on them more
easily than having to import them file by file every time we need to
use one.

Bug: 784372
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia5eb513198b32a1d2f93603c36884c90d04cbbaf
Reviewed-on: https://chromium-review.googlesource.com/766370Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516284}

Using wpt-import in Chromium d301cfc6.
With Chromium commits locally applied on WPT:
23705631 "service worker: Upstream sandboxed iframe test to WPT."


Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5245

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bajones@chromium.org:
  external/wpt/gamepad
domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org:
  external/wpt/streams

TBR=jsbell

No-Export: true
Change-Id: I5e5479f0de1868be63cd58b5acec42abbdaded4a
Reviewed-on: https://chromium-review.googlesource.com/768448
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516283}

The same logic used to sort passwords on other platforms will now be used on iOS too. This includes:
    - not displaying duplicates
    - removing all duplicates of an entry from the password store when this entry is selected for
deletion.

Bug: 764747
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I85070ed7563fcac482b13aa84bb126ff252a68b7
Reviewed-on: https://chromium-review.googlesource.com/766791
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516282}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4e1cd28a..9b3020fa

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I3ff2cab7d45f3da4a7fdde9a5c2bfd3792d9c771
Reviewed-on: https://chromium-review.googlesource.com/768449Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516281}

This patch implements "call a user object's operation" steps of Web IDL
from scratch discarding the existing implementation.  The steps include
(roughly speaking) a step to push a backup incumbent.

Web IDL 3.9. User objects implementing callback interfaces
https://heycam.github.io/webidl/#call-a-user-objects-operation

Bug: 778580
Change-Id: Ib2929f866884095d01e46ae9f4483db2726bccd5
Reviewed-on: https://chromium-review.googlesource.com/763191
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516280}

Bug: None
Change-Id: Id977614b4ed9ac6862656a82dc9366dff3b0e049
Reviewed-on: https://chromium-review.googlesource.com/768415
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516279}

These logs are still very noisy, possibly to the point where tests are
failing due to the log spam. Only log every 10th glitch.

Bug: None
Change-Id: I5b29ce917561ab00074fb477dbc38670447101af
Reviewed-on: https://chromium-review.googlesource.com/768728Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516278}

Bug: 674329
Change-Id: Iac71ae590f2a94f47ae36e052b67f4ed91c4898d
Reviewed-on: https://chromium-review.googlesource.com/768309
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516277}

Convert FormInputAccessoryViewTabHelper to directly track
registration with the observed WebState instead of relying
on the deprecated code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I74892db41e08aae6c9025d4ee7bcdd21246f3ffa
Reviewed-on: https://chromium-review.googlesource.com/757336
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516276}