GitLab

Review-Url: https://codereview.chromium.org/2292833002
Cr-Commit-Position: refs/heads/master@{#415270}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8ceac5bce3e789666da2daa8607d254055788114 Use 'goma_recipe_module' ref for specifying a version of cloudtail to use. (vadimsh@chromium.org)

R=vadimsh@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2293833002
Cr-Commit-Position: refs/heads/master@{#415269}

BUG=400674

Review-Url: https://codereview.chromium.org/2293443002
Cr-Commit-Position: refs/heads/master@{#415268}

Revert of Redirect all mouse input to Alt+Tab window when it's visible, (patchset #3 id:40001 of https://codereview.chromium.org/2284763002/ )

Reason for revert:
WindowCycleControllerTest.MouseCaptureLost fails on Chrome os and Asan.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1)

Original issue's description:
> Redirect all mouse input to Alt+Tab window when it's visible,
> effectively disabling the mouse. Capture is reset when the widget is
> destroyed.
>
> BUG=641171
>
> Committed: https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa
> Cr-Commit-Position: refs/heads/master@{#415096}

TBR=sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641171

Review-Url: https://codereview.chromium.org/2294723002
Cr-Commit-Position: refs/heads/master@{#415267}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a9f1ddb6..1af4dc5a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2294663002
Cr-Commit-Position: refs/heads/master@{#415266}

This patch converts "editing/inserting/return-key-with-selection-00[123].html"
to use w3c test harness to simplify test script for improving readability, and
consolidates into "return_key_with_selection.html" since these files use
similar test sample.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2293783002
Cr-Commit-Position: refs/heads/master@{#415265}

This patch converts "editing/inserting/insert-br-at-tabspan-00[1-3].html"
to use w3c test harness to simplify test script for improving readability, and
consolidates into "insert_br_at_tabspan.html" since these files are
in same patch at beginning.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2284343002
Cr-Commit-Position: refs/heads/master@{#415264}

Retires installConditionallyEnabledProperties.  This function has been
unused for months at least, and it's now unlikely we'll need this
mechanism again.

Stops generating unused functions of preparePrototypeAndInterfaceObject.
Even when we don't use them, each function requires an unique address,
i.e. each function consumes 8 bytes.  Uses nullptr instead of generating
unused functions.

This CL is expected to reduce the size by 400k+ bytes.

BUG=621802

Review-Url: https://codereview.chromium.org/2296573003
Cr-Commit-Position: refs/heads/master@{#415263}

Use LOG(INFO) instead.

For single-line strings like showNode():
  [n:n:n/n:n:INFO:Node.cpp(n)] fooBar

For multiple-line strings like showTree():
  [n:n:n/n:n:INFO:Node.cpp(n)]
  BODY
          #text "\n"
          ...

* This CL removes Node::showNode().  It was a simple wrapper for operator<< for
  Node.

* As for HTMLFormattingElementList and SnapCoordinator, just call LOG(INFO)
  multiple times because they don't show tree structures.

BUG=638849

Review-Url: https://codereview.chromium.org/2292843002
Cr-Commit-Position: refs/heads/master@{#415262}

This patch adds 'GetDefaultConfiguration' method to the generic sensor interface.
It is required in cases when client (e.g. blink bindings) doesn't know what
configuration to use for sensor initialization or when configuration that is
provided to the client is incomplete.

BUG=606766

Review-Url: https://codereview.chromium.org/2288103002
Cr-Commit-Position: refs/heads/master@{#415261}

This patch is a preparation for removing the call site of
Document::updateStyleAndLayoutIgnorePendingStylesheets from
TextIterator::rangeLength.

BUG=590369

Review-Url: https://codereview.chromium.org/2291883003
Cr-Commit-Position: refs/heads/master@{#415260}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e0889d6a389e6d44956a7dadf94e4f6106a349da Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/c8f3a3498ec18a8dbb3775d6a1bf7bd02e26cd28 Remove non-trivial SVN config from gclient recipe module (agable@chromium.org)

R=agable@chromium.org,recipe-roller@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2290043003
Cr-Commit-Position: refs/heads/master@{#415259}

This patch converts "editing/inserting/typing-around-image-001.html" to use w3c
test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2291973002
Cr-Commit-Position: refs/heads/master@{#415258}

Every Navigation Timing's bugs were already solved, but there was still
unrelated bugs in this category.

- The test: http/tests/misc/timer-vs-loading was misclassified in
  'Navigation Timing'. It is now in 'untriaged navigation'.
- The other ones, classified in 'Navigation Timing', have been moved in
  'Resource Timing'(BUG 641912)

BUG=576261

Review-Url: https://codereview.chromium.org/2289723002
Cr-Commit-Position: refs/heads/master@{#415257}

BUG=569301

Review-Url: https://codereview.chromium.org/2290113002
Cr-Commit-Position: refs/heads/master@{#415256}

The language code match in SVGTests::isValid() uses String::substring()
to limit the match to the primary language subtag. In the case where the
defaultLanguage() only contains the/a primary language subtag, this will
not require a copy, but otherwise it would.

Using startsWith() and a length-check guarantees that no copies will be
made. (A valid primary language subtag is always 2 letter long, so
checking only for length == 2 should be enough, although previously the
code could theoretically match a 1 letter, or even a zero-length tag.)

Review-Url: https://codereview.chromium.org/2284273002
Cr-Commit-Position: refs/heads/master@{#415255}

Schemas for gnome-keyring and libsecret are not 100% interchangeable. To
support gnome-keyring, we need to use equivalent schemas in both
libraries. This will allow a user to upgrade their machine from gnome-keyring
to libsecret, without chrome losing access to OSCrypt's encryption key.

We correct the unfortunate initial choice for a schema by copying entries
to the new schema.

As a bonus, this will correct the mislabeling of some entries (see crbug/640603)

BUG=639298

Review-Url: https://codereview.chromium.org/2273723002
Cr-Commit-Position: refs/heads/master@{#415254}

Fold the targetIsUsable(...) helper from SVGAnimateElement into said
method, and then replace the uses of the former with the corresponding
'should apply' predicate.

BUG=640676

Review-Url: https://codereview.chromium.org/2287983002
Cr-Commit-Position: refs/heads/master@{#415253}

BUG=551343

Review-Url: https://codereview.chromium.org/2282403003
Cr-Commit-Position: refs/heads/master@{#415252}

Pointed out by tkent in https://codereview.chromium.org/2242743002/

The original code could do 2 hash calculations for
adding a new key-value pair to ParentChildMap
(for find() and add()), and rehashing the map
may involve copying the HeapHashSet<Member<Node>>
objects.

Change the value part of ParentChildMap from a HeapHashMap
object to its pointer, to avoid redundant hash calculation
and object copy.

This does not change any functionality of the class.

BUG=594918

Review-Url: https://codereview.chromium.org/2290543002
Cr-Commit-Position: refs/heads/master@{#415251}

BUG=631966

Review-Url: https://codereview.chromium.org/2287473002
Cr-Commit-Position: refs/heads/master@{#415250}

This patch converts "editing/inserting/redo.html" to use w3c test
harness to simplify test script and renames to "redo_insert_text.html"
to provide to provide a hint what this test script verifies, for improving
readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2296583002
Cr-Commit-Position: refs/heads/master@{#415249}

Revert of Disable PasswordManagerBrowserTestBase.InternalsPage on Mac (patchset #1 id:1 of https://codereview.chromium.org/2287143003/ )

Reason for revert:
As leonhsl@ noted on https://codereview.chromium.org/2270333002/, the test failures only happened when the Mojo change https://codereview.chromium.org/2216463002 was on the trunk. Looking at the list of flakes [1], the revision numbers speak clearly:
413708 = Mojo change went in
413716 = first flake recorded
413923 = last flake recorded
413934 = Mojo change reverted

Therefore the revert is not needed, the Mojo change needs to be fixed before relanding.

[1] https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixQYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuSW50ZXJuYWxzUGFnZQw

Original issue's description:
> Disable PasswordManagerBrowserTestBase.InternalsPage on Mac
>
> The test flakes on Mac.
>
> BUG=640737
> TBR=vasilii@chromium.org
>
> Committed: https://crrev.com/2683579867440a6ead8e06329f00bd7d0b3a1ce2
> Cr-Commit-Position: refs/heads/master@{#414996}

TBR=vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640737

Review-Url: https://codereview.chromium.org/2292893002
Cr-Commit-Position: refs/heads/master@{#415248}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257113002
Cr-Commit-Position: refs/heads/master@{#415247}

This patch converts "editing/inserting/insert-paragraph-at-end-of-line.html" to
use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2284353002
Cr-Commit-Position: refs/heads/master@{#415246}

Review-Url: https://codereview.chromium.org/2290553004
Cr-Commit-Position: refs/heads/master@{#415245}

Network time is frequently unavailable when we hit certificate date
errors. This CL histograms additional information about why network time
is unavailable (specifically, whether no time query has been made or
whether the system clock lost sync since the last time query).

To do so, I deprecated the old network time histogram that shared an
enum with the build time histogram, and introduced a new network
time histogram with a network time enum (rather than adding more
network-specific values to the enum that is shared with the build time
histogram).

BUG=

Review-Url: https://codereview.chromium.org/2254433003
Cr-Commit-Position: refs/heads/master@{#415244}

The order of the CORS error messages for the link elements is not
stable. Stop logging them and compare only output from the test cases.

R=yhirano
BUG=633834

Review-Url: https://codereview.chromium.org/2277693002
Cr-Commit-Position: refs/heads/master@{#415243}

It seems a wrong baseline was checked in. This CL removes one in platform/win7/,
and Windows 7 refers one in platform/win/.

BUG=636258
TBR=keishi@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2289083002
Cr-Commit-Position: refs/heads/master@{#415242}

Since we're going to make ExceptionStates scope-like objects at
http://crrev.com/2272613003 , ExceptionState should be
STACK_ALLOCATED().

BUG=

Review-Url: https://codereview.chromium.org/2272313003
Cr-Commit-Position: refs/heads/master@{#415241}

This patch is a preparation for hoisting the call sites of
Document::updateStyleAndLayouIgnorePendingStylesheets from
TextIterator and PlainText.

BUG=590369

Review-Url: https://codereview.chromium.org/2291943002
Cr-Commit-Position: refs/heads/master@{#415240}

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord

Review-Url: https://codereview.chromium.org/2288823003
Cr-Commit-Position: refs/heads/master@{#415239}

This patch converts "editing/inserting/insert-div-025.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2287263002
Cr-Commit-Position: refs/heads/master@{#415238}

This patch converts "editing/inserting/insert-div-021.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2288113002
Cr-Commit-Position: refs/heads/master@{#415237}

SpellChecker::markMisspellingsAndBadGrammar() is simutaneously called
from outside as a public function and used by other member functions of
SpellChecker as an internal procedure.

This patch cleans up the relations by making the function private and
introducing a public wrapper.

BUG=n/a
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2289593007
Cr-Commit-Position: refs/heads/master@{#415236}

Parent style not used for HTML element adjustment.

Review-Url: https://codereview.chromium.org/2290623002
Cr-Commit-Position: refs/heads/master@{#415235}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/14f70933ab02..be813143dbae

$ git log 14f70933a..be813143d --date=short --no-merges --format='%ad %ae %s'
2016-08-29 toyoshim Add a workaround to work with dalvik running on x86

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2292823002
Cr-Commit-Position: refs/heads/master@{#415234}

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using ~/depot_tools/watchlists.py.

Review-Url: https://codereview.chromium.org/2294603003
Cr-Commit-Position: refs/heads/master@{#415233}

"if (testRunner)" throws if testRunner is undefined.

BUG=none

Review-Url: https://codereview.chromium.org/2295653002
Cr-Commit-Position: refs/heads/master@{#415232}

Revert of Add OfflinePageSuggestionsProviderTest (patchset #10 id:180001 of https://codereview.chromium.org/2279223002/ )

Reason for revert:
Fails on Chrome os.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/25426

Original issue's description:
> Add OfflinePageSuggestionsProviderTest
>
> BUG=628198
>
> Committed: https://crrev.com/5fe00b8dfc81a113eb3d02641cf71daff59b5fa0
> Cr-Commit-Position: refs/heads/master@{#415211}

TBR=treib@chromium.org,tschumann@chromium.org,dsansome@chromium.org,pke@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628198

Review-Url: https://codereview.chromium.org/2297493002
Cr-Commit-Position: refs/heads/master@{#415231}