- 16 Oct, 2019 40 commits
-
-
arthursonzogni authored
When a page is navigated away, every RenderFrameHostImpl are properly removed from find-in-page thanks to: https://chromium-review.googlesource.com/c/chromium/src/+/1254262 However, the problem is that a removed frame does not automatically remove its highlighted selections when it is removed. This patch clear the highlighted selection. If this CL is not applied, when users will go back to the page using the back-forward cache. They will continue to see the yellow highlight. Bug=1001087 Change-Id: Ied5d152d34210d66dfa9afc66b4b775f7cd82bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841631 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706547}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79f2a7ff7c3b..e5cc32d92cbf Created with: gclient setdep -r src-internal@e5cc32d92cbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I22c5bae015863af8ae8736b5f321384998ffd436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864562Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706546}
-
Vladimir Levin authored
depends_on means that the feature is only enabled if the depended-on feature is enabled. implied_by means that the feature is automatically enabled when the implied-by feature is enabled. We want CSSContentSize to be implied-by DisplayLocking, not DisplayLocking to depend-on CSSContentSize. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I39f908dee3d7a0b99d1f727b41f76ae3c1a8efcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863564 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706545}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id87590c9ae2e3dddf858cfb5886ce359245409a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706544}
-
John Budorick authored
This reverts commit 71c00bee. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/15783 etc Original change's description: > Welcome screen: Fix language list initialization > > Change ResolveLanguageListInThreadPool so that it uses AppLocale instead > of default locale if exists. > > Bug: 955397 > Change-Id: I6947dd89e297adea3fd019e38d083e45419ea282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704098 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#706436} TBR=antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org,raleksandrov@google.com Change-Id: Ide67b58544ccedb1abf8d58f6c7baaa6ba092e4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865422Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706543}
-
Sven Zheng authored
This change can deflake some tests. https://chromium-swarm.appspot.com/task?id=47e99ad537e07c10 Key log: [4056:4920:1015/120125.356:WARNING:profile_downloader.cc(250)] Loading profile data failed [4056:4920:1015/120125.356:WARNING:profile_downloader.cc(251)] Error: -11 [4056:4920:1015/120125.356:WARNING:profile_downloader.cc(252)] Response code: -1 [4056:4920:1015/120125.356:WARNING:profile_downloader.cc(253)] Url: https://lh5.googleusercontent.com/-ojmQNrzeV7Q/AAAAAAAAAAI/AAAAAAAAAAA/ACHi3rfg5XN95Zfmg7mltoIHmd3Ql0OVKw/s256-c-ns/photo.jpg The url is actually the user's profile picture. Bug: 1010568 Change-Id: Icc7ae2bb0599c6bdef089b66a8aa84fab7ece4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864020Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#706542}
-
Yusuke Sato authored
On ARC, the property is filled with a value in config.json in /usr/lib/arc-setup in the arc-setup binary. This CL does the same for ARCVM but with the same file in /usr/lib/arcvm. BUG=b:136128691 TEST=new unittests pass Change-Id: Iac8ff895b9a6da90585d5bc057e0bd1359e28754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861038 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#706541}
-
Avery Musbach authored
Bug: 970013 Change-Id: Iebbbab09b4e1542136b79b730a53424c13ef8d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864015 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706540}
-
Piotr Pawliczek authored
Add ExternalPrintServersWhitelist policy that allows for filtering print servers defined in ExternalPrintServers policy. It also changes the format of JSON file used by ExternalPrintServers by adding a required field 'id'. BUG=chromium:988489 TEST=tested on nautilus Change-Id: I2ab24170614163893a63c0604dabc4c17904e451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857566 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#706539}
-
Garrett Beaty authored
These changes simplify migrating to starlark by removing spurious diffs from the semantic diff. The names of the buckets have been switched to short names rather than long names of the form luci.<project>.<bucket>. These are treated equivalently by buildbucket, but lucicfg does not allow long bucket names. The category field is ignored by buildbucket, so the category field has been removed from the build definitions. Change-Id: If80a00385cb7a39539472295a51b7fd8713eaf55 Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852411Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#706538}
-
Collin Baker authored
This also renames TabStripViewProxy to TabStripEmbedderProxy for consistency with TabStripUI::Embedder. Bug: 1005565 Change-Id: Id48d9fd8f946fb81d5d5e161a1cec85f97e6a426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862120Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#706537}
-
Peter Boström authored
This has now been fully replaced with HighlightPathGenerator instances. Bug: chromium:1007546 Change-Id: Id163bd002143bc4b044dcd815abb5aa45d4e41c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864381Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706536}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/520ed2286b88..ebe5dcf0d9ad git log 520ed2286b88..ebe5dcf0d9ad --date=short --no-merges --format='%ad %ae %s' 2019-10-16 tdusnoki@inf.u-szeged.hu Define getHostCPUFeatures for Windows on ARM64 platform Created with: gclient setdep -r src/third_party/swiftshader@ebe5dcf0d9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:893460 Change-Id: I8ce09bf17bcc6f9166a5b680c12e054cce23722d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864561Reviewed-by:
-
Austin Eng authored
jsoncpp will be added as a DEP of Dawn to dump perf test output Bug: dawn:208 Change-Id: I0cfc3d9caebbcffb6ff68ecd98f6bd1ad4cbf873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863356Reviewed-by:
-
Andrew Luo authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/test/android/javatests/src/org/chromium/chrome/test/pagecontroller/README.md. Bug: 924194 Change-Id: I4ac12207fcd54125f5741021a9450c6c061bfbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838306 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
-
Manu Cornet authored
Bug: 1009550 Change-Id: Ifb3ba316dfd1c6bbb48a9e3c3d2a7efec6d5a630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864609Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706532}
-
Mason Freed authored
Prior to this CL, the root damage rect might have partially intersected child render passes that had backdrop filters applied. In that case, the backdrop filter code would attempt to read back the backdrop image, and would find already-filtered content outside of the damage rect, but inside the render pass quad bounds. It would then filter this image, and if the backdrop filters moved pixels, some of that double-filtered content would bleed back into the damage rect and be used. This would lead to visual artifacts. With this CL, any child render passes that contain pixel-moving backdrop filters are checked for intersection with the root damage rect, and if they intersect, the damage rect is expanded to include the entire child render pass output rect. Bug: 986206 Change-Id: I81a51e24548cae736172938ce190f6ba4c6d2b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847675 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#706531}
-
Bruce Long authored
Per suggestion in discussion in https://crbug.com/983683, the method SyncRendererPrefs() now calls WebContentsImpl::SendPageMessage to broadcast renderer preferences changes, going through RenderFrameHostManager to send the IPC to all processes involved in a page (via RenderFrameProxyHosts in the main frame). SyncRendererPrefs was also moved to from RenderViewHostImpl to WebContentsImpl where it more logically belongs. New test coverage is added (WebContentsImplBrowserTest.SyncRendererPrefs), which fails without the fix in this change because the SetRendererPrefs IPC is never sent from the render process hosts associated with subframes. Bug: 983683 Change-Id: I70ad24b5f7a8537edfbe40db239522f13f5388b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857398Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706530}
-
Dmitry Gozman authored
This change moves DispatchDidStartProvisionalLoad, call_before_attaching_new_document, DidCreateNewDocument and DispatchDidCommitLoad to a single place in FrameLoader::CommitNavigation. The only behavior change is that DidStartProvisionalLoad now happens after commit. This makes it possible to combine all of these callbacks, greatly simplifying contract between WebLocalFrame and WebLocalFrameClient. We can also create provisional document loader after detaching previous document, which will make the commit sequence simpler. This corresponds to the step 7.d from the doc linked to the bug. Bug: 855189, 555773 Change-Id: I0b99ca33754fc22427c20cc9948a5bab571c2f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818718 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706529}
-
Himanshu Jaju authored
GetDeviceCandidates + RenameDevices had become a bit complicated to understand. Also, the number of calls to GetDeviceName has been halved (at most once per device). Bug: 1014107 Change-Id: I1f5a04f63cef1b3e94b719fc376ae4d47cfbf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865173 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706528}
-
Yuki Shiino authored
Makes SymbolNode's constructor easy to call. It turned out that most callers will pass simple template text. Bug: 839389 Change-Id: Id27031efbbb5b216866c38a62fb805349652b380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862596 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#706527}
-
Daniel Hosseinian authored
Change-Id: I8f99b6ac598d280780b1569c1deabb512312b4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860284 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
If after drag ends, we should go to home launcher screen, do the window scale down and opacity fade out animation. The window will scale down to the middle of the display and disappear. During the window scale down animation, the backdrop should be disabled. Also fixed an issue that if the drag is cancelled, overview should be dismissed if it was opened during dragging. Bug: 997885 Change-Id: I6a27c8e4bf9021e14ed0d26260c89c97adec614b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863256 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706525}
-
Aran Gilman authored
Enabling the flag appears to break rendering of most pages on ChromeOS, including chrome://flags. This CL removes the option to enable it for now. Bug: 1011696 Change-Id: I818be2add7c34e181297477244805e02f7ffcb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848478Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#706524}
-
Olivier Li authored
This is ground work for moving ProfileSyncService to the ThreadPool (see bug) but also a logical change by itself since these functions have no specific need to be run on a dedicated thread. Change-Id: I45bdbeb0a768af838700a37945613c1ddc475ea0 Bug: 1014464 Change-Id: I45bdbeb0a768af838700a37945613c1ddc475ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862666Reviewed-by:
-
Aga Wronska authored
The feature is enabled since February and no problems were reported. Bug: 1013650 Change-Id: Iec095972123022e2b0d0e0a116a373c99daaeee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856629Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#706522}
-
zhaoyangli authored
Moved ensureAppLaunchedWithFeatures from -setUp to overriding launchAppForTestMethod to eliminate unnecessary relaunches. CQ bot run results show significant improvement without the relaunches. BUG: 1009017, 1010463 Change-Id: I650304daaa9e4271310e180635a8fb6ff865f717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854786Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706521}
-
John Budorick authored
Bug: 1014754 Change-Id: I0e3e24f8c43d9835937f47e95ece0ca9f3efd82f Tbr: bsheedy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864375Reviewed-by:
-
Daniel Hosseinian authored
Change "Fit to page" string to "Fit to printable area." "Fit to paper" will center and scale the page contents of a PDF to fit the borders of the paper being printed on. In contrast, "fit to printable area" will center and scale the page contents of a PDF to fit within the margins of the printer's printable area. Bug: 989978 Change-Id: I5caf319959fb8d9bd32f3c78c86a27379cffe166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812129 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706519}
-
Yuki Shiino authored
LiteralNode is a literal text, not a template text, so the template rendering engine will output the text as is without applying any template magic. Bug: 839389 Change-Id: Ie1c83e442ba68ff242854f491b0d042ad940b73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864753Reviewed-by:
-
Elly Fong-Jones authored
While the Ok/Cancel messages appear to be dynamically computed, in fact this dialog never calls DialogModelChanged, so the initial messages are always the ones used. As such, this change will cause no behavior difference. Bug: 1011446 Change-Id: Ib23484c83eaa8c64b8e5062d922b0365b4e65d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854684Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706517}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/45deba856dba..2f8a97068d48 git log 45deba856dba..2f8a97068d48 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 taylori@google.com Merge "perfetto-ui: Go to thread state" 2019-10-16 taylori@google.com Merge "perfetto-ui: Move details panel into it's own component" 2019-10-16 fmayer@google.com Merge "Set correct fields on fist packet in sequence." 2019-10-16 tneda@google.com Merge "perfetto-ui: Show heap profile track even if the trace has only heap profiles inside" 2019-10-16 zakerinasab@google.com Merge "Fix minor issue in setting arg id" 2019-10-16 lalitm@google.com Merge "trace_processor: fix dcheck failure when we get an out of order upid counter" 2019-10-16 fmayer@google.com Merge "Fix incorrect comment." 2019-10-16 lalitm@google.com Merge "trace_processor: fix support for optional<stringid> columns" 2019-10-16 eseckler@google.com Merge "Revert "processor: Move TimestampedTracePiece into its own header"" 2019-10-16 lalitm@google.com Merge "trace_processor: add support for remaining operations on new tables" 2019-10-16 eseckler@google.com Merge "processor: Move TimestampedTracePiece into its own header" 2019-10-16 eseckler@google.com Merge "processor: Import and export legacy flow event args for all TrackEvents" 2019-10-16 tneda@google.com Merge "perfetto-ui: Fixing SQL error for ambiguous name" 2019-10-16 tneda@google.com Merge "New track with flamegraph for heap profiles" Created with: gclient setdep -r src/third_party/perfetto@2f8a97068d48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I8a168ac61ce0bcb5f8b210fc92301209a14032f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864646Reviewed-by:
-
Elly Fong-Jones authored
This change migrates all the other overrides in //chrome/browser/ui/views/autofill of GetDialogButtonLabel over to set_button_label. Many of these dialogs dynamically compute their label text based on the state of their models/controllers. That causes some difficulty with the "push-based" (client sets properties) design DialogDelegate is migrating to from its existing "pull-based" (DialogDelegate asks client for properties) design. This change migrates: 1) CardUnmaskPromptViews, by adding an UpdateButtonLabels private method to this class that pushes updated label text to DialogDelegate when needed and calling it at every point that DialogModelChanged is called. 2) LocalCardMigrationBubbleViews, which uses a static ok button text. 3) SaveCardBubbleViews, which uses controller-generated text but never updates it in use (no calls to DialogModelChanged) 4) WebAuthnOfferDialogViewImpl, which already has a RefreshContent method, by pushing new button text in that method. Bug: 1011446 Change-Id: Iaf497223e3c44c3a6227e264e40e441f2fbe389f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854689Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
-
Samuel Huang authored
This reverts commit 168860e0. Reason for reland: Fixed problem: The target source_set("dev_ui_loader") had missing dependencies, and doesn't reach. third_party/blink/public/mojom:mojom_platform Two ways to fix this are: A: Add the missing dependencies to chrome/browser/dev_ui/android:dev_ui_loader B: Remove chrome/browser/dev_ui/android:dev_ui_loader, and fold its {sources, deps} into chrome/browser:browser. We're choosing B for simplicity, but may adopt A eventually. Original change's description: > Revert "[DevUI DFM] Change install flow to use NavigationThrottle." > > Reason for revert: Seems to have broken android-archive-rel compile, though this may be exposing some pre-existing bad dependency elsewhere: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/5717 > > Change-Id: I7eff36d7e01c31a76f39250a255d27972b0962d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864392 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Original change's description: > > [DevUI DFM] Change install flow to use NavigationThrottle. > > > > Bug: 927131,987040,1013522 > > Change-Id: I5c384671c858d26a303afc58c03f4314c8ef0117 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854524 > > Commit-Queue: Samuel Huang <huangs@chromium.org> TBR=pkasting@chromium.org,creis@chromium.org,huangs@chromium.org,thestig@chromium.org,dbeam@chromium.org,agrieve@chromium.org,tiborg@chromium.org Bug: 927131, 987040, 1013522 Change-Id: I526f3194b0115171721a53fca60fa6ffa6e3c441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864411Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706514}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I935953fc0afa563c2bcb453ac4ae1e53fd755905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864749Reviewed-by:
-
Alexander Timin authored
Before restoring a RenderFrameHost from the back-forward cache, cleanup existing pending RenderFrameHost. Without the back-forward cache, this is done automatically when GetRenderFrameHostForNavigation is used. R=arthursonzogni@chromium.org,lowell@chromium.org CC=alexmos@chromium.org,nasko@chromium.org BUG=1003744 Change-Id: I52375bca1c69f02cca367434342670ae287c1ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855924Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706512}
-
ckitagawa authored
The current code is too lax. It doesn't enforce bounds checks strongly enough. It claims to be for RVAs, but allows all sections through. This results in downstream code being unable to trust that the regions created are safely within the image resulting in issues when Fuzzing if the data is ill formed. To fix the fuzzers we should be remove this forgiveness. However, long term a better check for RVA forgiveness should maybe be investigated. Bug: 1013823, 1013842, 1013871, 1014124 Change-Id: Ic164fc76d687711c496f57b3bfe33ced6b8ad838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863070Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#706511}
-
Hiroshige Hayashizaki authored
This CL splits some WPT tests into - wpt/import-maps/core/ that tests the core features after https://github.com/WICG/import-maps/pull/176, and - wpt/import-maps/builtin-support.tentative/ that requires pre-#176 built-in module and fallback support, in order to test builtin- and non-builtin- versions easier. Bug: 1010751 Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706510}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the viz::mojom::FrameSinkManagerClient interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ice2d034ac1b5eed866c7296046cf031eb0f00f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859987 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#706509}
-
Robbie McElrath authored
See https://crbug.com/1010625 for background. This CL does the following: * Whitelist prefs needed to record the SeedFreshness metric * Change the SeedInfo.date field to use the device's current time rather than the server's time from the Date header * Copy the seed that VariationsSeedLoader finds to the pref that VariationsSeedStore uses so its metrics recording code will work Test: Manually verified SeedFreshness was being recorded Bug: 1010625 Change-Id: I8b3eda5967672b4fd4218bab288157dfd06ce38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828235 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706508}
-
