- 12 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6dff36314cb4..a7875dfced8a git log 6dff36314cb4..a7875dfced8a --date=short --first-parent --format='%ad %ae %s' 2020-02-12 dberris@chromium.org Increase max concurrency for histograms-queue Created with: gclient setdep -r src/third_party/catapult@a7875dfced8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I17ba84f702beb1bee5f376df95c87b9be5694a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740582}
-
Matthias Körber authored
Bug: 1051083 Change-Id: I41456f68e08668150f76b40c28a83d5ec3c5a8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050320 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#740581}
-
Hajime Hoshi authored
This reverts commit 45fb6502. Reason for revert: Test failure: crbug.com/1051400 Original change's description: > PPAPI: Add NetworkIsolationKeys to proxy lookup requests. > > This is needed to correctly isolate any DNS requests made by PPAPI in > the context of one page from those made in the context of other pages. > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/2008050. The > original CL was reverted because the DNS layer auto-detects whether the > current network supports IPv6, and the detection value was changing in > the middle of tests. When the value changes, the cache key used for the > DNS layer changes, which was resulting in cache misses. > > To fix the issue, the test now relies on IPv4 DNS lookups, which don't > have this issue. > > Bug: 1021661 > Change-Id: I959b81d0a3fc5973cde4ba7a0ccfd0c501ffc235 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050743 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740487} TBR=raymes@chromium.org,mmenke@chromium.org Change-Id: I40432831baa19cdf040c38684fb785f48816873f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051644Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740580}
-
Alan Cutter authored
This CL updates WebAppBrowserController::IsUrlInAppScope() to include web apps that had invalid scopes by using the default "parent of start_url" scope instead. Bug: 910016 Change-Id: I932d092f247c1b56638885e252534d2d2bb07509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049643Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#740579}
-
Hirokazu Honda authored
This CL adds CreateGpuMemoryBufferVideoFrame. It creates GpuMemoryBuffer-based VideoFrame. Bug: 1033799 Change-Id: I90415a5aafa4eb92aaf51fcf75f8ed94590c213a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010548 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#740578}
-
Alan Cutter authored
This CL updates ImportantSitesUtil to include all web apps regardless of manifest scope when it warns users about removing site data for origins with high engagement scores. Previously we would not include web apps whose scopes were set to invalid values. Bug: 910016 Change-Id: Idd7bca93a29b1752a1f8aa6bba3fcca1dc400ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049585 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#740577}
-
Sophie Chang authored
This will only fetch for URLs that we do not already have a hint or attempt for Bug: 1041693 Change-Id: I06486b5d764be9f0095b35ed494ec15cb24f1238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047824Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#740576}
-
Hirokazu Honda authored
The served stream in webrtc can be dumped by the chrome option [1]. When the stream structures spatial-layers, one spatial layer is separately saved in one ivf in the dumped ivf file. On the other hand, to play the ivf file properly, it is needed to group the spatial layers, which have the same timestamp in ivf frame header. IvfFileReader [2] in webrtc does so in fact. This applies the group logic to our own ivf parser used in VDA test. This enables us to test SVC stream in VDA test. [1] --force-fieldtrials=WebRTC-DecoderDataDumpDirectory/;tmp; [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/modules/video_coding/utility/ivf_file_reader.h Bug: 1044816 Test: video.DecodeAccel.vp9_ksvc Change-Id: I9a0bcfa9083dc71333ad3c727d6cbb6d902202bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032453 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#740575}
-
Yoshifumi Inoue authored
This patch introduces |NGFragmentItem::IsSiblingOf()| as replacement of |HasSameParent()| to make |NGInlineCursor::MoveToNextSibling()| and |TryToMoveToLastChild()| treates list marker and line box of <li> as siblings as same as paint fragment tree for fixing of hit testing on list marker and list item. This patch fixes following tests (at least): 1. fast/html/draggable-controls.html 2. fast/spatial-navigation/snav-expandable-sub-menu.html 3. hittesting/culled-inline-crash.html Number of failures is 163 to 145. Bug: 982194 Change-Id: Id8132ae6cc493e36f8824eb6c90fd442e21e664e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051469 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740574}
-
Yoichi Osato authored
Since actual usage except test was removed at crrev.com/c/1864499, we can removed this function now. Bug: 787704 Change-Id: I59d34c025d4d8c2fb40ddebf4e6465cca27708c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041686Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#740573}
-
Eliot Courtney authored
There is a timing where multiple presentation feedbacks for the same buffer can be in-flight at once. Make sure to clean-up all of them. Test: Running linux chrome on ChromeOS Test: Running linux chrome on weston Test: Running linux chrome on sway Test: Running linux chrome on mutter Test: ozone_unittests Bug: 1039428 Bug: 1039481 Change-Id: I349456b8c5f79e078ac2d59fc518f5792241be5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043263Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#740572}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74ecbaf391f4..7b39d7cb5d64 Created with: gclient setdep -r src-internal@7b39d7cb5d64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9f1ef500648653eba8eb510763b517cd259e7f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740571}
-
Anand K. Mistry authored
The original change had a log matching condition on the death-test. However, these log strings are stripped from official builds, causing the test the fail. Bug: None Change-Id: I4ee428f17c6cc71e0f8954ce055c3d63dae5b0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049999Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740570}
-
Alex Danilo authored
Uses CSS pseudo selector ::after to create a touch target that's larger than the cr-button itself. Bug: 992823 Change-Id: Ie3f9bc153bba6e40bf4d443a99da40636f49368c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041688 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740569}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fdcff246690a..6dff36314cb4 git log fdcff246690a..6dff36314cb4 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 dberris@chromium.org Remove references to tir_label Created with: gclient setdep -r src/third_party/catapult@6dff36314cb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I04d40ede5317bfbabda366a69f9c06a74ff45aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051565Reviewed-by:
-
Eliot Courtney authored
This CL marks submitted buffer N as released when buffer N+1 is submitted. Previously, buffer N was being marked as released when it was submitted. This fixes tearing / screen not updating glitches. This CL also adds some comments + minor cleanup. Test: Running linux chrome on ChromeOS Test: Running linux chrome on weston Test: Running linux chrome on sway Test: Running linux chrome on mutter Bug: 1039428 Bug: 1039481 Change-Id: Ieb14f6f097b53e89d2feedba42e33b47778c1f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041980 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- Add expectation for one crashing test - Rebaselines for filter tests. The failures were since crrev.com/c/2043878 which rebaselined the base tests. TBR=wangxianzhu@chromium.org Change-Id: Ia41ceb05d4d77268c10b34ef81b927c4cc788011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050325 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740566}
-
Ramin Halavati authored
OffTheRecordProfileIOData is predeclared in profile.h, but not used anywhere in the code. Bug: 1033903 Change-Id: I30af64e89246075c8a05938d5df06f20b0ccec08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049966Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#740565}
-
Rahul Singh authored
The enable-webrtc-hw-{h264,vp8,vp9}-encoding flags were previously removed. This change also removes them from flag-metadata.json. These flags were removed in this CL: http://crrev.com/c/2033246 Bug: 599650 Change-Id: I83e31396d8a2506d3ed6a7cc548a9b9cd53e1c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050828Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740564}
-
Kelvin Jiang authored
This CL modifies the logic for setActionCountAsBadgeText, where if an extension has no actions matched and has called setActionCountAsBadgeText(true), the badge text will show the default badge text (or no text, if default text is not set). This is changed from the previous behavior where it would show 0 if no actions were matched. Bug: 1050540 Change-Id: Id59bf5bf9ffd01fa0e39c9927f812f6c89ac9205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051403 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740563}
-
Yuly Novikov authored
Needed to run these tests also on VMs not having a GPU. Use --no-xvfb when running on real HW. TBR=kbr Bug: 1007018 Change-Id: I17754ccef84121d7bd1f0464311f0bd7a86d80d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920027 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740562}
-
Alex Danilo authored
Bug: 992823 Change-Id: I911bd7d04fc1c224d7ab18e6a040c852b3daafff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041974 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Alex Danilo authored
Sizes the buttons to 36px and styles them round. Adds an outline when the cr-button gets focus using box-shadow. Changes <files-ripple> and <files-toggle-ripple> to display:none when files-ng is enabled, so they don't render. Bug: 992823 Change-Id: Ia97652f330a7a721557fcc963ddb6787ec675d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026768 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Sophie Chang authored
Bug: 1050101 Change-Id: I0cbf08a82fa5dae51cf2b2252cd920c3a95d88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045588Reviewed-by:
-
Victor Costan authored
Testing code that was moved from //content to //storage is still under the content namespace. This is hindering Storage Service-related refactoring. This CL updates the namespace to reflect the directory structure. This CL also makes mechanical code health improvements (such as new -> base::MakeRefCounted) applied when obvious. clang-tidy improvements are applied where requested by Tricium. Bug: 653751 Change-Id: I3d0b5712b531d0d33205ee2a3de3de5dce73e84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048986 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740558}
-
Charlie Reis authored
WebUI bindings aren't granted to error pages, and we weren't granting them when reloading a NavigationEntry that had earlier been an error page. To fix this, reset all sensitive state (including bindings) on the NavigationRequest when the destination SiteInstance changes from what the NavigationRequest expected it to be. Bug: 1046159 Change-Id: I2b004423ad2f1f7aecd86220be75d32f26404040 Fixed: 1046159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045143 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740557}
-
Daniel Cheng authored
Mostly cleanup. Note that this still uses atomics instead of C++11's thread-safe statics. C++11's thread-safe statics incur a large (200+ KB) size penalty since they guarantee that only one thread enters the initialization block. Change-Id: I3b013b55d5108f86ede39d0e0273ea10f8abf5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045757Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740556}
-
Koji Ishii authored
This patch moves functions to get related objects of the current position from |NGInlineCursor| to |NGInlineCursorPosition|, in particular: * BoxFragment() * GetLayoutObject() * GetMutableLayoutObject() * GetNode() Also moves: * InlineBreakToken() * InkOverflow() This patch has no behavior changes. Bug: 982194 Change-Id: I39fe7268977dd2fce12e75f1c012d78ca9b9e2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049934Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740555}
-
Koji Ishii authored
Following bot results are included. 1317 1321 1322 1323 1324 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1338 1339 1340 1341 1343 1352 1353 1355 1356 1357 1358 1360 1361 1363 1364 1365 1366 1368 1369 1372 1370 59 lines were removed and 25 lines were deflaked by consecutive results since 1352. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I2e080c213b8ae75699d0e85c6a8475df2d0b0f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043617Reviewed-by:
-
Ian Kilpatrick authored
This fixes failures with FlexNG enabled, see: https://test-results.appspot.com/data/layout_results/linux-rel/292466/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html (*/text-with-display-style.html) NGBoxFragmentPainter didn't have a ScopedPaintTimingDetectorBlockPaintHook for the flexbox on the stack, meaning that the performance entry was never recorded for the flexbox element. This patch emplaces the ScopedPaintTimingDetectorBlockPaintHook for all box fragments. Bug: 845235 Change-Id: I5bb1a20734e9ef6c0d5babe5d6bff4ffb6d4aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044522Reviewed-by:
-
Koji Ishii authored
This patch moves floating objects in an inline formatting context from the fragment tree to |NGFragmentItem|. r717514 <crrev.com/c/1903122> moved them to the fragment tree. This patch reverts it, but fixes the problem it tried to solve (floats in empty inline formatting contexts) by adding |IsBlockLevel()| as suggested by <crrev.com/c/1927041>. Also contains new float hit-test code in this new structure. Fixes ~3 failures. Bug: 982194 Change-Id: Ic7320797a2aaab7bc0ca0a1bbea03f38baf7d693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022123 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I3dc766262c8202dd3e545acb09a7fcd7e1eb4baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050795Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88210f038eea..74ecbaf391f4 Created with: gclient setdep -r src-internal@74ecbaf391f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I55c51f6f84e1d1dea457ca8a4a8afd54d142c0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051142Reviewed-by:
-
Kent Tamura authored
Bug: 1049998 Change-Id: I539c4dae08338bbd15e0880709ae1c35e88b314f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050405Reviewed-by:
-
Manas Verma authored
We would like to know the relative conversion rates between CVC and WebAuthn. This CL introduces metrics that logs which authentication method was used when a form was submitted. Bug: 949269 Change-Id: I6c362327b3538b0c8890628316429654e6fae10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048043Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#740548}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/601fc962a276..fdcff246690a git log 601fc962a276..fdcff246690a --date=short --first-parent --format='%ad %ae %s' 2020-02-12 fancl@chromium.org Remove the Sheriff model and related infra Created with: gclient setdep -r src/third_party/catapult@fdcff246690a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050891 Tbr: oysteine@google.com Change-Id: Iac9f761954d371759d2dae1d6a7b224e90e43bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051429Reviewed-by:
-
Kevin Marshall authored
Postpones the destruction of the AmberRepo until the tests have finished, so that the repo can continue to be used during test runtime. Bug: 956100,1028775 Change-Id: I794b698af6dd6f84cb140d178cf888a175381f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966691 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#740546}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id3db89d2e0ba4b10b3e76ce4e076285fc0aacb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050098Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#740545}
-
Luciano Pacheco authored
Naming/Renaming input commits the new name when the input loses focus, this is broken when user right-click on the input, since context menu pulls the focus to itself for a11y. Change the renaming controllers to listen to the contexmenu event to be able to not commit the new name in this condition. Change some "let" to "const" as pointed by presubmit. Fixed: 1008816 Change-Id: Id5ccb97598afd597871793d2165f3132b9363448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049150Reviewed-by:
-
Timothy Loh authored
This CL updates our checks for allowing Plugin VM to not require an image url, allowing better support for manual installation via vmc. Admins can currently bootstrap via setting a dummy url in policy, but we probably shouldn't require this. The launcher icon and settings page will now both always show if PluginVmAllowed and PluginVmLicenseKey are set, regardless of the PluginVmImage policy and plugin_vm.image_exists pref. On launching the installer, it will immediately complete if the user installed Plugin VM using VMC, or otherwise display en error indicating an invalid configuration. Bug: b:148281022 Change-Id: If85ca4ca14a096db17c32b26769a72d55bc92eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043331Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#740543}
-
