- 11 Nov, 2019 13 commits
-
-
Stephen Chenney authored
Bug: 1021164 Change-Id: Ifc640896eae412c09cddb3bb70b694cca7e078a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899748 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#714136}
-
Dominic Farolino authored
The V8 CL (crrev.com/c/1902968) fixing console's table and dir method lengths has been rolled into Chromium, so this CL re-enables the tests and removes the IDL expectations now that the tests pass. Bug: 948678 Change-Id: I9fd1719fdc7382747c017876740df5e15c81b18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904335 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#714135}
-
Yuki Shiino authored
The |renderer| argument was introduced in the very early design, but it turned out that it's not often used (except for testing). This patch removes the argument and simplifies CodeNode and its subclasses. Bug: 839389 Change-Id: I434a13f5c4fd6bdc9cdf93ae50ec734f60359d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906611 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#714134}
-
nancy authored
BUG=1011235 Change-Id: Ib717d59170c30ada1613ee2b485d44c961fefa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906852 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714133}
-
tby authored
We still have one user report that isn't showing zero state files, and this is suspected to be because of a bad model that was saved to disk early in development. This CL prevents loading models on dev, which will help debug the issue. This code will be removed as soon as we have finished debugging. Bug: 955893 Change-Id: Ifef902e98919d166135127c2d8c140743ca5094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898896Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#714132}
-
Dominick Ng authored
This addresses a bug where visible icons for ARC++ apps "blink" when ARC++ finishes booting after a Chromebook is restarted. BUG=1022847 Change-Id: I563939f0dac0f8c1df1192e90dd5ac15684e0b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906687Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714131}
-
Timothy Loh authored
Change-Id: Iac811e43639f72801b2de59bfeaaf0ba1b6a66c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905292 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#714130}
-
Meredith Lane authored
This change now migrates the existing accessibility code to rely on the attr-associated-elements set via the content attribute or IDL attributes. Followup work to: https://crrev.com/c/1687013, https://crrev.com/c/1781917 Bug: 981423 Change-Id: If004f20d67ec6795ed3e0b54a73ff6999aed0af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826397 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#714129}
-
Yuki Shiino authored
"CodeGeneration" was a bit too long name and space consuming in code. This patch shorten the names. Bug: 839389 Change-Id: Ie1dae9d778c65aa7bb823675f530af7a48a2c6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906688 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia4102c93a9faaf4643448063cfce9c40c21dfc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714127}
-
Meredith Lane authored
In order to comply with the current version of the spec, elements are no longer validated on retrieval or getting. This means that explicitly set elements are still able to be the attr-associated-element, even if they have been moved into an invalid scope, such as a deeper shadow root, or a different tree scope or removed entirely. This is likely to change in future, but as the spec is still being actively discussed it is better to comply with the current version. BUG=981423 Change-Id: I496c06cfad5f056c49dedb3e9821781c755538b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898889Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#714126}
-
Fergal Daly authored
This is a reland of d6cbc51d. Landing this unblocks others to use this new times. The difference with the reland is that it disables BackForwardCacheBrowserTest.SubframeWithNoStoreCached on win. The cause of the 20ms difference in timestamps is unknown but seems likely to just a platform-difference between linux and windows that just impacts this test. We will investigate that later. The test can be seen failing in patchset 1 (no diff vs the original change) on the win_chromium_dbg_ng trybot and then passing in patchset 2 (both runs have problems with infra and tests that seems entirely unrelated, they are runs 2536 and 2537 on https://ci.chromium.org/p/chromium/builders/try/win_chromium_dbg_ng and they are preceded by a lot of other failures, all that matters to us is the result of this 1 test) Original change's description: > bfcache: Save back-navigation's navigationStart in pageshow event's timestamp > > When a page is restored from the back forward cache, there is > currently no way to know its navigationStart time since we aren't > updating performance.timing.navigationStart (which is undesirable), > even though users of bfcache might want to know the navigationStart > time to measure latency. To solve this, we are modifying the > pageshow event’s timeStamp to correspond to the navigation start of > the history navigation. Note as event.timeStamp is defined as time > elapsed since the beginning of the document lifetime [1], this is > effectively the difference between the initial navigationStart and > the navigation start of the last navigation. > > [1] https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp > > Note that we are only updating this for pageshow events for pages > that were persisted (restored from the back forward cache). > > For more background, see doc at https://docs.google.com/document/d/1XlZhphHW-bNcUPD98T-rfTa-TASI-3xUtxZzThZLJCA/edit?usp=sharing > > Change-Id: I81e399492eaa377ac56c4325e3134b1ff50ae451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888627 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713147} BUG=1022191 Change-Id: Ia916db46c6b5245d22a184d169c94fc0a58bfc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903185 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#714125}
-
Anand K. Mistry authored
When mounting SmbFs through cros-disks, there is currently no ability to pass a file descriptor (eg. for a socket) over the D-Bus Mount() method. Instead, a random string is generated and provided to SmbFs as part of the mount source path. SmbFs will then generate a socket pair and pass one end back to Chrome, along with the random string as an identifier, through this D-Bus service. This service is an exact duplicate of org.chromium.DriveFileStream. Bug: 939235 Change-Id: Ideaec725a50ab7a1dba6e11b152fb08280c3a75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890378Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#714124}
-
- 10 Nov, 2019 15 commits
-
-
Avi Drissman authored
The automatic creation of the distribution XML file yielded a file that when installed was missing user-visible strings. Bug: 1022413 Change-Id: If2ad9bfb1305d2dcd58b6a04d25aa0130216b25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906949 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714123}
-
Chris Mumford authored
Code using testing::CreateFunctor and testing::CallbackToFunctor is usually more easily read if they used C++ lamdas instead. This also avoids the situation where some closures needed to use BindOnce where others BindRepeating. Finally this eliminates a GN dependency issue identified in issue 806952. Bug: 1007833, 806952 Change-Id: I43d103b038465501019b68a3350d1a528d5686cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908708Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#714122}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I325a40af904135835589c36278375e75910452c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908710Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72fe40d810a1..23e6331756d9 Created with: gclient setdep -r src-internal@23e6331756d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I909f9afa680b430a33a32f9b614cde66f01af7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909021Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714120}
-
Koji Ishii authored
Following bot results are included. 210 211 214 215 216 217 218 219 221 222 223 224 225 226 227 228 229 230 231 232 233 2703 lines were removed and 910 lines were deflaked by consecutive results since 222. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I99c39916992cbd87c4431d322b2db5feeee4eff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903114Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714119}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I019d0fe9b3ba0173a8e532ff417bf15835a7f7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908628Reviewed-by:
-
Sylvain Defresne authored
Those dependencies seem to be obsolete as none of the symbols defined from the #included headers are used. Remove them as a cleanup. Bug: none Change-Id: I38c0649bf7cd47937b9c64ed690edf79b74dd4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906367 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70bbd167..e07ec11e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0a427c7f4a6de215b12271ac5fae1070c0967754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908591Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714116}
-
Ken Rockot authored
This needs to be implemented in the Storage Service. Moving is easy, and avoids a lot of future potential for Blink dependencies creeping into the service's client library. StorageArea and related types are moved into the Storage Service's mojom, with a "Dom" prefix since they are specific to DOM Storage. The KeyValue type is also renamed to KeyValuePair and placed in its own mojom. Bug: 1000959 Change-Id: I9d81c2444be833b643746103a85803002a84bb35 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900537Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714115}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I929f328cae34479f9859f702f09e250faaad982b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908053Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10706d4d4d82..c40495063dba git log 10706d4d4d82..c40495063dba --date=short --no-merges --format='%ad %ae %s' 2019-11-10 tvanderlippe@chromium.org Migrate cm/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@c40495063dba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: If9d8524a57e40e0b40cf0a03fb1601e2860475f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908054Reviewed-by:
-
Mike Wasserman authored
Adds a basic implementation of the Window Placement blink feature. Affects window.open/moveTo/moveBy/resizeTo/resizeBy coordinate clamping. This feature simply disables Blink's window rect adjustments for now. Chrome's UI still clamps windows in the multi-screen display space. That effective allows popup windows to be placed on any connected display. Future work will implement & test multi-screen clamping in Blink. This is simply a rough first pass to hopefully be used for a CDS demo. Update existing web_tests to handle experimental and stable behavior. Add a basic browser test for popup window bounds clamping. Test with chrome://flags#enable-experimental-web-platform-features or --enable-blink-features=WindowPlacement Bug: 897300 Test: Automated; window.open/moveTo/moveBy/resizeTo/resizeBy has experimental behavior. Change-Id: I8ab70aff2b638ec1f9c41f730b485cb013995bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756384 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#714112}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/601965061c9c..10706d4d4d82 git log 601965061c9c..10706d4d4d82 --date=short --no-merges --format='%ad %ae %s' 2019-11-10 tvanderlippe@chromium.org Migrate color_picker/ to ESM 2019-11-09 tvanderlippe@chromium.org Migrate formatter/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@10706d4d4d82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759,chromium:1006759 Change-Id: I3209b200ebd8a90e355bc0d27043f65082e2bae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908707Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6814905..70bbd167 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b869f2a41ad81f2a8ba2f7038575aa81e8dab7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908588Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f7bc2e33670a..601965061c9c git log f7bc2e33670a..601965061c9c --date=short --no-merges --format='%ad %ae %s' 2019-11-09 tvanderlippe@chromium.org Migrate diff/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@601965061c9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: If791ae8936d28ca6552e3960936fa48389a3a065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907225Reviewed-by:
-
- 09 Nov, 2019 12 commits
-
-
Abhishek Arya authored
This reverts commit da07f633. Reason for revert: Broke libFuzzer ChromeOS bot https://ci.chromium.org/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan?limit=200 ../../chrome/browser/chromeos/printing/printer_info_cups.cc:95:3: error: [chromium-style] auto variable type must not deduce to a raw pointer type. auto iter = std::find_if( ^~~~ auto* 1 error generated. Original change's description: > Add a histogram to record IPP versions. > > Adding Printing.CUPS.HighestIppVersion which will record the largest > version a printer supports when it is queried during setup. > > Bug: chromium:1020016 > Change-Id: I7180ed1f147b812d660903381af7aaba6e500bcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892193 > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714028} TBR=jwd@chromium.org,skau@chromium.org,baileyberro@chromium.org Change-Id: I603b7c6535f386416d718e2034462aa544fcbd05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1020016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908627Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714108}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b88663fc599c..f7bc2e33670a git log b88663fc599c..f7bc2e33670a --date=short --no-merges --format='%ad %ae %s' 2019-11-09 tvanderlippe@chromium.org Revert "Simplify build" 2019-11-09 tvanderlippe@chromium.org Migrate inline_editor/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@f7bc2e33670a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: I868d0dc041e180c1762c733840e252488e8f266b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907521Reviewed-by:
-
David Grogan authored
We had been doing row, column, and column-reverse correctly, but not row-reverse. So the items in row-reverse containers with asymmetric inline padding/border were positioned incorrectly. Bug: 845235 Change-Id: Icbfd2bae96070cd14590d4ffe6224278cc3da353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907197Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714106}
-
Sanket Joshi authored
The manual color picker allows users to select colors by manually entering color values in the RGB, HSL or HEX formats. If a user enters an invalid value, the value will be entered into the channel value container but will not be committed. While this behavior is reasonable, the problem is that user's invalid value continues to be reflected until they either choose a different color or close and re-open the popup. This change addresses this by resetting channel value containers to their last valid value whenever the container is blurred. Bug: 1021234 Change-Id: I4481f02d3a86d1c582bc87481743e96ae5aa6c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906118 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80a89976c142..b88663fc599c git log 80a89976c142..b88663fc599c --date=short --no-merges --format='%ad %ae %s' 2019-11-09 tvanderlippe@chromium.org Migrate source_frame/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@b88663fc599c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: Ib409a28c37cb50029aea7bf09bbd127b557af38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907572Reviewed-by:
-
wutao authored
This patche renames/adds features for the preparation to deprecate Assistant standalone UI. Specifically, 1. Rename the feature “app_list_features::kEnableEmbeddedAssistantUI”, to “app_list_features::EnableAssistantLauncherUI” to control open Assistant in Launcher. 2. We still need to use the old feature name “EnableEmbeddedAssistantUI” to guard stable users to use Assistant search because it is used in finch experiment. So we can change the feature struct to “app_list_features::kEnableAssistantSearch”. This feature needs to replace the old checks in the multiple places. Bug: b/137873091 Test: manual Change-Id: Ie8dee00163c23508f152edacf897c88ddafdff51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898619Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#714103}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9bebbca35ef03551032bd251bde69d3d7ebc0201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907571Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9f8edfc739f508cd9ed0ede56dee5e3bb212215d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907553Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#714101}
-
Nektarios Paisios authored
This patch is a followup to https://crrev.com/c/1894159/ In that patch, the CreateBoundaryStart/EndPosition methods were updated to handle offset boundaries. This patch takes advantage of that improvement by re-writing all the word navigation methods to use CreateBoundaryStart/EndPosition. This patch also fixes a bug in CreatePositionAtFirstOffsetBoundary, which occurs in the cases when an anchor has no offset boundaries. Additionally, I took the opportunity to fix some tests that check affinity of word positions and to update the comment explaining what affinity is used for. R=aleventhal@chromium.org, ethavar@microsoft.com Bug: 1008031 Change-Id: If9a4c9e37b9abcec856dacbf513f9bf95049d06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904537 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#714100}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie940119a2ba5b358187d526d999462ac39bd6b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906513Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714099}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f729062729e..72fe40d810a1 Created with: gclient setdep -r src-internal@72fe40d810a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iced64320e7c00602dec850dc62a8480fba124fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907833Reviewed-by:
-
Brian Salomon authored
This is a reland of 448ec6f6 Original change's description: > Build internals of Skia with c++17 > > Change-Id: I7fedc818b6fad5c08f37c8002268c65eefdf57a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757345 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713492} Tbr: mtklein@google.com Change-Id: If971b90ac7e6d24a2d42af8fa7da24c65169bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906306 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#714097}
-
