GitLab

This creates PluginPlaceholderElement, which manages a subtree of
elements which represent plugin placeholder content and exposes an
interface to manipulate this content. It is expected that this interface
will grow to encompass more than a single string in the future.

This change also adds an Internals method which uses this, so that its
appearance can be covered by layout tests, and adds one such layout test.

Ultimately, this class will be manipulated by a glue class which controls
this content on behalf of the embedder.

BUG=364716

Review URL: https://codereview.chromium.org/522783002

git-svn-id: svn://svn.chromium.org/blink/trunk@182014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These places may as well just use the global strings
from MediaTypeNames.

This CL also removes the unused speechButton method.

Review URL: https://codereview.chromium.org/564133003

git-svn-id: svn://svn.chromium.org/blink/trunk@182012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We already figured out the cause of the flakiness.
These loggings are no longer needed.

BUG=393331
TEST=bots
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/566253005

git-svn-id: svn://svn.chromium.org/blink/trunk@182006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181996

BUG=413479
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/574553002

git-svn-id: svn://svn.chromium.org/blink/trunk@182005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The code-paths that will operate on RenderSVGResources that are
paint-servers are quite easily distinguishable from those where other
resources are involved - and because all paint-servers have the same kind
of geometry generation it's trivially hoistable into the relevant
callsites.
This allows the argument list of postApplyResource to be shortened
(removing |path|, |shape| and |resourceMode| since they are now unused).
Since all callers of the hoisted function (fillOrStrokePrimitive) passes
either a |shape| or a |path| - but never both, we can split this method into
its two logical parts.
Doing this however reveal that the |shape| variant can be trivially folded
into it's callers since they will always end up calling the same method.
This means that fillOrStrokePrimitive is replaced with/transformed into
fillOrStrokePath.

Review URL: https://codereview.chromium.org/571923002

git-svn-id: svn://svn.chromium.org/blink/trunk@182004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm interested in following up changes to the preloadScanner and to prerender.
Therefore, I created a preloadScanner WatchList rule, added myself to it and to the prerender watchlist.

Review URL: https://codereview.chromium.org/571083002

git-svn-id: svn://svn.chromium.org/blink/trunk@182003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/555703004

git-svn-id: svn://svn.chromium.org/blink/trunk@182002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a regression from https://src.chromium.org/viewvc/blink?revision=175325&view=revision.
I didn't consider the case where there are floats in the same formatting
context but they don't actually overlap with the element so have no effect
on its width.

BUG=413202

Review URL: https://codereview.chromium.org/570933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new method does not take an opaque rect out-parameter. And the old
methods all just call the new method and discard the resulting opaque
rect.

Chromium side is not using this opaque rect anymore and we're removing
it there, so making the matching change to blink. This removes a call
to GraphicsContext::setRegionTrackingMode(), but there are others.

R=fmalita@chromium.org, jamesr@chromium.org, schenney@chromium.org
BUG=413479

Review URL: https://codereview.chromium.org/554183004

git-svn-id: svn://svn.chromium.org/blink/trunk@181996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added unit_tests for archiving of layout test results.

Review URL: https://codereview.chromium.org/489093002

git-svn-id: svn://svn.chromium.org/blink/trunk@181991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The computed index for negative elevations was off by one. When the
elevation is -45 deg, the selected response corresponded to the entry
for 90 deg, not 315 deg.

To simplify things, we just use a short table to map the index to the
(positive) elevation angle.

No tests for this, but see crbug.com/411191.
BUG=412442

Review URL: https://codereview.chromium.org/565303003

git-svn-id: svn://svn.chromium.org/blink/trunk@181986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=405502

Review URL: https://codereview.chromium.org/572653003

git-svn-id: svn://svn.chromium.org/blink/trunk@181984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes MessageEvent and ImageData's associateWithWrapper.  My first code in
http://crrev.com/542113003 assumed that associateWithWrapper was non-virtual
method, but it was changed to be virtual.  So I had to change the implementation
when and how to call associateWithWrapper from wrap (my first code assumed that
wrap calls the same class's associateWithWrapper because it was not virtual, but
since associateWithWrapper was changed to be virtual during the code review, now
wrap calls most derived class's associateWithWrapper).

BUG=413041,235436

Review URL: https://codereview.chromium.org/567063003

git-svn-id: svn://svn.chromium.org/blink/trunk@181983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This prepares for the landing of
  https://codereview.chromium.org/522783002/

which now requires a three-sided change due to changes in how Blink accesses
private script resources.

Part 2: https://codereview.chromium.org/556793006/

BUG=364716

Review URL: https://codereview.chromium.org/570863002

git-svn-id: svn://svn.chromium.org/blink/trunk@181980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a PromiseTracker is disabled as part of shutting down, it clears
its ID -> vector(PromiseData) map. However, once the unfulfilled
promises in that cleared map later on have their weak callbacks
invoked, we weren't prepared for the map being empty. Add the required
empty map check.

A further twist for Oilpan is that the ScopedPersistents held on the
PromiseData objects need to be cleared out eagerly to prevent v8
assuming that these objects will leak -- they won't, but will only be
cleared at the next Oilpan GC. Be more eager, and promptly clear out
the references.

R=haraken
BUG=414163

Review URL: https://codereview.chromium.org/571043002

git-svn-id: svn://svn.chromium.org/blink/trunk@181979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Platform is the wrong place for screenColorprofile, where it was
the only method there that did not know its Widget. ImageDecoder
is the only caller currently, move it there.

No change in behavior, covered by existing layout tests.

BUG=369787

Review URL: https://codereview.chromium.org/570023002

git-svn-id: svn://svn.chromium.org/blink/trunk@181978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let's disable horizontal scroll bar, while allowing the vertical one.
This will fix the UI glitch, while still allow to scroll dialog's
content when DevTools is docked to bottom into a frame with small height.

BUG=412689
R=vsevik

Review URL: https://codereview.chromium.org/560293002

git-svn-id: svn://svn.chromium.org/blink/trunk@181976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added a module for the Presentation API implementation and a dummy navigator.presentation.onavailablechange IDL.

BUG=412331

Intent to implement on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/J0ToSdOQVP8

Review URL: https://codereview.chromium.org/408663002

git-svn-id: svn://svn.chromium.org/blink/trunk@181975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename the range method to createRange and remove it from the classes
where we have gotten rid of all uses.

R=yosin@chromium.org
BUG=388681

Review URL: https://codereview.chromium.org/560333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To cater to Oilpan, introduce an explicit dispose() for
ApplicationCacheHost, which the DocumentLoader will call upon when
being finalized.

Without it, a DocumentLoader might clear the Persistent reference to
its ApplicationCacheHost, but it'll still be accessible to embedder
notifications via its WebApplicationCacheHost until the next Oilpan GC
strikes. If so, the callbacks might access a now-dead DocumentLoader.

R=ager
BUG=

Review URL: https://codereview.chromium.org/571003002

git-svn-id: svn://svn.chromium.org/blink/trunk@181973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376196
R=yurys, vsevik

Review URL: https://codereview.chromium.org/512003003

git-svn-id: svn://svn.chromium.org/blink/trunk@181972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The earlier commit for this was reverted here https://codereview.chromium.org/557543004
as it broke the compilation on Linux GN (dbg) which is tree closer.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20(dbg)

Adding the changes required, the flag --for-testing, in the Source/core/BUILD.gn to include
this flag.

BUG=312586

Review URL: https://codereview.chromium.org/569063002

git-svn-id: svn://svn.chromium.org/blink/trunk@181971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A DOMWindowProperty object should not be kept alive if it is only
referenced from a LocalDOMWindow's set of registered DOMWindowProperty
objects. Adjust LocalDOMWindow's DOMObjectProperty references to be 
weak for Oilpan also.

In most cases, DOMWindowProperty objects will remain alive for at least
as long as their associated LocalDOMWindow, but this cannot be assumed.
The added test checks for that wrt DOMSelection objects created from
shadow roots.

Along with adjusting the weakness of these references, simplify
how LocalDOMWindow unregisters its DOMWindowProperty objects. That is,
no longer have the instances unregister themselves, but let the
LocalDOMWindow remove them all after having notified them of impending
destruction.

R=haraken,ager
BUG=413316

Review URL: https://codereview.chromium.org/569643002

git-svn-id: svn://svn.chromium.org/blink/trunk@181970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/572623002

git-svn-id: svn://svn.chromium.org/blink/trunk@181969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=414163
TBR=loislo, amikhaylova@google.com

Review URL: https://codereview.chromium.org/568363003

git-svn-id: svn://svn.chromium.org/blink/trunk@181968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Get rid of unused methods
* Get rid of code duplication
* Ease return values: Classes with a static string field are replaced with a string

BUG=

Review URL: https://codereview.chromium.org/558593003

git-svn-id: svn://svn.chromium.org/blink/trunk@181967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch restores per-word wrapping of console messages. This was
regressed in r180833.

BUG=412515
R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/542383004

git-svn-id: svn://svn.chromium.org/blink/trunk@181965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=414163
TBR= aandrey@chromium.org, kouhei@chromium.org, hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/573633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, if you click on the selector container, there are two
handlers that conflict with each other. The patch fixes
the conflict.

BUG=413894
R=vsevik, apavlov@chromium.org

Review URL: https://codereview.chromium.org/571653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r181420 we started pulling the list of virtual test suites to run
from LayoutTests/VirtualTestSuites (a new file). The browser_test ports
do not pull their tests from that directory, and need a different list
of suites, but I forgot to override the port.virtual_test_suites() call
in their implementations.

The browser_test ports don't currently need or have any virtual test suites,
so this patch implements returning an empty list and adds tests to ensure
that we would catch this regression if it happened again.

We also rework the browser_test_unittest.py tests to eliminate a bunch of duplication and make it clearer that the tests are shared and testing the same behavior.

TBR=thestig@chromium.org
BUG=413986

Review URL: https://codereview.chromium.org/569913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=160207
R=vsevik, yurys@chromium.org

Review URL: https://codereview.chromium.org/548323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix to keep the selection of the text field in input element after setSelectionRange is called by dom events related to mouse

The problem is that the selection is cleared when handling mouse release.
The selection should be kept if the selection is set by setSelectionRange during handling mouse event.

BUG=32865
R=yosin@chromium.org
R=rbyers@chromium.org
TEST=LayoutTests/fast/forms/setrangetext-within-events.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181490

Review URL: https://codereview.chromium.org/507533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert "Remove resetScrollbars" (patchset #1 id:1 of https://codereview.chromium.org/534103003/)

Reason for revert:
This was reverted speculatively and was not the cause of the failure.

Original issue's description:
> Revert "Remove resetScrollbars"
> 
> This reverts commit ebcbf43b12652bf96a1d1d94d8dbb5bdfd363ce6.
> 
> Speculative revert.
> 
> NOTRY=True
> BUG=409708
> TBR=skobes@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181275

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/568303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 0ad77c5152a930f08e04a2db05ad5331c711333f.

It breaks compilation on Linux GN (dbg) which is tree closer.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20(dbg)

BUG=312586
TBR= dpranke@chromium.org, haraken@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/557543004

git-svn-id: svn://svn.chromium.org/blink/trunk@181957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink on github is not supported, Blink lives in:
chromium.googlesource.com/chromium/blink/+/master.

So these scripts are from an era where Chromium was integrating WebKit,
but since we forked and created Blink, they don't make much sense
anymore.

BUG=None
TEST=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/563983002

git-svn-id: svn://svn.chromium.org/blink/trunk@181956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: Mark fast/events/touch/gesture/gesture-tap-frame-scrollbar.html as failing for all platforms

BUG=414034
TBR= dpranke@chromium.org, rbyers@chromium.org, esprehn@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/558123003

git-svn-id: svn://svn.chromium.org/blink/trunk@181955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/569873002

git-svn-id: svn://svn.chromium.org/blink/trunk@181953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This completes the implementation of ServiceWorkerContainer#getRegistration().

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-getRegistration

[1/3] https://codereview.chromium.org/553983010/
[2/3] https://codereview.chromium.org/535753002/

BUG=404951
TEST=LayoutTests/http/tests/serviceworker/getregistration.html,webkit_unit_tests

Review URL: https://codereview.chromium.org/540823003

git-svn-id: svn://svn.chromium.org/blink/trunk@181952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=413987

Review URL: https://codereview.chromium.org/573473002

git-svn-id: svn://svn.chromium.org/blink/trunk@181951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As discussed on blink-dev[1].

[1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/gfifgxHdPXU/discussion

BUG=396369

Review URL: https://codereview.chromium.org/568253002

git-svn-id: svn://svn.chromium.org/blink/trunk@181950 bbb929c8-8fbe-4397-9dbb-9b2b20218538