- 26 Feb, 2020 2 commits
-
-
Zhuoyu Qian authored
This CL update the function DeleteDataForOriginOnFileTaskRunner to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: I597a2d31944ad41427b2c8b42586f069c5478e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071522Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#744447}
-
Henrique Ferreiro authored
This will make it easier to check for new issues when running `git cl lint`. Bug: 1053888 Change-Id: Ib3199e868ddda532198f84070a155ff5ffa85fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063000Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#744446}
-
- 25 Feb, 2020 38 commits
-
-
Bo Liu authored
Getting display from the WindowManager may raise errors in future versions of android because the API implies it supports multi-display but it actually depends on the Context being used. Application context definitely will not support multi display. Instead retrieve the default display from DisplayManager does not have this limitation and also makes it clear in code that this code is not multi-display aware. Note an earlier version of this to use DisplayAndroid was reverted because this code does not run on the UI thread. https://chromium-review.googlesource.com/c/chromium/src/+/2026354 Bug: 1042063 Change-Id: I1066c9f5b7dfed572c47ece72acd012329a863c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070331Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744445}
-
Sean Gilhuly authored
All ContextFactoryPrivate implementations are also ContextFactory implementations. Move the two remaining ContextFactoryPrivate functions into ContextFactory and clean up usage. Bug: 1042259 Change-Id: I48063717cd6e51ccfc94e0a160d50d95d7629388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047728 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#744444}
-
Robbie McElrath authored
This metric stores the same values as Variations.FirstRun.SeedFetchResult, but stores results for all WebView seed requests, rather than Clank's first-run request. See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details. Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'AwVariationsSeedFetcherTest#*' Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedLoaderTest#*' Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedServerTest#*' Test: Manually verified correct metrics were being recorded by adding Test: logging when recording the metrics. Bug: 1047536 Change-Id: I3f216084844198ed8828695d615a359bb83c41e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067275Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#744443}
-
Joshua Pawlicki authored
Bug: 1054843 Change-Id: I6ea53913579f94b6725902f7038c214dea05c9bc Fixed: 1054843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071046 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#744442}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: Ied0092d83f179dc47130c9bf882cc43aca647da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066477Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744441}
-
nancy authored
AppServiceAppIconLoader should replace the ArcAppIconLoader, so update arc_app_unittest to use AppServiceAppIconLoader. Fix the unit tests failures: 1. AppServiceAppIconLoader should support ARC shelf id, so add shelf_app_id_map_ to record the map from app_id to shelf id. 2. Move GetAppFromAppOrGroupId from ArcAppIcon to arc_app_utils, because AppService icon loader calls that function to get the app id from the ARC group id. 3. Update the unit tests, WaitForIconUpdates, the expected callback on OnAppImageUpdated should be once: From: delegate.WaitForIconUpdates(scale_factors.size()); To: delegate.WaitForIconUpdates(1); Because AppService will callback once when all supported scale factor is loaded: https://cs.chromium.org/chromium/src/chrome/browser/apps/app_service/arc_icon_once_loader.cc?l=101 4. Update AppService icon loader to call ArcAppIcon to generate the default icon in case the icon load failed. BUG=1016159 Change-Id: I1c8ebc018eab3becb37351f51116f63a395f6f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050143 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744440}
-
Chris Cunningham authored
Disables AccessibilityInputDateWithPopupOpenMultiple and XmlInIframeCrash on all platforms. Bug:1055764 Change-Id: I5f048849bcea1f400e69a65bae9bbedfa97d5f55 TBR=vicfei@microsoft.com Change-Id: I5f048849bcea1f400e69a65bae9bbedfa97d5f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072931Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#744439}
-
Edward Jung authored
Experiment has expired and we currently don't want to pursue this. Change-Id: I434333da5980be149f1f61fd74aa267ce9653ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071858Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#744438}
-
Aaron Krajeski authored
Worth it to only have to review all of these once a year. Bug: 1055383 Change-Id: I6948ea46796dc0a6891e017a59fac0ce86cb36e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070831Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#744437}
-
Kehuang Li authored
It used to be |has_audio| to differentiate audio message and non-audio message. But now we have one more type of message, i.e., metadata message. Meanwhile, add new util method to populate metadata message. Merge-With: eureka-internal/357770 Bug: internal: 140736325 Test: On device. Unittests. Change-Id: Ic89ffb293b75ce303631dda08ace720f949c318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049025Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#744436}
-
Ted Choc authored
Clunky commands: find chrome/browser/ -type d \( -wholename '*java/src' -or -wholename '*junit/src' -or -wholename '*javatests/src' \) | sort | sed -e 's/\(.*\)$/ <classpathentry kind="src" path="\1"\/>/gm' find components/ -type d \( -wholename '*java/src' -or -wholename '*junit/src' -or -wholename '*javatests/src' \) | sort | sed -e 's/\(.*\)$/ <classpathentry kind="src" path="\1"\/>/gm' BUG= Change-Id: I3fca1ab27b5c52bf62b5d048c782bba95ce5c06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072875Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#744435}
-
Mustafa Emre Acer authored
This CL adds a new bucket to the Download.InitiatedByWindowOpener histogram. The new bucket records if the opener (the tab that initiated the download) or the openee (the tab on which the download was initiated) is a non-HTTP or HTTPs URL such as about:blank. Bug: 121259 Change-Id: Ic45a82df693422419a15849a19027002697e0838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072678 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744434}
-
Stephen Roe authored
Apply the 'Fuchsia x64' CI and fuchsia-fyi-arm64-rel FYI builder exceptions to the 'Fuchsia ARM64' CI builder. This is being done before tests are enabled on the 'Fuchsia ARM64' CI builder. Bug: 1042512 Change-Id: Ie439d47b14d60a548335489e21ab47f4f9e10c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071368Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#744433}
-
Lan Wei authored
This reverts commit 756673ee. Reason for revert: <INSERT REASONING HERE> interactive_ui_tests fails BrowserFocusTest.PopupLocationBar PasswordBubbleInteractiveUiTest.AutoSigninNoFocus OmniboxFocusInteractiveTest.NtpReplacementExtension_LocationAssignment BrowserFocusTest.FocusOnReload ...26 more failure(s) (30 total)... on Builder Linux TSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests Original change's description: > Enable WebUITabStrip in fieldtrial_testing_config.json > > Bug: 1009881 > Change-Id: I0c784e4ac16bb14e5515b95680adfea3b5e3148c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069499 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744385} TBR=jwd@chromium.org,collinbaker@chromium.org Change-Id: I8be4824fcc9e2ccb873807d44faee7105d865dbd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073159Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744432}
-
Steve Kobes authored
This lets test authors put their HTML and JS content in an external file instead of inlining it into the LoadHTML call. Also update MetricIntegrationTest.LayoutInstability to use this capability. Bug: 1045064 Change-Id: I7b8de053b468f5cf82747a875a2730242665891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067348Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#744431}
-
Mike Wittman authored
Consistently use 'const Module' rather than 'Module' in the interface. Modules are not to be mutated by the ModuleCache or its users. Rename InjectModuleForTesting to InjectNativeModuleForTesting to be clearer about what it does. Have GetModules() return both native and non-native modules to make the behavior consistent with the function name. The only current user of GetModules(), content::protocol::MemoryHandler::GetBrowserSamplingProfile(), does not add any non-native modules to the ModuleCache so returning non-native modules from the function will not affect it. Bug: 1035855 Change-Id: Ie1cd38e081ee48297df3c7a15b8e4997d1df1589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062883 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#744430}
-
Peter Kasting authored
This reverts commit 38ee3ee4. Reason for revert: UX would like a complete review before making this change. Original change's description: > Compute omnibox background color from toolbar color. > > This makes the omnibox/toolbar contrast ratio 1.3 by default. > Theme authors can manually override the default colors. > > Bug: 878664 > Change-Id: I24b95e8d225fd375b573b48e403fbf147013e940 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986244 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730295} TBR=pkasting@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 878664 Change-Id: I1fb8a3c7cfd1b8cd57a260cc9d7f00aa8131e024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070601Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744429}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4be48f5a3603..be4da4f63d35 Created with: gclient setdep -r src-internal@be4da4f63d35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1054683,chromium:1055510 Tbr: jbudorick@google.com Change-Id: I864092390084e0c4c586a5c77467f9fdb2ce8522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072843Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744428}
-
Meilin Wang authored
This CL implements an entry point for ambient mode where it will show when user switches to the lock screen, e.g. by pressing the icon, with feature flag turned on. This CL also adds the first unit test case for the ambient controller. Bug: b/149245177 Test: run unittest. Change-Id: I8cf4424d861b1eac707db2d1dd978af6b7e0efce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065614Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#744427}
-
Oriol Brufau authored
When referencing a line name in the grid-placement properties, if the first track was defined using the auto repeat() syntax, then the code would assume that the line had to appear after the repeated tracks. However, it can precede them, e.g. grid-template-columns: [first] repeat(auto-fill, 10px) This patch fixes this by removing the special casing for auto repeat() being the first tracks. BUG=966090 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-002.html Change-Id: Ic9c1199532f8ed06c958b80aef4580b7a318490c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071873Reviewed-by:Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#744426}
-
Ted Meyer authored
the PLOG(ERROR) calls were removed on friday as part of a macro cleanup, but we need non-debug builds to have notices that dll loading has failed to avoid totally silent errors. Bug: 1055602 Change-Id: I0d83eca6caecca8b8bde3183ae02e52c1733d3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071580Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Peng Huang authored
Currently, Vulkan function pointers are called from everywhere in Chrome. All those files have to be in the CFI backlist. To reduce the CFI blacklist, this CL generates inline wrapper methods in vulkan_function_pointers.h to call Vulkan function pointers, and only puts those wrapper methods in CFI blacklist. Bug: 1055376 Change-Id: I967c8ce9543073c46695c64f0544abbc8aa391d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072339Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744424}
-
Alexander Surkov authored
HTML:time element doesn't support accessible value but listed what makes accessible name computation alg to ignore its content R=dmazzoni@chromium.org Bug: 1053507 Change-Id: Ifba735b2c017c00676169ab8cea80ae2d44d73fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070715Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#744423}
-
Parastoo Geranmayeh authored
It's flaky. TBR=agrieve@chromium.org Bug: 1054637 Change-Id: I2e3bdd2ea2f70a8a821c89443ecf9674a334ed95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073057Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#744422}
-
Parastoo Geranmayeh authored
Bug: 807080, 1054637 TBR=agrieve@chromium.org Change-Id: Ie45bd0e5b4906135acaf1f1ac33062c0abf03324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072999 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d6fb409d463d..422f9dd5df8e git log d6fb409d463d..422f9dd5df8e --date=short --first-parent --format='%ad %ae %s' 2020-02-25 thomasanderson@chromium.org Conditionally use OPUS_GET_IN_DTX if available Created with: gclient setdep -r src/third_party/webrtc@422f9dd5df8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047860 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5781a7ad712b7249eda5ee83d97a82fb2a4e8189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744420}
-
Lan Wei authored
This reverts commit 8411cc66. Reason for revert: <INSERT REASONING HERE> ResetFirstAfterBootTest.ViewsLogic fails on Builder linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome Original change's description: > OOBE - Improve reset screen confirmation dialog > > - Replace the dialog on the reset screen with the oobe-help-dialog > that complies with UX specs and reuses available code. > > - Refactor the confirmation dialog logic so that it lives in the > main element 'oobe-reset'. > > - Remove the intermediate oobe_reset_screen by using LoginScreenBehavior > > - Add a waiter to test::OobeJS for waiting upon the presence of an > attribute. Such as waiting on the 'open' attribute of dialogs. > > - Add constants and modifications to the browser tests of the reset > screen. > > Fixed: 933310 > Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec > Bug: 933310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474 > Commit-Queue: Renato Silva <rrsilva@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Auto-Submit: Renato Silva <rrsilva@google.com> > Cr-Commit-Position: refs/heads/master@{#744288} TBR=antrim@chromium.org,rsorokin@chromium.org,rrsilva@google.com Change-Id: I5a98467310e478ccd20c0cb3c9b92461229c5b3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072916Reviewed-by:
-
Hui Wang authored
This happens when a JavaScriptDialog is showing with the count of | in_flight_event_count | is greater than zero then we hide and re-show the view which will trigger the RestartInputEventAckTimeoutIfNecessary. Change-Id: I728d4ea26809c2f6ffcf7a46e0e3b124bb63b781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071191Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Kerberos add Accounts dialog page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I4693a83d86f7eafb1f0ac780df15bc9a0d177e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067254 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#744417}
-
David Tseng authored
AXMenuListOption currently inherits from AXMockObject. As a result, AXMenuListOption often misses various pieces of semantics computed by AXNodeObject. For example, restriction for something like <select><option disabled>foo</select> The option never gets the disabled restriction. Test: manual Change-Id: I477e1c1f1b9b06780609bd29e2b1d0ab25443e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071066Reviewed-by:
-
Ben Joyce authored
This CL was generated with android_studios. See https://developer.android.com/jetpack/androidx/migrate The android_deps/BUILD.gn file was modified so weblayer's build.gn DEPS will provide the required androidx libraries. NativeBrowserTestActivity.java needs to move to androidx as well otherwise compiling will fail as it links the code with android support library instead of androidx, thus causing a cast error. Bug: 1052460 Change-Id: Ifd21f96e32991d96bcc43092f8905bc9817817f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065409 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#744415}
-
Rachel Carpenter authored
To use SetManifestRequestFilter, need to move it to chromeos/components to avoid circular dependencies. This affects os_settings that was also using the function. Also adds the strings that will be used for additional search queries. Bug: b/149720483 Change-Id: Id1fe34dbb6a463963522bd256d0ccfa3366d1e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062116Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#744414}
-
Michael Spang authored
This adds new bindings for the following functions [GL_ANGLE_memory_object_fuchsia] glImportMemoryZirconHandleANGLEFn [GL_ANGLE_semaphore_fuchsia] glImportSemaphoreZirconHandleANGLEFn Bug: 766360 Change-Id: I2f9e90fb67674393bcbfe3358f1df6cd57ef3a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069177Reviewed-by:Jonathan Backer <backer@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9aa1a9673a3c..63832e9056ec git log 9aa1a9673a3c..63832e9056ec --date=short --first-parent --format='%ad %ae %s' 2020-02-25 iannucci@chromium.org [vpython] Update depot_tools vpython to match fleet. Created with: gclient setdep -r src/third_party/depot_tools@63832e9056ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051595 Tbr: agable@chromium.org Change-Id: I126812ea4096411f5f12a87a480bfee1f52c098c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072899Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Add a read-only file, "config-default.json", to the Hub debug directory for the WebEngine component containing the default configuration. * Add a read/write file "config-override.json" to the Hub debug directory for the WebEngine component allowing to override the configuration for all subsequently created Contexts. * Add "blink-settings" as an allowed command-line argument to configurations. Bug: 1014670 Change-Id: I4be28996bcfdd598836aa64c1fc2c59a0ac4432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032425Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#744411}
-
behdad authored
High confidence intervals are not failing the test anymore (except for control test), so it should also not invalidate the recorded averages. Bug: chromium:1052054 Change-Id: I016bf25c6229102a9b74255d9ee4b6a32fc1e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072125 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744410}
-
Hesen Zhang authored
Enable client to customize config related to throttling - mainly suppression duration and number of negative action count threshold from client side API - std::unique_ptr<ThrottleConfig> GetThrottleConfig() {...} This API will give client the option to override the fields related to throttling in global config. Internally a Delegate of ImpressionHistoryTracker will be created, and the glue layer NotificationScheduler delegates this request. Cleaned up throttled related parameters from schedule_params, and impression struct and proto. Some task need to do: - Check consecutive negative actions instead of dismiss actions only. - Need to write more detailed unit test to go through whole flow. - May consider adding other way (positive impression - release throttle) - Apply this layer to current existing clients including a more functional web_ui for better test and play purpose. Bug: 1053659 Change-Id: I3c767bd2be9259e74926a83ef5231ab1940b3972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063253 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744409}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4cc54b409feb..da659b374113 git log 4cc54b409feb..da659b374113 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 capn@google.com Fix ANGLE standalone build Created with: gclient setdep -r src/third_party/swiftshader@da659b374113 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8ac039adb16ac6a7988c0412f95f37886500eee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072838Reviewed-by:
-
