- 03 Sep, 2020 40 commits
-
-
Daniel Classon authored
Adds deep links to the Files Page. Bug: 1084154 Change-Id: I29729a708f640d32bcb89e6fdd61bedfafe9d67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389161 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804033}
-
Himanshu Jaju authored
- Added bug for ice candidate cache - Removed shared clipboard TODOs with my name Change-Id: Ia9ae308c7af05a13bca299fd96310bb82bd2f76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390901Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#804032}
-
Marijn Kruisselbrink authored
Rather than extracting the origin a token is associated with from its FileSystemURL, store the URL separately. This lets us use FileSystemURLs that don't have an origin (or in the future move away from FileSystemURL entirely). Other classes that have a FileSystemURL and are associated with an origin (i.e. NFSHandleBase) already stored the origin separately, this just bring TransferToken in line with those. Bug: 1093653 Change-Id: I26aeabce7bf35ad74e6beb3ffcb49d50b33d034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391179 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#804031}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ffd1d826be3..46877765c47c 2020-09-02 fmayer@google.com Handle sigaltstack. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160827189 Tbr: perfetto-bugs@google.com Change-Id: Id0cf43fd1a9686b96844af41c68086a56e819e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390886Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804030}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8395751f..7f5e0320 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30d5de3d62b8f295a476ee154188a894b411f944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391740Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804029}
-
Anastasia Helfinstein authored
TBR=dmazzoni@chromium.org AX-Relnotes: n/a. Bug: None. Change-Id: I69a8229f75647608efbb96f8b5632925b18d0300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391591Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#804028}
-
Ye Kuang authored
This is to fix failures like https://luci-logdog-dev.appspot.com/logs/chromium/buildbucket/cr-buildbucket-dev.appspot.com/8870257532584800912/+/u/RECIPE_CRASH__Uncaught_exception_/logging Bug: 894045 Change-Id: I2d6e6dde6bf0194794c4723f88eaf6e886a7b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392020Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#804027}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/168986591cc1..dcb0e91ca94b 2020-09-02 gredelston@google.com test_that: Rename whitelist-chrome-crashes 2020-09-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-02 bpastene@chromium.org cache: Use 'pixz' when extracting .xz tarballs if it's installed. 2020-09-02 yichengli@chromium.org artifacts: Exclude private fingerprint libraries If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib815a99e16e81b13f2680639a71b7d223cb94498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#804026}
-
Xing Liu authored
Download later shouldn't show notifications. This is handled for the new download backend in offline items code stack, but not for the old backend. We can block the notification in SystemDownloadNotifier which is the entry point API to show download notifications. TBR=dtrainor@chromium.org,qinmin@chromium.org Bug: 1123923 Change-Id: Ice0ed2ce44dd5aaf4351633f7de828c95cd8073d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388894Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804025}
-
Charles Zhao authored
(1) an enum LoadHandwritingModelResult is added in mojom, in histograms.xml and enums.xml. (2) LoadHandwritingModel is also modified in ServiceConnection for the new enum. `LoadHandwrintingModel` was meant to be deprecated, but for avoiding another breaking change, we modified it to be almost identical to `LoadHandwritingModelWithSpec`, but returns a new defined enum `LoadHandwritingModelResult`. And LoadHandwritingModelWithSpec will be removed soon. (3) Unit test is also fixed accordingly. Bug: 1054628 Change-Id: Idaafebb2bd1b2a129ec8163a7b925dbffd4fccf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366516Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#804024}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598908665-e5f1c62a762858adc54e97055fdde89a186c58c5.profdata to chrome-win32-master-1599069432-d8eb5597bd424e2ad3cbb5c17808a3e6923469d2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Ic9b1a179b2f731a7c83d05b2cfcdd2d90c574932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804023}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/132b4bab67e1..88d9ad2f3b2d 2020-09-02 cjamcl@chromium.org [Lighthouse] Translate the Lighthouse report based on system locale. 2020-09-02 jacktfranklin@chromium.org Make elements visible to all component_docs 2020-09-02 sigurds@chromium.org Don't patch CSS variables for dark mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1122511,chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If51e0d6ac1e17fa20cb0ff4bc8e50ca96ebfaf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804022}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599025789-640f7b1f8708a3cc11acd7ca6b1de767d17f4a26.profdata to chrome-mac-master-1599089820-64812fa7a88dc8607ac3baec5789a7fcb10cfda3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I62a93f931d5536a6a30fced2e0a49387bdf2f870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804021}
-
Xinghua Cao authored
This patch exposes the shader_shader16 extension, which allows use of 16-bit floating-point types in shaders for arithmetic operations and use of 16-bit types in buffers. Bug: 996713 Change-Id: Ib09301fb9d396a85926952f9df396f426b15ee1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324318 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#804020}
-
John Williams authored
This is a reland of f51b93d7 Original change's description: > [Cast MRP] Stop mirroring immediately when a the tab is closed. > > Bug: 1095764, b/159154368 > Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: John Williams <jrw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803343} Bug: 1095764 Bug: b/159154368 Change-Id: Ib3fbf021e10e48b3cb7289427ed130b01109a71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388153Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Auto-Submit: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#804019}
-
Mike Wasserman authored
Check the appropriate frame's runtime-enabled feature state. Pass the |requesting_frame| into SetWindowRectWithAdjustment. (use window.open's opener, same frame for window.moveTo, etc.) Fixes cross-screen open for sites with OT tokens & permissions. (the newly opened window's OT tokens have not yet loaded) (we generally care about the opener's tokens, not the popup's) Bug: 1124480 Test: michaelwasserman.github.io/window-placement-demo WAI Change-Id: I32e88dd252d1b8d04d12363952b643341e47710a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391731Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#804018}
-
Darren Shen authored
Add a new feature flag, that when enabled, uses the IME shared library for physical typing in languages based on latin script. Bug: 1019541 Change-Id: Ib3a84fe19028164c82947f4257c2787005cb4b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371064 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#804017}
-
Steven Bingler authored
getDeviceEnterpriseInfo() could run callbacks synchronously if a result is cached. This could lead some reentrancy problems for consumers of the class. This CL modified getDeviceEnterpriseInfo() to always run callbacks asynchronously. Testing: Built and ran Chrome(ium) on a managed Android emulator and observed that "EnterpriseCheck.IsFullyManaged2" indicates managed. Bug: 1120955 Change-Id: I122ecbc07946129220776de063a224d5173f1540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385640 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#804016}
-
Ben Kelly authored
Bug: 960012 Change-Id: I1852e992c7573845e0ddb8ccc24e1f4a0254ed1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387177Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#804015}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1051cbaad46..3c0e0582acfa 2020-09-02 capn@google.com Skip texel address sample offset if zero 2020-09-02 srisser@google.com Fix enum-hashing build error on Ubuntu 16.04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idd18caa93232766e44ef48bf2f04022b02c8817e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391474Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804014}
-
Angela Yoeurng authored
This shouldn't have any functional changes, just a nice to have all references in the same order :) Bug: 1123668 Change-Id: I503650e9520e823941e92f9037ee193034a60d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391729 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804013}
-
Jason Chase authored
Launch approval in crbug.com/1077038. Bug: 1069623 Change-Id: I2c739c82aecfcefbb76a9fe9a142362412bde8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391724Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#804012}
-
Joe Mason authored
This adds MeasurementMode::kEagerForTesting, which can only be used if SetEagerMemoryMeasurementEnabledForTesting is called. This mode causes an instrumented GC as soon as the measurement request is sent, so the measurement times are more predictable in tests. R=fdoray Bug: 1122131 Change-Id: I7901f3021cea1e133a9c20c94ad7082bad114fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386775 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804011}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie5df7ae4672bd39945ccce51d163835b254a43fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387020 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#804010}
-
Chris Cheng authored
Bug: 1116207 Change-Id: I320664402cd84cee47a8f5cb89ddbc500656f6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380816Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chris Cheng <chriscycheng@google.com> Cr-Commit-Position: refs/heads/master@{#804009}
-
Pranav Batra authored
Refactor PrintSettingsFromJobSettings to return a unique pointer. Also add unit tests for the print settings conversion functions. Test: ./printing_unittests Change-Id: I4afd3e7ff466948cea9a372293dbff93ca2a12bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337953 Auto-Submit: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#804008}
-
Juanmi Huertas authored
These test are flaky, marking them as such, and then will investigate issue. Bug: 1122037 Change-Id: I739c88f40c12cbaf95a777642280f9b2b645ae7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391502Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#804007}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6b2639b023f9..84bd9dade9cb 2020-09-02 syoussefi@chromium.org Vulkan: Allow pbuffer usage if no window support 2020-09-02 geofflang@chromium.org Add a frontend feature to disable anisotropic filtering. 2020-09-02 syoussefi@chromium.org Vulkan: Don't break the RP on masked/scissored clears 2020-09-02 sugoi@google.com Make copyTexImage2D robust when source area is out of bounds 2020-09-02 syoussefi@chromium.org Vulkan: Fix resolve with different formats 2020-09-02 syoussefi@chromium.org Vulkan: Fix resolve-with-subpass with non-zero read attachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1034840,chromium:1123524 Tbr: cwallez@google.com Change-Id: Icf79fe2ec8d251015215e21e800877538092f27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391373Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804006}
-
Kuo Jen Wei authored
Turn on strict closure compiler check and fix all related errors. Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: I8411d21a7a84b2e0172108ad71275a0c6c93b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383592 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#804005}
-
adamta authored
Adds a named guide for the Discover feed header menu gear icon. This guide is meant to be used in the feed IPH message. Bug: 1124448 Change-Id: If86cc3d5d0d9b3934d135f56a1e3b85954618aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391542Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#804004}
-
Ian Kilpatrick authored
Introduces Node::InvalidateIfHasEffectiveAppearance to handle what this function did previously. There should be no behaviour change. Change-Id: I93c1a1a4112df5dcc395010b1812927e8d1f6c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369505Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#804003}
-
Carlos IL authored
Elision can be broken for URLs in which the tld appears separate from the rest of the host, which can happen for some bidirectional hosts. This disables elision completely for any URL with a bidirectional host component while the bugs are fixed. Bug: 1117631 Change-Id: Ib47b77ec8331b82810383d8c558c33912aad992c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388910Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#804002}
-
Luciano Pacheco authored
Files app doesn't open in the Downloads folder by default since MyFiles folder has been introduced. So the implicit expectation from ARC++ bridge that Files app would show Downloads is broken. This CL fixes it by passing the Downloads folder when opening Files app. NOTE: To have the whole workflow working other changes in Files app and App Service are required and will be tracked on Issue:1090211 This issue was noticed in the Google Photos Android app, which shows a link to open the Downloads folder after user has clicked "Save to device" in a photo. See comments #10 and #11 in crbug.com/1090211#10 Test: Manually from Google Photos Android app Bug: 1090211,607411 Change-Id: I1a320987f58961e069eb49f5b2de7c204bc5211c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381332Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#804001}
-
Yuly Novikov authored
Failures fixed by https://chromium-review.googlesource.com/c/angle/angle/+/2390781 TBR=bsheedy Bug: 1123524 Change-Id: I583adf0ac6117b8d4b5e7e03b3da12cea244e054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391617Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804000}
-
Vladimir Levin authored
This patch cleans up the code and removes DisplayLockLifecycleTarget. The reason for this is that for kSelf the checks always return true, so it's only meaningful for children. This patch updates the function names to indicate this and removes the enum. R=chrishtr@chromium.org, szager@chromium.org Change-Id: Ic17c69e414ece0f0e23fe0d5e20687fea0f8e589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391385Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803999}
-
James Cook authored
Mark crosapi.mojom.Bitmap as stable (it's simple and controlled by the lacros project). Mark crosapi.mojom.Notification as stable (its only interesting dependency, ImageSkia, was recently stabilized). Bug: 1113889 Test: presubmits Change-Id: I0dbf3663d3bd4af72184d360be1f6f4269a5eab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388907Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#803998}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /components/gwp_asan This CL was uploaded by git cl split. R=inferno@chromium.org Bug: 1110266 Change-Id: I1d55608a65e101e9809d5691c1d6ff4dab2152fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370290Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803997}
-
Aleks Totic authored
Bug: 958381 Change-Id: I91df6f992533deffb8192d38d167f7bdd20cd6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385926 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803996}
-
Brian Sheedy authored
Adds a script that can be used to find unexpected passes of tests suites on the CI bots. The intended use case for this is to cut down on the number of stale test suppressions in the GPU tests, but it could potentially be useful for other test types. Bug: 998329 Change-Id: Iac09971a8545721bdf1c7e877477e4a56b2a7969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386423 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803995}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56048e67ae15..e4dd8ba9285c 2020-09-02 nodir@chromium.org Roll dirmd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If63857c85859db2b877f1806e1deccb82da6bf53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803994}
-