GitLab

The base::SupportsUserData::Data superclass seems to be left over from a
previous architecture. It adds cognitive overhead, as it implies that
AppCacheRequestHandler may be used in a base::SupportsUserData
container.

Change-Id: Ibe61b6cec71ebd513eb8ccd896845d4c04b47f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066104
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743199}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf2de16258dc..8ef250cfe144

git log bf2de16258dc..8ef250cfe144 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 tvanderlippe@chromium.org Remove typedefs from {perf_ui,persistence,protocol}-legacy.js
2020-02-20 tvanderlippe@chromium.org Add e2etest for cacheable responses in the network panel
2020-02-20 tvanderlippe@chromium.org Add test for utf-8 character encoding

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@8ef250cfe144

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1044632
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie96e85bdabc6c432b4ab251cc069912b827a782a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066089Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743198}

TBR=kyleju@chromium.org

No-Try: true
Bug: 856601
Change-Id: I08b33a249252e2615cd26fb26ac43e1113d1a028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067243Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743197}

Currently, it takes 120 seconds for 2,000 Hz sampling,
and it takes more than 5 minutes for 10,000 Hz sampling.

This is slow because of the use of double loops. This can be avoided by
using a hashmap (dict) and a single loop with a more lenient pattern
matching. (ntfschr@'s idea)

With this change, the address matching part takes < 1 second.

Also, this adds some more logging to understand what is going on, and
adds a test case around the address that was not recognized.

Test: run_simpleperf_test covers this
Test: output result looks correct.
Bug: 1048428
Change-Id: I795c83133baeb07f8b78342d94e6d3b227eebd61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063811
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743196}

Back button tests - update test setup to set accessibility setting that
forces the back button to be shown (as the tests verify actual button
functionality).

ShelfLayoutManagerWindowDraggingTest.DraggedMRUWindow - for drag from
bottom tests, use the shelf bottom directly instead of current test case
widget bounds (to handle the case where navigation widget is hidden, and
thus has 0 size).

ShelfLayoutManager.PressHomeButtonOnAutoHideShelf, and
ShelfViewTest.HomeButtonMetricsInTablet- the tests verify the button
functionality, so set accessibility setting to force it to be shown.

BUG=1051714

Change-Id: If6f65ef16530af2ca655101698a8a00857dc6da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063730
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743195}

Per request on https://chromium-review.googlesource.com/2029236/ .

Bug: 1048907
Change-Id: If19466721c616114affbde9d65cdd19bd69c5980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040445Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743194}

The script was removed in crrev.com/c/1867257, so (hopefully) the
wheels only it needed are no longer necessary.

Incidentally, this will help certain tests on CrOS which use the root
vpython spec, but don't have the room for the whole venv. By removing
scipy, there will now be enough room.

Bug: 1053547
Change-Id: I8cda733283ff379c93ec027c97935cb8c6ff915c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065419
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743193}

https://webrtc.googlesource.com/src.git/+log/cdda76d1c88e..d881983a38b4

git log cdda76d1c88e..d881983a38b4 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 mbonadei@webrtc.org Change faq.md titles.
2020-02-20 mbonadei@webrtc.org Add FAQ page for git repo.
2020-02-20 hta@webrtc.org Remove old-style OnFailure callbacks

Created with:
  gclient setdep -r src/third_party/webrtc@d881983a38b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:589455
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ia49c58395a9f5adfcccd07d810e64f3b428b471a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743192}

Next step:
* Consolidate string grd file into single shortcut_viewer_strings.grd
* Remove NewWindowDelegate::ShowKeyboardShortcutViewer
  and open it directly.
* Remove KSV_EXPORT

Bug: 1046624

Change-Id: I4241bd00d5c27520ac11c09e7264e8c8c9729a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065852
Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743191}

Bug: 1047454
Change-Id: I9cd74e14d66ed9018c48dee4c711e85c456c1610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044874
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743190}

This CL moves chromeOS strings for settings crostini subpage from
settings_strings.grdp to os_settings_strings.grdp. It continues the
process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: I0b04d2eb1b079c1a4a8e3ef5aedcd86766f737cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062942
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743189}

Revert to previous version (pre crrev.com/c/2039752).

|plane| is shared state between previously submitted frame and the current frame. We can't rely on that state since generating the new frame would have updated the plane state. It's existence in the |old_plane_list| is sufficient to signal that |plane| was previously used.

BUG=1045743,1053603,1053839
TEST=ozone_unittests

Change-Id: I08cdb1ae7962debf7ec35eea6f00291995454d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062684Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#743188}

Original: r743081 http://crrev.com/c/1991446
Revert: 743086 http://crrev.com/c/2065671

The previously landed CL included changes in RenderAccessibilityImpl
that made more sense in previous iterations of that CL where that class
was not implementing AccessibilityModeChanged(). Those changes forced
us to adapt a few unit tests (accessibility_ipc_error_browsertest.cc,
autofill_browsertest.cc, cross_platform_accessibility_browsertest.cc)
that would otherwise no longer pass.

Unfortunately, it seems that those changes in RenderAccessibilityImpl
broke tests in some platforms (ChromeCast and ChromeOS) so, making the
most of the fact that the final code in RenderAccessibilityImpl is much
closer to the original one than in previous versions, we can drop those
changes and avoid even touching those unit tests we had to adapt before
to fix those build failures, which is what we have added in this CL.

And as a plus, the delta compared to origin/master is much smaller now,
since RenderAccessibilityImpl is now practically unchanged.

Original description:

Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org>

This CL starts the process of converting accessibility IPC to Mojo. We
start off by converting the message FrameMsg_SetAccessibilityMode
which, while not strictly a message from accessibility_messages.h,
it's very important in that it's responsible of getting accessibility
enabled in the renderer side, when the ui::AXMode::kWebContent is
specified.

Also, it's important to migrate this message first and doing it using
an associated channel for the new mojom::RenderAccessibility interface
since we need to make sure that this new RenderAccessibility::SetMode()
method gets processed in the expected order relative to other messages
already being sent using Mojo between the browser and renderer process,
such as those for mojom::NavigationClient, for instance. Not doing it
in this way would lead to race conditions during the migration period,
since the ordering of some messages from accessibility_messages.h being
migrated to Mojo could not be processed in the expected order compared
to this new RenderAccessibility::SetMode() method, which is required to
happen first to get the RenderAccessibilityImpl object created in the
renderer.

Specifically, this CL does the following:
- Adds render_accessibility.mojom with the RenderAccessibility
  interface.
- Adds a new class RenderAccessibilityManager implementing the new
  mojom::RenderAccessibility interface, which will also manage the
  lifecycle of the object that will be handling accessibility in the
  renderer (i.e. the RenderAccessibilityImpl object).
- Sets up the plumbing for RenderFrameHostImpl to be able to connect to
  the mojom::RenderAccessibility implementation via RenderFrameImpl,
  using an associated channel to connect to the receiver side,
  implemented by RenderAccessibilityManager.
- Changes how RenderAccessibilityImpl gets created, so that its
  existence is now manager by RenderAccessibilityManager, which is
  permanently connected to the browser process for the entire lifetime
  of the RenderFrameImpl object.
- Uses this infrastructure to replace the sending and handling of
  FrameMsg_SetAccessibilityMode.
- Updates RenderFrameImpl::SetAccessibilityModeForTest() to rely on
  RenderAccessibilityManager::SetMode() from now on.
- Updates tests as needed.

Future work will incrementally convert the rest of the accessibility
messages, including introduction of the Mojo interface for methods
that go from the renderer to the browser.

TBR=dcheng@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,haraken@chromium.org,rockot@google.com

Bug: 1010831
Change-Id: I323c7875a77d05fecf4ae57c61a24fa8268ce463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066758Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#743187}

NetworkChangeNotifierFuchsia #includes the fuchsia.netstack FIDL header
in a header that is published by the //net target, requiring that the
fuchsia.netstack dependency is itself public.

TBR=mmenke

Bug: b/149757507, 1050703
Change-Id: I6bc7088817fd0180b1da85d3c40c0ca7a548fc1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066719Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743186}

*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not
*** revert this CL. Instead, please disable the offending test(s) and
*** add them to the crbug.com/1053725 section of TestExpectations. I
*** will then take care of them as I fix up the remainder of these
*** tests. Feel free to cc me if you create a bug. Thanks.

This CL enables the FormControlsRefresh flag by default on all Desktop
platforms. The launch bug is crbug.com/1051552.

Because many layout tests use form controls, including tests that are
not directly testing form controls, this CL requires many tests
to be rebaselined. The bug at [1] tracks the effort to re-baseline all
of these tests and remove these new lines from TestExpectations. This
will be done in pieces, to reduce the code review burden. The bug at
[2] tracks cleaning up some of these tests eventually, as there are
new tests (see [3]) that directly test the appearance of the new form
controls, and those likely supersede many rebaselines in this CL.
However, I would like to get this landed first, as it might require
several Revert/Reland cycles to get landed for good, and then I can
come back and do the cleanup.

[1] https://crbug.com/1053725
[2] https://crbug.com/1034611
[3] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/

Bug: 1012108, 1053725, 1034611, 1051552
Change-Id: I2d6da06c21567506cf1fc601b90c686c74310376
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063530
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743185}

This CL bumps the expiry milestone for the
reduced-referrer-granularity about flag to M85, so that
it can be around during an M82 rollout of the new default
referrer policy and two milestones' worth of subsequent
enterprise policy lifetime.

Change-Id: If8fe6fed2691c1dafea45bb891f15abd2b702eed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043130
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743184}

This CL adds a new bucket to Download.InitiatedByWindowOpener to
indicate that a download is initiated by a same-site but
cross-origin opener of that tab. E.g., if a tab
subdomain1.example.com opens another tab subdomain2.example.com and
then navigates it to a download, this CL will now record the download
as kSameSite instead of kCrossOrigin.

This is added because latest number from Canary for the kCrossOrigin
bucket is unexpectedly large. I suspect this is caused by sites serving
their downloads on subdomains. This would previously go to the
kCrossOrigin bucket but it now goes under kSameSite bucket.

Bug: 121259
Change-Id: Idf142448b052a342df057982cfb79b0669fbd229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065252
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743183}

Enables LegacyTLSEnforced feature in the testing config, for the new
study name (to fix server side config errors). Previously
crrev.com/c/2056936 updated the feature flag but not the study name.

Change-Id: Ibf55717fe10c87f9ea264c2e8fcc9355c537abc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065407Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743182}

Extend the expiry date of UMA.LowEntropySourceValue to 2020-09-01.

Bug: 1043734
Change-Id: If3eef672679dfed159e807b19458d22a831e32a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066101
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743181}

Extends the expiry of two histograms that we expect to be critical
in the Longpress and Translation experiments.

BUG=1053120

Change-Id: If9bfaa1defc88ed1bb5e6b3d5e6ac47bbe93c35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063357
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743180}

Bug: 1053153, 1037311, 1037121
Change-Id: Ia5347d3279f2ab52cf21591f7ac9b8ac30321cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062939Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743179}

This prevents the app from crashing when the user navigates to the
setting page.

Change-Id: I4c48d8996694a681d27bf423e5212eaf82de29ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046711
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743178}

Bug: 648382
Change-Id: I4db6eb8cfd081c1dde3998db2f1264f0adf42cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065350
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743177}

SwapWebContents is implemented by WebContentsDelegates and is used in
portal activations as well as having several chrome/ layer uses. We'll
need portal specific code in this method, so we now have the
WebContentsDelegate method be specific to portals, instead of bloating
the content API. The chrome/ implementations can then add portal
specific code and then swap. Other callers in chrome/ can call chrome/
implementations' swap methods directly without going through the content
API.

Bug: None
Change-Id: I12106a43e5b7dc510f0f044fea378e0b66df2afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053400
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743176}

This experiment was enabled in fieldtrial_testing_config, because it
was being rolled out in Chrome M80.

However, the experiment with a same name is being reused in M81/M82
code, where it's disabled again for the time being, and so it should be
disabled in fieldtrial_testing_config too.

Bug: 1032584
Change-Id: Ic903f1c082350d7067aaadbafee49b73772a21a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064998
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743175}

These histograms are still useful until we update AccountManagerFacade
to cache account ids together with emails.

Fixed: 1053141
Change-Id: Ifcf2208d15b0692789d8ebdd5f20863397d1e641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066742
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743174}

Bug: 778325
Change-Id: I2ab991daf1eac20daed33feb6009b3cebe4c446e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065590Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743173}

host_app defaults to 'NO_PATH' via run.py, but the check doesn't
include this in shard_utils.py. Including this check and printing
the host_app in this logic.

This only is triggered for gtest_type tests for iOS that are
sharded by Swarming, thus, having those environment variables set.

Change-Id: If9cfcb707866e23ef416ee6be32b54dd48eb7910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045375
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Auto-Submit: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743172}

Change-Id: Ie7cbfe1ef76d0cbb26535748488fd4a2c3c1b1a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065396
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743171}

https://android.googlesource.com/platform/external/perfetto.git/+log/df5f7f9e4e1a..c6be40a04209

git log df5f7f9e4e1a..c6be40a04209 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 treehugger-gerrit@google.com Merge "Stringify errors from libunwindstack."
2020-02-20 treehugger-gerrit@google.com Merge "Log errors enabling / disabling tracing."
2020-02-20 fmayer@google.com Merge "LOG on HardResetFtraceState."
2020-02-20 primiano@google.com Merge "UI: Add CSP policy"
2020-02-20 treehugger-gerrit@google.com Merge "core: Add DCHECKs for process ID to TraceWriter (+1 in TraceBuffer)"

Created with:
  gclient setdep -r src/third_party/perfetto@c6be40a04209

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Iaff45e3848cafe6ea1062c597e8242627558602e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743170}

Bug: 1053130
Change-Id: Ifb56bd19472e57ff0e318b2da26b3f79e4b4244c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061109
Auto-Submit: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743169}

This fixes the regression that the input field wasn't auto-focused when
the smart card PIN dialog (<security-token-pin>) is shown during the
SAML login.

The regression was introduced in https://crrev.com/c/1968989, which
erroneously changed the focus to be set synchronously. This didn't work,
because in practice this happens too early, while the dialog still has
the "hidden" attribute - because Polymer doesn't guarantee the order of
updates triggered by the changes in |pinDialogParameters_|.

The fix is to schedule the focus assignment to be done asynchronously
(soon), so that this happens after Polymer updates all properties
synchronously.

Bug: TODO
Test: enroll Chromebook under domain with smart card settings, start SAML login via the smart card, wait until the PIN dialog appears, verify that the PIN input field is auto-focused
Change-Id: I2f1b4961867f735ac00290cd0cb62cb10fc3d33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047167
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743168}

BUG=1054342
R=bcwhite@chromium.org

Change-Id: Icb07c344efbef1592730dce1ca40bc0079e378e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066542
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743167}

This reverts commit 62751ae7.

Reason for revert: MediaCodec tends to tell us things that aren't exactly true.  Plus, overlay promotion get skipped.

Bug: 1054174, 1049192

Original change's description:
> Plumb color space from MediaCodec to MCVD.
> 
> Bug: 1049192
> Change-Id: I49ca6860718a2a015cfccf07150bd3aa4344b781
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042042
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740406}

TBR=dalecurtis@chromium.org,liberato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1049192
Change-Id: I97b1ab9ade5477d992b8a6fc5e7ecbd7cb84f7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065339Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743166}

- Hide GCInfoTable for most users as the table is mostly an
  implementation detail.
- Provide a type alias GCInfoIndex.
- Functional: Use relaxed memory order when reading the index in the
  fast path.  The setup is done under lock and the index retrieval
  itself should not be used for external synchronization.

Change-Id: I5f4ac9c6493520e2b719f9fc867e3337fd7b0937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062440
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743165}

This reverts commit 7a6d0761.

Reason for revert: the underlying issue that caused the revert
was addressed in crrev.com/c/2062328 by lowercasing GUIDs that are
populated via sync's originator client item ID.

Bug: 1052789

Original change's description:
> Revert "Enforce lower-case use of GUIDs for sync"
>
> This reverts commit b6a3c9f3.
>
> Reason for revert: bookmarks created around 2016, between [M44..M51]
> use an uppercase GUID as originator client item ID.
>
> Original change's description:
> > Enforce lower-case use of GUIDs for sync
> >
> > base::GenerateGUID() produces lower-case GUIDs and they should get
> > exposed to the sync protocol exclusively in this canonical form to avoid
> > running into issues.
> >
> > This patch replaces all occurrences in sync codebase with:
> > git grep -l 'IsValidGUID' -- components/sync* | \
> >   xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g'
> >
> > In addition, the implicit GUIDs used for bookmark sync, in particular
> > for permanent nodes, are updated to adopt lower-case GUIDs. These are
> > never committed to the server so there are no backward-compatibility
> > considerations.
> >
> > Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201
> > Bug: 978430
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#741381}
>
> TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 978430
> Change-Id: If3a135e24cb61d15cfc7616dd1160e76ce9dd3e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061749
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742118}

TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org

Bug: 978430
Change-Id: I9bb6813c5b3edba7b6204e515475d6e644212c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064931Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743164}

As per the following spec resolution, SVG text no longer should be
adjusted in forced colors mode by default.
https://github.com/w3c/csswg-drafts/issues/3855

Bug: 970285
Change-Id: I11a785f64ca6f7e7840b17d6b59d4ce9b9f8b4e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055431Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#743163}

Bug: 1049042
Change-Id: Ib5932f00c2b100aec03240f994370748ff8d2a78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065730Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743162}

Waiting for the compositor "activation" means that we cannot
parallelize the layers. Create an experiment here to remove it.

Tests and perf with this WIP CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2057346

Bug: 1046463
Change-Id: I7631a84eca45e2ce20de51628c8c652108ba6cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056933
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743161}

The intent handler for SearchInChromeIntent and OpenInChromeIntent both
assumed the intents would only happen while the app was backgrounded.
This worked since that's usually true, and the startupInformation would
be processed when the app was foregrounded.

However, OpenInChromeIntents can be chained, and presumably this is also
true for SearchInChromeIntent, which means the first in the chain will
trigger while the app is backgrounded, and the remainder when the app is
in the foreground.

Instead of assuming the foregrounding step will process
startupInformation, let the logic flow to -continueUserActivityURL.

Bug: 1051783
Change-Id: Ia61334ac33995030744c1316f5accef2eae15b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062097Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743160}