- 22 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 1042208 Change-Id: I80b1b804c9c2f9938fd2f3fb3051623871cb0253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010821 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734003}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52524c03db2f..de885c91d53b Created with: gclient setdep -r src-internal@de885c91d53b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5d22d0e80442655f4ffef704ca1c425e9f48c94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734002}
-
Benjamin Beaudry authored
Before this change, focused gridcell were perceived as selected by ATs. This is because we assumed that a focused gridcell was also selected, but that can't be the case. Gridcells are mentioned here, but all ARIA grid roles and treeitem were affected by this misinterpretation of the specs. According to ARIA 1.0 and above, all ARIA grid cells, rows and columns are selectable, but not necessarily selected. We can't assume a relationship between the focused state and the selected state as they are completely independent. We can only do so when the aria-selected attribute is implied or required. To the best of my knowledge, it only is implied and/or required for: - ax::mojom::Role::kListBoxOption: - ax::mojom::Role::kMenuListOption: - ax::mojom::Role::kTab: This CL introduces AXLayoutObject::SelectionShouldFollowFocus(). This method was implemented following the ARIA specs, so that only the elements with an implied and/or required aria-selected attribute value are also marked as selected when focused. Bug: 1030378 Change-Id: I5875cf3f6198aeea73100806d365bb73f7a6c389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996138Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734001}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e5fb5497abf6..0a5ac419555b git log e5fb5497abf6..0a5ac419555b --date=short --first-parent --format='%ad %ae %s' 2020-01-22 nuskos@google.com Merge "Add is_nacl gn arg and prevent nacl from building ipc layer." 2020-01-22 lalitm@google.com Merge "tp: add benchmark for SetBitsIterator and test more bv fill %" 2020-01-22 lalitm@google.com Merge "Revert "Stack profiling: Don't attempt hex conversion on Breakpad build_ids"" 2020-01-22 lalitm@google.com Merge "trace_processor: fix mm ids in rss stat during vfork" 2020-01-22 fmayer@google.com Teach experimental_flamegraph to build native flamegraphs. 2020-01-22 fmayer@google.com Merge "Rate limit map reparsing." 2020-01-21 oysteine@google.com Stack profiling: Don't attempt hex conversion on Breakpad build_ids 2020-01-21 treehugger-gerrit@google.com Merge "logging: don't print negative numbers" 2020-01-21 treehugger-gerrit@google.com Merge "perfetto-ui: Fix thread state" 2020-01-21 treehugger-gerrit@google.com Merge "Define HWUI rendering metrics" 2020-01-21 nuskos@google.com Address comments we had offline. 2020-01-21 taylori@google.com Merge "perfetto-ui: Add panning hint" 2020-01-21 dproy@google.com Merge "Add custom field option annotations to json output" 2020-01-21 primiano@google.com Merge "Add /proc/kallsyms parsing" 2020-01-21 nuskos@google.com Update libperfetto to directly dep on the ipc target on posix systems. Created with: gclient setdep -r src/third_party/perfetto@0a5ac419555b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1041605 Tbr: perfetto-bugs@google.com Change-Id: I60c0911e5a6d2e5c897b5b742aba779f11e029f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734000}
-
Hirokazu Honda authored
After crrev.com/c/1994849, a renderer process queries GPU process HW encoder capabilities when the renderer process is created. To get hw encoder capabilities, it is needed to open driver nodes and query them. The time is small but may not be small enough to ignore. This CL caches hw encoder capabilities so that GPU process only needs to query one time. The exception is V4L2 HW encoder. Since V4L2 driver nodes may not be loaded at the early time of a system boot up, we need to query it until the capabilities are detected. Bug: b:147404923 Bug: 948147 Test: HW encoder is used at appr.tc Test: tast run webrtc.* on krane Change-Id: Iba256bfda861adb75a5454eb011244cb193618d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994038 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733999}
-
Fergal Daly authored
This will only trigger once I land https://crrev.com/c/2006890 but we have no repro steps https://crbug.com/1014212 and are depending on crash reports. Check that: - the RFH pointer is always replaced by a non-null pointer - RFHI.frame_ is valid after we declare the RenderFrame to have been created - RFHI.frame_ remains valid after all calls to SetUpMojoIfNeeded Bug: 981339,1014212 Change-Id: Iab311832be80dcbe1a1ff431af551cdb3a3d645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010511 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#733998}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/80880ee99854..6b66b67f69e2 git log 80880ee99854..6b66b67f69e2 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 cwallez@chromium.org Fix compilation of Log2(uint64_t) on MSVC Created with: gclient setdep -r src/third_party/dawn@6b66b67f69e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I399ef679a8a34174a63d9970e7040d3207580b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014663Reviewed-by:
-
Tim Van Patten authored
The test conformance/renderbuffers/depth-renderbuffer-initialization.html is flaky on AMD GPU on Windows: https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-32/3210 https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-32/3155 https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-32/3113 This CL will suppress that test while the issue is investigated. Bug: 1043773 Tbr: ynovikov@chromium.org Change-Id: If8b39ea44d0b6c9a78f790c57d2f7897547b7768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013263 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#733996}
-
Olga Sharonova authored
This reverts commit b23ba4d3. Reason for revert: Speculative revert for multiple failures in https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/2057 Original change's description: > Ice Server API integration > > Integrates network traversal API to fetch stun and turn servers for > webrtc p2p connection. Handles API failure by returning a list of > public Google stun servers as a fallback. > > Bug: 1031156 > Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733941} TBR=droger@chromium.org,msramek@chromium.org,knollr@chromium.org,himanshujaju@chromium.org,ajgo@chromium.org Change-Id: I62270288afa5716c4dfb5fa6c35df2cfe0a82d79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013288Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#733995}
-
Yann Dago authored
When navigating back from IE to Chrome using LBS, the latest Chrome installation was opened, unless the admin specified a Chrome path to use. By writing the chrome path of the browser that initiated the IE navigation cache.dat, the chrome instance was used last will be the one we back to. Bug: 1005849 Change-Id: Iad4c4d601eedcc8cd7d9bee6f0f90143352f96fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004949 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#733994}
-
Paul Jensen authored
Since Android P, ConnectivityManager's NetworkCallback signals (which NetworkChangeNotifierAutoDetect listens to) include changes to VPNs so Chrome doesn't need to use AddressTrackerLinux to detect VPNs coming and going. Avoiding it should speed up initialization and decrease memory usage. This change disables all of NetworkChangeNotifierAndroid's BlockingThreadObjects for Android P+ as it only contains an AddressTrackerLinux instantiation. Change-Id: Ic64f0360d78ee9d75e3f7e5a46ac7e57ccc2dd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007525 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#733993}
-
Olga Sharonova authored
TBR=seblalancette@chromium.org Bug: 1044568 Change-Id: Ieec8a5cf947733a75be3167dcef69e457f033b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013051Reviewed-by:
-
Colin Blundell authored
This CL transforms CaptivePortalService's dependence on Profile to instead be a dependence on BrowserContext as a step in enabling the componentization of CaptivePortalService. The transformation is straightforward. Bug: 1030692 Change-Id: If23ff0b104b695a66bff4d5d99261c9cebd756e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007725Reviewed-by:
-
Nicolás Peña Moreno authored
We're currently still implementing changes in the LargestContentfulPaint metric, so it's good to keep ContentType metrics around to help debug metric changes. This CL extends the expiry by 6 months. Bug: 1037182 Change-Id: I0887fef67a587b27e5c9b0849e6bd26a28ef3d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013922 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733990}
-
Jit Yao Yap authored
The |ResultCatcher| and |ExtensionTestMessageListener| are possibly not ready before the login screen extension is re-enabled when the screen locks. This results in a race condition. This CL fixes the race by using 2 separate listeners which are initialised before the call to the lock. Bug: 1044280 Change-Id: I221f3f70e4eef02df3f13bd5c9c8cda24f132a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012952Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#733989}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1eb0ddb4d0c3..ed94ccdde306 git log 1eb0ddb4d0c3..ed94ccdde306 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 11cb891a01a2..b766e5e7fbf4 (1 commits) Created with: gclient setdep -r src/third_party/angle@ed94ccdde306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I99fc2ebc18e9030ae06f2bd67c8c271d7672bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014661Reviewed-by:
-
Stepan Khapugin authored
Remove the ability to hide OmniboxContainerView's leading image, since it's always shown in HL. Cleanup the implementation to not have that option anymore. Bug: 945334 Change-Id: I39107d51c69e861251f0fd2e2111542c1c075d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007411 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#733987}
-
Mark Brand authored
There's an integer overflow in ArrayDataTraits<bool> since the intermediate calculation takes place with a uint32_t. Reducing kMaxNumElements slightly prevents this overflow, and use of such large arrays would anyway have broken. Also added a regression testcase into the fuzzer directory, and added in support for the array<bool> type to the fuzzer. Change-Id: Ieabe5a9abe7fa5ebd6a27cb810db63d47dc52473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003179Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Palmer <palmer@chromium.org> Auto-Submit: Mark Brand <markbrand@google.com> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#733986}
-
Nico Weber authored
The one instance was fixed in upstream Vulkan Loader early Dec 2019, and we rolled that into angle yesterday. Bug: 1002945 Change-Id: I524bea56f50776e6fb2453ae68fce9f8b3f709e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948231 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#733985}
-
Yuichiro Hanada authored
This reverts commit 43afaff3. Reason for revert: The CL breaks touch and mouse events on ARC++ notifications. Bug: b/148028487 Test: manual - interact with the buttons inside ARC++ notifications Original change's description: > Tray bubble animation improvements > > FPS on arm+hires is now ~60fps even with bg blur (w/o notifications) > > * Use layer clip during animation > * Remove unnecessary background paint > * Fine tune layer structures: Remove unnecessary texture layer, > and use smaller layer, or change so that it require less > repainting. > > Refactoring: > * Consolidate the shield/blur/rounded code into TrayBubbleView. > * Introduce layer type to buggle dialog delegate. > > Fix: > * Looks like we were painting bg twice which made blur darker. > It happens once in TrayBubbleView's layer. > > Bug: 1033986 > Test: no functional change. > > Change-Id: I6b31513b04c55c851e468f621b2d18a3183abd56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963234 > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724822} TBR=msw@chromium.org,oshima@chromium.org,tengs@chromium.org Bug: 1033986 Change-Id: Ie3046439d91b882e0a6b9ccfc13106dbeae4124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014359Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#733984}
-
Alexander Timin authored
There is a possibility that is we put the page in bfcache too early during its loading, it might not have installed pageshow() handler yet, which means that the page can't record metrics appropriately. Add some metrics to quantify this. R=haraken@chromium.org,hajimehoshi@chromium.org CC=rakina@chromium.org,bfcache-bugs@chromium.org Change-Id: I38d18cf9477c5ee3da6c615379f3049ee222eaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013102 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733983}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/13f30b96a857..10a452110979 git log 13f30b96a857..10a452110979 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-22 tvanderlippe@chromium.org Typecheck Color.js with TypeScript 2020-01-22 sigurds@chromium.org [heap-snapshot] Hide 'treat global objects as roots' behind experiment 2020-01-22 tvanderlippe@chromium.org Reland "Fix typescript compilation with ts_library" 2020-01-22 sigurds@chromium.org [sourcemaps] Report error message on resourceLoad error 2020-01-22 pfaffe@chromium.org Don't set markers for multi-line breakpoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@10a452110979 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1030746,chromium:1034504,chromium:1043614 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I217bb390a7419303f173924e812245dc1dd95237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014662Reviewed-by:
-
Ewann authored
- Adds flag. - Changes tab switcher button position from tab strip to toolbar. - Removes bookmark button from toolbar. - In InfobarCoordinator: The Omnibox frame wasn't translated to the correct coordinates. Updates the translation to get the expected coordinates & removes the kiPadBannerOverlapWithOmnibo constant. Screenshots: https://drive.google.com/open?id=14hmYjuwDnC7Fn6Rs-pRr5A0P4QRDb615 Bug: 1035850, 964136 Change-Id: I2e7c7de7ca07ce6abc2e1a98a9661f0c48d67ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978798 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733981}
-
Guido Urdaneta authored
Bug: 1017219 Change-Id: Ice1478f8341b1facbd55c16cb90e65ec98ca0cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013284Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#733980}
-
Avi Drissman authored
Chromium requires the 10.14 SDK. As per <https://en.wikipedia.org/wiki/Xcode>, that version of the SDK came with Xcode 10.0, which requires at least macOS 10.13.6. Update the documentation accordingly. Bug: none Change-Id: I9ade5aedd6811ba6a4f4c1951191f21af0bd58fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013634 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0fd69f5e. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" 1d0a2056 "Remove error.message in SharedWorker WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I9da216b18339bad96369cdb5282bc9f025948cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014462Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733978}
-
Olga Sharonova authored
TBR=foolip@chromium.org Bug: 1044567 Change-Id: Id058aefb9b62f35fbdbd638918da8370d7a0f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013249 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Jan Krcal authored
This reverts commit d6f90584. Reason for revert: The culprit for the flakiness has been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2013281. Original change's description: > Disabling TwoClientAutofillProfileSyncTest.ClientsAddSameProfile_Test on desktop > > > Failing > > TBR=vitaliii@chromium.org > > Bug: 1044514 > Change-Id: I698c4527a69a6e689e4be99e145b1bbf7bef327b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013047 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733922} TBR=olka@chromium.org Change-Id: Ie468acf3fe421a5aa186fa96e057a4e9637b6271 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013128Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#733976}
-
Robert Flack authored
When we are applying scroll anchoring we should not update the pressed part of the scrollbar as it leads to unstable scrolling. Bug: 1043674 Change-Id: Id19f33626be2c2607351bb208f1b4f340477db8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010053 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733975}
-
Hazem Ashmawy authored
Schedule a low priority (best effort) non-blocking PostTask when chrome comes to the foreground or when a WebView MonoChrome process is created. The task is responsible to show a launcher icon to open WebView DevTools if monochrome is the current selected system webview provider otherwise it hides the launcher icon. The component (activity-alias) that shows the icon is disabled by default and is only added to the manifest in build-time when GN argument `webview_devui_show_icon=true` which is enabled by default for dev and canary channels. icon_webview is added to the activity-alias for monochrome so the launcher icon for DevTools will be WebView icon not Monochrome. However, the icon the application switcher will still show monochrome icon. Bug: 1026062 Bug: 1026060 Test: select monochrome as webview implementation and launch monochrome browser, observe icon appearing Test: select monochrome as webview implementation and launch webview shell browser, observe icon appearing Test: select different webview implementation, launch monochrome and observe icon disappearing Change-Id: I9c05aa9d8bcdddc016a06b62a5e76e2aa20f30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000724 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733974}
-
Nicolas Ouellet-Payeur authored
Change an empty destructor body to `= default'. Change-Id: If1f3ce393aa45a93a806cf8336afddec070817ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012543 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#733973}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: I1dde40ae065191ba440a39173db12e06c4220fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010787 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733972}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cedab522227a..d59053987a27 git log cedab522227a..d59053987a27 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 845a09b8241e..8c396a9cc4a8 (5 commits) 2020-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 11cb891a01a2..b766e5e7fbf4 (1 commits) 2020-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 4c751358..f2517d68 (355 commits) 2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-21 brianosman@google.com Improve error handling in SkSL ByteCode 2020-01-21 brianosman@google.com Tweak pointlight3d sample to work in Raster backend 2020-01-21 jlavrova@google.com Calculating drawing area for a line with shadows 2020-01-21 benjaminwagner@google.com Revert "Reland "Pass in a SkColorType into SkImage_Gpu ctor."" 2020-01-21 reed@google.com remove the last vestiges of SkMScalar 2020-01-21 reed@google.com IWYU -- colorspace no longer includes matrix44 2020-01-21 egdaniel@google.com Pass swizzle into createProxy instead of inferring from GrPixelConfig. 2020-01-21 robertphillips@google.com mv BackendTextureData to end of parameter list 2020-01-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-21 egdaniel@google.com Reland "Pass in a SkColorType into SkImage_Gpu ctor." 2020-01-21 mtklein@google.com let picture record take a bbh directly 2020-01-21 mtklein@google.com modernize some picture internal types 2020-01-21 robertphillips@google.com Add GrTexturable type 2020-01-21 egdaniel@google.com Better handle colorTypes in GrTexutreProducer. 2020-01-21 herb@google.com Simplify 1 pixel padding calculation 2020-01-21 reed@google.com use safe cast when converting double to float Created with: gclient setdep -r src/third_party/skia@d59053987a27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: Ie1dc16a1e35662364099e4780bd4ea7998acc802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013830Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4cde67a8..4a1aaa1a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75c63abbacf2af957052a109efb37a1e1aa34f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014461Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733970}
-
Tobias Sargeant authored
When we determine whether a stack frame refers to WebView we look up the class by name in the WebView classloader. If dynamite module code used by the app has been proguarded, then it's possible for there to be a class name collision, which causes us to treat it as a WebView class. We can avoid this case specifically by relying on the fact that GMS proguarding sets the source filename to a predictable value. Bug: 1043656 Change-Id: Icff4d7eb931d8295902cdda2483da2578f071cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014445Reviewed-by:
-
Benoît Lizé authored
On Windows, the exception record can contain extra data. This is already used to record the size of the failed allocation for some allocators in a way which is easily accessible in crash reports, but PartitionAlloc does not make use of it. This CL adds support in PartitionAlloc for this feature, and unifies OOM handling somewhat. For instance, we no longer have 2 distinct ways to crash, one which records the size, and one which doesn't. Also a few cosmetic changes: - gOomHandlingFunction -> g_oom_handling_function - Fix a few "git cl lint" warnings. - A typo Bug: 983348 Change-Id: I0e13b2d6a6c41d8be6a57c81d969d8476ef256ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988349 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#733968}
-
Bence Béky authored
Add four header files that are included from files already in BUILD.gn. After this change, every *.h, *.cc, and *.inc in QUICHE is listed in BUILD.gn other than common_cert_set_[23][ab].inc, quic_interval_deque_test.cc, and the entire quic/qbone subdirectory. Change-Id: Ic90e50a88f69a3be0e59b350915abd99017ac64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011061 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#733967}
-
chrome://killFergal Daly authored
https://crrev.com/c/2006890 will reland a CL that broke this. This test "correctly" fails when patched onto f4c4a4aa however it passes when patched onto the reland. Manual testing of the reland also does not trigger the bug, so I guess something changed but having an automated regression test seems wise. Bug: 981339, 993701 Change-Id: I048868e3181f9c3b0c856ce8553226fe29acc696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011585 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#733966}
-
vitaliii authored
This way it can be later extended easier (e.g. tag number space is separate from outer SharingMessageSpecifics) and also passed as an argument in C++ code. This is the first step to start building SharingMessageSpecifics in the bridge instead of doing this in Sharing code. Changing tag numbers in the proto is fine, because a) it is not used anywhere yet b) it is not persisted anywhere anyway. Bug: 1044537 Change-Id: I4201680cfd8149888efbc35da6fbb5a7969f436a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013246 Auto-Submit: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Emily Stark authored
https://chromium-review.googlesource.com/c/chromium/src/+/2006473/ introduced new tests for redirects that lead to error pages. These tests used custom request handlers to serve the redirects, since I didn't know that there were default EmbeddedTestServer handlers for 307 redirects. This CL simplifies the tests to use the default handlers instead. Bug: 1041597 Change-Id: I8377bd25d5890bf6c8c77ce2ca06e9b1a999935f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013342 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
