GitLab

Bug: 963764, 963141
Change-Id: Iabffc84c01c9bf15dcfa2a9da20ae98b859efd4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625207Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662239}

The argument they receive is only called once, so it should be a
OnceCallback.

R=liberato@chromium.org

Bug: 953861, 751838
Change-Id: I8158bb89855084813ba2721698119cde76f15c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622639Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662238}

Publish the metrcis for each request type individually.

Bug: 959398
Change-Id: Ia1280fdc3c2fa328a364918c53de69e35b230003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594119Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662237}

The format of the clang build stamp file was changed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1615030/27/tools/clang/scripts/update.py

The update_clang_coverage_tools.py script is broken because the
expected format doesn't match anymore, and this CL fixes the issue.

Change-Id: Ic72e9dc3d45bbb4ebbdb914c6dacee8d7259edb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625549Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662236}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/927eded5..28b0246e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1ec826d2d325c647dacb6d6ad93b9e33e21f0d07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625098Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662235}

Adds a new Feature OverlayNewLayout and chrome://flags entry to enable
the new Overlay layout that uses a drag handlebar and separate icon
for open-in-tab.  The old layout code is restored and the default.

The new layout was introduced in CL 1580686, so now we can evaluate
old vs new layout until we decide which is best.

BUG=964155

Change-Id: I37b2182ec041b12f058e7849a7aa8249e7d318bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616974Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662234}

android_webview: Make system_webview_shell_layout_test_apk and webview_ui_test_app_test_apk use BaseChromiumAndroidJUnitRunner

Using this instrumentation class will soon be required when using Base's
test runner.

Bug: 441859
Change-Id: I4e1df9abb143bbd5440bcbfd1c1384e9a039ea78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625014
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662233}

TracingController may not actually have been initialized if shutdown
occurs very early (before mojo was initialized). In that case, we
shouldn't attempt to finalize startup tracing.

Bug: 961594
Change-Id: I2f913630309cf01598060ad9e1334345603d0fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625108
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662232}

Add ChromeOS specific RelaunchHeadsUpPeriod policy. It will be used to
control time of the first user notification. The exact usage of the
policy and related pref will be added in the subsequent change.

Bug: 963883
Change-Id: Ib8cefc940879a984780987b5fbb1f8a01182b832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621922
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662231}

According to crbug.com/961017#c11, we always intentionally
leak crash keys.

Bug:961017

Change-Id: Ic515375a93180998e4adab03daf739d1cd56d494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614101
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662230}

Convert AutocompleteCoordinator into an interface and move existing code
into AutocompleteCoordinatorImpl. Isolate its creation to
AutocompleteCoordinatorFactory.

Move several inner interfaces out as top-level interfaces. This allows
fewer intra-package imports, especially important for making the factory
as simple as possible.

Reduce visibility of test-only methods to package-private, and create
AutocompleteCoordinatorTestUtils for test support to access these test-
only methods.

Bug: 961368
Change-Id: I37e2f04e8fe1dd76fc754ee67d8ef504525d85ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603093Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662229}

As part of work to replace usages of paper-icon-button with
cr-expand-button in the ChromeVox options, I found that the control
needed a aria-label set when no |alt| was set. cr-expand-button was
also using aria-pressed instead of aria-expanded. After testing with
VoiceOver, aria-expanded provides a clearer description of the control.

Here is the CL to replace paper-icon-button with cr-expand-button:
https://chromium-review.googlesource.com/c/chromium/src/+/1618564

Bug: 960564
Change-Id: Ib60507ec816507ba9a6010f3bfe6d7a6a55fc116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622705Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662228}

Bug: 965974
Change-Id: I12a8f52e6636035a20b105841f23587d3f68a6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625010
Commit-Queue: Peter Lee <pkl@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Peter Lee <pkl@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662227}

These tests were replaced by ServiceWorkerBasedBackgroundTest.TabsEvents
tests and will no longer work when extension API bindings are restricted
to the service worker script specified in the manifest.

Bug: 961836
Change-Id: I2f28ee669038f7dad1d24d5e44c55551db9ddeba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612558Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662226}

HttpAuthHandler is a base class that has a couple of pure virtual
methods for specialization by HTTP authentication scheme specific
handlers. There are three main entry points to an HttpAuthHandler:

  1. Construction and initialization, which is only invoked via a
     HttpAuthHandlerFactory.
  2. GenerateAuthToken().
  3. HandleAnotherChallenge().

Of these the initialization -- via InitFromChallenge() -- and
GenerateAuthToken() methods wrap pure virtual specializations via Init()
and GenerateAuthTokenImpl() respectively. This wrapping allows
consistent handling of logging around the specialization.

The odd one out is HandleAnotherChallenge() which was left as a pure
virtual method to be overridden by each specialization. This CL makes
HandleAnotherChallenge() also a wrapper in line with the other entry
points. This is done by making HandleAnotherChallenge() be a concrete
wrapper that invokes HandleAnotherChallengeImpl() which is a pure
virtual specialization point.

In addition, this CL introduces AUTH_GENERATE_TOKEN and
AUTH_HANDLE_CHALLENGE NetLog event types that wrap the events happening
within GenerateAuthToken() and HandleAnotherChallenge() respectively.
The handlers no longer log any target specific events like AUTH_SERVER
and AUTH_PROXY which are removed by this CL.

Bug: 884313
Change-Id: Ib7f97e61e0dcdc60dc15326604b7d3e383ab5c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566490Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662225}

Before this patch, the PaymentMethodChangeEvent would be exposed in
WebView, because it has its own feature flag that was not explicitly
turned off in WebView.

This patch disables PaymentMethodChangeEvent and PaymentApp features in
WebView when the overarching feature PaymentRequest is also disabled.

After this patch, the PaymentMethodChangeEvent is not exposed in
WebView.

Bug: 965980
Change-Id: I4fb351a367638c9d830cfb189a5c9e8011c0a8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625265
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662224}

https://skia.googlesource.com/skia.git/+log/2961ddb9eacc..1706cbffc791


git log 2961ddb9eacc..1706cbffc791 --date=short --no-merges --format='%ad %ae %s'
2019-05-22 csmartdalton@google.com Remove VisitorType from GrOp::visitProxies
2019-05-22 jvanverth@google.com Fix resize and vsync issues in Mac Viewer
2019-05-22 robertphillips@google.com Make GrGLGpu::createBackendTexture parallel GrGLGpu::createTextureImpl
2019-05-22 halcanary@google.com VkTestUtils: respect new optional SK_GPU_TOOLS_VK_LIBRARY_NAME define
2019-05-22 jvanverth@google.com ARC cleanup and memory leak fix.
2019-05-22 mtklein@google.com use float -> float math functions
2019-05-22 zhenyu.shan@intel.com Add AVX2 implementation for blit_row_s32a_opaque


Created with:
  gclient setdep -r src/third_party/skia@1706cbffc791

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Change-Id: I50181b5aada3c26a6d9bda0c2d874bb5c891e567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662223}

This reverts commit beea44ce.

Reason for revert: Breaking feedless builder.

Original change's description:
> Trichrome Proguard: Fix locale pak selection.
> 
> This CL moves the arrays of locale pak files out of BuildConfig.java
> into a new file, LocaleConfig.java.
> 
> This file is generated with a unique package which allows Chrome
> and Webview to have different versions in Trichrome.
> 
> Bug: 960025
> Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662209}

TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org

Change-Id: I163a3039092ea585c3ea0ee16784e49ae5d1227f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625450Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662222}

This might take more than milestone to finish so putting this behind a
feature flag.

Bug: 964919
Change-Id: I11acaa377b282d9acd9788b2e1a54bf0d2297511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617762
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662221}

This test verifies the behavior change landed in
https://crrev.com/c/1594115 (i.e. that all top-level navigations should
be allowed to set SameSite=* cookies).

This matches proposed spec update:

https://github.com/httpwg/http-extensions/commit/49bcb4fddb8a8c294749ec9d81a236cde4df94b0


Bug: 960375, 958331
Change-Id: Ief84f5a7dcfd8d7dae4a8ed5cdd70335fb164647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600341
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662220}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e66f7aeb4a32..b173466778a5


Created with:
  gclient setdep -r src-internal@b173466778a5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: Iba13c7c60c0a8592b99e5d739d48da50ea5f45e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624829Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662219}

-v is not always desired, and does not play with with --local-output

Change-Id: Ia8bb3132f90e6da64953463fed523d97470802c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624828
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662218}

This reverts commit 35a25733.

Reason for revert: This is suspected to have caused test failures.

Original change's description:
> Enable preload=metadata lazy load everywhere.
> 
> Turns out I should have pulled the latest 28D data for 74 before
> limiting to !CrOS && !macOS. No regressions are shown in that data
> anymore, so enable eveywhere.
> 
> This leaves the flag in for now until we reach stable.
> 
> BUG=879406
> TBR=liberato
> 
> Change-Id: I48bd5440893ee2c74b8cc54d5575d0347b2b7e78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623487
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662017}

TBR=dalecurtis@chromium.org,liberato@chromium.org

Change-Id: Ief5816c1045c03a0f0c53bd42affa893478668b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879406,965983,966003 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624916Reviewed-by: Lowell Manners <lowell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662217}

The spec[1] says "If the global object is not a Window object, throw
a TypeError". We should check whether the global object is a window
object when converting a performance-timing name to timestamp. If
it is not, throw a Type Error.

[1] https://w3c.github.io/user-timing/#convert-a-name-to-a-timestamp

Bug: 953869
Change-Id: I188d810f2505a37f2cdfc823ce076cec96dd7839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613653
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662216}

Landing this manually because of issue 958017.

Using wpt-import in Chromium 51dfc6b4.
With Chromium commits locally applied on WPT:
c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed"
fec827fb "Added wpt tests for overscroll customization."
c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet"
d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions"
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
c4fa33ec "CSS: WPT for scroll-padding computed value"
9200fa90 "Add WPT test for sctp.maxChannels"
297e5505 "Bring reference space naming/interfaces up to spec"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
ecobos@igalia.com:
  external/wpt/css/css-display
ericwilligers@chromium.org:
  external/wpt/css/motion
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
kojii@chromium.org:
  external/wpt/css/css-text/line-break
  external/wpt/css/css-writing-modes
meade@chromium.org:
  external/wpt/web-animations
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mstensho@chromium.org:
  external/wpt/css/css-multicol
rego@igalia.com:
  external/wpt/css/css-ui

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I89e163e716b5d3c0dcdbf47c675a2ba401c13713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624946Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662215}

This patch changes |NGPhysicalFragment::GetLayoutObject()| to
return |const LayoutObject*|.

There are 18 places where we need mutable objects.
|GetMutableLayoutObject()| is added to support them. We'd
like to eliminate them over time.

Original discussion at a review comment[1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1614732/14#message-6290a1c82a1344f0dda119af20225e0b5fa867c9

Bug: 635619
Change-Id: I0aae9d9bb5d1eb9c9c34e149edbecc3c59a7870d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616834
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662214}

This CL temporarily disables one of
SavePageOriginalVsSavedComparisonTest tests to enable landing of
a change to //testing/variations/fieldtrial_testing_config.json
that enables MimeHandlerViewInCrossProcessFrame everywhere in
preparation for shipping this feature to the stable channel in M76.

The test failure seems mostly understood and the test should be
re-enabled within a week or two.

Bug: 964364
Change-Id: I3006897f260301bcc5eff52e828c08702517bea8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620700Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662213}

This CL generalizes helper functions used in the following tests
* PasswordAccessoryControllerTest,
* AddressAccessoryControllerTest (https://crrev.com/c/1614200), and
* CreditCardAccessoryControllerTest (https://crrev.com/c/1599927)

Bug: None.
Change-Id: Ief1ad6cb78e14d558e2202cf874d8dbbaa54e9fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615464
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662212}

One of the paths that determines eligibility is during onboarding.

Bug: 958995
Change-Id: I58056f8edea1b9da2f9ddd4b0ff0ae9ef6d1bcf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621397
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662211}

https://webrtc.googlesource.com/src.git/+log/23aff9b73788..b32f2c7f57cc


git log 23aff9b73788..b32f2c7f57cc --date=short --no-merges --format='%ad %ae %s'
2019-05-22 danilchap@webrtc.org Publish rtc event log api and default factory for it in api/


Created with:
  gclient setdep -r src/third_party/webrtc@b32f2c7f57cc

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I60c30034f3c40738946905907871a2229fe98dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625007Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662210}

This CL moves the arrays of locale pak files out of BuildConfig.java
into a new file, LocaleConfig.java.

This file is generated with a unique package which allows Chrome
and Webview to have different versions in Trichrome.

Bug: 960025
Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662209}

Bug: 961120
Change-Id: Ic0315eb4a99c9ccc3dcc22207de5838c2fb5fe2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624945
Auto-Submit: Peter Lee <pkl@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662208}

Copied from //build/android/.style.yapf.

Ran "yapf -r -i --style base/android/.style.yapf base/android",
fixed a couple instances where the suggested changes weren't nice due
to complex statements, and fixed two long line issues.

Also updated testREForNatives to not have an unused variable.

Bug: 846432
Change-Id: Ic11f0bf808adaae03fbd2b2d6e819169f4e9bd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622909Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662207}

This patch removes the deprecated accessibility selection code from Blink.
This is timely, because the new selection code has been on for 1.5 weeks and
no major regressions have been encountered.

R=aleventhal@chromium.org, dtseng@chromium.org

Bug: 639340
Change-Id: Ibdf8a7575e229407fe3418a4efd5eed96b7b8540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620967Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662206}

For history webuis and the recent tabs menu, we offer the possibility
of using requests to Google's favicon server as a fallback mechanism,
instead of requesting from sync. We use LargeIconService to achieve it.
This behavior is guarded by a feature flag disabled by default. We also
fix a minor formatting issue in chrome/browser/about_flags.cc.

Bug: 955475
Change-Id: I1ff64611cfde1e995a14b36ea2496b33d214eea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603444
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662205}

If a notification is dismissed but not dealt with,
then show it again after 1 day.

If a notification is not dismissed, and password is not changed,
then notification is updated after one day, since the text showing
the how urgent it is should change.

Deleted some code that special cased the "expired" case -
this case actually has the same logic as "about to expire" case,
so it doesn't need a special case.

Added more unit tests for SAML password expiry notification.

Bug: 930109
Change-Id: Ie035ec788ee083d07261bca0e19f216e6bc7d6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620642
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662204}

The cookie was a domain cookie, but host cookie is preferred.

This allows simplifying and re-enabling the test.

The test was failing with net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN.
This CL removes the DNS rule and the SSL configuration (which were
required for the domain cookie, but can be removed for a host cookie),
which makes the test simpler and hopefully more robust.

Bug: 964264, 965993
Change-Id: I03412b9046b79a2cbb56ebdb95dd1661d67fb938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617360
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662203}

Also remove the base writer interface as it's not needed.

Bug: 961336
Change-Id: Ie942c35079ba45c37b549a977e952470a95d529c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613881
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662202}

This CL adds a workaround for the advertised supported VAImageFormats in
Intel's media driver (iHD). Right now, the driver is advertising some
formats that it actually doesn't support. Until this is fixed, we are
conservative and remove all the formats other than I420 or NV12 from the
list of advertised formats.

Some additional cleanup is done per https://crbug.com/956581.

Test: VaapiJpegDecoderTest.* pass on eve.
Bug: 955284
Change-Id: I734581ef7c533251559c66355755d9e7766239cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623491Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662201}

Old parser is disabled is final state of the launch of the new parser,
so everything should work for it. PasswordManager::ProvisionallySavePassword
sends ReportMissingForManager metric even if old parser is disabled (and
then it sends it incorrectly). This metrics is sent for NewPasswordFormManager
in PasswordManager::ProvisionallySaveForm.

Along the way extracted sending of SubmittedFormFrame metric to a separate
method and called it for NewPasswordFormManager.

Bug: 831123
Change-Id: If170658a030e2b34b8aa7b9bd70cc048d8de0fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624573
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662200}