- 14 Apr, 2020 40 commits
-
-
Christopher Lam authored
https://chromium-review.googlesource.com/c/chromium/src/+/2126408 renamed a color which broke existing clients. This CL fixes the crostini_upgrader. Bug: 1070423 Change-Id: I3015451bd25376ad981c160a2551b94fcd197718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147130Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758818}
-
Victor Hugo Vianna Silva authored
CredentialsItemView now supports setting an optional right-aligned G-logo icon to disguish account store forms from profile store ones. The icon is set in the AccountChooserDialogView for credentials read from the account store. If the user has not opted in to b4p, no forms will satisfy this, so there's no need explicitly check the opted-in state of the user to guarantee that no badges will be shown for non opted-in users. Account chooser with badges: https://screenshot.googleplex.com/JMiryuMoec8 Bug: 1060134 Change-Id: Id0a27324ad7955dae366a3e6efa8102c1145633f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116211 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#758817}
-
Corentin Wallez authored
TBR=kbr@chromium.org Bug: chromium:1064305 Change-Id: Ia27f42ea9688aca2b0f97037c06843ca5edb1776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148773 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758816}
-
Anatoliy Potapchuk authored
This cl adds a new policy, which controls the visilibity of the FloatingAccessibilityView via FloatingAccessibilityController. Bug: 1061068 Change-Id: Ie0b5cbe18f714cc6b848fb8f71b92bc120a2f19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134826 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#758815}
-
James Cook authored
Supervised users (including child accounts) use the sync subsystem to load settings and URL allowlists from Google backends. Change these data types to use sync transport mode because we want them to run even if browser sync-the-feature is disabled. Bug: 1043755 Test: Added to unit_tests and components_unittests Test: Sign in child account and manually verify the types are running in chrome://sync-internals Change-Id: Ic681adab2fd3101ec326b99ed3aee085f0597a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142132 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#758814}
-
Antonio Gomes authored
This CL migrates clip-path-reference-mutated.html to external/wpt/css/css-masking/, adding links to the relevant specs and a test assertion describing its purpose. Note that the use run-after-layout-and-paint.js is replaced by rendering-utils.js and reftest-wait.js. BUG=1063749 R=fs@opera.com Change-Id: I3cf19dee73ab4baf66b8a67449e1d2e302288c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144712 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#758813}
-
Joshua Pawlicki authored
Bug: 1070206, 1062285 Change-Id: Ia5c5222efcf2b90e41f1db9f5cac216a15befb4f Fixed: 1070206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147752 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758812}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e43b27e8b45..dfd18c4e7516 git log 5e43b27e8b45..dfd18c4e7516 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 tvanderlippe@chromium.org Remove istanbul-diff from node_modules Created with: gclient setdep -r src/third_party/devtools-frontend/src@dfd18c4e7516 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068145 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5c5dea2d3cc5bf6c4de9489b7b7a68f5e6471da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758811}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/10b1902d893e..e3f0319d89f4 This CL also removes references to gmock-generated-matchers.h, which was removed from googletest in commit 41b5f149ab306e96b5b2faf523505d75acffd98a, and to gmock-generated-function-mockers.h, which was removed from googletest in commit fbf67a70d07543f40832d0cd7a58f304bc6ab1d1. $ git log 10b1902d8..e3f0319d8 --date=short --no-merges --format='%ad %ae %s' 2020-04-01 absl-team Googletest export 2020-03-30 absl-team Googletest export 2020-03-23 absl-team Googletest export 2020-03-24 krystian.kuzniarek remove chapters on Autotools, Meson and plain Makefiles 2020-03-24 krystian.kuzniarek remove dead code in googletest-output-test 2020-03-24 pkryger Swap settimer and sigaction calls to avoid SIGPROF 2020-03-20 absl-team Googletest export 2019-07-11 adam.f.badura Add support for std::function in MockFunction (#2277) 2019-12-26 adam.f.badura Add tests for MockFunction deduction (#2277) 2020-03-17 absl-team Googletest export 2020-03-16 dmauro Googletest export 2020-03-13 absl-team Googletest export 2020-03-06 absl-team Googletest export 2020-03-03 absl-team Googletest export 2020-03-03 absl-team Googletest export 2020-03-11 romain.geissler Make sure IsATTY does not clobber errno. 2020-02-27 absl-team Googletest export 2020-02-25 absl-team Googletest export 2020-02-19 absl-team Googletest export 2020-02-21 johan.mabille Fixed warnings 2020-02-12 absl-team Googletest export 2020-02-11 absl-team Googletest export 2020-02-11 absl-team Googletest export 2020-02-10 absl-team Googletest export 2020-02-10 absl-team Googletest export 2020-02-07 absl-team Googletest export 2020-02-07 absl-team Googletest export 2020-02-06 durandal Googletest export 2020-02-05 absl-team Googletest export 2020-02-05 absl-team Googletest export 2020-02-03 absl-team Googletest export 2020-02-03 absl-team Googletest export 2020-01-31 absl-team Googletest export 2020-01-31 absl-team Googletest export 2020-01-29 absl-team Googletest export 2020-01-27 absl-team Googletest export 2020-01-27 absl-team Googletest export 2020-01-27 absl-team Googletest export 2020-01-24 absl-team Googletest export 2020-01-24 absl-team Googletest export 2020-01-23 absl-team Googletest export 2020-01-29 krystian.kuzniarek remove a dead reference to the Autotools script 2019-11-11 krystian.kuzniarek add documentation for the premature-exit-file protocol Created with: roll-dep src/third_party/googletest/src Change-Id: I61d40d4c3ac7ff0a6dc8f5b04c9b91538c1bebbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146238 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 1068233 Change-Id: Ie7b4dd8e6743dd963b8d94056bf71366c8633265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139438 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#758809}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/02ab3396..603aaa5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I983743d589df0db9fde2b33bc207032bd004045a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148761Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758808}
-
Jose Lopes authored
This is a once closure because it's always reset after it's run: * https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/login/screens/error_screen.cc;drc=07f9a5f113196414dbed86bb9dea110ee1c40e9f;l=199 This is part of the base::Callback migration. Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r Bug: 714018 Change-Id: I2ce577954a9d04ec66f8dcfb5f29bec82426af08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134289 Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#758807}
-
Eugene But authored
This reverts commit 0e8c98fa. Reason for revert: Download test server performance was improved, which might have fixed the test. I don't have access to iPad device and won't have for a while, so reverting to see if the test still failing/flaky. Original change's description: > Disable testSucessfullDownloadInIncognito on device. > > Bug: 1059320 > Change-Id: Ib14a8dd209e277d01b7d2769b2b7ff6da5169f7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091937 > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747837} TBR=eugenebut@chromium.org,sczs@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1059320 Change-Id: I47716dd36214b3e2204ab2a4e1400f1b246b9310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148168 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#758806}
-
Gyuyoung Kim authored
This CL migrates grid-element-bad-cast.html and its -expected.txt from fast/css-grid-layout to external/wpt/css/css-grid with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to grid-item-script-001[-ref].html to be align with existing tests. Bug: 1063749, 767015 Change-Id: Ieea0ba3fb0f712652420276c0bc5967140614b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143185Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#758805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c8408b7248c..11d03194c82f Created with: gclient setdep -r src-internal@11d03194c82f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I64cd505f70af271c00a7fb15fea747bcd888ba4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148860Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758804}
-
Vladislav Kuzkokov authored
This is required so it could be used separately from CupsPrintersProvider. Bug: 1060700 Change-Id: Ie5b6c655ca74a325bffaf02849dba6a90eb12554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127031Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#758803}
-
Nazerke authored
This Cl removes unused headers for TabModel use and cleans the gn files. Bug: 1045575, 1050138, 1049845 Change-Id: I05dd5a083d15f70642a49541f2b80bc238db18dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144967Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#758802}
-
Roman Sorokin authored
Bug: 1067260 Change-Id: Ic769be285484a47ec6cbb11cd20622b413ff84f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144174Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8a948a3e2b43..2d2c2947fd50 git log 8a948a3e2b43..2d2c2947fd50 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 mbonadei@webrtc.org Remove OpenSSLAdapter restartable_ data member. Created with: gclient setdep -r src/third_party/webrtc@2d2c2947fd50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I57f9bad76f651ade8361e4a82d4648165120839e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148861Reviewed-by:
-
Aya ElAttar authored
Changed OSSettings to be only disabled by SystemFeaturesDisableList policy as a lot of domains use ExtensionsWhiteList policy and OsSettings isn't whitelisted. Bug: 1068558 Change-Id: I6055f625993b842d2b129d2f65cad6ef344dfbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144041 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758799}
-
Yuki Yamada authored
Migrates BeginFrameProvider to use HeapMojoReceiver/HeapMojoRemote to reduce potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iecd9a91da7a8cc2fb741645da8bc22fe8d477a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145746Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758798}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@chromium.org Change-Id: Ia09f38dfa050611dc0204b00c7d43fc911c30420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145833 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Jinsuk Kim authored
chrome/browser/tab:java is a new build target that modularizes Tab interface for the rest of the chrome for Android code. The target consists of following classes with plans to include more from tab/ package: - EmptyTabObserver.java - Tab.java - TabAttributeKeys.java - TabAttributes.java - TabCreationState.java - TabHidingType.java - TabLaunchType.java - TabLifecycle.java - TabObserver.java - TabSelectionType.java Bug: 995903 Change-Id: Id188c99b9e92195ce834ef7f5dc6d330d918c477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102998 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#758796}
-
Antonio Gomes authored
CL migrates clip-path-reference-nonexisting-existing-local.html to external/wpt/css/css-masking/clip-path/, adding links to the relevant specs and a test assertion describing its purpose. BUG=1063749 R=fs@opera.com Change-Id: Ic31f186879f7b37f9df9b49bfac891749d001d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144235Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/711867566999..20220a0b0640 git log 711867566999..20220a0b0640 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 capn@google.com Reuse Store logic for Modf and Frexp output parameters 2020-04-14 capn@google.com Separate Operand store logic from EmitStore() 2020-04-14 capn@google.com Only store component count in Operand 2020-04-14 capn@google.com Rename size/sizeInComponents to componentCount Created with: gclient setdep -r src/third_party/swiftshader@20220a0b0640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic82e6573c590e1516eb2bd3c71de496b9a69496f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148720Reviewed-by:
-
https://crbug.com/1064676arthursonzogni authored
This bug has been fortunately/unexpectedly fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2111170 The old code was trying to "guess" the document was the initial empty document. It failed. The new code is using CreateCSPForInitialEmptyDocument() to set the CSP of the initial empty document. It works consistently. Bug: 1064676 Change-Id: I3778b7a2a0e4eed0599424e3711cbaec24c80c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144012 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#758793}
-
Anqing Zhao authored
According to the request in https://crbug.com/1052664, the os version should be changed to M83 because M82 is skipped. BYPASS_POLICY_COMPATIBILITY_CHECK=Demanded in the launch review Bug: 1040078 Change-Id: I9d29dc60df4d7cd6f3fa5efbf5ba48d3c89a04de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148313Reviewed-by:
-
Ewann authored
This CL creates the Cookies view controller & coordinator and adds Cookies to the Privacy screen. 4 options have also been added to the Privacy view controller. Bug: 1064961 Change-Id: I48534388d195f15ae199d63ef995668f0b43125b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129708 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, migrate this test from being a testRunner-based reftest with plain text expectation into a testharness.js-based test that uses check-layout-th.js instead of the utils from the Chromium-specific check-layout.js file, and drop the expectations file. Bug: 767015, 1063749 Change-Id: I3a056716ec99f979b9171aaa2a1e053f9f782e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144188 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#758790}
-
Alex Ilin authored
This CL enables Mirror for the extension consent flow: - Makes the account settings dialog appear during the consent flow when Gaia passes a Mirror response header. This allows the user to modify the list of accounts on their device. - Keeps the consent flow window opened when it happens. In the case the user don't want to modify their accounts, they could go back to the consent flow. Bug: 1026237 Change-Id: I3cdd8bb868e7ec8b80f9cd59f45aee2d06616b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144200Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758789}
-
Leszek Swirski authored
This feature has enabled by default for a couple of releases, so the feature flag for it can be removed. Bug: 945321 Change-Id: Ifed3760a46e82e0ead9d3cfc37c5e58d86beafb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134298 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#758788}
-
Marc Treib authored
This CL adds some unit tests for MultiStorePasswordSaveManager which cover saves/updates to both stores at the same time. Bug: 1060524 Change-Id: I7170b18fa313facb4203f3131e0eba1b2639a1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141593 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#758787}
-
Rune Lillesveen authored
Bug: 1069300 Change-Id: I3e1281857c54d6b21cebc5a6c58f7c114069247d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148775Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758786}
-
Zhenyao Mo authored
This triggers compile warnings for projects with -Wextra-semi-stmt. BUG=1064305 TEST=bots compile R=dcheng@chromium.org Change-Id: Ic9ae72dc4a04f410c8768614e2f6b2558ea52e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148250 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This allows subscript access into model identifiers, both direct (e.g., "my_identifier[0]" as well as indirect, e.g., "my_identifier[index]", where |index| is a model identifier that points to a single integer. This can be nested arbitrarily deeply, i.e., "a[b[c[d[...]]]]". Note that subscript access into UTF-8 model identifiers is NOT supported. Specifically, identifiers must match a regular expression \w+ for subscript support. Bug: b/145043394 Change-Id: I03ca5c2d2c11a8c9c014a8cb3ad1768b7c13a62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139725 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#758784}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/834c6893..02ab3396 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I210f9949335f395edd16cda9cd017f9407937e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144222Reviewed-by:
-
Yuki Shiino authored
[CachedAccessor] was used only for supporting fast access to window.document in the main world. This patch extends its support to fast access to 'window', 'self', and 'frames' IDL attributes of Window interface even after window detach- ment in case of the new bindings generator (no change for the current bindings generator). In the new bindings generator, all attributes, including cross origin attributes, will be implemented as accessor properties, so the old 'lazy data property' will no longer work. 'window', 'self', and 'frames' need to be implemented with the same technique as 'document', i.e. 'cached accessor'. This patch doesn't change any user visible behavior. [CachedAccessor] on 'window', 'self', and 'frames' attributes have currently no effect because these attributes are not accessor properties. Bug: 839389 Change-Id: Id6ffa965304627f2b9ad4488d090dc62e71077d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147753 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#758782}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, migrate this test from being a testRunner-based reftest with plain text expectation into a testharness.js-based test that uses check-layout-th.js instead of the utils from the Chromium-specific check-layout.js file, and drop the expectations file. Bug: 767015, 1063749 Change-Id: I4291bedea5a83fcc9012ba7c0707238f93a6b052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144187 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I4f034c6f54893086074b200deb6c656d52b570e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147521Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dee4d7a54e44..965eedbfbf1e git log dee4d7a54e44..965eedbfbf1e --date=short --first-parent --format='%ad %ae %s' 2020-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 019f4e38eb79..f89de66a9bcb (7 commits) Created with: gclient setdep -r src/third_party/angle@965eedbfbf1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I02ffdcfe110606618007df7f4911f171376d0b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148717Reviewed-by:
-
