- 27 May, 2020 40 commits
-
-
Guido Urdaneta authored
Fixed: 1084128,1075631 Change-Id: I70a29dc9bd5b3a5fe9c6d1981d1a14e805417ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216072Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#772131}
-
Hitoshi Yoshida authored
WebSocketStreamOptions.signal is a non-nullable dictionary member. This CL fixes the way to check if it is missing; makes to call hasSignal() instead of checking a nullptr. This is a preparation for the new code generator, with which the original code would crash. Bug: 839389 Change-Id: I5d43009f4998b00bc4705a912148382fbf2902a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214739 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772130}
-
Ian Kilpatrick authored
The old code was also looking at sticky positioned offsets, but it looks like position: sticky is generally broken with split inlines so couldn't trigger a reliable bug. Change-Id: I82bf9c0b5cdbfb316ca095e7acb574737c63678d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215367 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772129}
-
Gang Wu authored
Add thumbnail for clipboard image suggestion behind the flag. Bug: 1055925 Change-Id: I8cbf77725cc11fc0853ba801766e9b61acb5c048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204083 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772128}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaf8ee33c59a6edb0d6d3974e3cec972d8bd9cf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212104Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=ksakamoto@chromium.org Bug: 1026641 Change-Id: I7f14fa5fdc132e2d0760a7013147e69af3e5275f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217206 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772126}
-
Kent Tamura authored
They are used only in ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: Ia07346ed04b4cb0a70608dd1eaa10a41ca923cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215544 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772125}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94b3d7589061..dfd24879a942 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tasak@google.com Change-Id: Ia7dac10192c358209616d3a9f48cb203543e1c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217069Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772124}
-
Timothy Loh authored
This CL simplified the process of adding new steps to PluginVmInstaller by reducing the number of things that need to be written/changed. - Simplify PluginVmInstaller::Observer interface by replacing separate functions for stage completion to a single OnStateUpdated function. - Simplify PluginVmInstaller unit test so new stages don't require all existing tests to be updated. - Add PluginVmInstaller::download_image_for_testing_ so this can be set up front in tests instead of needing to be injected in the middle of the flow. This lets us more easily stop the installer at a chosen step. Bug: 1063748 Change-Id: I7a948942dc51d911da63c5b4206cad0ffcb90e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214586 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#772123}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd9745eee98f..3f479f3da7f8 2020-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 31c9c6949e02 to bdc05c3d5fef (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I253385fa8c48b0cb379dd530452344d9a9d0795a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772122}
-
Connor Moody authored
Bug:1080703 Currently, web app subsystems in BMO mode are not notified of profile deletion because AppRegistrar::NotifyWebAppProfileWillBeDeleted is never called on WebAppRegistrar. In contrast, NotifyWebAppProfileWillBeDeleted is properly called on BookmarkAppRegistrar during profile deletion through the following call stack: BookmarkAppRegistrar::NotifyWebAppProfileWillBeDeleted BookmarkAppRegistrar::OnExtensionUnloaded ExtensionRegistry::TriggerOnUnloaded ExtensionRegistrar::DeactivateExtension ExtensionRegistrar::RemoveExtension ExtensionService::UnloadExtension ExtensionService::OnProfileMarkedForPermanentDeletion This CL makes WebAppRegistrar observe profile deletion through the ProfileManagerObserver interface and call NotifyWebAppProfileWillBeDeleted accordingly. NOTE: An alternate implementation that consolidated ProfileManagerObserver subscription into AppRegistrar (base class) was also explored. However, because ExtensionRegistry (the backend storage for BookmarkAppRegistrar) is also a ProfileManagerObsever, ExtensionRegistry may be notified of profile deletion first and clean up its internal app state before AppRegistrar handles profile deletion and queries installed apps. BookmarkAppRegistrar and ExtensionService cannot both be ProfileManagerObservers that interact with one another during profile deletion. Change-Id: Ic2244e10a3e1d7cc1b0f76ccb18cd1a397d06fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191112Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Connor Moody <connor.moody@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772121}
-
Dominick Ng authored
Call TestWebAppProvider::Start() in the tests to stop the App Service waiting for web apps to be published. BUG=1082887 Change-Id: Iaac9d8c2357dc74c12e30942a68a5d5a02d532ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215159Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#772120}
-
Timothy Loh authored
This CL makes PluginVmInstallerView re-use from PluginVmInstaller the enum indicating installer progress. This somewhat reduces the code that needs to be written when adding new steps in the installation flow, but more importantly allows a subsequent CL, crrev.com/c/2214586, to simplify the installer's observer interface so the UI will only need to be concerned with what to display to the user for a given state. Bug: 1063748 Change-Id: I5ce64bb7d641f221af822d4737e35fb21de8d589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213651Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590522742-0a47a4b988135fc20c9cc7cd17fdfcf6ba51301c.profdata to chrome-mac-master-1590551922-893b4e02197be5d53e80dcc9648783993fdfcda3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I51b08f7fd74a8a0347ddcff6bfdabc4dc722e43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217318Reviewed-by:
-
My Nguyen authored
Following https://crrev.com/c/2154639, add API to input.ime. API Reviewed in https://crbug.com/1075855. This API helps show/hide a type of input assistive window and listen to events sent by buttons in the window. Bug: 1068807 Change-Id: I7df33223f8a4be8744518603dca96fb44b8e2874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166227 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#772117}
-
David Staessens authored
This CL updates the video_decoder_(perf_)tests usage documentation with the additional "--use_vd_vda" parameter that was added recently. BUG=None TEST=checked doc in gitiles Change-Id: I175ba21fe3563d092409a3202c7257dae90d520a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215394Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#772116}
-
Sangwoo Ko authored
We were depending on view_->GetWidget() to see if the view is removed from a widget or not. But in ViewObserver::OnViewRemovedFromWidget(), GetWidget() may return valud widget. It's because View's parent pointer is still valid at this point. Please see GetWidget() implementation. So explicitly clear animation runner without checking GetWidget(). note: tried invalidating parent pointer before the propagation, but caused crash. it seems some classes are using GetWidget() in the OnViewRemovedFromWidget(). Bug: 1082633 Change-Id: I607f1845002398fa24311dcf697f52f19f25aa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212109 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772115}
-
Ramin Halavati authored
Change-Id: I63a9b2f8fc276dfc6ad8e605f952aeafa96fd75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213521 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#772114}
-
Hesen Zhang authored
Bug: 1086675 Change-Id: I80f71de863c3a6db40d9c7459356d5ef0184c4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213899Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#772113}
-
Ramin Halavati authored
Profile::IsIncognitoProfile() currently returns true for incognito profiles and also other non-Guest OTR profiles. This behavior is updated so that it only returns true for incognito profiles. Bug: 1033903, 1074201 Change-Id: Ic2ce57b85a92534f0f6582c5c718b2947a899ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124249Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#772112}
-
Matt Menke authored
It's not actually being used anywhere. Bug: None Change-Id: Id11dddbbc99d78de841a2faafe2473adbbee197d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216284Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#772111}
-
Darren Shen authored
They used to be separate because Base acted as a base class for all platforms, but we've since removed support for the other platforms [1]. Also remove some non-ChromeOS code from the class since it's dead code. Follow up CLs will combine InputMethodEngineBase with InputMethodEngine. [1] https://crrev.com/c/2198861 Bug: 1083803 Change-Id: Ia49ac04c161df37a42ed5e9bd5ac41b052b453b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212194Reviewed-by:
-
danielng authored
Refactoring crostini port forwarding tests to be more readable and more easily editable in the futre. Also adding new tests to cover interface switching. Tests: Running the implemented tests Bug: 848127 Change-Id: I26fdbb65c92c2e9ea161fe20738644e12965fd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214804Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#772109}
-
Trent Apted authored
The NativeFileSystem API currently only supports "real" files, backed by inodes. Attempting to open a non-native file results it it not being found because there are no attempts to "uncrack" virtual file paths. This CL causes file_manager::file_tasks::FindWebTasks() to early-exit if any entries in the file selection are non-native files. A testing chrome app is included that uses the file system provider API as a basis for providing files that can be used for end-to-end testing. Bug: 1079065 Change-Id: I5ed5649eb85dcfb25cdfd4965770ae39c3c56dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213652 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#772108}
-
Peter Kasting authored
This relands http://crrev.com/771122 with compile fixes. It's safe for the Widget to own the underlying View via SetContentsView(). This was not immediately obvious; much of this CL is adjacent refactoring and cleanup that simplifies the ownership/lifetime. Bug: 1044687 Change-Id: I49820e70df1387cfde6998de6ab67e119b5a451a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213227 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772107}
-
Juan Pablo de Lima authored
Bug: 1084325 Change-Id: I151b5ca66e420dae91feaff8e47f56aaffe4d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207923Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Cr-Commit-Position: refs/heads/master@{#772106}
-
Gabriel Charette authored
This a rerun of the same script as in https://chromium-review.googlesource.com/c/chromium/src/+/2026350 on r771943 this time. TBR=fdoray@chromium.org Bug: 1026641 Change-Id: I9d32d1262b0f0e1eaa771358cb77d837c3d3467f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217115Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772105}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9dac86c9c458..5b4c627389a6 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6ff146b0bfce to 424cdd54fe80 (12 revisions) 2020-05-27 geofflang@chromium.org Don't allow glReadPixels of depth buffers with ES3.1. 2020-05-26 sunnyps@chromium.org Use surface texture offset for clears and blits If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I5790febf21cb162059162fbf219852057a2c9dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217076Reviewed-by:
-
Ionel Popescu authored
Prior to http://crrev.com/c/2138156, the outline-offset was ignored when drawing the focus ring. Unlike normal outlines (whole width is outside of the offset), focus rings are drawn with the center of the path aligned with the offset, so only a part of the ouline is outside of the offset. This CL updates the behavior of NeedsDecorationOutlineLayer to consider the part of the outline drawn inside. Added textarea-with-scrollbar.html to validate the change. Bug: 1084997 Change-Id: I50949194c0a2f413d7a3c508509339dac63cfbb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216705Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772103}
-
Lepton Wu authored
This reverts commit 7a8d0e7d. Reason for revert: DT tree CL landed and we don't need this now. Original change's description: > arcvm: Add /factory as /dev/vdc > > BUG=b:155128030 > TEST=try > > Change-Id: Ic03e43b2ba8af5453f376417e5312b76c14274e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203274 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Long Cheng <lgcheng@google.com> > Cr-Commit-Position: refs/heads/master@{#769632} TBR=yusukes@chromium.org,lgcheng@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:155128030 Change-Id: If4555182a1e1fdb21801d05435ebbec7df9b3c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213898Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Lepton Wu <lepton@chromium.org> Cr-Commit-Position: refs/heads/master@{#772102}
-
Takashi Sakamoto authored
[Sheriff] Disable MediaHistoryBrowserTest.DoNotRecordWatchtime_Background/0 and DoNotRecordWatchtime_Muted/0 flaky on 6 builders. The builders are linux-chromeos-dbg, Mac ASan 64 Tests (1), Linux ChromiumOS MSan Tests, Win7 Tests (dbg)(1), Linux Tests (dbg)(1), and Linux CFI. Bug: 1086794 Change-Id: If0b9d37b3d4662880916f26b8acfc5612200e075 Tbr: beccahughes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216098 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#772101}
-
Yoshifumi Inoue authored
This patch changes "modify-up-on-rtl-wrapping-text.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I0306f6f80da87804a739398f3e9201d3ced1c2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215542 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "extend-to-line-boundary.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I3c31e572b3f4ba3e2eb5a72e62857c054b4a56b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214738 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772099}
-
Takashi Sakamoto authored
Bug: 1083585 Change-Id: I5660fbc7cf8ce917013eabd6c2c8d66385baa7f5 Tbr: danakj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216137Reviewed-by:
-
Hsin-Yu Chao authored
For M84. Launch bug: http://crbug.com/1062024 Bug: b/150951008 Change-Id: I9943a5295282f028ec19886a0d758cba37a7a879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214653Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772097}
-
David Stevens authored
A surface can be submitted to the compositor without a corresponding call to its commit method if it is a subsurface and some other surface in the hierarchy changes. When this happens, the surface hasn't changed since the last frame, so there is no damage on the surface. To prevent sending stale damage rects when this happens, clear surface damage when sending each frame. TEST=SurfaceTest.SubsurfaceDamageAggregation TEST=Run ARC++ YouTube app, observe no graphics corruption BUG=b:155369189, 1082084 Change-Id: Iea935e0252674b112d1a1e511aab71a530266874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198527 Commit-Queue: David Stevens <stevensd@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#772096}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64391c4a55c7..fd9745eee98f 2020-05-27 reed@google.com SkDrawLooper has not been supported by Skia for a while. Update dox and remove examples If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I7076d63fb828b39989e9e4308e2a82a39311de35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217078Reviewed-by:
-
tby authored
This is a follow-up to crrev.com/c/2086360, which added a custom version of launcher file icons for use in the suggestion chips. That CL only added 2x PNGs. This CL updates the icons to GM2, and adds 1x versions also. We're expecting to move these to SVG next. Bug: 1081586 Change-Id: Ic6e6fbce6fb0b32c47b36d79781e70ae9cddbade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216830Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#772094}
-
Hsin-Yu Chao authored
Bug: b/156333981 Change-Id: Ieec9421a98119684f3ad901b16c1ad8dbe8998ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196082Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772093}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aef138255c4c..94b3d7589061 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069072,chromium:1073232,chromium:1085525 Tbr: tasak@google.com Change-Id: Id06ca384c77a125f4f1ee1c1adca6e7e7f20c6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217077Reviewed-by:
-
