- 16 Dec, 2020 40 commits
-
-
Nohemi Fernandez authored
Bug: 1043080 Change-Id: I436610d9e21d34968fb10a05e30a186181355712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593616 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#837530}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/67a17949745b..cd5020ceeec9 2020-12-16 wolfi@chromium.org Rename LiveLocation's isBlackboxed() to isIgnoreListed() 2020-12-16 wolfi@chromium.org Rename class BlackboxManager to IgnoreListManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152082 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36a96cb7990a70752ec18954ad861cd1c50ff5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837529}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/fbdff6f3ae..68f1ad9325 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/fbdff6f3ae..68f1ad9325 Bug: None Change-Id: I3b563f234a8d3951cd314635746e8b22e522f830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593006Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837528}
-
Mihai Sardarescu authored
This CLs extends flags account-id-migration and use-multilogin-endpoint until M92 as they are still not fully rolled out. Bug: None Change-Id: If2d0a2b4fa5fc0f32930eff1ea0267862a924456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593104 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#837527}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607859899-3af4835f8191253724015cbe66471290f6d68a04.profdata to chrome-win32-master-1608087498-7951485823b3a2725f3c6d796de85103e94919f6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2affaf32d74326cdbb1a64c7db7ef8eaacf9d67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594561Reviewed-by:
-
Richard Stotz authored
This CL moves parts of NativeIO to the IO thread to simplify interaction with the QuotaClient which must live on the IO thread. * Rename NativeIOContext to NativeIOManager. The NativeIOManager lives on the IO thread (see next point) * Create a new NativeIOContext to straddle the UI and IO thread. * Replace the deprecated DISALLOW_COPY_AND_ASSIGN() macro with deleted copy constructor and assignment operator in native_io_manager_browsertest.cc No functional changes are introduced. Bug: 1137788 Change-Id: I507e11f17eefb56524ef82121d14118afc0edbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588910 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837525}
-
Pavol Marko authored
This file should have been removed in CL:2513592 but was forgotten. Bug: 832127 Change-Id: Idfe231a200fc564d3744549f6d58e836966e078b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593003 Auto-Submit: Pavol Marko <pmarko@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#837524}
-
Jason Lin authored
Bug: b/167491603 Change-Id: I1dd3f252f2f6919bb8f6dd2032825a969d79546b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591647Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#837523}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c29aca88aeb5..cec10df94078 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jdoerrie@google.com Change-Id: I9bb46bfd304d12eb5ae53d203cb87abf6c9e5d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594296Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837522}
-
Jana Grill authored
Replace references to domain with manager in TermsOfServiceScreen. Additionally adjust IDS_TERMS_OF_SERVICE_SCREEN_HEADING and IDS_TERMS_OF_SERVICE_SCREEN_SUBHEADING to support FlexOrgs by adjusting the domain placeholder names and descriptions as well as adding screenshots to make it easier for the translators to understand the usage of the texts. Finally replace a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager. Bug: b:172684210 Test: Manual Change-Id: I5acd16c1fa1638fbd6715f355a77ceca21f02bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593120Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837521}
-
Jasmine Chen authored
Authenticates all CameraHalClient's and disable CameraHalDispather::RegisterClient(). Now that we finish migrating CameraHalServer and CameraHalClient registration, we have a stabilized interface and behavior for TokenManager. Here we add token_manager_unittest and a series of unittests to make sure things work as expected. Bug: b/170075468 Test: Verify that all CameraHalClient's are correctly recognized and authenticated. \ (hatch-arc-r) $ capture_unittests --gtest_filter='*TokenManager*' \ capture_unittests --gtest_filter='*Dispatcher*' Change-Id: I701cc4de99b34a1599c36b57d63a5a2429d6ef9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576228Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#837520}
-
Jérôme Lebel authored
the UserSigninViewController mock setup was too strict. On iOS 12, -[UserSigninViewController presentationController] is not called. This change is not relevant UserSigninCoordinatorTest tests. Change-Id: Ie7a1eaf8210d18492dc7a326f88cf848c1534fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593124 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837519}
-
Shik Chen authored
This CL adds a new barcode detection toggle button and removes the old item in expert mode menu. Bug: b/172879638 Test: Manually Change-Id: Ia89657f5d3d2900b53721f650058240e472b254b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594827Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/a3edbfa983ba..f6be92767d1d 2020-12-16 chris.liddell@artifex.com [truetype] Fix incremental metrics (#59503). 2020-12-16 apodtele@gmail.com Documentation edits. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ie1f116b6c77a413e5698e97a589a10a9eac89371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594560Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#837517}
-
rajendrant authored
Bug: 1147753 Change-Id: Ifee76ed84a963669c8fcecc57471e59df0adf0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582958 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#837516}
-
Martin Šrámek authored
This project is temporarily deprioritized. Bug: None Change-Id: Ieb9a49d861e38e787dc0adcedccf8bbe8b5b0601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593610 Auto-Submit: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837515}
-
Fredrik Söderqvist authored
This function is similar in spirit to the other functions in this class. Tangentially it also shows the variation of techniques for achieving the same thing (slicing - or not - border/background/mask/...). Bug: 1005048 Change-Id: Idd58d1f7b822d65132de6cdd54caae5204c8fb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593094 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837514}
-
Fredrik Söderqvist authored
We need to be able to track more properties (than just 'filter'), so adapt a mechanism similar to that for StyleImages. I.e add a set of "pending" properties that we iterate when we've finished building the ComputedStyle object. This requires plumbing the key (property id) through the converter function. Retire the |allow_external| argument to GetSVGResourceFromValue() in favor of the new property id argument, and then determine if a certain property allows external resources or not. The 'backdrop-filter' property was allowing external resources but not actually issuing loads for them. Align them with 'filter' by also loading the resource. Bug: 109212 Change-Id: Iee600907bbb2b3cd2e03e9d6cee0590cde11ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593114Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#837513}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607990340-72af9acbfb590e4fca630056e163f51242d80be6.profdata to chrome-win64-master-1608087498-2f929d29b1a1e70fb6742374bfad7f4f226a61c8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I58dfbee5ce38fae78bee44c768cb56cff2244563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594559Reviewed-by:
-
Robbie Gibson authored
This fixes a few issues: 1. Crash when deallocing the FullscreenDisabler when closing the last incognito tab. This is probably because the underlying FullscreenController has already been dealloced. 2. Before, the entire thumb strip machinery wasn't alerted to the new incognito BVC that is created when the incognito state is reset. Now, it is. 3. There was an intermittent crash when closing the app because of a zombie ViewRevealingVerticalPanHandler. It is a web view observer, but that is controlled by the ThumbStripMediator. However, when the pan handler is dealloced, the observation isn't stopped. Fixed: 1155559, 1155607 Change-Id: I1a2f6ea805cfc810bd36b5bab547fb179cacbaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593119 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837511}
-
Ewann authored
This CL updates the cell background on tools menu. Bug: 1158393 Change-Id: Ib0aee6dbb5bc34dc2f011529fbe9e5f5db1b6052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593635 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Rainhard Findling authored
Adds a banner to the top of the privacy sandbox page. Bug: 1152336 Change-Id: Ia44f468945fc1a36529185ae82a80aac465246b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593372Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837509}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I564ee79a79613e4bdea5e87977c24dd95681189e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593602Reviewed-by:
-
Antonio Sartori authored
When parsing a referrer policy from a meta tag, we were trying to update the PolicyContainer (and with it, the PolicyContainerHost in the Browser process) without checking for it not to be nullptr. However, the PolicyContainer is nullptr for LocalFrames which have no RenderFrameHost counterpart in the browser, which are used for rendering SVG images. As a consequence, there are cases in which a meta tag in an SVG image made the renderer crash. This change adds a nullptr check to fix this. Bug: 1158034, 1130587 Change-Id: Ia0b5c51b4d1d68cfd7329da8c5e153bdef7deb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593000 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#837507}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/627c1580a7ea..ba1c65b08f2d 2020-12-15 tsepez@chromium.org Remove GetXFAPageList(). 2020-12-15 vmiklos@collabora.co.uk Add FPDFAnnot_GetBorder() API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I58039195a1853477f09d49acc821322d2c14ebf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594867Reviewed-by:
-
Christopher Cameron authored
The CanvasPixelFormat should have only user-specifiable formats. At some point it ballooned to support BGRA and RGBA and RGBX. Those formats now live in CanvasResourceParams as a SkColorType. Trim down CanvasPixelFormats to just F16 and Uint8. Remove accessors that aren't used anymore. Remove CanvasColorParams::GetNativeCanvasPixelFormat. Bug: 1157747 Change-Id: I8b45326a92cd6fdfb1d7e140a3edb1b7862726b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591711 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#837505}
-
Antonio Sartori authored
Executing a javascript: URL does not commit a new document, and executing a javascript: URL in a srcdoc iframe does not change the fact that this is a srcdoc iframe. (cf https://crrev.com/c/2464930). On the other side, the algorithm for computing the referrer of a srcdoc iframe defers to the parent: https://w3c.github.io/webappsec-referrer-policy/#strip-url Bug: 1043895 Change-Id: I144aa288204f9e92d1b41b0f3c64bc0d6274f10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582045Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#837504}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ae8efc5c4e6a..67a17949745b 2020-12-16 patrick.brosset@microsoft.com Bring back expander icons for the Flex and Grid sections in Layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47020ba14b0fded35382cde1757cdc4fcd56172d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594868Reviewed-by:
-
Gauthier Ambard authored
This CL fixes the audio test when the new error page workflow is enabled. It was failing because the LoadHtml method is triggering the WebState callbacks twice, letting the delegate_ receiving empty data for the first callback. Bug: 1152364 Change-Id: I6e6a4d196e0381d7388981a4ecb5f086543396a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593092 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837502}
-
Nohemi Fernandez authored
As a follow-up to crrev.com/c/2562778, moves all sign-in utilities to the new signin namespace. Bug: 1157531 Change-Id: Ic695832a7cd5778e69039b2d3fd1395de3cde50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593259Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#837501}
-
Hwanseung Lee authored
this histogram expired since M85 branch out. so remove this historam. Bug: 1088836 Change-Id: I1b05d0773d1f8d83200ff815eb667c72c057727a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588676Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Benoit Lize authored
Bug: 998048 Change-Id: I266cdb8ff0c37f0f4e4c57673674890772f9df09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593118Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837499}
-
Alice Wang authored
This CL refactors the ViewBinders in account_picker MVC in two ways: 1/ Make all view binders implements the ViewBinder interface instead of using static class; 2/ Merge IncognitoRowViewBinder and AddAccountRowViewBinder into one reusable class. Bug: 1158373 Change-Id: I6a1f5442c52e4eb8e2115cd34c140822a494bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589934 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#837498}
-
rajendrant authored
This CL implements OAuth login flow detection - login start and successful completion. Subsequent CLs will record these login types to UKM and also add more login detection heuristics. Design doc: https://docs.google.com/document/d/1EUf4reGzB2peV60Vx2iop5rchHLEIAnE6GviwTESvt8/edit#heading=h.x3b01qdtugx8 Bug: 1149853 Change-Id: Idfe0428e4cde4c0721c72c60bfe0f38cf38c6185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575121 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Shik Chen authored
The naming is following the Google color palette. Bug: b/172879638 Test: Manually Change-Id: I99b0f350bebd60270e33b4d300cf37b23276178f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592573 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#837496}
-
Hirokazu Honda authored
crrev.com/c/2576298 rejects non-8-bit streams in VaapiVideoDecodeAccelerator. This adds the test case to its unittest for the change. The new test case confirms that VaapiVideoDecodeAccelerator rejects a vp9 profile 2 stream. Bug: b:174798524 Test: media_unittests Change-Id: Iab4a561a1df37c7df52b97cb1693fee0cdf21dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576235 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#837495}
-
Hiroki Nakagawa authored
To deflake browser tests, this CL makes NavigationWithLocation() helper ignore the result of ExecJs(). The helper is used for activating prerendered pages. Depending on timing, activation could destroy the current WebContents before ExecJs() gets a result from the frame that executed scripts. This results in execution failure even when it actually succeeded. This part will drastically be modified by the MPArch, so this CL takes the approach just to ignore it instead of fixing the timing issue. When ExecJs() actually fails, the remaining test steps should fail, so it should be safe to ignore it. Bug: 1156141 Change-Id: Ia9c72ccd161b29f9fde4481cbc3e4fae4167fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593796Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837494}
-
Luciano Pacheco authored
JS modules for - //u/f/f/b/j/mount_metrics.js - //u/f/f/b/j/mount_metrics_unittest.m.js Change metrics_base to refer to its own namespace `metricsBase` instead of `metrics`. Bug: 1133186 Change-Id: Id4929916ce3571faa9d63aed741860a1b22e052c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592576 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837493}
-
Victor Hugo Vianna Silva authored
- Make sure the non-obsolete/expired ones have at least 2 owners. - Move components/invalidations/ histograms from */others/histograms.xml to a new */invalidation/histograms.xml. - Remove code recording expired/obsolete histograms. Fixed: 1158383 Change-Id: Ie3c7ab0334b0458057e63429927c09c88e1cef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589975Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#837492}
-
Victor Hugo Vianna Silva authored
Sync.{CookieJarEmptyOnMismatch,CookieJarMatchOnNavigation} have been expired since M77. This CL marks them as obsolete and removes the associated plumbing to record them, which is considerable. Bug: 1158449 Change-Id: I03a9c48c17ba71508f96fb122b522ba03300d773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589836Reviewed-by:
-
