GitLab

Add support for [inline] autocomplete of about:blank.
The support handles fixup of the scheme separator.
Add BuiltinProviderTest.AboutBlank and do related cleanup.
Update OmniboxViewTest.UndoRedo and do related cleanup.

BUG=92577
TEST=about:blank is suggested in the omnibox; unit tests.
R=mpearson@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/290333015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274083 0039d316-1c4b-4281-b951-d872f2087c98

libtinfo is needed to build GDB on the NaCl toolchain builders.  We
previously built only i686-linux versions, but now build x86_64-linux
versions too, so we need the 64-bit version of this library package.

BUG= none
TEST= none
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/309503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274082 0039d316-1c4b-4281-b951-d872f2087c98

Currently if no response headers are passed into the plugin in OOP PDF then the
headers fetched URLLoader that loaded the stream URL will be used, but the
MIME type for the blob URL is always plain text, which causes the document
loader to refuse to load the document. Currently, if no headers are passed
to the in process plugin, we always try to load the document, so this just
mimics that behavior in the OOP plugin. When the in-process plugin is removed
we can change the document loader and remove the hack.

This also removes blob: URLs from the MIME type check in document loader
because they are no longer ever passed in.

BUG=303491

Review URL: https://codereview.chromium.org/301223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274081 0039d316-1c4b-4281-b951-d872f2087c98

For Kitkat, we can play video in immersive mode without the navigation bar.
Maybe we should do the same for other elements?

BUG=378412

Review URL: https://codereview.chromium.org/303263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274080 0039d316-1c4b-4281-b951-d872f2087c98

This is being done to remove use of a deprecated API in net/

BUG=81979

Review URL: https://codereview.chromium.org/302573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274079 0039d316-1c4b-4281-b951-d872f2087c98

browser_tests require xdisplaycheck to run, but the target does not list
xdisplaycheck as a dependency.

R=mseaborn@chromium.org, vadimsh@chromium.org
BUG=359338

Review URL: https://codereview.chromium.org/305053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274078 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/301033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274077 0039d316-1c4b-4281-b951-d872f2087c98

A changed to Textfield broke OnFocus/OnBlur behavior of PassphraseTextfield.
This provides an expedient fix until the class is deprecated completely.

BUG=378914
TBR=kevers@chromium.org, msw@chromium.org

Review URL: https://codereview.chromium.org/308933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365352
TEST=none
NOCHECK=true

Review URL: https://codereview.chromium.org/303423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274075 0039d316-1c4b-4281-b951-d872f2087c98

This allows targets that do not wish to depend on net
to use the MetricsService code.

Also, moves compression code to be in the net/ directory
of the metrics component.

BUG=375771,374295
R=isherman@chromium.org,blundell@chromium.org,davidben@chromium.org
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/291153013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274074 0039d316-1c4b-4281-b951-d872f2087c98

Gapless support for AAC is similar to MP3 but unlike
MP3 which only has padding in the first frame, AAC may
require discarding data across multiple frames.

Unfortunately this means we can't just discard the padding
frames wholesale without changing what's decoded from the
first non-padding frame.

Testing reveals we need to decode the padding frame prior to
the first non-padding frame in order to correctly decode the
non-padding frame.

We accomplish this by introducing the concept of a preroll
buffer which is to be played out prior to the current buffer
but must be entirely discarded.  Luckily this is easily done
with the infrastructure in place for the gapless MP3 playback!

While we need to support post splice buffers with preroll for
gapless playback, for simplicity, pre-splice buffers are not
allowed to have preroll.

In sum, this change:
- Adds SetPrerollBuffer() and preroll_buffer() to the
StreamParserBuffer.
- Refactors splice frame handling into a new
HandleNextBufferWithSpliceFrame() method, introduces
HandleNextBufferWithPreroll()
- Modifies the frame processor to use the frame prior to the
partial append window discard as the preroll.

BUG=371633
TEST=new unittests!
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/276573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/308513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274072 0039d316-1c4b-4281-b951-d872f2087c98

Windows has a fancy backgrounding mode which lowers IO priority.
Sadly it can only be set from within the process to be backgrounded.
So add a new ChildProcessMsg to tell child processes when they should
enter and leave background mode.

This reduces glitching during background tab load. This should only be
landed along with https://codereview.chromium.org/298253004/ which
removes backgrounding for active audio tabs.

I expect this will reduce CPU and I/O load significantly for background
processes which will lead to power savings.

This is only done on Windows since ChromeOS / Linux require privileges
only available to the browser process for setting background mode.

BUG=362294
TEST=Play audio. Load background tabs. Observe less/no glitching.
R=jam@chromium.org, luken@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/305533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/304163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274070 0039d316-1c4b-4281-b951-d872f2087c98

pushState/replaceState should always report as a GET, even if they happen in a
document that was the result of a POST.

Currently, POST->replaceState->reload sends a GET (as the spec
requires), but we incorrectly show a form resubmission warning.

BUG=239907
TEST=NavigationControllerTest.PostThenReplaceStateThenReload

Review URL: https://codereview.chromium.org/306033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274069 0039d316-1c4b-4281-b951-d872f2087c98

There are no web sites currently using this feature, but it causes
all multichannel users to waste resources unnecessarily upmixing,
generating, and transferring empty channel data.

Further this breaks fancy OSX multichannel users which have non
standard channel layouts.  Mostly because we don't want to deal
with the plethora of ways OSX wants to map channels ourselves.

Instead we can require that MSE users which want to change channel
counts, must specify the maximum number of channels in the first
initialization segment.

This also fixes use cases where clients routed multichannel streams
into WebAudio for processing instead of actual playout.

BUG=266674,379288
TEST=Only 2 channels are created for stereo sources when a 7.1
device is connected.

R=rileya@chromium.org, wolenetz@chromium.org

Review URL: https://codereview.chromium.org/304233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274068 0039d316-1c4b-4281-b951-d872f2087c98

Added a second configuration that can support two http proxies and one https proxy. In the process, added a new DataReductionProxyParams object to encapsulate static configuration details and made DataReductionSettingsAndroid a BrowserKeyedContextService.

BUG=370039

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273810

Review URL: https://codereview.chromium.org/286013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274067 0039d316-1c4b-4281-b951-d872f2087c98

LevelDB sometimes returns Status::InvalidArgument() when it encounters
corruption. But LevelDB doesn't provide a Status::IsInvalidArgument()
accessor so we need to indirectly detect it.

This patch revealed that IndexedDBDatabaseOperationTest.CreatePutDelete
had been passing by accident. In order to make it continue to pass, this
patch adds a method to IndexedDBFakeBackingStore.

BUG=322707

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273757

Review URL: https://codereview.chromium.org/303073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274066 0039d316-1c4b-4281-b951-d872f2087c98

This micro benchmark will used in a follow-up patch to generate various
kinds of invalidations (viewport, random, full layer) from the telemetry
repaint benchmark.

R=vmpstr@chromium.org
BUG=376379

Review URL: https://codereview.chromium.org/298723013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274065 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw

Review URL: https://codereview.chromium.org/269313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274064 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/)

Reason for revert:
Broke android bots it looks like:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683

Original issue's description:
> Properly prioritize the sources of an accessible name on Android.
> 
> This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation
> 
> Now Android basically matches Windows, the difference is that Android has
> to pick just one accessible name while Windows can have both a name and
> a description.
> 
> There were existing cross-platform tests; I updated the Android
> expectations.
> 
> BUG=359216
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=359216

Review URL: https://codereview.chromium.org/304293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274063 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Mojo: Specify/check alignment of pointers more carefully. (https://codereview.chromium.org/304303006/)

Reason for revert:
Broke the windows bots:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40269
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26580

Original issue's description:
> Mojo: Specify/check alignment of pointers more carefully.
> 
> Improve the verification routines especially in the case that no count
> is necessary.
> 
> Also add a test.
> 
> R=darin@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273936

TBR=darin@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/312463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274062 0039d316-1c4b-4281-b951-d872f2087c98

Introduce NewTabButtonTargeter, a derived class of 
MaskedViewTargeter, to define the custom hit-test 
region of the new tab button.

BUG=377551
TEST=none

Review URL: https://codereview.chromium.org/299353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274041 0039d316-1c4b-4281-b951-d872f2087c98

If the browser does not yet have permission to access the user's contacts, one
of the Autofill suggestions has the text "Enable Autofill using Contacts". If
the user selects that suggestion, the browser will prompt the user for access
to the user's address book.

The act of clicking the permissions dialog causes Blink to lose its focus on
the text field, which also dismisses the Autofill popup. If the user has
granted Chrome access to the address book, the autofill popup will be presented
again, and filled in.

This CL does not include the image asset, nor does it include the logic to
display the image asset on the left of the autofill entry.

BUG=139154
TEST=Run the command `tccutil reset AddressBook` to reset AddressBook
permissions for all applications. Clear the default Chromium profile:
`rm -rf ~/Library/Application\ Support/Chromium/Default/`.  Launch Chromium by
double clicking on it from Finder.  Navigate to
`https://www.mycontactform.com/samples/change_address.php`. Double click the
"First Name" field. There should not be a prompt to access your "Contacts".
There should be exactly 1 autofill entry: "Enable Autofill using Contacts...".
Clicking that autofill entry should open a system prompt that asks for Contacts
permissions for Chromium.

Review URL: https://codereview.chromium.org/286243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274038 0039d316-1c4b-4281-b951-d872f2087c98

This is designed to prevent deadlocks on the buildbots.

I couldn't figure out a way to kill them without killing the parent as well. I
also haven't looked into a Windows equivalent yet.

BUG=357059

Review URL: https://codereview.chromium.org/301313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=no functional change.

Review URL: https://codereview.chromium.org/308193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367896

Review URL: https://codereview.chromium.org/305233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274034 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274033 0039d316-1c4b-4281-b951-d872f2087c98

Use EstablishGpuChannel() with callback instead of EstablishGpuChannelSync() 
and skip and defer browser Composites until the channel is ready.

BUG=326297

Review URL: https://codereview.chromium.org/228663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274032 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174974:175159&mode=html

TBR=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/309653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375416

Review URL: https://codereview.chromium.org/305103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274030 0039d316-1c4b-4281-b951-d872f2087c98

This patch relands the final portion of r273386, which was reverted due
to issues with the gpu rasterization test. Those issues have been
separately fixed in r273755 and rXXXXXX.

BUG=368495
TBR=navabi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/304233010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369680

Review URL: https://codereview.chromium.org/307003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274028 0039d316-1c4b-4281-b951-d872f2087c98

nacl_thread.h only defines nacl_tls_get() and nacl_tls_init(), which are
not generally useful for application code.  They are only used
internally within libc/libpthread.

This is part of general cleanup to reduce Chromium-side dependencies on
NaCl headers that are not in public directories (src/include/nacl and
src/public).

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
TEST=NaCl SDK bots

Review URL: https://codereview.chromium.org/308163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274027 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for the devtools generated resources.

Still doesn't compile, but getting closer.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/304223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378849

Review URL: https://codereview.chromium.org/308063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274025 0039d316-1c4b-4281-b951-d872f2087c98

Previously if a static library depended on a source set, we'd link it in. This can easily cause multiple inclusions of the source set's code if there are multiple shared libraries that depend on it.

This patch forwards the source set up the dependency chain to the next linkable target (shared library or executable). This solves the multiple-definition problem. The downside is that if you make a static library that depends on a source set, it won't be "complete" in the sense that you can give it to somebody and it will have all of the files in it. If we need that capability, we'll add some kind of "complete" flag.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/302033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274024 0039d316-1c4b-4281-b951-d872f2087c98

When run in a component build, isolate_driver recursively descends the
dependency graph to discover implicit shared library dependencies. A
bug in the recursion caused dependencies at certain depths in the
graph to be missed.

Also changed the recursion to use a set to record newly added
dependencies to avoid adding them to the isolate multiple times.
Expanded the ignored set of suffixes slightly.

BUG=378021
TEST=GLES2 conformance tests run via isolate in component build on Mac OS
R=maruel@chromium.org,vadimsh@chromium.org,csharp@chromium.org

Review URL: https://codereview.chromium.org/304993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274023 0039d316-1c4b-4281-b951-d872f2087c98

Change some targets to source sets. These are small ones that are currently depended on by other source sets. This avoids some duplicate symbols.
duplicated.

Fix some conditions around the touch_device in ui/base.

Lots of Skia build fixes. It turns out our skia library does not use the "util" target, and some of the files in "util" reference functions that it seems are never defined in any file. This removes the ones in our list that weren't in skia_library.gypi to make accessibility_unittests link.

Update gesture recogniser file lists.

BUG=377890
TBR=scottmg

Review URL: https://codereview.chromium.org/305993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274022 0039d316-1c4b-4281-b951-d872f2087c98