- 05 Dec, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This is a follow-up CL for the review comment from [1]. HidConnectionImpl has Create method with hiding the bare call to new HidConnectionImpl. The constructor is used to access the created object from tests. This CL moves the constructor and the destructor to private and adds friend class for HidConnectionImplTest. [1] https://crrev.com/c/1941447/2/services/device/hid/hid_connection_impl.cc#48 Change-Id: Ic9ae9883ea0eb13b9616ecb477920220e370a066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947619 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#721842}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLEmbedElement> and DynamicTo<HTMLEmbedElement> as new downcast helper 2. Use IsA<HTMLEmbedElement>(element) in place of IsHTMLEmbedElement(element) Bug: 891908 Change-Id: Ib010cd9ad496f3c93aa2b85e36ffb0273d00018b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948687 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#721841}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLInputElement> and DynamicTo<HTMLInputElement> as new downcast helper 2. Use IsA<HTMLInputElement>(element) in place of IsHTMLInputElement(element) Bug: 891908 Change-Id: I631cb99e39533393c4302d1136b1ef9449f22bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948396Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Jarryd authored
New dialog gives more context about consequences of clearing data such as calling out affects on installed apps. Bug: 997258 Change-Id: I6642390f99765632e1dda7730946e68ddd0b9339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888554 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#721839}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b266398. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" a93be69b "Update reversing-an-animation test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I1bfd6552246169b153095bd81d1b4d220485a2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950975Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721838}
-
Shakti Sahu authored
This CL adds the UI for showing content indexed content. 1- Renames PrefetchViewHolder to PrefetchArticleViewHolder (and the XML files) 2- Adds separate view holders for prefetch grouped item, card header, card footer, and prefetch audio 3- Favicon will be added in a followup CL Bug: 1030924 Change-Id: Ie95f8c1340423218652964b126d9bb09ac6237cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929869 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#721837}
-
John Z Wu authored
Converting from a public method to a delegate based one so we can share the form fetching implementation with AutofillAgent. Bug: 1030451 Change-Id: I5e5c7e9ee3abac5769b79dc20d96f532a6a19d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952030 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#721836}
-
Shakti Sahu authored
This CL adds mutator changes for adding the content indexed items. The view holders will be added in a later CL. 1 - Comparator interface was changed to Sorter 2 - Prefetch tab will show a date wise sorted list which will have standalone prefetch cards and group cards for content indexing. 3 - Added CardPaginator to remember the pagination for each card 4 - Added GroupCardLabelAdder to add card header and footer 5- Introduced dividers as separate view holders to handle top, middle, and bottom dividers in a group card. Bug: 1030924 Change-Id: I033ce36344d3b7095a6b9a5e6d47e9b273121954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941041 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/989b6154e4ff..be9c8b0410e0 git log 989b6154e4ff..be9c8b0410e0 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 abennetts@google.com Add a basic “category” attribute to many JobErrors. Created with: gclient setdep -r src/third_party/catapult@be9c8b0410e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:990241 Tbr: sadrul@google.com Change-Id: I3a430870188245a0dfc98e9faee02d498059a8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721834}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/d58736db7b79..5debd13b6484 $ git log d58736db7..5debd13b6 --date=short --no-merges --format='%ad %ae %s' 2019-12-04 nharper Set quic_send_max_push_id_with_settings in some test cases 2019-12-04 vasilvv Send the path and query parameters of QuicTransport URL in the client indication. 2019-12-04 bnc Do not send QPACK Stream Cancellation instruction. 2019-12-04 rch gfe-relnote: Flag protect the new MaxPushId logic in quic_spdy_session.cc to simplify Chrome merge. This code is already protected by disabled v99, but this new --gfe2_reloadable_flag_quic_send_max_push_id_with_settings flag disables this new behavior in Chrome tests until they can be modifie. 2019-12-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_treat_queued_packets_as_sent. 2019-12-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_reject_unprocessable_packets_statelessly. 2019-12-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_populate_nonretransmittable_frames. 2019-12-04 fayang gfe-relnote: Fix an unsigned integer overflow bug in QUIC v99 when processing Ack frame. Not used in prod. Not protected. 2019-12-03 rch gfe-relnote: Move the logic for sending the MAX_PUSH_ID frame from QuicSpdyClientSessionBase to QuicSpdySession along with the other "send initial data" logic. Protected by disabled QUIC v99 flag. 2019-12-02 wub Internal QUICHE change 2019-11-27 bnc Send Stream Cancellation QPACK instruction. 2019-11-27 rch gfe-relnote: Do not flush clear coalesced packets while sending multiple connection close packets. Protected by --gfe2_reloadable_flag_quic_close_all_encryptions_levels2 2019-11-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_mtu_discovery_v2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I36ca0585cc880f2efb9087570e8ff5dd90ba910b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952183 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721833}
-
Ken Rockot authored
All the details around if/when a service instance is started and whether it's in- or out-of-process have been centralized into the implementation of a single GetAudioService() helper in Content. A few other helpers are added to ease the transition off the Service Manager, though they aren't necessarily ideal APIs. For example, client library APIs which once took a Service Manager Connector may now take a RepeatingCallback to bind a specific type of interface. In addition to GetAudioService(), Content provides helpers for AudioSystem construction and StreamFactory binding from any sequence. Because all timeout/lifetime management logic is now generically supported within Mojo and Content and requires no service implementation details to get right (and because unit tests launching service processes is no longer supported outside of Content), all Audio Service test coverage relevant to lifetime management is deemed superfluous and has been removed. Bug: 977637 Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee Tbr: oshima@chromium.org Tbr: guidou@chromium.org Tbr: vollick@chromium.org Tbr: xiaohuic@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#721832}
-
Jenny Zhang authored
kukui is the board name of krane device. This cl is needed for setting up krane demo mode. Bug:1027478 Change-Id: I469d26cb6c6dedf2f28d8e1d60e8d95cde372a07 TBR=xiyuan@chromium.org Change-Id: I469d26cb6c6dedf2f28d8e1d60e8d95cde372a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951808 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721831}
-
Manu Cornet authored
Bug: 1021698 Change-Id: I98b1e1c1e8fbc8cbdc2f959cc27fd0870d28ba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952201 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721830}
-
Kuo Jen Wei authored
While CCA will maintain which video device id of the resolution settings is opened, but the logic for judging whether the device id of opened settings still exists is broken. This CL fix this logic. Bug: 1030622 Test: Unplugged external camera while open resolution settings of built-in camera, the settings should be closed. Change-Id: I660f439221ab57b4c72f4b8cd4488d74f1a0f055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950106 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#721829}
-
Karan Bhatia authored
This CL plumbs the navigation IDs for navigation network requests through to the WebRequestInfo objects at the extensions layer. This will be used in a subsequent CL to correct the behavior of declarativeNetRequest.setActionCountAsBadgeText for main-frame requests. Navigation IDs will make it possible to correlate the network request with corresponding navigation event for that request. BUG=992251 TBR=changwan@chromium.org Change-Id: I2c11e421e6d6ad3c0dcfae7a56e117132a2793be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923611 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721828}
-
Hirokazu Honda authored
V4L2(S)VDA, V4L2SVD and V4L2VEA are available if chrome is built with USE_V4L2_CODEC. VAAPIVD, VAAPIVDA and VAAPIVEA are available if chrome is built with USE_VAAPI. If they are available, chrome always attempts to initialize and use them for video decoding and encoding. V4L2 API's hw codecs are not available in x86 boards in general. VA API's hw codecs are not available in arm boards in general. In other hands, V4L2 API and VA-API hw codecs' initialization are redundant on x86 and arm boards, respectively. The one exception is a x86 board that equips kepler, on which v4l2 hw codecs is available. Because of the above, the current status of those flags are USE_VAAPI=false, USE_V4L2_CODEC=true on CrOS ARM boards, and USE_VAAPI=true, USE_V4L2_CODEC=true on CrOS x86 boards. The current initialization step is V4L2 instances first and VAAPI ones second. In summary, the initialization flow is as follows; [ARM] V4L2 (success or failure) [x86(Intel and AMD)] V4L2 (failure all the time) -> VAAPI (success or failure) [x86+kepler] V4L2 (success for codecs supported by kepler) -> VAAPI (success or failure) This CL swaps the V4L2 and VAAPI initialization order. The initialization flow is changed as follows; [ARM] V4L2 (success or failure) [x86(Intel and AMD)] VAAPI (success), or VAAPI (failure) -> V4L2 (failure all the time) [x86+kepler] VAAPI (success), or VAAPI (failure) -> V4L2 (success for codecs supported by kepler), or VAAPI (success) -> V4L2 (failure) The redundant V4L2 instance initialization on x86 boards is omitted. Note that we will not build v4l2 code for x86 devices without kepler. See crrev.com/c/1948018 and crrev.com/c/1948378. Bug: 1030376 Test: VDA tests and VEA tests on atlas and kevin Change-Id: I7313a27ec4ccb1f1640023bf41c285c01e8e905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947872 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721827}
-
Brian Sheedy authored
Adds the --no-sandbox flag to content_browsertests on "Win10 Tets x64 (dbg)" in order to get information on the renderer process crashes that are occurring on that configuration. TBR=kbr@chromium.org Bug: 1007013 Change-Id: I16174081881712e55af248b6dbc33a62c53e2605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952097Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721826}
-
Trevor Perrier authored
This CL changes the TextView for the Lite Mode FRE and Second Run Promo to use TextViewWithClickableSpans so double tap to follow the link works in Talkback mode. Bug: 1029466 Change-Id: I624b4c94f2992c6dcf26dd872b5ed448730568d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948058Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d90f59573de9..ab60e2ade15b git log d90f59573de9..ab60e2ade15b --date=short --first-parent --format='%ad %ae %s' 2019-12-05 primiano@google.com Merge "perfetto-ui: Fix js stack overflow" Created with: gclient setdep -r src/third_party/perfetto@ab60e2ade15b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9a03f3b2bd118d474c771a3271f8132f289f6ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952080Reviewed-by:
-
Tim Judkins authored
This change adds a new pref key to represent if permission withholding is enabled on an extension and code to migrate all existing extension prefs to use the new key if it doesn't exist for an extension on startup. It also changes the logic for setting the pref on installation to only be set for extensions which can have permissions withheld from them. Bug: 984069 Change-Id: Ibbde3a7bdb0000e71f3d18f451ac9c8792714330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911479 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721823}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a0b8c5dcf189..9212599f6aac git log a0b8c5dcf189..9212599f6aac --date=short --first-parent --format='%ad %ae %s' 2019-12-04 yiwzhang@google.com [recipes] replace the variable ${platform} with resolved-platform in test output 2019-12-04 ehmaldonado@chromium.org Revert "[bot_update] Also bootstrap in the case that there are 0 pack files" 2019-12-04 iannucci@chromium.org [bot_update] Also bootstrap in the case that there are 0 pack files Created with: gclient setdep -r src/third_party/depot_tools@9212599f6aac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:875523 Tbr: agable@chromium.org Change-Id: I77c0d16e6ac98f793ba133a55e83ae3c067b18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952079Reviewed-by:
-
Hiroshi Ichikawa authored
There are still some missing parts, which I left as TODO. Change-Id: I5fbe6e6c4e84bde922fb70ee1c8099d446025b6c Bug: 1023250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906863Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#721821}
-
Akihiro Ota authored
This reverts commit bdf15246. Reason for revert: When running ChromeVox on the ChromeOS Linux emulator, an error occurs when loading ChromeVox messages. This is indicated by the following error: Unable to load message file: /usr/local/google/home/<ldap>/chromium/src/out/cros/resources/chromeos/accessibility/chromevox/_locales Then, whenever ChromeVox attempts to look up a message defined in chromevox_strings.grd, the following error is displayed: Uncaught Error: Invalid ChromeVox message id: <message_id> Bug: 1030986 Original change's description: > Support compressed .json grit files, compress chromevox msgs (Take 3) > > This provides support for type="chrome_messages_json_gzip" in > grit/build.py, which compresses the output files (which should have > .gz appended to the name, e.g. messages.json.gz). > > This makes it fairly simple to convert an extension (e.g. chromevox) > to use compressed l10n files. > > Original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1913610 > > For changes reviewed in the original CL: > TBR=agrieve@chromium.org > TBR=dtseng@chromium.org > TBR=rdevlin.cronin@chromium.org > > Bug: 1023568 > Change-Id: I7f83e5de8e339aea2e47b84f3ec701350246b38d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947386 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720779} TBR=stevenjb@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1023568 Change-Id: Id79a63a2977a1c273597195d4682661a7c5a379f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951977Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#721820}
-
Natalie Chouinard authored
Move Accessibility settings and tests to subpackage, and rename according to go/clank-preferences-refactor naming conventions. Bug: 876376, 1030446 Change-Id: Ib0cdb031cf43fb2b93de8447e2c45af4ab18936b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949534Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#721819}
-
Varun Khaneja authored
1. SafeBrowsing.CheckBrowseUrl.SafeSynchronously This metric is useful to identify how often we do not match any hash prefixes in the local blocklists for phishing, malware, social engineering, etc. If true, no local hash prefix matched; if false, one or more hash prefixes matched. 2. SafeBrowsing.RT.LocalMatch.Result This metric logs the result of checking current top frame URL being a match on the local high confidence allowlist. 3. SafeBrowsing.V4GetHash.CountOfPrefixes If SafeBrowsing.CheckBrowseUrl.SafeSynchronously is false, we may send a full hash request to Safe Browsing. This metric logs the number of hash prefixes in each of those requests. Bug: 963165 Change-Id: Iaaaecce490d2164af954582241eb34381ca0b183 Fixed: 1030629e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947829Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721818}
-
Sara Kato authored
This CL also removes unused mojom field (WHITELISTED_PACKAGE_NAME_DEPRECATED). Android side change (ag/9816677) Test: ArcAccessibilityHelperBridgeTest.* passes Bug: b/145316954 Change-Id: Ibac294eddbb45077ec4014b8b5c494599d724dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935636Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#721817}
-
Collin Baker authored
Bug: 989131 Change-Id: I0e26834422c2c4999927566ecc44528a711c3200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949672Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#721816}
-
Hesen Zhang authored
- This CL creates utils for update notification service. - Implemented and tested CalculateDeliverTime, which will be used in building notification params. Bug: 1013685 Change-Id: Ibdf465e9b1d0285c02bac8bca5ac602e2b048e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947923Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721815}
-
Alexey Baskakov authored
The code in web_apps.cc|h is inspired by the ExtensionApps class implementation. WebApps publisher doesn't support AppInstanceRegistry for now. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Next thing missing: Implement WebAppContextMenu for AppServiceAppItem. Bug: 1029221 Change-Id: I5bf2523d62b8ad990b8f7ca9017a1347903abd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941534Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#721814}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/bluetooth as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - BluetoothRemoteGATTDescriptor::Create Bug: 939691 Change-Id: I439ce17703a6a0a37ac1d690dd26c14f1cf467ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950044Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#721813}
-
Andrey Kosyakov authored
Change-Id: I0f8cd7d661ae8ca928dac8ff003760a501075d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951088Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#721812}
-
David Black authored
This CL adds UMA histograms for proactive suggestions views that are shown inline in Assistant UI. Proactive suggestions views are rendered from HTML, so we use deep links to bridge the web impression event over to the native side for UMA logging. The new histograms are: - Assistant.ProactiveSuggestions.ViewImpression - Assistant.ProactiveSuggestions.ViewImpression.ByCategory - Assistant.ProactiveSuggestions.ViewImpression.ByVeId The latter two histograms allow for in depth analysis of impression events while the former histogram is recorded for all impressions. Bug: b:144875278 Change-Id: I42cb9e784e0e495c01672177d66e872f3d66d0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947548Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/460dca5483db..69c83f87ced1 Created with: gclient setdep -r src-internal@69c83f87ced1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1027182 Tbr: jbudorick@google.com Change-Id: Icd4cbe7a3f5aeaaba5456d0edd41c55342f45a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721810}
-
Christopher Grant authored
This change should be a no-op in terms of build output, and has been tested by diffing APK/AAB output (other than a correction in Trichrome6432, a currently unused config). The change prepares to support 32-bit only Monochrome and Trichrome configs on 64-bit build configurations. The following is happening here: - Support all four version number variations. - Make any target that builds on both 32 and 64-bit explicit about it's configuration. Eg. "monochrome" on 64-bit implies a 32-bit browser, with a 64-bit Webview companion library. - Refactor logic for readability. Bug: 1027573 Change-Id: Ia37a9011717e7c2269cc9b87e817e1e9fd6ef888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940355Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#721809}
-
Dan Harrington authored
This change: - moves feed library tests into chrome/android/feed/core/javatests - adds required robolectric annotations (sdk=...) - adds test files to junit target - disables a few tests that do not yet pass - renames variables to conform to chromium style Note, https://chromium-review.googlesource.com/c/chromium/src/+/1940719 has this same change without the required variable renaming. Bug: 1024945 Change-Id: I07653ae0eaec053cbbe5823067d57ced8212d109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940725Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#721808}
-
Michael Crouse authored
This change clears all host model features from memory and from the optimization guide store when the browser history is cleared. Bug: 1001194 Change-Id: Ibf158f4128cc18c7279bea08a73fd2ac0f0b9fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951553Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#721807}
-
llin@chromium.org authored
Bug: b/144800297 Test: unittests Change-Id: I41066e4e7aaf69aea8878709bf7576d3eb923004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949732 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721806}
-
Collin Baker authored
Ideally, this IPH will show on the first close to show the user how to reopen it. The promo is incomplete and still needs visual polish. Note that this does not enable the IPH. To test it, set chrome://flags. Bug: 1028388 Change-Id: Ib37ff99ae6f3b3a531f56d9615fb06ae5a174a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949664Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1026073 Change-Id: I14ce8ac49020b797a11f9a5dfa51678c802bf293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950891 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
-
Markus Handell authored
This change adds getters for currently stored primary ID, transfer characteristics ID, matrix coefficient ID, and range ID. The change also adds a test case for making sure they don't regress. Bug: 1013590 Change-Id: I6da4d567591649e08a57e9bf8d6ed69f732bd26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950974 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721803}
-
