- 09 Nov, 2020 33 commits
-
-
Takashi Toyoshima authored
misc/link-rel-prefetch.html and css/mask-image-loading.html use the same server logging infra, network-simulator.php, and the access logs for them are sometime mixed and randomly failed due to that. This patch updates link-rel-prefetch.html not to depend on the server logs as we can verify the behavior via client side callbacks. Bug: 1140244, 1140251 Change-Id: I092e092c7c9310b815b09419a206b1517ebd21f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521975 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#825260}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfe647c02fb4..ee0ce9858cbc 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2b6b0f45ff05 to 3e17e33724b4 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I56a01f70e9b1a616452e8374c75da620128d2fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825259}
-
Hitoshi Yoshida authored
This CL refines back-send-referrer test again. https://crrev.com/c/2501881 updated the test to work with back-forward cache, but introduced strange states and it turned out not working with the latest implementation of BF cache test infrastructure. This CL cleans it up, and make it work again with BF cache. Change-Id: I28862271f540e61830e9df948bbb0b282c55e2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509641Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#825258}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bb6ca4c0c230..65040af1001b 2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I27bc2e55d0b8a8542e02792536a7840c54fdd5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524755Reviewed-by:
-
Luciano Pacheco authored
Reland of CL:2503909, I've tested locally as described in crbug.com/1144470#c3 and it's fixed. The change to fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/2519177/2..3 Add a new PAK file for resources in Files app and companion apps like Audio Player, to host the generated JS modules. Change ChromeComponentExtensionResourceManager to also load the resources from this new PAK file. This was refactored to not depend on file_manager_resource_util.h any longer, which allowed to remove this util. Rename Audio Player optimize_webu() to "build" to follow the convention. This is a preparation for converting these apps to JS modules. Bug: 1133186, 1030998, 1144470 Change-Id: Ic803e5f071cde0ac31713578a6f17e74a07c5465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519177Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825256}
-
Wei Lee authored
This CL fixes a bug that the pinned status might be lost after migrating CCA to SWA. Bug: 1144678 Test: Manually Change-Id: I9bf2fd846645a77d8b7a47cbd7b9afc043950943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516659 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#825255}
-
Luciano Pacheco authored
Add the HTML import for IronButtonState and IronControlState because these become the JS import after the conversion. These are used by the `auto_imports` in the BUILD.gn. Move the <link> tag inside the <template> because this is enforced by polymer_modulizer() this requires changing from rel="import" to normal rel="stylesheet" which in turn requires to changed the URL to request the CSS. Remove build target "closure_compile_externs" because it had empty sources and externs_list, thus not checking anything. Bug: 1133186 Change-Id: I96b7e475b7099465186f94615f2564c2548adddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520480Reviewed-by:
-
Darren Shen authored
During the handling of a key event, an IME may call SetComposition. IMF will delay the processing of SetComposition until the key event is handled. However, when a call to SetComposition("") is delayed, it is run as ClearComposition() when the key event is handled. This can cause issues because SetComposition("") has different behaviour from ClearComposition(). Specifically, SetComposition("") deletes any selected text, whereas ClearComposition doesn't. The root cause is that the code uses empty composition text to indicate that there's a pending ClearComposition. So it's impossible to distinguish between a pending SetComposition("") from a ClearComposition(). Fix this by putting the pending composition into an Optional, so that nullopt means ClearComposition and anything else is SetComposition. Bug: b/172284307 Change-Id: Iec39e8124eab6bd897d543f66f1a4bdb71b3fe78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520556Reviewed-by:Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#825253}
-
Takashi Toyoshima authored
Remove remained Blink CORS dead code from ThreadableLoader. Even after this change, we still have some duplicated code in the class. I will remove it in the next CL as it won't change visible behavior, but it changes the timing for an error detection. Let's keep this change containing only mechanical changes though some of them are still a little complicated. Bug: 1053866 Change-Id: Iaa02a6682dda02f88b6a824a4542b6dc1608129e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522277 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825252}
-
Rakina Zata Amni authored
This reverts commit a79726df. Reason for revert: This is suspected to break some network-related tests Original change's description: > Fix CertVerifierService initialization in some unittests > > The manual resetting of the CertVerifierServiceFactory in between > unit_tests seems not to work on Android. So, refactor the > initialization code to look like the Storage Service's, using > SequenceLocalStorage to reset the CertVerifierServiceFactory > between unit tests. > > Bug: 1015134, 1094483 > Change-Id: Ic13f67274cecd49450279da401fb4cd29c9b1e94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520377 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825141} TBR=jam@chromium.org,mpdenton@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015134, 1094483, 1146899 Change-Id: I4903c4c8fa157f0e47cefd32cfb679fe144d050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524812 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
This reverts commit aae065c3. Reason for revert: Need to revert a parent change (crrev.com/c/2524812) Original change's description: > Enable Cert Verifier Service by Default > > Bug: 1015134, 1094483 > Change-Id: Ie7c2c5e1c32fa7066c56241966385e1b25fcf61f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505748 > Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825181} TBR=jam@chromium.org,mpdenton@chromium.org,caitlinfischer@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015134, 1094483, 1146899 Change-Id: I5fc021f589657d471749e909b7b2449336c9db3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525465 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Nazerke authored
This CL fixed the tabStrip position in the fullscreen. Bug: 1128249,1139770 Change-Id: I56fa6f03c758f9103e55e74a0069b79103c39d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519976 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825249}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I4ec409b13fad245e50d590f3106cf58f5d4e58cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524824Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825248}
-
Jinsuk Kim authored
HomepageManager is referenced in toolbar/ for mostly its static util methods. This CL injects the method references of them instead to the classes from ToolbarManager. Bug: 1127732 Change-Id: I2b863ede270ee17ad992c88f2ce02fa23f969fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519349 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#825247}
-
Kenichi Ishibashi authored
ServiceWorkerInstalledScriptReader owns a ServiceWorkerResourceReader which can be disconnected when the Storage Service disappears. Set a disconnection handler that calls CompleteSendIfNeeded() to abort script reading gracefully. Bug: 1133143 Change-Id: I94b83798834f4287798df5e24e670309961af7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519682Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825246}
-
Kenichi Ishibashi authored
This is a workaround to handle a situation where `container_` is disconnected when CountFeature() is called. Ideally `container_` should not be disconnected during the lifetime of ServiceWorkerContainerHost. This CL is a mitigation until we figure out the root cause. Bug: 1136843 Change-Id: I666624b2142d538b60957dd594cb2c3557e42a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522719Reviewed-by:
-
Zhaoliang Ma authored
The code would previously copy SkImage data out and use libyuv to do RGB ->YUV conversion, which causes some unnecessary memory copies. This CL use Skia's YUV420 readback API instead of doing an RGB readback and a color space conversion afterwards. This is verified via a demo which do 720P/30fps UserMedia->ImageBitmap-> VideoFrame->encode->decode->render. and from chrome::tracing, the average cpu time of VideoFrame::Create is reduced from 6.462ms to2.24ms. and the package power consumption is reduced from 8.03W to 6.02W, so about 25%. The IA memory bandwidth is reduced about 29%. Bug: 1102290 Test: Manually test on atlas Change-Id: I709bef072102e9fe23e16d69a370641b969e47e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494900Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#825244}
-
Eric Willigers authored
If excessively large files, or too many files, were passed to navigator.share(), we rejected the request but also incorrectly updated state (client_ in NavigatorShare), leading to future share attempts failing with InvalidStateError "A earlier share had not yet completed." We now only set client_ when we are about to make a mojo call. Bug: 1146317 Change-Id: I8ced104d0c2486c75987847c0f23c2d632a6cc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522813 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#825243}
-
chrome://flagsAsami Doi authored
The feature CheckOfflineCapability feature has 3 states: disabled, enabled with warn-only, and enabled with enforce. This CL exposes all states of the feature to chrome://flags. Bug: 965802 Change-Id: I657ffd8032016dead0115a59fcf6f2ca14a8d301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517278 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iccffb33e4d93c985f372af3a15b1c37e4680d0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525262Reviewed-by:
-
Mason Freed authored
Attempting to reduce the memory regression seen in crbug.com/1146309. This doesn't seem like it could possibly account for that entire regression, but perhaps the story there has many iframes or something? Bug: 1146309 Change-Id: I98470080f4398abd4c79d51a0bd24283c85bd3b0 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523062 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#825240}
-
Mason Freed authored
A previous CL added an opt-in for declarative Shadow DOM, and this test needs to activate that opt in. Fixed: 1146530 Change-Id: Iefa585f0a4c83208c6aa977fc65a85ebf6fb4a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523734 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aca3d408105d..d4439824c554 2020-11-08 jmadill@chromium.org Gold Trace Tests: Fix JSON output with empty test set. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If409b56e1ba4cd1af2f68bcf630431ce015baec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524514 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I17aab5834dcc57f860ede6db1e90f84106f71a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524685Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825237}
-
Thanh Nguyen authored
Updates owner and expiry date of some historams. Bug: 1117106, 1127944, 1125829 Change-Id: Ia944875ff3f349976b02e4d9a3e5f663bad5d795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522015Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825236}
-
Austin Tankiang authored
These cause flakes during *tabindex* integration tests. Bug: 1139247 Change-Id: I56024c545e254c35ab0d20ff6009358b700c0e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520482Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#825235}
-
Mitsuru Oshima authored
I'll look into the paint issue with MirrorView separatgely, but I think this is good change anyway because it can eliminate activation animation when entering/exitting overview for performance. Bug: 1083951 Test: manual see bug for repro step. Change-Id: I02a9ed265b2ab36cf348b37937669777cfd76c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523907 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825234}
-
Mason Freed authored
This just adds a few more test cases to the existing declarative Shadow DOM opt-in test. Bug: 1042130 Change-Id: I11f20fd3115d4e508e1cf4091afafe2c10cd2382 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522874 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Jing Wang authored
(1) The mojom interface is generated with the script "chromeos/services/machine_learning/public/mojom/roll_mojoms.sh" from https://https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2497369 (2) An implementation and fake implementation are also added for unit_tests. Bug: 1132699 TEST: unit tests passed. Change-Id: Ib80675eace10b0abf331518fe61b9d63506ade17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521973 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825232}
-
Hiroki Sato authored
In a fullscreen (user immersive) mode, the shelf visibility state is SHELF_HIDDEN, and the client expects the state to be mapped into auto hide. Bug: b:172022584 Test: manual. follow the step in the bug, shelf is correctly handled on fullscreen. Change-Id: Ic492638b1a0391d2641941bd37c2bf8eac36c99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509310Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#825231}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e9d0a99d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I668527d7ada07c6f11d8cb3b01e8be98b0e26b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524962Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825230}
-
Nicholas Hollingum authored
These utilities will be used as the basis of the structured state refactoring. I'm committing them now so we can partially re-work what we have and benefit from them earlier. Bug: b/172178036 Change-Id: I812c32ba90eb6e5a5c3538ed7aea492b4d49872e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519181Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#825229}
-
Nicholas Hollingum authored
This test ensures that control returns to the task *before it is deleted* on completion, which tasks expect in order to be able to clean up. Bug: b/172605172 Change-Id: I159cb2e78f3b368128b1540cd672503b8e9c404b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521878 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
- 08 Nov, 2020 7 commits
-
-
Abigail Klein authored
Make the MediaDialogView observer the SODAInstaller and update the live_caption_title with a download message as SODA installs. Bug: 1055150 Change-Id: I54317158bf6678c98ba823490157e510c2fd3d10 AX-Relnotes: N/A (feature has not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495922 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#825227}
-
Joel Hockey authored
Change-Id: Iea3c4f398da33308841d04ed95371d2f09a8e38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519548 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#825226}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/5aSyRE6sYFfgSxo Bug: 889763 Change-Id: Ib3f2f411824e2055c340d039b311720c1e91b015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517228 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825225}
-
Jinsuk Kim authored
The search box scroll listener needs updating whenever search engine provider changes. It was prevented by a small optimization introduced in https://crrev.com/c/2500389 which updates the listener only when there's a new visible NTP. This CL fixes the bug by removing the line added in the culprit CL. Bug: 1145981 Change-Id: I674d82546e5bf9f2067cf26f3413c57bf8dc35b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521977Reviewed-by:
-
Jason Lin authored
`chrome.test.callbackPass()` call `chrome.test.succeed()` automatically, so `settingsTest()` was actually calling `succeed()` twice. Also, calling `callbackPass()` inside a callback function seems to be a bad idea. For example, the test could succeed prematurely if the callback is not called in time. Change-Id: I6d46337db933e515551a1c172ad072ac92abe9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522715 Auto-Submit: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#825223}
-
Abigail Klein authored
ChromeOS and non-ChromeOS installations. Introduce a new SODAInstaller which is responsible for installing SODA (Speech On-Device API). It has a separate implementations in ChromeOS and non-ChromeOS. The SODAInstallerImpl on ChromeOS installs SODA with the DlcserviceClient. The SODAInstallerImpl on non-ChromeOS installs SODA with the ComponentUpdaterService. Each sends installation progress updates to its observers. The SODAInstaller has a single instance, because SODA is only downloaded once for the entire device. The CaptionController initiates the SODA download by calling the InstallSODA method of the SODAInstaller. It initiates language downloads by calling InstallLanguage. The CaptionsHandler is a SODAInstallerObserver. It sends SODA download updates to the captions subpage WebUI in settings. Since the SODAInstallerObserver is a common interface between the ChromeOS and non-ChromeOS implementations, there now only needs to be one CaptionsHandler. More SODAInstallerObservers will be introduced in upcoming CLs. For more information, see this design doc: https://docs.google.com/document/d/1e9ie7WequR4UafYq72-wpXwFj0-lLWMvjXZP5jXXpwU/edit# Bug: 1055150, 1111002 Change-Id: Ia82285a1dc1440229d7912bb07ae522abde9900b AX-Relnotes: N/A (feature not yet launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473744 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#825222}
-
Nohemi Fernandez authored
Open the Settings UI to manage on device accounts when user clicks on 'Settings' button from the infobar. Bug: 1145592 Change-Id: I6cf2021b09f920a0de84674b202ffc89bba3d664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521815 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#825221}
-
