- 02 Dec, 2017 40 commits
-
-
Nate Chapin authored
It had a custom implementation to support use of RawResourceClientStateChecker. Separate these. Bug: 790778, 640291 Change-Id: Id8a29a5ad916429969b47a0258675437de284b55 Reviewed-on: https://chromium-review.googlesource.com/802094 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521177}
-
Peiyong Lin authored
PageSignalReceiver delivers signals to all PageSignalObserver with WebContents, which may not be managed by the client. This patch ignores those WebContents that are not managed by TabManager. BUG=789084 Change-Id: Ia697a5c6ef734c5cf3e3042caa4c81d1d4932f77 Reviewed-on: https://chromium-review.googlesource.com/804821 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521176}
-
Steven Bennetts authored
This CL: * Prevents updating the 'Enable SIM card locking' toggle while a SIM dialog is visible (e.g. when a network update arrives). * Debounces toggle state update. Bug: 784805 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6780330af0675ca09ac61dca67e72e0a40e582bb Reviewed-on: https://chromium-review.googlesource.com/803629 Commit-Queue: Ben Chan <benchan@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521175}
-
David Reveman authored
This fixes a regression introduced by crrev.com/d4e5fdd3. 'image-activate' needs to fire when selected item is of type OLD. Test: captured image is activated when selected Bug: 786887 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ef20f00ef8581721463be33b667456a955e0b6d Reviewed-on: https://chromium-review.googlesource.com/804834Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521174}
-
Robert Ma authored
which is a more logical and intuitive place than Rebaseline. Besides, we add support for removing redundant all-PASS testharness.js baselines that are not at the root. This may happen when a platfrom result becomes all-PASS, when its fallback platforms are already all-PASS, in which case we only download a new all-PASS baseline to the platform. The previous optimization only looked at the root. Bug: 768525 Change-Id: Icf4fa98850f5a72541a20d54217a64daef8cb389 Reviewed-on: https://chromium-review.googlesource.com/803795 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#521173}
-
Jacob Dufault authored
This allows a consumer to call SetAccessibleName multiple times and have the new name be reflected in ChromeVox. Bug: 719015 Change-Id: If355c3988907f67f336255a9b146e742e44bf9e2 Reviewed-on: https://chromium-review.googlesource.com/709921Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#521172}
-
Dale Curtis authored
Field has a label of "ms", but was actually being output in seconds. BUG=none TEST=manual Change-Id: I24025ba0dc956697d8315c81aa940ea86937a013 Reviewed-on: https://chromium-review.googlesource.com/804616Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521171}
-
Tarun Bansal authored
signal strength value is added to the network ID struct. This makes it possible to store multiple network qualities for the same network (e.g., a cellular network) along with the signal strength at which the quality was computed. When reading the cached network quality, the entry with the signal closest to the strength of the current network is used. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 786997 Change-Id: Ib0f1ad2dacc8590cba7fc0d5180ef0547fb5c6e6 Reviewed-on: https://chromium-review.googlesource.com/785554 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#521170}
-
Adam Langley authored
The API implementations and the code that uses that API generally evolve together so it makes sense to have the same owners for each. Also arnarb has lost commit privileges and juanlang is away, so this code is otherwise stuck. Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iadc44d9cf12c975f5857a1601fe88b3e09e16c9b Reviewed-on: https://chromium-review.googlesource.com/804405Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#521169}
-
Quinten Yearsley authored
As of yesterday, LUCI UI is the new default for Chromium (https://groups.google.com/a/google.com/forum/#!topic/chops-team/dYJaBL-b46U), and this means that in the future, we can expect build pages to generally have URLs with ci.chromium.org, e.g. "https://ci.chromium.org/buildbot/tryserver.blink/mac10.10_blink_rel/4830". As far as I understand, LUCI builds with build numbers will behave basically the same as Buildbot builds with build numbers; layout test results would be archived to the same place, etc. Bug: 771438 Change-Id: I42d498caa3a455115e05a50d5f7f69046010530e Reviewed-on: https://chromium-review.googlesource.com/803615Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#521168}
-
Fabio Tirelo authored
This adds a new state to ChromeChromeController indicating that the reporter is currently running. This allow us to reflect the global state in chrome://settings/cleanup and makes it easier to update the card currently being rendered. This also simplifies the reporter installer by not requiring the on_sequence_done callback to be passed, once we decided that the cleanup page will reflect global state for reporter/cleaner runs, so we don't need to keep track of the results of individual sequences. Bug: 776538 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2ba1c6fb5b72e981d6d25de5e340bc711fbe3b30 Reviewed-on: https://chromium-review.googlesource.com/794533 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#521167}
-
Biao She authored
Bug: 791159 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idbc8b244d2f39c61eeaccf177cf306e4edc1ba4c Reviewed-on: https://chromium-review.googlesource.com/804339Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#521166}
-
Sandeep Vijayasekar authored
Used by MediaCodec to display HDR content Bug:internal b/68950223 Test:none Change-Id: I6db3a1e5ce8e74ee6614d557edc7351b75306f2d Reviewed-on: https://chromium-review.googlesource.com/756443 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521165}
-
Kenneth Russell authored
This will make it possible to autogenerate these files with 100% fidelity. Stop skipping the associated testers on chromium.android.json in the manage.py script. This was the reason the gtests got out of order in the first place. BUG=662541 R=dpranke@chromium.org NOTRY=true Change-Id: I2efc4ed6e7f7564737709d5eda607f5d4543a2a8 Reviewed-on: https://chromium-review.googlesource.com/804748 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521164}
-
David Reveman authored
Images from files are typically not PNG so we can't rely on image bytes to be available. Check format and bytes when selecting image type 'old' to fix this. Test: DCHECKs passes when selecting image from file in settings Bug: Change-Id: I00ac5ff27520e6a7de249e3fb4a9a4c6c9663e7b Reviewed-on: https://chromium-review.googlesource.com/804855Reviewed-by:
-
David Bokan authored
The drag and drop autoscroll tests were timing out under root-layer-scrolls but autoscroll itself worked. The issue was that the LayoutView now owns the scrollbars when RLS is turned on so its bounding box is larger. This meant that the autoscroll activation region was further out so the test never activated autoscroll. This test fixes the issue by excluding the scrollbars when calculating the autoscroll regions. This means that the activation area starts from the scrollbar-content edge, rather than the window edge. Bug: 781431 Change-Id: Ifc0e03d8e5016055586f6242feddc7af50f90069 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/802519 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521162}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/752e9bf892ab..b8d86800487d $ git log 752e9bf89..b8d868004 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 thestig Get rid of else after break/continue/return. 2017-12-01 npm Check for success of decodes to avoid infinite loops Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia547589983fd183d6e9a130426663c638a4f72c6 Reviewed-on: https://chromium-review.googlesource.com/804815 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521161}
-
Mehran Mahmoudi authored
This CL hides the BarBanner with an animation if it is triggered while already showing. Bug: 786459 Change-Id: I252dbad91ebbcca0ce1e7449e556a3e74cc1109a Reviewed-on: https://chromium-review.googlesource.com/803906Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521160}
-
Thanh Le authored
Merge DataReductionProxyConfig::ShouldEnableServerPreviews() into DataReductionProxyConfig::ShouldAcceptServerPreview(). Bug: 790733 Change-Id: Iea803f50c5f0346e4ade31e80fcb98f18d3c99d7 Reviewed-on: https://chromium-review.googlesource.com/803670Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Joy Ming authored
The in-progress cache is used to store metadata related to in-progress downloads. The entry for the download is created upon the initiation of the download and removed after the download is completed. This CL continues the implementation of the in-progress cache by implementing the read/write functionality in the following manner: - making the in-progress cache an interface. - initializing the cache during the creation of the download item, halting the completion of the creation until the cache is initialized (similar to the history database, which persists longer-term info). - reading from the file during initialization and storing information in an |entries| object. - updating the |entries| object when adding/replacing/deleting and then writing to the file using ImportantFileWriter. - including unittests for this process. Bug: 778425 Change-Id: I8f69dd51dd619dbc688c0f2b6a3b079a3b1164ec Reviewed-on: https://chromium-review.googlesource.com/736907 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521158}
-
Theresa Wellington authored
If the user initiates a search, then deletes a folder without entering a query, we were previously crashing. Folders are not typically shown in search view except when the query is empty. Prevent the crash by exiting search if a bookmark is removed while the search query is empty. BUG=789910 Change-Id: If4c3586deb72ce5cd61c87a903ba594d1a706351 Reviewed-on: https://chromium-review.googlesource.com/804419 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#521157}
-
Bence Béky authored
This CL is in preparation for https://crrev.com/c/734223. Create Http2PushPromiseIndex::Delegate and thus remove circular dependency between Http2PushPromiseIndex and SpdySession. Also, change the internal container type of Http2PushPromiseIndex from map<vector> to set<pair>. Later, when SpdySession::UnclaimedStreamContainer is torn out from SpdySession and is merged into Http2PushPromiseIndex, there will be multile set<tuple> containers, storing identical data but sorted by different keys, kept in sync internally (because fast lookup will be required both by GURL and by SpdySession*). set<tuple> will be a lot simpler for this purpose than map<vector>. Also, unlike in draft https://crrev.com/c/734223, keep only Delegate raw pointers and use those to generate the WeakPtr<SpdySession>, instead of keeping a copy of WeakPtr in addition. Again, this is to simplify things. Bug: 791055 Change-Id: I8c9fcd77c85f3801eb24ca171c66d18ea027965b Reviewed-on: https://chromium-review.googlesource.com/797438 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521156}
-
David Dorwin authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I913d26985c4fbe9ed1a9daea65ec57094aaf5043 Reviewed-on: https://chromium-review.googlesource.com/786327 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
David Trainor authored
Add the Chromium string representation of Locale.getDefault() to the collected feedback. BUG=773416 Change-Id: If3d0af50d8a8fbba81671a5866994b03d9d88daa Reviewed-on: https://chromium-review.googlesource.com/804661Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521154}
-
Xianzhu Wang authored
For SPv175+, don't push mask transparency layer in BoxPainter::PaintMaskImages() because the layer will be generated by PaintChunkToCcLayer based on paint properties. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iadd15bd4234387fe5ecdd248e2b0ca9c5664451f Reviewed-on: https://chromium-review.googlesource.com/803861 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521153}
-
Jungshik Shin authored
This is a reland of cd106529 after the Chrome OS side changes (2 CLs) were landed. TBR=derrat@chromium.org Original change's description: > Update Arabic font preferences > > sans-serif/standard: Noto Naskh Arabic UI => Noto Sans Arabic UI > serif: Noto Kufi Arabic => Noto Naskh Arabic . > > This is accompanied by the following CrOS-side change: > > https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/786080 > > TEST=See bug commnet 1 > > Bug: 787944 > Change-Id: Ib9555abddd7576541f918a7331a0b20b9cc617af > Reviewed-on: https://chromium-review.googlesource.com/790937 > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520235} Bug: 787944 Change-Id: Ia9481af5065915b150fe50c7826fc62c6831f940 Reviewed-on: https://chromium-review.googlesource.com/804014 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521152}
-
Jiaquan He authored
Currently search related information is composited in AppListModel and it'll be accessed in a different way from other app list model data. To makes the app list migration easier, this commit separate app list search model from the other model data. In detail, this commit: - moves //ash/app_list/model/search_* into //ash/app_list/model/search/; - moves everything about search from AppListModel to the newly created SearchModel; - initializes a SearchModel in AppListSyncableService and passes it to AppListViewDelegate; - updates users of app list search model to use SearchModel instead of AppListModel; - removes OnAppListModelStateChanged from AppListModelObserver because it's never used; Bug: 733662 Change-Id: I5042ac02651cff0259edb2fcc60ada8b882a29a9 Reviewed-on: https://chromium-review.googlesource.com/803898 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521151}
-
Jonathan authored
The Linux Mojo FYI bot is intended for testing just network services, in preparation for moving the tests to the CQ. However in the interim this can sometimes be ran on the CQ. viz_content_browsertests that run on the FYI bots are intented to sometimes fail, and are not CQ ready. Due to this I'm removing them from this config until I can find a more appropriate FYI bot. TEST=viz_content_browsertests Bug: 760181 Change-Id: Ia5a5712162d24267b8ce5414d2c1e59b73106171 Reviewed-on: https://chromium-review.googlesource.com/803800Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#521150}
-
mrefaat authored
Notable change: - define IS_BAZEL_BUILD to build as a static library instead of building a framework bundle Bug: 785248 Change-Id: Ie1aa8ff9439dcae4be1ec8c2185057b4b171b453 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/802694 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:Peter Lee <pkl@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#521149}
-
Jungshik Shin authored
In ICU 60, the skeleton of 'w' is not 'vv' any more. It's just 'w'. The top domain gperf file was regenerated with ICU 60. Bug: 766816 Test: components_unittests --gtest_filter=*IDN* Change-Id: Ifde69a696f8b3062803745f8a9ad242ca4915549 Reviewed-on: https://chromium-review.googlesource.com/802765 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521148}
-
Becky Zhou authored
Adds an animation to the checkmark icon for History/Bookmark/Download. Bug: 774673 Change-Id: I72254511a5b79026d26f0bfe7bf6b2df26b37daf Reviewed-on: https://chromium-review.googlesource.com/801977 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521147}
-
Xiaohan Wang authored
Today on systems where we use AesDecryptor for Clear Key key system and MojoCdm for other key systems, the DecoderSelector will always try to see whether there is a Decryptor exposed by the CDM to decrypt the stream directly (e.g. AesDecryptor). If not, it'll fallback to MojoCdm which will typically will decrypt and decode in the remote process. Hence, "no decryptor" exposed by a CDM is normal. Previously we report this as a "debug" message in MediaLog, but it often causes confusions. This CL changes this MediaLog log to DVLOG to avoid such confusion. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If434dd7ae5bc7e76ab68c964190b465bf55d9185 Reviewed-on: https://chromium-review.googlesource.com/803671Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521146}
-
Patrick Monette authored
Fixes include: - Include what you use - Running "git cl format" - Reordering classes to be consistent Change-Id: I197eb04cb84babe0f91aa47a7f4792c6289d92ee Reviewed-on: https://chromium-review.googlesource.com/780019 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521145}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/43a5c4971235..c8947ecc4964 $ git log 43a5c4971..c8947ecc4 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 simonhatch Revert "Remove original addSeriesGroup and rename addSeriesGroup2." Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I86b55e837b4501e7611614b397ebe5625087c817 Reviewed-on: https://chromium-review.googlesource.com/803669 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521144}
-
Will Chen authored
This should speed up DevTools tests without increasing flakiness because it no longer needs to clear localStorage to reset DevTools settings since we're using a JS object as a mock localStorage. Bug: 667560 Change-Id: I1a1e06346d64855d1d8eb1d9749cc223271791fc Reviewed-on: https://chromium-review.googlesource.com/798535Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521143}
-
Joshua Bell authored
The implementation enforced IsSecureContext manually by throwing SecurityError, but per spec the API (`caches` global and the interfaces) should not even appear in non-secure contexts. Bug: 564245 Change-Id: I9f66d7398dbf6934b5b47a094c6343b57046a81a Reviewed-on: https://chromium-review.googlesource.com/802538Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521142}
-
Ilia Demianenko authored
PowerShell is a powerful command-line shell which is preinstalled on all Windows 7+ machines and is capable of issuing arbitrary network requests. This change adds two options to the network request context menu on Windows systems: "Copy as PowerShell" and "Copy all as PowerShell". Testing done: strings from the old curl-command.html and the Big List of Naughty Strings (https://github.com/minimaxir/big-list-of-naughty-strings) were submitted as request URL and bodies. Requests then were copied, submitted from PowerShell and cURL (bash) and compared on the server side. All requests got byte-for-byte match. Bug: 787693 Change-Id: I1a404e0a127cc27f154ad965661fb227232a0b08 Reviewed-on: https://chromium-review.googlesource.com/784770Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Blaise Bruer <allada@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521141}
-
James Cook authored
A previous CL left AcceleratorControllerDelegateMash empty. Most of the commands in AcceleratorControllerDelegateClassic work fine under mash, so put all the commands back in AcceleratorController. Add early exits for the few that don't work under mash. These files were split up during the WmWindow conversion, when some ash subdirectories were not allowed to use aura. Bug: 612331 Test: ash_unittests, chrome browser_tests Change-Id: Ic4ce3783c1c50ef85091bd012c7b366b26761120 Reviewed-on: https://chromium-review.googlesource.com/803054 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. TBR=sky@chromium.org Bug: 289619 Change-Id: I7a3769cfb30db3a2bb8d761f646cf23f1582f972 Reviewed-on: https://chromium-review.googlesource.com/787810Reviewed-by:
-
James Cook authored
Several tests can be re-enabled now that crbug.com/786544 is fixed Also rename a bluetooth test exclusion because the underlying bluetooth test was renamed. Bug: 786544 Test: browser_tests --mash Change-Id: I68cd79028e15636c810257a95aa64bfed6862e69 Reviewed-on: https://chromium-review.googlesource.com/803668Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521138}
-
