- 08 Jul, 2020 40 commits
-
-
Nazerke authored
As a tabmodel was decided to be deprecated, this CL is cleaning up the tabmodel from unused properties and functions. This CL removes - public property to know if this tab set is off the record. - public property to know if the model has at least one tab. - public method to close the tab at the given valid index. - public method to close ALL the tabs. - unittests which test those mentioned above. At this stage the tabmodel deprecation is still an on-going work. Bug: 1045575 Change-Id: I3902618da006a112600a814736a78b7d7856955e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278044 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#786236}
-
Ravjit Singh Uppal authored
Bug: 1073883, 1103143 Change-Id: Ib4121c2fea110ae13f490faffeb113a609e6b81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279796Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#786235}
-
Saurabh Nijhara authored
The minimum chrome version policy enforces updates within a warning time supplied by the admin. Once the device has installed the updates, it is up to the relaunch notifications to enforce relaunch for applying the updates. This CL configures the relaunch notification according to the deadline of the minimum chrome version policy if the relaunch deadline lies post this policy deadline. It also overrides the relaunch notification type to required. Any further policy change to relaunch notification type, period and heads up period would have no effect to enforce updates within the policy deadline. Bug: 1048607 Change-Id: I96a665a8feb494fd8a59d01e7dcb8155d8b07e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270457 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#786234}
-
Sadrul Habib Chowdhury authored
Affected metrics: . Compositing.Browser.PicturePile.UpdateInvalidatedAreaPerMs . Compositing.Browser.PicturePile.UpdateUs . Compositing.Browser.RasterTask.RasterUs . Compositing.Renderer.PicturePile.UpdateInvalidatedAreaPerMs . Compositing.Renderer.PicturePile.UpdateUs . Compositing.Renderer.RasterTask.RasterUs BUG=1088690, 1088688, 1089795 Change-Id: Ie8d1dc15647b9876987a5566626eb5ab002d09f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285478 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#786233}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idc8096b765b6bb96d8718ae613bb170a06f91dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786232}
-
Minggang Wang authored
This CL converts base::Bind to base::BindOnce in //chrome/browser/profile_resetter/. With this CL, there should be no base::Callback, base::Closure and base::Bind any more. Bug: 1007635 Change-Id: I57bb5ec4d0dbf9518015c8c9cf1ef6d739a327cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284387Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#786231}
-
Mason Freed authored
This is one CL of many, moving tests out of the virtual/controls-refresh directory, into fast/forms. This CL moves: virtual/controls-refresh/checkbox -> fast/forms/checkbox virtual/controls-refresh/meter -> fast/forms/meter virtual/controls-refresh/password -> fast/forms/password virtual/controls-refresh/range -> fast/forms/range virtual/controls-refresh/fast/forms/text -> fast/forms/text This is a pure move of the above folder(s). A few tests share names in the old/new location, but in all cases, the version being moved is updated/new and should overwrite the old version. Additionally, two password-* tests were moved from fast/forms -> fast/forms/text for consistency. See also crbug.com/1102647 - there is additional cleanup that will be needed after this move is complete. But to keep the review process simple, this is just a pure move. Bug: 1034611 Change-Id: I211d12131dc5503522f4d4a03c75c8a38101bc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284223 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Omer Katz authored
This CL does the following: 1) Move flushing of ephemeron pairs to the start of AdvanceMarking (also increase frequency by 2x and make step counters actually count steps). 2) Introduce additional (disabled) scopes for diagnostics. 3) Increase frequency of deadline checks when draining worklists (by ~8x) 4) Revise worklist draining so that the deadline is checked before draining starts. Bug: 986235 Change-Id: Ie24827a52cbcb497426fd51bc052fb129c417702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283743 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#786229}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594176896-1abe2c53da5158e1bb4939e0c26aa192b0d7f8b2.profdata to chrome-win32-master-1594187879-ebfd6a43efdbcc89fbe635e86e12f487d90a9077.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I73acae075d7caadc1bcb163e06af4453153e95f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286785Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3688cb363ccd..e6a6e45f3af0 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 4c6019a855e9 to 145050bf2b98 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I16ec5fe1a43be66afeef50a2082941b6ff51b0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286782Reviewed-by:
-
Antonio Gomes authored
This is now possible after switching most of Blink to operate over MediaStreamDescriptor directly. BUG=704136, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1bbce476fb6b83e37ad99723fe799ad94fd8236f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284962Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#786226}
-
Oriol Brufau authored
The list-style-type and list-style-image properties can affect the kind of list marker that we have. However, what matters are the values on the originating list item, not on the ::marker itself. Right now the difference doesn't matter, since ::marker doesn't accept these properties, and thus must be inherited. But in the future we might remove the restrictions and accept arbitrary properties in ::marker. This patch makes LayoutListMarker stop detecting changes in the list properties. They are instead detected in LayoutListItem, which notifies the marker, using a similar logic as for LayoutInsideListMarker and LayoutOutideListMarker. Also, the SetNeedsLayoutAndIntrinsicWidthsRecalcAndFullPaintInvalidation call when list-style-type changes is now avoided if list-style-image is a valid image, since then it overrides list-style-type. And there is no need to check list-style-position, since it affects the display, thus forcing a layout tree reattachment. So the layout invalidation reason can be changed from kStyleChange to kListStyleTypeChange. Bug: 457718 Change-Id: Ifde0068bbc3fbf8802c1c9c4fed13bc682b65d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279775Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#786225}
-
Adrienne Walker authored
This fixes a null pointer crash where the ScriptState's context is not valid and is not checked before being passed to ExecutionContext::From. Bug: 1099813 Change-Id: Ibdb5d33b6383f904a6f0ddb3b0eb0c6489b561d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283926 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786224}
-
Titouan Rigoudy authored
Part of the library is unused for now. It will come in handy for CORS-RFC1918. Bug: 986744 Change-Id: Ic5081003d3df470104f1e115da9dbe358a271e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260422 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786223}
-
Patrick Brosset authored
DevTools wants to highlight named grid areas in the page, but these highlights should not include the space reserved for gaps between tracks. This change just subtract the gap breadth when building the paths for the overlay. Bug: 1100384 Change-Id: I32fe57d80d660941a4eb58112686706d1390c4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278851 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786222}
-
arthursonzogni authored
Add a few more tests when navigating with one document using COOP:same-origin-allow-popup or COOP-Report-Only:same-origin-allow-popup (or both) Bug: chromium:1090273 Change-Id: I95bf3c4aaf2f2db5e8f0076c495f5c1872d77431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279767 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786221}
-
Corentin Wallez authored
Use "blocklist" for the concept of block certain GPU features based on the system's configuration. The usages of "blacklist" in the command line flags are not addressed in this CL and will be done in follow-ups as they require more careful migration. Bug: chromium:1101491 Change-Id: Iafb94471e72e67260131cccbefe571a1360428c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283321 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786220}
-
Elad Alon authored
Bug: 1092514, 1095040 Change-Id: Iea56dea0beed02cca32cd3775a42f3626fb385e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283606 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786219}
-
Sylvain Defresne authored
Chrome on iOS has some internal landmines and uses a forked version of build/landmines.py for that to allow using a separate landmines file. Add a --landmines-path parameter to build/landmines.py script in order to remove the forked version and instead use the shared one. Bug: 1033067 Change-Id: Iac668c5877ae181442078cda7ce8e727f91104b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283582Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786218}
-
Artem Titov authored
NOTRY=True Bug: webrtc:11756 TBR: hbos@chromium.org Change-Id: I7eb8aeaa10ff5f2aacc69ec7bf03f18453d7f736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287294Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#786217}
-
Jan Krcal authored
This CL adds a new implementation of SetProfileIdentityInfo() within ProfileMenuViewBase guarded by a feature flag. The new implementation: - adds a colored background that matches the active frame color, - forces the profile name to always appear (for standard profiles), and - replaces the previous edit action (when you click on the profile name) with a dedicated edit icon. https://screenshot.googleplex.com/1OV5VXrCVKK Bug: 1099286 Change-Id: I20fff5b4a117aeb47174c3337900347057eb4b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266958 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#786216}
-
Kim-Anh Tran authored
This allows DevTools to retrieve possible breakpoints (and thus to set breakpoints) while the main thread is blocking. Bug: chromium:1076337 Change-Id: Ia86d1c59bc3036edc334302eb739d5a113a0f55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284485 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This patch: 1. Renames FileBasedTrustedVaultClient -> StandaloneTrustedVaultClient to better reflect its purpose. 2. Moves StandaloneTrustedVaultClient into dedicated subdirectory, since there are more related classes coming. 3. Moves Backend into dedicated file to simplify future testing. Bug: 1102340 Change-Id: Iec2bff0132123ee37cc620dcc504cecd24b6573e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282745Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#786214}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a4da9da4215..7afbc0c8be3f 2020-07-07 andreperezmaselco.developer@gmail.com spirv-fuzz: Add variables with workgroup storage class (#3485) 2020-07-07 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement the OpVectorTimesMatrix linear algebra case (#3489) 2020-07-07 vasniktel@gmail.com spirv-fuzz: fuzzerutil::MaybeGetConstant* #3487 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I18d8b33b213d65919e1726e6531750cac073af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286780Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL removes checks for the client from codepaths where it's supposed to be non-null. Bug: None Change-Id: Ia85af01559410d8486d158841bbb7bbee8e38201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283311 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#786212}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90b0c9e859ab..41acf46e02a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huanzhong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093365 Tbr: huanzhong@google.com Change-Id: I8ff0507c78345959ecd7ab6fcd9ea85f7f362e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286778Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786211}
-
Mugdha Lakhani authored
Move tests that verify logic around canceling prerenders to NoStatePrefetchTests. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I038bf08496483cd07545f26ae2937e34d2283e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284991Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#786210}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Iff307d9955f43827fe21cb137b032a5fda440909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287330 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The script build/clobber.py tried to parse the build.ninja when clobbering a directory and use it as a template, however if the parsing failed, it generated a broken build.ninja file. The script ios/build/tools/setup-gn.py would create multiple empty build directory with just args.gn and a build.ninja file that would result in invoking `gn gen` as a first step. However, the build.ninja created by setup-gn.py could not be parsed by clobber.py since it did not include minimum required version of ninja command. Also, setup-gn.py did not recreate the file if they existed, even if they were incorrect. All this caused build/clobber.py to sometimes leave a build directory in an unbuildable state requiring the developer to run `gn gen` manually. To fix this, change setup-gn.py to always overwrite build.ninja file, to use a format that can be parsed by clobber.py and fix clobber.py to write a build.ninja file that is valid if parsing fails. Always overwrite the build.ninja file to ensure that `--check` is added to `gn gen` invocation (as locally running `gn gen` without `--check` even once would disable the local check of the deps and later be reported by Chrome iOS developers as a bug). Bug: 1102331 Change-Id: Iabe906ac5f676f1b837c6ebb03ee32d73c7b6cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283143 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786208}
-
Richard Townsend authored
EndIfDelayed stops document parsing if all scripts and resources are complete. To do this, it calls PumpTokenizer one last time to ensure that there's no input left to parse. Because it wasn't possible to delay work in this context, it meant that if something needed to call EndIfDelayed, PumpTokenizer could spend a long time processing all the available input, delaying first paint. It looked something like this in chrome://tracing: | HTMLDocumentParser::ResumeParsingAfterPause | | PumpTokenizer (budgeted) | EndIfDelayed | | | PumpTokenizer (unlimited budget) | This change adds new methods to permit this schedule instead: | ResumeParsingAfterPause |<paint>|PumpTokenizer (budgeted)|<paint> | ScheduleEndIfDelayed | The parser (via DeferredPumpTokenizerIfPossible) then schedules further tokenizer pumps until every piece of input's handled, and finally calls EndIfDelayed. |PumpTokenizer (budgeted)|<paint>| EndIfDelayed | |PumpTokenizer (unlimited budget)| Because there are more opportunities for painting to happen under this schedule, this CL improves this parsing mode's TTFP and also makes tuning the foreground tokenizer budget easier and more effective. Bug: 901056 Change-Id: I55d7f045e352ada239bffea65fe687b167160fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274629 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#786207}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594169954-cd07ad6b204758d03bed8bf845cd0c0bb5f93bcd.profdata to chrome-win32-master-1594176896-1abe2c53da5158e1bb4939e0c26aa192b0d7f8b2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia754d99959fd095790f3e52feb61f14728d66452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287149Reviewed-by:
-
Leszek Swirski authored
The ResponseBodyLoaderClient is held weakly by the script streaming SourceStream class, which means we have to manually check for a null client when notifying it that we've received data. Bug: 1098874 Change-Id: I9e2b307a5fcc5fe13f489773a3657f55ba0c1180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287310Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#786205}
-
Koji Ishii authored
r782445 crrev.com/c/2266052 changed to use copy instead of move when reusing previous layout results because we can't break them. There is another case we copy |NGFragmentItem|, when |NGFragmentItemsBuilder| creates a new |NGFragmentItems|. In this case, it is safe to break |NGFragmentItem| in |NGFragmentItems|. This patch adds move constructors to support moving in this case. The caller, |NGFragmentItems::NGFragmentItems| already use |std::move|. https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/ng/inline/ng_fragment_items.cc;l=23?q=NGFragmentItems::NGFragmentItems Bug: 982194 Change-Id: Iee89fb228459ab37144824f2809f33726a4a2543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286249 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#786204}
-
Oleh Lamzin authored
Introduce ConvertPtr template that checks whether input is null. Since ConvertPtr is a template we can test it with any valid type. Bug: b:158658869 Change-Id: I78d5f7c984303cbd9e34b187c07e1f08a0a891eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273065 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786203}
-
Rune Lillesveen authored
This CL is a revert of [1] and an alternative fix for 1093747. The original change caused increased memory use for some reason. It's confirmed with a pinpoint job that this CL fixes that regression. [1] https://crrev.com/c4a447a85cdb4de7740476a74c9d258feb0a976d Bug: 1100637, 1093747 Change-Id: If13212db30f818e68649f56a5c68ca5221a73dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278052Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786202}
-
Tal Pressman authored
Prior to crrev.com/c/2227049, there was a check to see if the frame had a document before reading its agent cluster ID. Removing that check causes crashes when GetAgentClusterId() is called from AgentSchedulingStrategy. Bug: 1103105 Change-Id: Ia0f75d1e66aaffa24ddf88269eacf2303d85c677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287191Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Oleh Lamzin authored
Use which() method and switch to convert Mojo unions. Ther benefit is that if union will be extended on cros_healthd side, there will be compilation error. Bug: b:158658869 Change-Id: If86b6c9a1e8eebe7b28ba8597234d6f742638e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273064 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Christian Dullweber authored
OnStatusChanged was wired up to the wrong number for allowed_cookies. Fix call and add test. Bug: 1077766 Change-Id: I196a92022deeb2e79a2449bfd48c00a743791a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283587 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#786199}
-
Benoit Lize authored
Adds basic uncontended Acquire()/Release() and contended Acquire()/Release() tests. There are two goals: 1. Assess base::Lock improvements / regressions 2. Compare to the similar base::subtle::SpinLock perf tests The first one was used to evaluate the impact of the recent patch to always Try() in base::Lock (https://chromium-review.googlesource.com/c/chromium/src/+/2270203). Using the following code on Linux x86_64, release build: $ for i in `seq 1 10`; do out/Release/base_perftests \ --gtest_filter='Lock*' | grep baseline | grep 'runs/s' \ | sed -e 's/.*= //;s/ runs.*//' >> /tmp/results-after; done shows that the throughput of uncontended Acquire()/Release() pairs improves by 29% on this machine (Xeon "Haswell" running Debian testing). Throughput of contended Acquire()/Release() pairs increases by 1-2%, though this is likely a wash there. Sample test output: Before the Try() patch: [ RUN ] LockPerfTest.Simple *RESULT Lock.lock_unlock_throughput: baseline_story= 36441076 runs/s After: [ RUN ] LockPerfTest.Simple *RESULT Lock.lock_unlock_throughput: baseline_story= 43857328 runs/s The second one is related to moving away from base::subtle::SpinLock in PartitionAlloc, which currently causes performance regressions. See linked bug for details. Bug: 1061437 Change-Id: I9d2047bcc74d4d7d20ca6c44683d537508d92264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283203Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Keeping empty anonymous blocks around is bad. The only known actual problem is in multicol (but it may cause other issues too). Based on the layout object tree, multicol creates anonymous LayoutMultiColumnSet and LayoutMultiColumnSpannerPlaceholder objects, to keep track of what is regular column content and what are spanners. Leaving a LayoutMultiColumnSet around just for the sake of an empty anonymous block (which may get cleaned up without notifying the multicol code) will confuse multicol layout. Bug: 1102137 Change-Id: Ibfb46d0dc173ecfdb2e7903efee5a49de3da3ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283355 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786197}
-
