- 19 Dec, 2019 40 commits
-
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers: - components/navigation_interception/ - components/net_log/ - components/offline_pages/ Fixed: 1007710, 1007705, 1007704 Change-Id: Ifdab534c0dce4d1b484540b6c770a0f3d8e6e7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976493Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726480}
-
Eric Stevenson authored
Change-Id: Iaa03a4edd1bdc1657e388930ac675655795b1bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976563Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726479}
-
Stephen Nusko authored
This reverts commit e9af78d1. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable failing blink_perf.canvas tests. > > blink_perf.canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF > everywhere and others on android, mac, and win. > > NOTRY=true > TBR=crouleau@chromium.org > BUG=1035865,978500 > CC=aaronhk@chromium.org,fserb@chromium.org > > Change-Id: I747fb7924f9632edd3bf5f6582e99f028e4fb65e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975923 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726395} TBR=crouleau@chromium.org,nuskos@chromium.org Change-Id: Idba3ad4cc6838dbcc12b7783e4dc8e57ad301ac1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035865, 978500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976824Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726478}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b70d915..0340c945 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I330e3d51362344115c5861b6ab395b0136f78429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976220Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726477}
-
Steven Bennetts authored
When we switched to using an unmanaged enum for vpn.type (which is an intrinsic / immutable property of a configured VPN), it broke the policy indicator for the type selector, which assumes that the 'property' property will be a managed type (e.g. ManagedString). Since the provider type can not be changed, it is not useful to show the policy indicator for policy managed networks (the provider type must be provided by the policy). Therefore we should just leave 'property' undefined for that network-config-select element. Bug: 1035581 Change-Id: I47704adff49fa1063eab5e93a8654645a2ec1893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976492Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726476}
-
meacer authored
This CL adds a list of characters that look like Latin characters. A domain consisting only of these characters and not having the .il ccTLD will be converted to punycode, as is done for Cyrillic Latin-lookalikes. The impact of this change is minimal on existing domains with <5 domains being affected. Bug: 722167 Change-Id: I0fd9c13331b10845958612f58fb6353d5fdb6c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975054Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#726475}
-
Sammie Quon authored
Prior to this patch, the drop target would: - show an extra background for windows with backdrop or maximized windows with top insets - shift when dragging a maximized window with top insets Test: manual Bug: 1035526 Change-Id: Iac2ae0ec35268417d8cf369c76d9890b49583587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976312Reviewed-by:Avery Musbach <amusbach@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#726474}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a9153faa00d..bd7e3bec93be git log 7a9153faa00d..bd7e3bec93be --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com trace_processor: add a fast path for zero/one row filtered tables 2019-12-19 lalitm@google.com perfetto: fix amalgamated build Created with: gclient setdep -r src/third_party/perfetto@bd7e3bec93be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Ib41fb9fc77a5d237c12ae9a9a51c45843d35f282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726473}
-
Kai Ninomiya authored
Reviewed upstream. TBR: cwallez@chromium.org Change-Id: I1bac1e7abd7f5b8e932bad6c6a591311178f239c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975999Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726472}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ef1ca1d089e..a8352ccaae37 git log 4ef1ca1d089e..a8352ccaae37 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 nifong@google.com Write a debugger user guide. 2019-12-19 robertphillips@google.com Add test for the GrContext::createCompressedBackendTexture API Created with: gclient setdep -r src/third_party/skia@a8352ccaae37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I3a3b9e4a2ab3718f6ece8a630a62fdcfd8e32d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976740Reviewed-by:
-
nancy authored
BUG=1011235 Change-Id: I322a6924aff0f77b4a030f534b36f251987c8992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975376Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726470}
-
Tibor Goldschwendt authored
This CL loads the Chrome themes into the customize dialog and enables applying a theme when clicking on the respective icon. Bug: 1032327 Change-Id: I971ad2fb3f7b2088a789f6570c5217680e981a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966500 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726469}
-
Jorge Lucangeli Obes authored
Source: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1958504 BUG=985492 TEST=validate_format.py, pretty_print.py. R=mnissler@chomium.org Change-Id: I9c36aa321a69304d09402dd00f2849daf901b310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976310Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726468}
-
Tom Anderson authored
R=thestig BUG=None Change-Id: I4be3f08565992d08a6ab4e7b06552efa8d77c23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974582 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#726467}
-
liberato@chromium.org authored
PowerStatusHelper helps to record power status(!) for the media power experiment. Change-Id: Ic8fc73f7129e5603625ae3b373c3626b6a06223c Bug: 1017788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902081 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#726466}
-
Natalie Chouinard authored
Following the naming conventions decided in go/clank-preferences-refactor, this change replaces the "Preferences" suffix with "Settings". Skip presubmit to avoid AlertDialog checks for existing usages. NOPRESUBMIT=true Bug: 1030446 Change-Id: Iebdf6d7d6a552c05179cd767f9fd7e0a288dc3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974675Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#726465}
-
Mike Reed authored
Temp CL until this can land: https://skia-review.googlesource.com/c/skia/+/260998 Change-Id: Ice6365c6827f85f57ccf2f44fe94a7a54ab0231c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975041Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#726464}
-
Trevor Perrier authored
The following 27 locales are being added to Android bundle builds: af, as, az, be, bs, eu, fr-CA, gl, hy, is, ka, kk, km, ky, lo, mk, mn, my, ne, or, pa, si, sq, ur, uz, zh-HK, zu The first language ("af") was added in this CL: https://crrev.com/c/1941058 This CL adds everything else except for "zh-HK" which is left out because currently "zh-HK" is mapped to "zh-TW" https://crbug.com/780847. A separate CL will add zh-HK. Note on size increase: Adding support for a language has an unavoidable increase in SystemWebview binary size. Since SystemWebView should support all languages that Android does this size increase is unavoidable. There is an increase in size even when language splits are used in bundles. A bug has been created to look into this: - APK Bundles wastes a lot of space in resources.arsc (400kb) - https://crbug.com/1031645 Bug: 812837 Binary-Size: Size increase is unavoidable (see above). Change-Id: I77cddf38d28ae8eacf37c3de9a09344646f5afb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952288Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#726463}
-
Oksana Zhuravlova authored
This change adds a warning for new uses of GetInterfaceProvider() and suggests using GetBrowserInterfaceBroker() instead. Bug: 718652 Change-Id: I2e99ba36a8cdb198200967d27a64931a32adcdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967759Reviewed-by:
-
Andrew Xu authored
The regression issue was introduced by https://crrev.com/c/1925783 by destructing the removed view at the end of ShelfView::ShelfItemRe- moved. However, on some edge cases (like switching between accounts), the removed item may be destructed before animation on item ends. This CL fixes the issue by stopping the animation associated to the removed icon before destruction. Bug: 1032002 Change-Id: I98aea59c9f4d0310c4c170edbb23c581816fdbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975084Reviewed-by:
-
Marzena Dell'Aquila authored
Split //chromecast/net:net to allow code to use ConnectivityChecker alone without additional dependencies. Bug: internal b/146520104 Merge-With: eureka-internal/345308 Test: compiled on several different builds Change-Id: I15ca6d84cd88f635e03f20b5b329b9804a14eea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974862 Commit-Queue: Marzena Dell'Aquila <mdellaquila@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#726460}
-
Ian Kilpatrick authored
... and associated code. As of: https://chromium-review.googlesource.com/c/chromium/src/+/1753557 This is now dead! \o/ Bug: 993813 Change-Id: Ia1e0b1bc6ae357cae40d6a26c0eda81aa6c084a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954925 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#726459}
-
Oksana Zhuravlova authored
This change adds trace entries under content::Start. Also moves the call to TraceEvent.setATraceEnabled to the very beginning of startChromiumLocked(). Bug: 1019793 Change-Id: I06d3a9d4cb20075f2dc2ce999ffe5efe3d1dd0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962858Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Abigail Klein authored
Using the accessibility recorder on native chrome ui crashes Chrome, causing the bug below. This CL only shows the button to start recording events for web pages in the chrome:accessibility page. There is also a TODO to add support for native chrome UI later. Bug: 1035760,785493 Change-Id: I416e00f4b8e577c5f497074243bd5eadc68ab6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976017Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726457}
-
Jimmy Gong authored
- This is the fixed approached to retrieving the EULA URL for printer preview. - Previously, it was under the assumption that the EULA URL would be available in the Printer object. - EULA URLs are now fetched through a server call. Subsequent calls are cached, reducing the needs for more repetitive server fetching. - Fetching for the EULA URL does not block fetching capabilities. - We attempt to fetch the URL only after the user selects a destination, which may start a fetch for capabilities. So the calls may be in parallel. Feature: 1020586 Test: End to end manual, browserTest Change-Id: I8ce7592100de763710fae2a1f2b1b0edcf2b5d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967031 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Andreas Haas authored
As the size ByteLength field of ArrayBuffers is now size_t, I changed the implementation of AudioBuffer::copyFromChannel and AudioBuffer::copyToChannel to be able to handle size_t buffer offsets. R=rtoy@chromium.org Bug: chromium:1008840 Change-Id: Iaf3a336a6fdc9c4af44708335a91b50de9d43783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975718Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726455}
-
John Abd-El-Malek authored
This matches Chrome & WebView, which fixes websites that use cache storage. This cl is meant to be small and self-contained so that it can be merged safely. I'll work on making this more generic in a followup. Bug: 1035420 Change-Id: I692f685569427e0d5277c97d5fca658cd2b56897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976550 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Xiang Ji authored
Validation: https://ci.chromium.org/p/chromium/builders/try/win-celab-try-rel/102 Change-Id: I8b797a034515d71ad40be739b6b96199e29563d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970910Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#726453}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 36607112. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I39f5af0d6d86a759b715de7e5a7d01febc51b94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726452}
-
John Budorick authored
Encountered while running tests on the emulator bots, but liable to affect device tests as well. Bug: 922145 Change-Id: I80b78627975c248b9146e76d6ecbc65d89624376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976004 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#726451}
-
Andreas Haas authored
This CL replaces calls to deprecatedLengthAsUnsigned by calls to lengthAsSizeT. Unfortunately the current implementation cannot deal with huge ArrayBuffers yet. Therefore I reject the incoming ArrayBuffers with a RangeError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=rtoy@chromium.org Bug: chromium:1008840 Change-Id: If2518d9ea341212b9024f2b2f9e0f8d07db9899b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975883 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
Bug: 1035930 Change-Id: I95c63e80eb1c64a366a2d14018808ec2e6cc6712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976432 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726449}
-
Robert Ferrese authored
Bug: b/140491587 Change-Id: I0bb446e8740c058526c3899b4ec3ec47171d3d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956012 Commit-Queue: Robert Ferrese <rferrese@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726448}
-
yilkal authored
This CL default enables supervised user iframe filters. Bug: 850328 Change-Id: Iab050a660967d10a254e2a09896363279b1b487d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967756 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#726447}
-
Marijn Kruisselbrink authored
Since all this runs on the same thread these days, there is no longer any reason for FileSystemDispatcher::DidCreateSnapshotFile to create a BlobDataHandle. The callbacks called by it already do the same synchronously anyway. Bug: none Change-Id: I86cbc0f0c4feeb20b6495f6741493d9a11ec98b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975088Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726446}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/451c28a14b36..04d5ba90fb16 git log 451c28a14b36..04d5ba90fb16 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 brgoddar@microsoft.com Audits: give focus to New Audit button after completing a report. Created with: gclient setdep -r src/third_party/devtools-frontend/src@04d5ba90fb16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5ba94a66ee71a5051cdeb1a67c1a2ac1c15ef78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976105Reviewed-by:
-
Bo Liu authored
Enable zygote in chromium code in chrome and content shell. Requires crrev.com/i/2340835 for private code to build. Change-Id: I99a3f550a81b0c877389ccb839b59afba8a7d447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976015 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Rakib M. Hasan authored
Test expectations for directories need to have globs at the end of the pattern in the new expectations format. If they do not have a glob then the expectation will not apply to tests within the directory. Bug: 986447 Change-Id: Ia44254b7d79d26647463000a6c13cb6610f10101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974318 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#726443}
-
Jan Wilken Dörrie authored
This change adds branding strings for Touch To Fill and includes logic that selects the right string via a Finch parameter. It also modifies the padding computations to take the new string into account. Bug: 1034499 Change-Id: Ib262c12dd1fa4db6e5f0788feb46526ecd99a15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971835 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This CL does several things: - It removes the legacy IPC OnPageImportanceSignalChanged IPC. - It makes third_party/blink/renderer/core/page/chrome_client_impl.cc send a message to PerformanceManager in the browser process via Mojo when a frame is interacted with. - It removes a lot of unnecessary complex code from Blink. - It adds this this information to the FrameNode class. - It removes the property from the WebContents(Impl) class and move this to a WCUserData. One side effect of this CL is that the bit that indicates if a form on a page has been interacted with is now more accurate, as it gets cleared on navigation events. See crbug.com/1031661 for more details on this. Bug: 1031661, 793806 Change-Id: Iab62fabfe0e33cb1e6a9896153d8942008a35103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954606 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#726441}
-
