GitLab

For a Voice Control name, the "1 unread reading list item" isn't
useful. The name should still be just "Reading List."

Bug: 1004319
Change-Id: I64e968a57c8aa027977220dbf8a62bc638baa07f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837792
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702894}

Fix for AXRange::GetScreenRects to not return bounding boxes for ranges
that are offscreen.
Previously, we assumed ranges that are offscreen will have empty
bounding rects, this is incorrect because offscreen rects has its
width/height clipped to 1 rather than 0; so bounding box is not empty.
See doc:
https://cs.chromium.org/chromium/src/docs/accessibility/offscreen.md

Instead, GetScreenRects now looks at the offscreen status from the
bounds API to ignore offscreen ranges.

This fix is one of a series of fixes need for bug:964078.

Bug: 964078
Change-Id: Ibfb4d245845b7e18d59724b8c7fd09f9cc3de793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824061
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#702893}

Instead of re-calculating whether the virtual keyboard is open every
time auto-scan changes, cache the value and explicitly set it when the
keyboard is entered or exited.

Bug: None
Change-Id: Ia86a95f6552df4f919d6e583829f5d3f15077cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829767Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#702892}

Found using tools/check_grd_for_unused_strings.py.

Change-Id: Ib94967bb7045e9de1c97f96f5ece96b7435eb04e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839632Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702891}

- Refactor GetValue() to use an existing struct.
- Make the parameter names in the .cc / .h files match for GetValue().
- Mark GetValue() and GetStringValue() const.
- Make all ::VerQueryValue() callers consistent.
- Add a comment to note |fixed_file_info_| is never nullptr.
- Fix various nits.

Change-Id: I4e73bf5791045005c2cfdeb6a039815c39e953ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837490
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702890}

Change-Id: Ife5804b2897aac9463d91a5e20e154678ce274bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841633
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#702889}

Bug: 1007397
Test: covered by unittest
Change-Id: Ib6b5ed47c3368133d0dcccf7a9be202570d0f541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833007
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702888}

At the moment AppBannerManager disables bfcache when committing the
initial navigation and prevents every frame from being cached.

Fix this by requiring state to be not INACTIVE.

R=arthursonzogni@chromium.org
TBR=dominickn@chromium.org
BUG=1001087

Change-Id: I5c63a35d2a56872b36f79e738d4db90c554a9caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840233Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702887}

Test to make sure no_version_info.dll, which has no version info, causes
base::FileVersionInfo::CreateFileVersionInfo() and
CreateFileVersionInfoForModule() to return nullptr.

no_version_info.dll is just an one-off component build of pdfium.dll,
with everything stripped out.

Change-Id: I3e4b527f1d2f52dcec55c2c38af369a651608175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838268Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702886}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/485edf28..666d4144

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I86327aa0af90495cb06d3524a8864cef7cee652b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841311Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702885}

In crrev.com/c/1454156 the checks in
AppsGridView::ReparentItemForReorder and
AppsGridView::ReparentItemToAnotherFolder to see if a folder would be
deleted by removing an app was broken for persistent folders. This
would cause the model for the folder to be deleted, while the view
remained in place. Interacting with the empty folder would then cause
a null dereference and crash chrome.

Bug: 1009989
Change-Id: Ief7bc007683b38d536aabb1418d8142e5c0f7702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837556Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#702884}

This reverts commit 3dd37620.

Reason for revert: Suspected of causing webkit_layout_tests in http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html on "Win10 Tests x64".

Original change's description:
> Reland "[iOS] Make the leak detection backend available on iOS"
> 
> This is a reland of 74640a89
> 
> TBR=vasilii@chromium.org
> 
> Original change's description:
> > [iOS] Make the leak detection backend available on iOS
> >
> > Bug: 986317
> >
> > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267
> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> > Commit-Queue: Ioana Pandele <ioanap@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#702059}
> 
> Bug: 986317
> Change-Id: I490b8d96074e1786b74905a083f0554fe914b4c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840771
> Reviewed-by: Ioana Pandele <ioanap@chromium.org>
> Commit-Queue: Ioana Pandele <ioanap@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702835}

TBR=vasilii@chromium.org,ioanap@chromium.org

Change-Id: Ic28424989edd62fb5eed9b1b15c409406fd267df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841754Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702883}

This CL relands the interactive UI tests for the global media controls.
The original CL was flaky for the ShowsMetadataAndControlsMedia test
because sometimes it checked for toolbar icon visibility after media
started but before the media starting caused the icon to appear. This
CL fixes that by waiting for the icon to appear.

TESTED=Was locally flaking about once every 20 runs before the fix.
After the fix, I ran it 300 times and it passed every time.

Description from original CL (crrev.com/c/1753690):
This CL adds some basic interactive UI tests for the global media
controls. This ensures we have better coverage than just unit tests.

Bug: 993879, 999297
Change-Id: I7abf36e4f82b64b262d3d0a7eb9d426e8ae1c5f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814671Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702882}

* Modify tab group naming related methods to make them easier to use.
* Add unit tests for TabGroupTitleEditor.

Bug: 1001738
Change-Id: I42591d5b73e1b9c5dd00798939a48da92dede4c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837979
Commit-Queue: Yue Zhang <yuezhanggg@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702881}

Some methods (i.e. center, unionAll) are not used in this change, but
will be in a followup change.

Bug: None
Change-Id: I2fe31bdfa1e02d609813e352a51e8b105631660c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830361Reviewed-by: Aran Gilman <gilmanmh@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#702880}

This class handles the BatchSetFeatureStatuses portion of the CryptAuth
v2 DeviceSync protocol. While the BatchSetFeatureStatuses API allows for
setting multiple feature statuses for multiple devices, we restrict our
interface to a single feature for a single device. This is for
simplicity as well as consistency with the CryptAuth v1 DeviceSync
interface.

CryptAuthFeatureStatusSetter::SetFeatureStatus() is the v2 DeviceSync
analog of SoftwareFeatureManager::SetSoftwareFeatureState(). A future
change will introduce a SetFeatureStatus() method into the DeviceSync
mojo service, which will use CryptAuthFeatureStatusSetter.

Bug: 951969
Change-Id: I57b315cb4a1853120f4ccf26bb7cdfd0f18e022c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833317
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702879}

Given that CPU usage is now reported to AdsPLMO, this updates the
criteria for when an ad frame is recorded. Specifically, it is recorded
iff it has either non-zero bytes or non-zero CPU usage. This change
also fixes an issue where metrics would still be collected for
resources blocked by the Subresource Filter.

PageLoad.FrameCounts.AnyParentFrame.AdFrames is versioned to
PageLoad.FrameCounts.AdFrames.Total. The other affected metrics have
not been versioned as the increase in the number of ad frames recorded
should be small (~5%).

Bug: 1000810
Change-Id: I7ec57326ca93f6e6686d84869bb7f4dfbf58bf15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824124Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702878}

Reporting and Document Policy are going to be using SH, and it is more generally
useful as a building block for new features than just Web Packages. This CL
moves it into blink/[public/]common/http, and removes the http_ prefix from
individual files and directories.

Bug: 993790, 1011101
Change-Id: I344e4aad6ebeb6956e441a7ab75478d98d7f60a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835998Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702877}

These have no need to use array buffers and are a minor nuisance to those who
refactor the Blink-side array buffer code. We can just use the Skia type for the
paths that only ever want to pass the data back to Skia anyways.

Change-Id: I9bd9d056c79c4819628aae243f7a333f08dbcaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835659Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702876}

We currently create a BackgroundSyncNetWorkObserverAndroid object to
monitor changes in network connectivity. We also rely on JobScheduler to
run a task that fires all ready (periodic)sync events when we have
network connectivity.

The latter has better network detection, given that it validates
connectivity before running the task. This means that we don't attempt
to fire sync events when the device is behind a captive portal, or
hasn't yet authenticated to a locked network. It also respects Data
saver mode, and doesn't run the task if the user has prohibited the
browser from consuming data in the background.

This change adds a BackgroundSyncParameter to ignore network changes
coming from BackgroundSyncNetworkObserverAndroid. This means that we
only fire ready events when the JobScheduler task tells us to, relying
entirely on Android's network detection logic.

Note that this won't have any effect on sync events that are ready to
fire as soon as they're registered, since JobScheduler isn't involved
at that point. This ensures we don't introduce any delays for the first
attempt. Second attempt onwards, JobScheduler can be involved on Android
M+. It is also always used when there's no connectivity at the time of
registration of sync events, and for all periodicsync registrations.
So the change is a net improvement.

The plan is to enable this parameter through a Finch study on Android M
and above where we can rely on JobScheduler for this task.

Bug: 529351, 574478, 529351
Change-Id: I482b2a6eb59a073fa0cde2a5d6bb58d55e8691ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833590
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702875}

When a page load is cancelled, the pending navigation shouldn't
necessarly be discarded because another navigation could be the current
pending navigation (if there is a delay).
This CL makes sure to check that the cancelled navigation is the
pending navigation before discarding the pending navigation.

Bug: 1007243
Change-Id: Iae01e31bea3e40ae4ff08f1dbcc4a28c9f70198c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837931Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702874}

Bug: 1010998
Change-Id: I7f389c9e36fb672f727acec914c4f97dde3e3133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838191
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702873}

Bug: 900581
Change-Id: Id7b0a8dbc03457343ce7fa8d25f30ee0da39f901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841071Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702872}

TBR=jbudorick@chromium.org

Bug: 1011225
Change-Id: I3b5e5789da0a6d0a7a19f333ffab11e36b5fe0e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841572Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702871}

Bug: 995480, 995482, 995488, 995489, 995497, 995499, 995500, 995505, 995512, 995516, 995519
Change-Id: I7dc1aaab76b498c35a57cbfdcad35f87f98dd098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829648Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702870}

This makes it much easier to roll expat. It automates calling rolldep,
updating the README.chromium, updating the expat_config.h
configuration header, and adds the OWNERS to the review.

Bug: chromium:1004341
Change-Id: I9e19e0016cedc12b1f2079cd54b95bd7e3d3f25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829677Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702869}

The post task in RenderWidget was in order to keep IPC receipt of
destruction of a frame-based RenderWidget (ie a RenderView in the past)
from happening while the RenderWidget was already closing due to the
renderer-side detaching, but running a nested message loop.

The RenderView destruction now already does a PostTask hop in
RenderThreadImpl before starting destruction of the RenderViewImpl
and its frame tree and RenderWidgets. A RenderWidget for a frame closes
when the frame detaches, and that is built to be consistent even if
it occurs inside of unload. The RenderWidget does not need to be kept
around after the blink frame and RenderFrame and WebWidget associated
with it are all gone.

Popups and pepper RenderWidgets can close during a frame unload without
a consistency problem.

R=dcheng@chromium.org

Bug: 419087
Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702868}

Telemetry marks stories as failed when there is a problem with metrics
computation. This CL reproduces the same behavior in Results Processor.

Bug: 1010041
Change-Id: Idb0b86fc30c2cc4a9e8fd18feb56737501f34487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840654Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#702867}

libyuv is referenced in vpxenc.c but was never built or used anywhere in
chromium. Make this explicit.

BUG=1011071

Change-Id: If3fd27ccc728cbe50023297b47744596634978da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838164
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Auto-Submit: Johann Koenig <johannkoenig@google.com>
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#702866}

Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/449,
this CL makes use of ={} syntax in IDL files.

Bug: 877147
Change-Id: Icc2fd12b7cf7800456398f6e1a5021e159a3f8fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837791
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702865}

These histograms are still being used to evaluate the AsyncStackAdTagging
experiment.

Bug: 995527
Change-Id: I8959e046d1ad6559ff7ef369b97ceba2649d15dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832401Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702864}

Convert the remaining bits in both the implementation and clients from the
browser and renderer processes for the viz::mojom::CompositorFrameSink and
viz::mojom::CompositorFrameSinkClient interfaces, and adapt unit tests.

Bug: 955171, 978694
Change-Id: Ic01dd94b8e070794df82668d01e0c45b058737f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835507Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#702863}

Convert the remaining bits in both the browser and renderer processes
for the resource_coordinator::mojom::blink::DocumentCoordinationUnit
and the resource_coordinator::mojom::blink::ProcessCoordinationUnit
interfaces to the new mojo types.

Bug: 955171, 978694
Change-Id: I7fd19d7aa32882347bf059a00f17269aecabc1cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837613
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702862}

The framework attempts to call {manifest_package}.R.onResourcesLoaded()
when an APK that is built as a library (typically WebView) is run as a
standalone app, which is intended to fix the R class references to point
to the correct package ID.

We usually already generate the required class/method, but we weren't
keeping it during proguard. Fixing this by adding the missing keep rule
and ensuring that we always generate a class with the right package
means that code running in the context of the WebView APK should now be
able to refer to resources normally via the R class without needing to
use getIdentifier.

Bug: 1009982
Change-Id: Ib33d59ca2696ba949536be34c997690a310c2370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834042
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702861}

Bug: 1009443
Change-Id: If5cc243605332b6264aead0ba2a869a751e57bb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834143Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702860}

I noticed that md5_check.py was taking up to 200ms for javac actions.
Turns out it was due to it hashing really big .jar files. The utility of
md5_check is that it tracks the md5s of often-changing source files
(e.g. .java files). It's not worth spending >100ms to check if rt.jar has
changed over and over again.

This now uses mtime for files greater than 1mb, and the md5_check
overhead for javac.py is down below 10ms on my machine.

Bug: 906803
Change-Id: I4956419e12b69ad025f12a79d82cf044fc9db34d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839238Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702859}

On CrOS when the default device is unplugged, the capturing is
automatically switched to the next default device. This is not the case
for other platforms. For this reason, we should not surface the onended
when the default device is unplugged.

BUG=b:141964689

Change-Id: Ia804a25147a213d2db6827670c586e89370eb06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840513
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702858}

This CL converts usage of |TracingSessionHostRequest| to
mojo::PendingReceiver<mojom::TracingSessionHost>

Bug: 955171, 978694
Change-Id: I79f31015757c0a92179c60fb5fea69adcd24ae59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831930Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#702857}

This CL attempts to improve the fuzzer coverage of the various
Create() functions that are invoked by RecordParsed::CreateFrom(),
e.g. ARecordRdata::Create().  See [1] for fuzzer coverage prior to
this CL.

[1]: https://chromium-coverage.appspot.com/reports/699620_fuzzers_only/linux/chromium/src/net/dns/record_rdata.cc.html

Change-Id: Icad9ca987464f76099daf649d9f46f41c1c9ab9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829939
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702856}

Bug: 1005288
Change-Id: I336f17fa43b7d0db0b4d16657fd3d14a925deedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837771Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702855}