- 01 Oct, 2020 40 commits
-
-
Mohammad Refaat authored
Update previousSessionInfo to retain the session id in the case of single window app, then use it on later runs for the first restore of the run. Bug: 1131031 Change-Id: I3b245826e9a9c40cb6df1d2e9c4123276c8d73f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442231 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#812730}
-
ckitagawa authored
Use 1/4 size tiles that represent 1/4 the current bitmaps we use. This results in less memory usage as less data will be used by edge tiles that aren't visible. Change-Id: I8d1164cdb9cd28b0681d86c94885d150d3e0df04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441322 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812729}
-
yiyix authored
This change removes the flag ExtendedTextMetrics.fontBoundingBoxAscent and Descent and references in code to ship attributes in TextMetrics: fontBoundingBoxAscent and fontBoundingBoxDescent. Currently chrome is only returning the width, actualBoundingBoxLeft/Right/Ascent/Descent of the measured text. https://html.spec.whatwg.org/multipage/canvas.html#textmetrics Intend-to-ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/GSmWjdqmgCA/m/c5Y8DfKyCAAJ Bug: 1129621 Change-Id: Id367f0f8d74aa82f6baa64f5909b325fede57b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440847 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812728}
-
Bailey Berro authored
This change makes SystemDataProvider an observer of PowerManagerClient. Whenever UpdateBatteryChargeStatus is called or an event is received from PowerManagerClient, updated BatteryChargeStatus information will be fetched from CrosHealthd + PowerManagerClient. Bug: 1128204 Change-Id: Icecaabf56da030734804194acc38e3716b01d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431726 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812727}
-
chinsenj authored
If a user presses on a folder name textfield it selects the whole field. If they press the left/right arrow keys it does nothing. Only after the second left/right arrow key press does the textfield clears the selection and shows the cursor. This CL makes it so after the first left/right arrow key press the textfield clears the selection and shows the cursor. Bug: 1133681 Change-Id: I8c27ce850c05411f887bc8bf92f706485645c6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441999Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812726}
-
Jan Wilken Dörrie authored
This reverts commit d0bda2ee. Reason for revert: Logging Password Length is not needed. Original change's description: > Add metrics to InsecureCredentialsManager > > This CL adds metrics about passwords weakness check. > > Bug: 1119752 > Change-Id: I20ff20dde480c84ebd5d252ce7684cecc4fc4c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434336 > Commit-Queue: Irina Fedorova <irfedorova@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812625} TBR=rkaplow@chromium.org,jdoerrie@chromium.org,irfedorova@google.com Change-Id: I6b01baa8be4e0e351deb3ff8f5eae79e12c2ab4a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442971Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#812725}
-
chinsenj authored
This change enables interactive window cycle list, introducing new ways to interact with alt-tab. Fixed: 1067327 Change-Id: Ia93463d86134e22952ade8bc74b10cb4bc55ee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441257 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812724}
-
Guido Urdaneta authored
These tests are flaking frequently on TSAN. Bug: 1127211 Change-Id: I063e6435f5c33659bfdc2f21c5a38b55cbaf9881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442791 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#812723}
-
Tanmoy Mollik authored
All the grey icons in settings page should be of same color. They should all use @color/default_icon_color value. ic_google_services_48dp and ic_signout_40dp icons uses a different shade of grey. This cl updates these icons. Screenshot: https://crbug.com/1132900#c6 Bug: 1132900 Change-Id: If24bda31f812513757c44d77815c71b156945687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435310 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812722}
-
Alice Wang authored
This CL uses CoreAccountInfo as argument instead of Account in the method SigninTestUtil#signinAndEnableSync(). Bug: 1002056 Change-Id: Ia3882dde8dea95b6b8782823e0438362a5193255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438414Reviewed-by:
-
Hua, Chunbo authored
Bug: None Change-Id: I1cebed8f85622697230fe91dc165f3eb3d47e30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434144Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#812720}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2fde3fac998c..f01bf538a4ff 2020-10-01 taylori@google.com Merge "perfetto-ui: Order thread tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7e294276b5e0a7fbe82f4eba3701443289e0e328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442718Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812719}
-
Greg Thompson authored
BUG=1089800 R=chromium-metrics-reviews@google.com Change-Id: Iabb68d2fb2189dcffee05d9d2a4be6a226b1d32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440667 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812718}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. This cl does not address entropy leaked by MIDIConnectionEvents. Given those events only occur when a device is connected or disconnected, it is unlikely that they would be useful to fingerprinting scripts. Bug: 973801 Change-Id: I7b3ad5682126dbcbdb2196bdbac0fa985bfee404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432811Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#812717}
-
Thomas Tellier authored
The current value for this policy indicates that it applies to all ChromeOS versions after M84, however this wasn't right as that policy was not released by then: it was ready after a change I made in M86. This CL updates the 'supported_on' value to match what the product actually supports. BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but setting the correct value causes the policy checker to complain. Bug: b/169582602 Change-Id: I9c4d27a73f2ab78d13a95d6ab49dabc7d65c200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435098 Commit-Queue: Thomas Tellier <tellier@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#812716}
-
Adam Langley authored
Previously the contents of the QR code changed because the keys were continually rotated. The latency of BLE adverts turned out to be significant however, so the acceptance window grew to the point where it wasn't providing very much security. The contents of the QR code no longer changes so this change animates the QR code by rotating the masking function applied. BUG=1002262 Change-Id: I5d1a179d0400b35e3840bf9fce356a038e5c2ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441300Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#812715}
-
Maksim Ivanov authored
This reverts commit dc61429b. Reason for revert: Speculative revert, see crbug.com/1133102 Original change's description: > [Payments][Metrics] Extend expiry for ever-green metrics. > > Also updated ownership. > > Bug: 1128111 > Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811232} TBR=mpearson@chromium.org,nhiroki@chromium.org,danyao@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1128111,1133102 Change-Id: Ib9e0eba5421247c1d9b556fbe4fd82b2408b4a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442793Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#812714}
-
David Bokan authored
This should make the tests more reliable since waitForAnimationEnd simply rAFs x frames. In web_tests, rAF intervals are artificially made much shorter than in the real world so this doesn't actually wait very long. The time based version waits using rAFs but breaks based on the wall clock time (currently 200ms without a change) so it doesn't depend on the rAF interval time. Bug: 915926 Change-Id: I052cede0a3712911a9bd385929bec56d987af7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442350 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#812713}
-
sandromaggi authored
This adds the non-implemented (or deprecated) actions from the backend to the list of reserved fields. Bug: none Change-Id: Id77bffb0da81c2d17362cf7a0e383fa810250528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440669 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#812712}
-
Joon Ahn authored
https://screenshot.googleplex.com/4HWAicLVp6pnhNp Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5f53c37dd5e99631438b736eed8211214292d70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436953 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59f1d1e36d26..281fb1ed7ba9 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 97f841d7..2cdb2cb6 (812293:812617) 2020-10-01 philipp.hancke@googlemail.com stop sending x-peer-id in peerconnection_server 2020-09-30 glahiru@webrtc.org Replace one use of sigslot with RoboCaller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7651293284447a1dd64711116bab8b06ae9165a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442715Reviewed-by:
-
Sky Malice authored
Previous OWNERS file was not located in the top level folder for the given feature. This causes the ownership checks for DEPS rule changes to fall back to the parent folder, and in this case, to //chrome/, which is probably not what was intended. Change-Id: Ica17765d2e5a974ee1b27b0a6d733cddf2dd37b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440972Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#812709}
-
Sky Malice authored
The user_education feature was recently moved from //chrome/android/ to //chrome/browser/, see https://crrev.com/c/2422060. Because of the top level -chrome DEPS rule, all of the places that previously used the user_education feature are now in violation. Current usages are in the following directories: * //chrome/android/feed/ * //chrome/android/java/ * //chrome/android/junit/ Bug: 1127732 Change-Id: I57ab4659d420fa791774269badd370534279e7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441670Reviewed-by:
-
Arthur Eubanks authored
EXPECT_FALSE(CFRangeToNSRange(CFRangeMake(LONG_MAX, LONG_MAX), &range_out)); is failing with a new clang roll, there may be some existing undefined behavior due to signed integer overflow. Bug: 1133974 Change-Id: I5a1de0db2753fcb9f325e0dfaa2c228268417e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441736 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#812707}
-
Morten Stenshorne authored
A column spanner essentially overrides the rules in https://www.w3.org/TR/css-break-3/#unforced-breaks ; e.g. if a block has a spanner as its first child, it's perfectly okay to break right before the spanner, even if this means that we're not really breaking *between* stuff (class A breakpoints only occur *between* siblings). So set break appeal to perfect, or it'd be a last-resort breakpoint. Bug: 829028 Change-Id: I34cb1853febe38a766cc74ebbc5efff61aee653c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440528Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#812706}
-
Omar Morsi authored
This CL separates functions interacting with the PrefService from KeyPermissionsService so that these functions can be used by other components (such as KeyPermissionsManager see crbug.com/1127284) without depending on KeyPermissionsService. Bug: 1127284 Change-Id: I79120c1f05cc2582755ec596eebc4eedfff80e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440475 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812705}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601531335-92722dc44bbb5dcb3fdddbecff6eb0d1b4a38ee3.profdata to chrome-linux-master-1601553580-367c6f76c3cbdd1ced1ecc49db85241195c30ea6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I2b47ffdf2c6d4d0cfe46bc46f6a59285d4c35dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442716 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Etienne Pierre-doray authored
So that task with more workers yield to other tasks. This works by recording both |priority| and |worker_count| the same way we did for |min_allowed_priority_| Change-Id: Ife315ad2304f4b417f85ebd338138354176fe013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390943Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812703}
-
Dominique Fauteux-Chapleau authored
This regression was caused by crrev.com/c/2339282, which suppresses with a bad condition. The fix is to check for existing malware verdicts before suppressing the metadata check verdict instead of just checking if an async scan took place. Bug: 1127454 Change-Id: Id23eb4e26124ea823b0687f9bbfe7f562d0fe7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441281Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812702}
-
Rohit Agarwal authored
This CL adds TargetApi annotation for the incognito notification tests which uses method that is available only from M. Bug: 1134054 Change-Id: Ic0e91ac3438d69589a28a6dab20c09e70f5e3753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442015Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#812701}
-
Ilya Nikolaevskiy authored
This will allow WebrtcVideoFrameAdapter to set feedback. Currently, it may get a wrapped frame in some cases. WebrtcVideoFrameAdapter is a logical place to attach feedback, since it's the wrapper of VideoFrame available inside WebRTC. Bug: chromium:1134073 Change-Id: Id955609dc00d4555294cd39192b55db66ac8f72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440513 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#812700}
-
Ewann authored
The OPEN IN.. toolbar wasn't displayed correctly when the "Fullscreen Smooth Scrolling" feature was disabled. To correct this, a top constraint has been added to the bottomMargin view and the height calculation of the toolbar has been updated. Bug: 1130529, 1133280 Change-Id: I5e60e1e63db70f5ca2f3b6ab79f32105d1ca1a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438132 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#812699}
-
Yoav Weiss authored
PSA: https://groups.google.com/a/chromium.org/d/msg/blink-dev/sIGNgOAC0oc/TFST-dJxAwAJ When srcset selects images, it takes the screen density into account, but beyond a certain density, that can result in excessive downloaded images. Currently, when adding `w` descriptors to srcset, developers run a risk that large `w` descriptor images will be used on small screens with very-high density values. For example, when defining `<img srcset="300.jpg 300w, 600.jpg 600w, 1200.jpg 1200w, 2400.jpg 2400w">`, developers that define the 2400px wide image typically intend for it to be used for very large screens (e.g. a 32" 2x screen), but it often ends up also being used on small screens (e.g. a phone with 4x DPR and viewport width of 600+px) . Research[1] shows that density above 2-2.2x is not visible by most people, and therefore we could avoid wasting those bytes and avoid the related slowdown. See https://github.com/whatwg/html/issues/4421 for full discussion Change-Id: I52afd505b023767883088a939083f9f835e7fa14 BUG: 1125973 [1] https://observablehq.com/@eeeps/visual-acuity-and-device-pixel-ratio Change-Id: I52afd505b023767883088a939083f9f835e7fa14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395619Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812698}
-
Ken Rockot authored
This eliminates the remaining target in the embedder directory by merging its only interesting definition back into content/public/common. All references to the directory are removed here, including some stray DEPS. Bug: 977637 Change-Id: I43f77e0c9122289c82e9c24e851714cbeb3c6e38 Tbr: boliu@chromium.org Tbr: thestig@chromium.org Tbr: yucliu@chromium.org Tbr: lazyboy@chromium.org Tbr: kvitekp@chromium.org Tbr: mbarbella@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441727 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812697}
-
Jinsuk Kim authored
ThemeColorProvider deals with colors on toolbar for a suitable theme. It is mainly used within toolbar/, only by a few outside the package(namely task.tab_management). This CL moves the class to toolbar/ which it can be justified to be a part of. Bug: 1127732 Change-Id: I4730f3eab566e165b62e1a60ecf737eeb4c8c31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423829 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#812696}
-
Maria Kazinova authored
PasswordAccepted. Having this check ensures there is no nullptr dereference in case the driver is deleted and the browser process is not aware of it (i.e. in case when the renderer is compromised). Bug: 1133635 Change-Id: Ieee8c2200a4b323af39f730011e733b74e8bc911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440095 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812695}
-
Austin Eng authored
This reverts commit 71c10e67. Reason for revert: Breaking Dawn's CQ. This CL likely needs to update webgpu_blink_web_tests as well. Original change's description: > Change blink_web_tests and blink_python_tests test types. > > This CL changes the GN blink_web_tests and blink_python_tests > targets to use a new script_test() GN template. > > A script_test is a kind of test target that implements the > [test executable API](//docs/testing/test_executable_api.md) > via a Python script (rather than being an executable target). > > :blink_web_tests, :blink_python_tests are examples of this type > of test; other targets will be switched over in future CLs as well. > > Most importantly, using script_test() will ensure that > the $root_build_dir/bin/run_$target_name test wrappers are > generated with all of the appropriate arguments, simplifying the > invocation of the test both for devs and for the bots. > > Bug: 816629 > Change-Id: Ib4bfd2342d762db24cdef75b64ed5dd7fbf3c10e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380936 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#812523} TBR=dpranke@google.com,robertma@chromium.org,rmhasan@google.com Change-Id: I16c0d8bfaebbeabbeee7dd98a0f4bb083403444f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442872Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#812694}
-
Morten Stenshorne authored
When performing column layout, we need to tell the builder that it's to generate a column box, as this determines the behavior when finishing fragmentation; see IsFragmentainerBoxType() check in FinalizeForFragmentation() in NGBlockLayoutAlgorithm). The other entry points to column layout already take care of this, but it was missing for the initial column balancing pass. Bug: 829028 Change-Id: I60914b7adead19e4efa441d05733d4bd819dafd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440527 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This CL adds : 1 - Mediator unit tests for the video player. Bug: 1117157 Change-Id: I27e000e63e6e528f7480caa0b26932fd89d5300e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430688 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#812692}
-
Anders Hartvoll Ruud authored
Otherwise, for a selector such as ':is(:host(.a), .b) .c', the tree- boundary crossing flag will be set when processing :host(.a), and then incorrectly carry over to subsequent list items (i.e. .b). Bug: 568705 Change-Id: I2a8eb5735c0fc44242d7c0e089b85814e6080b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435190 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812691}
-
