GitLab

We're getting away without checking bounds today because we're building
and checking a bounding-box hierarchy at record time; draws outside the
picture bounds happen to never be recorded.

This isn't a guarantee of the recording API, and indeed doesn't happen if you
record without a bounding-box hierarchy.  We want to lean on this lack of
guarantee a bit more.  To cut down on time spent recording, we may move around
when we build a bounding box hierarchy.  The upshot is that the SkPicture may
contain commands that won't draw anything, and AnalysisCanvas might receive them.

In short, the safe thing to do is quickReject just like SkCanvas does.

tested: cc_unittests, unit_tests

(Background: found this when debugging PicturePileImplTest.AnalyzeIsSolid* failures from  http://crrev.com/504823003)

BUG=

Review URL: https://codereview.chromium.org/505263002

Cr-Commit-Position: refs/heads/master@{#292141}

BUG=None

Review URL: https://codereview.chromium.org/504183005

Cr-Commit-Position: refs/heads/master@{#292140}

Cr-Commit-Position: refs/heads/master@{#292139}

This CL switches CryptohomeAuthenticator's mount code from the old
MountAsync() method that takes a password to a MountEx() that takes a
Key for authentication.

BUG=367847
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/488633003

Cr-Commit-Position: refs/heads/master@{#292138}

Revert of mojo: generate Proxies and Stubs for java bindings. (patchset #16 of https://codereview.chromium.org/411913002/)

Reason for revert:
Fails license check on android bot:

http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64641

Original issue's description:
> mojo: generate Proxies and Stubs for java bindings.
>
> This CL allows to generate Stub and Proxy of mojo service in java. This
> allows to call interfaces method through message pipes.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57

TBR=ppi@chromium.org,rmcilroy@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/511543005

Cr-Commit-Position: refs/heads/master@{#292137}

This CL allows to generate Stub and Proxy of mojo service in java. This
allows to call interfaces method through message pipes.

Review URL: https://codereview.chromium.org/411913002

Cr-Commit-Position: refs/heads/master@{#292136}

Having both username and password empty is incorrect. We should find out where they come from.

BUG=404012

Review URL: https://codereview.chromium.org/514573002

Cr-Commit-Position: refs/heads/master@{#292135}

This reverts https://codereview.chromium.org/493123002. There were too many generated crashes.

BUG=407767

Review URL: https://codereview.chromium.org/512673002

Cr-Commit-Position: refs/heads/master@{#292134}

Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/)

Reason for revert:
Build failure on Google Chrome ChromeOS:

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164

Original issue's description:
> Remove the last piece of deprecated synchronous IO code.
>
> BUG=337096
> TEST=bots
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193

TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,xians@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=337096

Review URL: https://codereview.chromium.org/509893002

Cr-Commit-Position: refs/heads/master@{#292133}

BUG=337096
TEST=bots

Review URL: https://codereview.chromium.org/460373002

Cr-Commit-Position: refs/heads/master@{#292132}

BUG=404818

Review URL: https://codereview.chromium.org/498653003

Cr-Commit-Position: refs/heads/master@{#292131}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/507773002

Cr-Commit-Position: refs/heads/master@{#292130}

This callback is needed to measure the performance of booting ServiceWorker.

BUG=401389
TEST=N/A

Review URL: https://codereview.chromium.org/493373002

Cr-Commit-Position: refs/heads/master@{#292129}

predictor.

R=asvitkine@chromium.org, jkarlin@chromium.org

Review URL: https://codereview.chromium.org/498223002

Cr-Commit-Position: refs/heads/master@{#292128}

The file can be moved into the component as-is.

BUG=373245

Review URL: https://codereview.chromium.org/506863003

Cr-Commit-Position: refs/heads/master@{#292127}

This will make the test not fail once the new avatar menu is enabled by default.

BUG=400667

Review URL: https://codereview.chromium.org/489823003

Cr-Commit-Position: refs/heads/master@{#292126}

Review URL: https://codereview.chromium.org/513623002

Cr-Commit-Position: refs/heads/master@{#292125}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/510453002

Cr-Commit-Position: refs/heads/master@{#292124}

The history page shows the current tabs of synced devices. This works by
having the client upload its open tabs to the server, which feeds this
data into the history backend.

If history saving is disabled by policy then the opens tabs should not
be uploaded to the server. This also prevents them from showing up in
the history page.

BUG=292976,372108,393051

Review URL: https://codereview.chromium.org/394223002

Cr-Commit-Position: refs/heads/master@{#292123}

BUG=405550

Review URL: https://codereview.chromium.org/508433004

Cr-Commit-Position: refs/heads/master@{#292122}

This is a resubmit of https://codereview.chromium.org/459603003 without
the media/ changes.

BUG=349320
TBR=cpu@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/511773002

Cr-Commit-Position: refs/heads/master@{#292121}

TBR=phoglund
NOTRY=true
BUG=408006

Review URL: https://codereview.chromium.org/506423002

Cr-Commit-Position: refs/heads/master@{#292120}

BUG=405800

Review URL: https://codereview.chromium.org/510693002

Cr-Commit-Position: refs/heads/master@{#292119}

This moves all checks in the browser process into a common function.

BUG=368372

Review URL: https://codereview.chromium.org/489313002

Cr-Commit-Position: refs/heads/master@{#292118}

The instrumentation was dropped and the code is unused.

BUG=None

Review URL: https://codereview.chromium.org/510703002

Cr-Commit-Position: refs/heads/master@{#292117}

BUG=407750
TEST=unit_tests

Review URL: https://codereview.chromium.org/511753002

Cr-Commit-Position: refs/heads/master@{#292116}

TBR=gcasto
NOTRY=true
BUG=407998

Review URL: https://codereview.chromium.org/508893002

Cr-Commit-Position: refs/heads/master@{#292115}

Cr-Commit-Position: refs/heads/master@{#292114}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502293002

Cr-Commit-Position: refs/heads/master@{#292113}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502203002

Cr-Commit-Position: refs/heads/master@{#292112}

BUG=401588

Review URL: https://codereview.chromium.org/507913002

Cr-Commit-Position: refs/heads/master@{#292111}

SWProviderHost had sent the SetVersionAttributes message to set version
attribtues of SWContainer (eg. navigator.serviceWorker.installing), but
these attributes were moved into SWRegistration and the message is now
sent from SWRegistrationHandle.

BUG=404982
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker

Review URL: https://codereview.chromium.org/496983002

Cr-Commit-Position: refs/heads/master@{#292110}

This patch adds libpdf.so to whitelisted plugins so that
it can use histograms. Without this patch, an error is
displayed every time when Chrome is launched with OOP PDF flag
and PDF file is opened.

BUG=405305

Review URL: https://codereview.chromium.org/508543002

Cr-Commit-Position: refs/heads/master@{#292109}

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/510673002

Cr-Commit-Position: refs/heads/master@{#292108}

https://skia.googlesource.com/skia/+log/d3f6e893df53fb0cfeefd01a8a49a77c72d742bd..5e8dbd31de0dff44aff83295bdfe518477a5a088

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/506403002

Cr-Commit-Position: refs/heads/master@{#292107}

Reland of 2da192af after:
- disabling some layout tests that need to be rebaselined
- landing 6cce6b78f "Decouple script_url from ServiceWorkerRegistration"
so Registration doesn't get in a weird state with a script_url that failed to
register

Before this patch, register() would delete an existing registration at
the scope if the script URL didn't match, and register a new one. This
overwriting creates a scenario where old tabs have a different
controller than new tabs, which the Service Worker spec avoids.

This patch implements the spec steps for same-scope, new script
register(). That means:
- If the existing registration is uninstalling, wait for that to
complete before doing anything.
- Create a new worker which becomes the installing worker of the
existing registration.

BUG=398355
TEST=https://codereview.chromium.org/480943002/

Review URL: https://codereview.chromium.org/506043002

Cr-Commit-Position: refs/heads/master@{#292106}

TBR=thestig
BUG=407904

Review URL: https://codereview.chromium.org/504253003

Cr-Commit-Position: refs/heads/master@{#292105}

This change adds DataSource and DataSink interface request parameters to
SerialService::Connect, passes them through to SerialConnection
instances via SerialConnectionFactory; the SerialConnection now uses a
DataSourceSender and a DataSinkReceiver for implementing serial receive
and send, respectively.

BUG=389016

Review URL: https://codereview.chromium.org/488363002

Cr-Commit-Position: refs/heads/master@{#292104}

BUG=405354
TEST=about:gpu page for Win/NVIDIA with driver version forced to "", gpu_unittests
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/503243002

Cr-Commit-Position: refs/heads/master@{#292103}

This includes some minor changes which allow tests to when NPObject is replaced
by gin in pepper:
-Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in
tests.
-Add gin as a dependency to content_unittests for use in host_var_tracker_unittest
-Change TestInstanceDeprecated so that it doesn't execute a script from the
ScriptableObject upon destruction. The reason for this is that the garbage
collector is manually run from the destructor of the plugin Instance object.
This results in destruction of the ScriptableObject and then javascript is
re-entered via ExecuteScript. This should never happen outside tests because
the garbage collector won't be run synchronously. Instead of running
ExecuteScript, which just set a variable in the Instance object to verify
that the ScriptableObject was correctly destroyed.

BUG=351636

Committed: https://chromium.googlesource.com/chromium/src/+/92c3074f4b4417924115f880657f1ec15da0e0ba

Review URL: https://codereview.chromium.org/472693002

Cr-Commit-Position: refs/heads/master@{#292102}