GitLab

BUG=none
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10827080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149216 0039d316-1c4b-4281-b951-d872f2087c98

On Windows XP and Vista, new windows don't indicate activation on the taskbar.
(the window buttons should look "pressed" on launch and new window)
This regression was introduced by http://crrev.com/104051

Limit the original fix for http://crbug.com/90386 to Windows > Vista.

BUG=90386,123473
TEST=New Chrome window appear "pressed" on the taskbar on Vista and XP. No regressions (especially not of crbug.com/90386)

Review URL: https://chromiumcodereview.appspot.com/10826058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/10807038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149214 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149213 0039d316-1c4b-4281-b951-d872f2087c98

This picks up support for None entries, which is needed for iOS.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10824109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149212 0039d316-1c4b-4281-b951-d872f2087c98

This is to make 'git clean' a no-op.

BUG=

Review URL: https://chromiumcodereview.appspot.com/10837024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149211 0039d316-1c4b-4281-b951-d872f2087c98

Add RPH use for said notification to clear the setting affordance from the location bar.

R=bauerb@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10821059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139680
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10824110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149209 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the test case to compare SkPMColor between SkPMColor, rather than SkColor.

BUG=138933
TEST=ui_unittests --gtest_filter=PNGCodec.EncodeBGRASkBitmapDiscardTransparency

Review URL: https://chromiumcodereview.appspot.com/10831031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139819
Review URL: https://chromiumcodereview.appspot.com/10823066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149207 0039d316-1c4b-4281-b951-d872f2087c98

In FileManager when clicking on the current root while viewing the top directory, do nothing (instead of rescanning the directory).


BUG=137985


Review URL: https://chromiumcodereview.appspot.com/10834087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/chromeos_login.py
R=nirnimesh@chromium.org
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10824096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149205 0039d316-1c4b-4281-b951-d872f2087c98

1. Add option to suppress logging to omit sensitive information.
2. Change debug output to longMsg to aid debugging.

BUG=137853


Review URL: https://chromiumcodereview.appspot.com/10823093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=happier dominic


Review URL: https://chromiumcodereview.appspot.com/10824111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149203 0039d316-1c4b-4281-b951-d872f2087c98

R=gavinp


Review URL: https://chromiumcodereview.appspot.com/10829090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10816040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149198 0039d316-1c4b-4281-b951-d872f2087c98

BasicStartupComplete is not invoked for browser tests

BUG=none
TEST=no complaints about MainMenu not found when running content_browsertests on mac


Review URL: https://chromiumcodereview.appspot.com/10843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113688


Review URL: https://chromiumcodereview.appspot.com/10836029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149196 0039d316-1c4b-4281-b951-d872f2087c98

This is a barebones implementation of the skia target in skia.gyp.  iOS will not
use a full skia implementation, but it will use an occasional header here and
there.  Those headers require an implementation of SkDebugf_FileLine(), so this
CL adds a barebones skia target that simply compiles skia/ext/google_logging.cc.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10832081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149193 0039d316-1c4b-4281-b951-d872f2087c98

extension from the webstore. Without that, webstore-specific permissions
checking doesn't happen, notably, whitelisted extensions requesting the
"experimental" permission (e.g. Accessibility Developer Tools) can't be
installed without enabling experimental APIs in about:flags.


Review URL: https://chromiumcodereview.appspot.com/10834082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149190 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10835027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149189 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149188 0039d316-1c4b-4281-b951-d872f2087c98

* r9294 requires removing 'pylib' from DEPS.

This pulls in the following Native Client changes:

r9278: (kschimpf) Add tzcnt as an acceptable instruction to x86-64 validator
r9279: (kschimpf) Fix macros NC_EXPECT_EQ_PRECOND and NC_EXPECT_NE_PRECOND.
r9281: (kschimpf) Add tzcnt as an acceptable instruction to the x86-32 validator
r9282: (mseaborn) x86-64: Remove one hard-coded numeric offset into NaClThreadContext
r9283: (phosek) Check of memory mapping consistency for all supported OSes.
r9284: (jvoung) Handle another case where we cannot search for bugs, from 9254.
r9285: (mseaborn) Thread suspension test: Refactor how we set and check register state
r9287: (khim) Handle most REX prefixes
r9288: (mseaborn) Introduce #defines for the offsets of NaClThreadContext fields
r9289: (dschuff) Do qemu sandboxed translator tests sequentially
r9290: (kschimpf) Clean up super_cop table in Arm validator.
r9291: (khim) Fix precise_64-newlib-x86_64-pnacl bot
r9292: (khim) Fix precise_64-newlib-x86_64-pnacl bot - try2
r9293: (dschuff) Update archived toolchain test rev to 8851
*r9294: (bradnelson) Moving third_party/pylib/* to third_party/.
r9296: (bsy) code clean up and commenting: remove printing sockaddr
r9297: (ncbray) Remove a redundant dependency from a broken test
r9298: (mseaborn) Add a test for the registers reported for a thread suspended in a syscall
r9299: (mseaborn) Make the thread_create() syscall responsible for aligning the stack pointer
r9300: (pasko) Validator refactoring: define NaClCopyInstruction() for x86/arm separately
r9301: (halyavin) Update gdb revision.
r9302: (khim) Fix xchg instruction.
r9303: (robertm) Fix readelf and size usage in preparation for
r9304: (robertm) Remove unused readelf and size binary from newlib/bin directory in the pnacl toolchain
r9305: (khim) Fix small typo in ragel_tester.c
r9306: (khim) Fix memory leak in enuminst
r9308: (kschimpf) Fix table ext_reg_move table in ARM validator.
r9309: (jvoung) Bump pnacl toolchain rev to 9299.
r9311: (bradnelson) Exclude pnacl/src dir from checkdeps for now.
r9312: (jvoung) Remove use of mozrunner in browser tester
r9313: (robertm) Fix dangling reference to size tool in pnacl toolchain build.
r9314: (mseaborn) Testing: Move register_set.h into a new tests/common directory
r9315: (jvoung) Bump pnacl llvm rev to pull in byval + vararg change:
r9316: (mseaborn) Remove the nacl_sys array and the "sys" instance of NaClThreadContext
r9317: (mseaborn) Testing: Simplify untrusted assembly code used for saving x86 flags

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10829093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149187 0039d316-1c4b-4281-b951-d872f2087c98

Follow up from:
http://codereview.chromium.org/10826071/
Build and install content shell on all attached devices.

BUG=139365
TEST=Android FYI tester runs instrumentation tests.


Review URL: https://chromiumcodereview.appspot.com/10825100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155
TBR=mark@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10821107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132684

Review URL: https://chromiumcodereview.appspot.com/10832071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155
TBR=mark@chromium.org
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/10834086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149183 0039d316-1c4b-4281-b951-d872f2087c98

Replace yellow outline from focused searchbox with blue border. Replace yellow outlines with blue ones for buttons and rename input. Replace the default search cancel button with the custom one.

BUG=137995,137996,137997
TEST=

Review URL: https://chromiumcodereview.appspot.com/10826082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149182 0039d316-1c4b-4281-b951-d872f2087c98

This broke the WebKit Mac bot, as the directory it works in is different there
compared to the Chromium configuration. Determine the source's root through the
DEPTH define, and then walk up in the build/mac/ directory.

BUG=
TEST=WebKit Mac builder doesn't break after a Chromium DEPS roll.


Review URL: https://chromiumcodereview.appspot.com/10824105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155
TEST=no
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10575037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149180 0039d316-1c4b-4281-b951-d872f2087c98

We used to show different messages when opening unsupported files from the Files app and from the Downloads page. I made them more similar, although the one displayed from C++ does not have links because the standard warning dialog does not support HTML.

BUG=139523

Review URL: https://chromiumcodereview.appspot.com/10828092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108997


Review URL: https://chromiumcodereview.appspot.com/10826061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10829100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149177 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10828091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149174 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10829038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139772
TBR=kbr

Review URL: https://chromiumcodereview.appspot.com/10843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139365
TEST=Android FYI tester runs instrumentation tests.


Review URL: https://chromiumcodereview.appspot.com/10826071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130466


Review URL: https://chromiumcodereview.appspot.com/10832036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149170 0039d316-1c4b-4281-b951-d872f2087c98