GitLab

Using wpt-import in Chromium 440da23e.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
dcheng@chromium.org, palmer@chromium.org:
  external/wpt/domxpath
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I1609fa65bef8cce4e600c21611af0adce18b1526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033483Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737538}

Currently, Chrome uses application context when it creates
ContentView because it needs to reparent the view across different
activities.

Since it is not using activity context, and it seems quite challenging
to refactor the codebase to do so, we are landing this as a short term
workaround. The workaround consists of the following:

1) Pass WindowAndroid into IMMWI, and try to get activity context, only
   for Chrome.
2) Call setLocalFocus(true, true) only for showing keyboard.
   (jinsukkim@'s idea)
3) Wait for input connection to be established
   (yukawa@'s idea)

The rest are just plumbing work.

Manually tested the following on physical device and emulator:

1) activate IMEs between omnibox and content
2) activate and deactivate IMEs by touching inside and outside input
   box
3) move ChromePublic between displays and activate IMEs

Also, manually tested that this works on WebView.

Bug: 1021403

Change-Id: Ia952f76e2fb1afef073825435ab4569bcded6762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994393
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737537}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2a397db501d..1ab87e04c957

git log c2a397db501d..1ab87e04c957 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 chrche@microsoft.com Fixed localization presubmit command line too long error

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@1ab87e04c957

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:941561
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib748032d28af476f9b71b991625b9314e8febbbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033600Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737536}

This reverts commit 0744e76c.

Reason for revert: Suspect CL in causing compile errors on
ios-device-xcode-clang and ios-simulator-xcode-clang builders.

https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/121716
https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-xcode-clang/98510


Original change's description:
> [base] Use dummy class to avoid superfluous initialization in Optional
> 
> The initialization of "char empty_" union-member in Optional is
> redundant and causes the compiler to generate extra code to ensure
> zero-initialization. Using an empty Dummy class for the union member is
> more optimal, since it guarantees that no code for its initialization is
> generated.
> 
> Explicitly touching this char member in the constructor also causes a
> problem for conservative GC. Compiler is free to split shared and not
> shared parts of the union in separate memory locations on stack (or keep
> them in different registers). If a conservative GC is triggered at this
> moment, stack scanning may not find the correct object (this is exactly
> what happened in the bug 1044331).
> 
> This can be tested in a minimized example: https://godbolt.org/z/t5q5ry.
> 
> Bug: 1046776
> 
> Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948
> Commit-Queue: Anton Bikineev <bikineev@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737494}

TBR=gab@chromium.org,fdoray@chromium.org,mlippautz@chromium.org,bikineev@chromium.org

Change-Id: I6a1f3a20d2c19716f51a45a4a1bb0bcafb7a558a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033439Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737535}

Add SmartBatteryInfo to store Smart Battery information. Update
DeviceStatusCollector to correctly include this info in the
DeviceStatusReportRequest.

Bug: 1026848
Change-Id: I00951bc8c4ef7e2acdd5f5371108e3d10993f76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028261Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737534}

Per bcwhite@'s instructions on crrev.com/c/2015832, this CL removes the
unnecessary enum and now matches the "BooleanMigrated" in
histograms.xml.

Bug: chromium:730242
Test: sync tests pass
Change-Id: I1fad2ef07cf428160fc3e284a94439568728211d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025869Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737533}

It calls MigrateShortcutsInPathInternal several time and each call may
or may not load DLL's, so the whole thing needs to be in the foreground
in case it needs the loader lock.

R=gab

Bug: 1047442
Change-Id: Id962af6556e312bf638066e33268fe4902e0110f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032005Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737532}

This creates an EG2 test suite for Translate for the new Messages UI.
Many tests are either direct copies or similar to those found in
TranslateTestCase. Some of them were also not moved over, because they
do not apply to the new Messages design.

Bug: 1014959
Change-Id: I3e8c5865686f23f500a31902dbfd60fe225bda6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027127
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737531}

This reverts commit 46b1cc8c.

Reason for revert: was not the cause of the flaky crashes. See anglebug,com/2273 .

Original change's description:
> Revert "Remove three flaky suppressions on Mac NVIDIA WebGL"
> 
> This reverts commit 2a085af2.
> 
> Reason for revert: 5 GPU FYI bots started failing after this (extremely mysteriously, because this shouldn't affect them this way)
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20Intel/98243
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Release%20%28Intel%29/19387
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20AMD/96734
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/20055
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20GPU%20ASAN%20Release/14113
> 
> Original change's description:
> > Remove three flaky suppressions on Mac NVIDIA WebGL
> > 
> > These tests are no longer flaky
> >  conformance/ogles/GL/exp2/exp2_001_to_008.html (WebGL 1 and 2)
> >  conformance2/textures/canvas/tex-3d-rg16f-rg-float.html
> > 
> > Bug: 923080
> > Change-Id: Ibc0e4b488779a0843a787acacac6c9544e34c50f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029260
> > Auto-Submit: Austin Eng <enga@chromium.org>
> > Commit-Queue: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#737052}
> 
> TBR=kbr@chromium.org,enga@chromium.org
> 
> Change-Id: I92cc1297bd71bc82b8e22662e58affe53b40ad6c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 923080
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033626
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737412}

TBR=ccameron@chromium.org,kbr@chromium.org,enga@chromium.org

Change-Id: Ib9d24c670f4f4d91f78e7b3696d571d4dcab1201
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 923080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033914Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737530}

Why: We’d like to learn where and how often they are used.

How: In LocalFrameView::RunIntersectionObserverSteps, fire a hit test
event in the center of the main frame with a 1 second interval. We check
the style of the returned element and its container elements, to see
whether it is immobile to scrolling and if it can overlay with other
contents in the page.

Bug: 1032681
Change-Id: I18acd22a7972a1e4ca361a7c466aa20705844dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993140
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737529}

Switches the heuristic that GPU Gold tests use to determine if they're
running on a workstation or not. Previously, it checked for the presence
of a git repository, but is now checking for the presence of the
SWARMING_SERVER environment variable. This is the heuristic that will
be used in other test types as they get switched to use Gold.

Also removes the RunInChromiumSrc context manager that was being used to
run the git commands, as it's simpler to just pass cwd to subprocess.

Change-Id: If1b2fdf2ebda355319359d80017b25e24bb07d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033637Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737528}

Using test TaskEnviroment's built-in mock timer and task runner.

Bug: None
Test: run unit tests
Change-Id: I47ee9f3366298fa07cbfe56a06674a5f6932db49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033817Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737527}

https://android.googlesource.com/platform/external/perfetto.git/+log/22ab8b24f234..d4073a3e9ecf

git log 22ab8b24f234..d4073a3e9ecf --date=short --first-parent --format='%ad %ae %s'
2020-01-31 primiano@google.com Suppess ServiceWorker errors

Created with:
  gclient setdep -r src/third_party/perfetto@d4073a3e9ecf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:147015767,chromium:148675312
Tbr: perfetto-bugs@google.com
Change-Id: Ie68ac01b311f33aa1a47a6665341c0d8a36b4aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033596Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737526}

This is needed to fix the "Build From Tarball" bot:
https://ci.chromium.org/p/infra/builders/cron/Build%20From%20Tarball

R=thakis

Bug: 1047860
Change-Id: Id41ebee75dc760580b1d2334dffcbb5fc2004f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033904
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737525}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d67872733ec..42a51f6af195

git log 4d67872733ec..42a51f6af195 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 tvanderlippe@chromium.org Enable Javascript formatting by default

Created with:
  gclient setdep -r src/third_party/depot_tools@42a51f6af195

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I9864f318ce68bd029319b8c274e2251c95350d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033593Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737524}

https://skia.googlesource.com/skia.git/+log/c0c0522e8076..4513cdde4912

git log c0c0522e8076..4513cdde4912 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 herb@google.com Rename flush -> issueDrawMaybeInlineUpload
2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@4513cdde4912

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: I775eeea35657092c86849e996af3d8608f0dc781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033597Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737523}

If we erase all of the history we should reset the
entire Media History database. We do this by deleting
the database and creating a new one.

BUG=1024352

Change-Id: I14589cdee5ed8b807d0463f1efb5ccfb6d7e7d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990218
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737522}

Add cc_unittests to the fuchsia_gtests test suite.
Create an exception so that it doesn't run on Fuchsia CI bot.

Bug: 1041160
Change-Id: Ie8dedb172085fad735155ac657a4e38f493e1e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025992Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#737521}

This will be used in a follow-up CL to support storing native file
system handles in IndexedDB.

Also slightly simplify how BlobStorageContext is plumbed through the
IDB code, addressing some of the follow-ups from
https://chromium-review.googlesource.com/c/chromium/src/+/1994009

Bug: 955193
Tbr: avi@chromium.org
Change-Id: I00038ad4a058c492ba9c53038a6effbed89ec639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026507
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737520}

This CL removes the "time" role description for <time> elements on
Android. Anything with ax::mojom::Role::kTime will no longer
have a role description explicitly set. Unit test expectations
are updated as well.

Bug: 1043377
Change-Id: I05c184244b84783b9ed4afc615e1e534a346a67a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032059
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737519}

When an extension message is received, we check `MessageSender.id` to
disallow requests from unknown clients.  Unfortunately,
`MessageSender.id` is currently not trustworthy (issue 982361) and
therefore this CL switches to using `MessageSender.origin` instead.

Bug: 10321587
Change-Id: I3729a407bef47e5ca4212ee3fe748b89c8d16a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031526Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737518}

This adds a new (internal) mojo interface that will be used by IndexedDB
code (in the Storage Service process) to talk to Native File System code
(in the browser process) to serialize and deserialize handles.

Bug: 955193
Tbr: pwnall@chromium.org
Change-Id: I01aad3db0787483caff11f94904eda00829c6033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025950
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737517}

Bug: None
Change-Id: I53fd720e73d6c68a9264cc153a65fea5ff3dba4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033631
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737516}

This reverts commit 86a3bbcd.

Reason for revert: talked with jpor@ more about this. Looks like
miscommunication regarding what a 'disabled' element is;
jpor@ clarified he meant 'non-interactive' elements, which is a
secondary color tint for icons. we don't have this explicitly available, so may need to address this separately.

the cl that cleans up color definitions is in flight (https://crrev.com/c/2031754), hopefully will land soon. meanwhile
let's revert this for M81 branch

Original change's description:
> Clean up use of explicit suggestion tint colors.
>
> Synced with jpor@ to learn why these colors are different and what
> these should be. Apparently these colors are intended to be the
> "disabled" color values, which was not immediately obvious.
>
> Bug: 1028397
> Change-Id: I20a0f8b9fe3f23dcaf9335961ec89ed411f2caad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021330
> Commit-Queue: Ender <ender@google.com>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735523}

TBR=tedchoc@chromium.org,ender@google.com

Bug: 1028397
Change-Id: I41b6161549a8cc908aa0b75a0a2e1b6d53bfc2ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033756Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ender <ender@google.com>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#737515}

If, while a PDF is loading, an extension injects elements into the top-
level HTML's DOM such that a new RenderFrame is created, this new frame
can confuse existing code in MimeHandlerViewEmbedder::RenderFrameCreated
and cause it to early out.

This CL guards against that by making sure we (i) check that the newly
created frame is an <embed>, and (ii) that it is the correct <embed>.
We achieve the latter by making sure the embed's name attribute matches
the unguessable internal id we're using for the PDF extension's <embed>.

TBR=ekaramad@chromium.org

Bug: 1046795
Change-Id: I6a7d32ce6269a18fac14586b3298a59688230b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033636Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737514}

Remove app_modal_strings.grdp, which was left behind as a workaround
for a presubmit bug.

Bug: 1047487
Change-Id: Idd906bc9d1ec127f442925f0399af41911064d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033696
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737513}

The test is failing when an entry is unexpectedly not in the DNS cache,
this CL adds some logging to the test and to the host cache, and
re-enables the test, to help diagnose the failures that are happening
on the bots.

Bug: 1042354
Change-Id: I6b241a279aafc7a65a20aaae510d96dd0c2576fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033546
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737512}

Also add a note saying it can be dismissed with a click.

Bug: 1041809
Change-Id: I193c111666c340f9b064a023fbee9e08e1b55ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033635Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737511}

When chromedriver is built with a dynamically linked ffmpeg on macOS
we need to set the rpath so that ffmpeg.dylib is loaded correctly.

Change-Id: I204810ac8610375aa8b0a2e7fae78464c1a3371e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033343Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737510}

Host resolution will soon use per-context result tracking for the DoH
activation probes.  ContextHostResolver now owns a ResolveContext that
gets passed around in place of raw URLRequestContext to everywhere that
will need access to per-context data (probe results, DoH server
availability, server stats, etc).

Minor behavior change because JobKey now contains ResolveContext. This
means that requests from two different ContextHostResolvers will never
be merged into the same job, even if both are given the same
URLRequestContext. This shouldn't make a difference in practice because
we only create ContextHostResolvers 1:1 with URLRequestsContexts.

Bug: 1022059
Change-Id: Ia9b7bd4d1055630dbfdab627429638bb5f63eb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002899
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737509}

Expand message center / quick settings bubble when it gains
accessibilityfocus.
Allow quick settings to collapse / expand with chrome vox enabled.

Bug: 1047538
Change-Id: I50626e7116ee51cd35f99199715501c6cb504d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032508Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737508}

This is slightly less verbose now, but mostly will be convenient in the
future if/when updating things about the flex rule calling convention.

Bug: none
Change-Id: I59e41714abf2d23290e56350c0daa83f71419a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026588
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737507}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f18fddd279d2..9b0c794156ba


Created with:
  gclient setdep -r src-internal@9b0c794156ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1046904
Tbr: jbudorick@google.com
Change-Id: I3854b0b85c20f9f62c43d8219edd820e0e5d56de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033594Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737506}

With the release of the cardholder name fix flow on iOS and conflicts
with Project Butter resolved in M76, we finally have feature parity
across all platforms and can enable this feature by default client-side.

Change-Id: I7ab9779188c3a1d913b998554568a6e03ef53415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017911Reviewed-by: Manas Verma <manasverma@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#737505}

The identity disc visibility is set to gone on sign out.
After it is set to gone, it is not considered onLoayout, but it keeps
its position and size. Therefore the gone view will be hanging around
the middle of the screen in landscape and overlay with the logo.

Now we only consider views that are not GONE when determining whether the
logo intersects with any sibling view.

Bug: 1044914
Change-Id: I3b79119c3f6dad002a0cc8366677447b0146e1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020889
Commit-Queue: Mia Glaese <glamia@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737504}

In some scenarios (e.g. http range requests for linearized PDFs) the PDF
plugin may need to initiate requests on behalf of the PDF's origin.
Such requests are currently proxied by the renderer process hosting the
plugin (i.e. the renderer hosting the PDF extension -
mhjfbmdgcfjbbpaeojofohoefgiehjai) and therefore go through
URLLoaderFactory that is locked via request_initiator_site_lock to a
different origin (i.e. the origin of the PDF extension, rather than the
origin of the website that hosts the PDF file).

Before this CL, such requests would be classified by
CorsURLLoaderFactory::IsSane and
VerifyRequestInitiatorLockWithPluginCheck as incorrect and possibly
malicious.  After this CL, the request_initiator checks are relaxed by
PluginServiceImpl::FindOrStartPpapiPluginProcess using a new mechanism
similar to AddCorbExceptionForPlugin exemption available for Flash.

We don't want to relax request_initiator_site_lock checks for renderer
processes hosting arbitrary origins from the web, so as a
defense-in-depth the CL adds a CHECK to FindOrStartPpapiPluginProcess
that verifies the origin lock of the renderer process that is granted
the extra capabilities.

Relevant tests:
- ChromeFindRequestManagerTest.FindInChunkedPDF (tests that range
  request do not result in a request initiator lock mismatch)
- PDFExtensionTest.EnsureInternalPluginDisabled (tests that the PDF
  plugin may only be embedded in trustworthy contexts)
- PDFExtensionTest.RedirectsFailInPlugin (the 'noRedirectsSucceed' testcase
  tests non-range requests initiated by the PDF plugin)

Bug: 1027173b
Change-Id: Ib5111fd7a5d5b31727a9754c46c316e75def5143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986923
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737503}

[ This is a reland of https://crrev.com/c/1970834 + changes that remove
  a redundant test in //chrome/browser/portal/portal_browsertest.cc (see
  CR comments).  Original CL description follows below. ]

Tab contents may get focused during some renderer-initiated navigations
(e.g. navigations from an NTP-replacement extension - see the regression
test added in r723022).  This CL ensures that the focus decision is
applied not only to navigations that go through OpenURL, but also to
navigations that go through (more freqeuent, usual) BeginNavigation.
This change helps ensure that we retain the right focus behavior after
more navigations switch to the BeginNavigation code path (e.g. after
relanding ShouldFork removal in https://crrev.com/c/1949448).

The CL covers both the OpenURL and BeginNavigation code paths by
handling the focus decisions in a newly added TabContentFocusingHelper
class (replicating/moving the focus decisions from OpenURL-only
Browser::UpdateUIForNavigationInTab).  Adding a new tab-helper class is
useful, because the existing, OpenURL/BeginNavigation-shared navigation
notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot
distinguish between replaceState and new navigations (see also new steps
in the OmniboxFocusInteractiveTest.NtpReplacementExtension test).

While this CL changes how focus behavior is implemented, it should have
no effect on end-to-end/high-level expectations of focus behavior (as
observed by end users or browser tests).

browser_tests do not guarantee window activation and/or focus, but
before this CL navigation in browser_tests would focus WebContents.
This is not happening after this CL, and requires moving a handful of
focus-dependent tests from browser_tests to interactive_ui_tests.

Bug: 1029161
Tbr: Karan Bhatia <karandeepb@chromium.org>
Tbr: Rouslan Solomakhin <rouslan@chromium.org>
Tbr: Brian Sheedy <bsheedy@chromium.org>
Tbr: Bill Budge <bbudge@chromium.org>
Tbr: Peter Kasting <pkasting@chromium.org>
Tbr: Charlie Reis <creis@chromium.org>
Change-Id: I7324e7ecb08a51601b12fba3f57c68af59f33128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024155Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737502}

This is a follow up to rename refactor in cl/2007319 to rename the
corresponding test class for TranslateAgent.

No functional changes.

Bug: 1043351
Change-Id: I06db57f2b07c603f769e6dd4c8d9cda2f163659d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031191Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737501}

This completes the provision of reasons for all lifecycle updates. The
next round of patches will use this information for UKM data and emit UMA
for the most important reasons (particularly hit testing).

A best effort has been made to associate the true reason, though in some
cases code is used by multiple paths so there is some ambiguity. For metrics
purposes that is unlikely to matter as it will still allow us to identify
a small set of sub-systems for any performance regression.

Bug: 902436
Change-Id: Iaff728a6fdf407af3c7cb70b81290553a59df2bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033429Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737500}

Fixed: 1040844
Change-Id: I99dea98fa8568b135b74e577004af4ed61fde731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031927Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737499}