GitLab

Review URL: http://codereview.chromium.org/149293

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20104 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149291

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/13967

Review URL: http://codereview.chromium.org/155183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20102 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/149295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20100 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16149
Review URL: http://codereview.chromium.org/155182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20099 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam
Review URL: http://codereview.chromium.org/149289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20098 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20097 0039d316-1c4b-4281-b951-d872f2087c98

Sprinkle some defensiveness into the UI tests so that they don't explode if the proxy doesn't respond (e.g., due to a timeout).

BUG=none
TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking).
Review URL: http://codereview.chromium.org/149281

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98

Allow keyboard and mouse navigation between the two while one is open.

BUG=none
TEST=the page and wrench menus feel like a native menubar

Review URL: http://codereview.chromium.org/155164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20095 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for an initial set of WAI-ARIA roles, needed to support screen readers in AJAX web applications (e.g. Gmail).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/149265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20094 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20093 0039d316-1c4b-4281-b951-d872f2087c98

Fix a typo.

CID=2001
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20092 0039d316-1c4b-4281-b951-d872f2087c98

I mvoed the implementation of the previously-inline amimate function to the .cc file so we don't have to depend on STL includes in the header.

Review URL: http://codereview.chromium.org/155170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16094
TEST=Open the task manager in Linux.  Make sure the task manager treeview has a frame around it.
Review URL: http://codereview.chromium.org/149286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20090 0039d316-1c4b-4281-b951-d872f2087c98

removed when we maximize/go full screen.

BUG=15317

Review URL: http://codereview.chromium.org/155169


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20089 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=26088

Add in the test output for LayoutTests/fast/text/text-letter-spacing.html
(platform-specific output for https://bugs.webkit.org/show_bug.cgi?id=26088).
Chromium-mac matches the output in platform/mac from webkit.

R=darin
BUG=https://crbug.org/10977
TEST=none

Review URL: http://codereview.chromium.org/155162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20088 0039d316-1c4b-4281-b951-d872f2087c98

Move printing related stuff to the root printing project from the browser project.  This simplifies further refactoring and eases understanding of the printing part of Chrome.
Also renamed win_printing_context to printing_context_win (correct naming convention) and added stub implementations for _linux and mac.
Now all but one file is compiling on all platforms.

TEST=none (no functional change).
BUG=none

Review URL: http://codereview.chromium.org/149212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20086 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Open popuptest.com in one tab and anything else in another. Switch between
GTK theme and normal. Theme of blocked popup container should change, even when
not the active tab.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/149277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20085 0039d316-1c4b-4281-b951-d872f2087c98

(The interstitial is displayed on top of an existing page. We don't want the hidden page to interfere with the interstitial.)

BUG=http://crbug.com/3256
TEST=Open the page attached in the bug (interstitial_test.html), no alert boxes should show.
Review URL: http://codereview.chromium.org/149261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20084 0039d316-1c4b-4281-b951-d872f2087c98

This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager.

BUG=15881
R=mpcomplete

Review URL: http://codereview.chromium.org/149161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20083 0039d316-1c4b-4281-b951-d872f2087c98

here is warranted.  I failed to translate this over when adapting this code to
the new interfaces.

The tight coupling with WebView, WebFrame and WebViewDelegate makes this code
non-trivial to test.  My next patch was anyways to remove those dependencies.
I'll circle around at that point with some unit tests for these classes.

R=brettw
TEST=none
BUG=16144

Review URL: http://codereview.chromium.org/155166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20082 0039d316-1c4b-4281-b951-d872f2087c98

Origin issue: http://codereview.chromium.org/150122

B=16052,12745
TBR=brettw

Review URL: http://codereview.chromium.org/155157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20079 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20077 0039d316-1c4b-4281-b951-d872f2087c98

Testing to see if this is the reason we hit the CHECK(!group_name_.empty()) in ClientSocketHandle::GetLoadState().
BUG=http://crbug.com/15374
TEST=none

Review URL: http://codereview.chromium.org/155150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20076 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20075 0039d316-1c4b-4281-b951-d872f2087c98

Enable build dependency checking for dpkg-buildpackage so that we get a better error if there are missing dependencies. (I thought this was on by default already, but it turns out that adding -a turns it off by default.)

Review URL: http://codereview.chromium.org/149275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20074 0039d316-1c4b-4281-b951-d872f2087c98

Gears 0.5.25.0.  Has been verified by QA. Should be merged into beta and stable channel for a future release.

M    binaries/gears.pdb
M    binaries/gears.dll


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20070 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=14931
TEST=none.
Review URL: http://codereview.chromium.org/155159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20068 0039d316-1c4b-4281-b951-d872f2087c98

We still have a few crashes when for some reason we believe
an entry is not dirty and we follow the pointer stored by
its rankings node only to crash while accessing the memory.
I have no explanation to why the dirty id matches the current
one (a page boundary issue maybe?), but having a map with all
open entries solves the issue of having to follow pointers
from disk.

BUG=15596, b/1120346
TEST=unittests

Review URL: http://codereview.chromium.org/149218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20067 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=maruel

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20066 0039d316-1c4b-4281-b951-d872f2087c98

from a web page, and always run it through valgrind once no matter
how perfect it is visually.

Review URL: http://codereview.chromium.org/149271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20064 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15892
TBR=ojan
Review URL: http://codereview.chromium.org/149269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20062 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run the browser tests with the --gtest_also_run_disabled_tests flag. Disabled tests should be run.
Review URL: http://codereview.chromium.org/155112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20060 0039d316-1c4b-4281-b951-d872f2087c98

Issue #1) creating HTML by string is fast in all browsers.
Creating HTML by DOM methods is extremely slow in IE. 100-300x slower.

http://www.quirksmode.org/dom/innerhtml.html

Issue #2) There's a bug in IE related to <select> tags.

http://support.microsoft.com/kb/276228


Review URL: http://codereview.chromium.org/155154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20059 0039d316-1c4b-4281-b951-d872f2087c98