- 15 Nov, 2018 40 commits
-
-
Ken Rockot authored
We underestimate the total size of a message carrying arrays with struct elements. This fixes that. Bug: 905529 Change-Id: Ib05fa52e42d850c3ebe38bd4f716f7c1327e4cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1336779Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#608246}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ccb751a21b7d..5c1d38395f19 Created with: gclient setdep -r src-internal@5c1d38395f19 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idbcd9367eb0e4ccffc150dfd72325e25a8a65dd7 Reviewed-on: https://chromium-review.googlesource.com/c/1336923Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608245}
-
Hiroki Nakagawa authored
Nested dedicated workers has been enabled by default since Chrome 69: https://www.chromestatus.com/feature/6080438103703552 Bug: 31666 Change-Id: I12785dd8c1d5582ae0d069b5b6993ad50c6be9b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325596Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#608244}
-
Charles Zhao authored
Changes made in this CL: (1) new preprocessor_config.pb and new native_inference weights. (2) the native_inference.cc logic is also changed a bit because new quantized model does not have dequantization any more. (3) only kept 'score tests' to confirm this model returns same result as the model trained in google3. Other 'expectation tests' are all removed, because we have to fix them for every new model. Instead we do a full feature analysis before submit the model to verify that. Bug: 902196 Change-Id: I3dd4382f750b9216369c7de14edd9c692cf6db71 Reviewed-on: https://chromium-review.googlesource.com/c/1319209 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608243}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d2aae3165a2..3da725065a5f git log 7d2aae3165a2..3da725065a5f --date=short --no-merges --format='%ad %ae %s' 2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@3da725065a5f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I93ef7c7c0a21fc258635661a44dd490d464a45d8 Reviewed-on: https://chromium-review.googlesource.com/c/1336922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608242}
-
Akihiro Ota authored
Added functionality for AXNode::PosInSet(), which determines a node's position within an ordered container, and AXNode::SetSize, which determines the total number of elements within the node's container. Change-Id: Idd1849891db8cb96c30edda4d4b85b9a206220f2 Reviewed-on: https://chromium-review.googlesource.com/c/1336327 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608241}
-
David Tseng authored
This changes does the bulk of the work to stitch together all of the public surface a UI component needs to expose a list of braille displays: - connect/disconnect/forget operations - device change, pincode request notifications - finish pairing response - management of a single preferred display connection ChromeVox will keep an explicit list of braille display device names. This appears to be the same strategy used by all other clients of Brltty, including NVDA, and BrailleBack. This list is currently not complete, during the initial phase of this feature. Bug: 882261 Test: new test suite added. Manually tested. Change-Id: I033c6ce6425421db26ad04a1af8f04a04a9e8a47 Reviewed-on: https://chromium-review.googlesource.com/c/1335946Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#608240}
-
Stuart Langley authored
As requested by Drive SRE these changes reduce the frequency of requests on the drive back ends, and also lessens the likelihood of convoying. 1. When XMPP is connected, change the poll timeout for changes from 5 minutes to between 60 & 120 minutes. 2. When XMPP is disconnected, change the poll timeout for changes from 1 minute to between 1 and 2 minutes. This issues start page token requests which are cheap for the drive back ends. 3. When batching XMPP notifications, change the batch time from 5 seconds to between 15 and 30 seconds. This reduces the QPS on drive back ends when a team drive change notification is broadcast to a large corpus of users, and prevents convoying of requests by introducing jitter. Bug: 905201 Change-Id: I5310d956c9ccb5b59261cdf99bbefb515f75771f Reviewed-on: https://chromium-review.googlesource.com/c/1336949Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#608239}
-
Hitoshi Yoshida authored
IDL compiler did not work for cases that have multiple values separated with ', '. For example, we couldn't specify "Exposed=(Window, Worker)". This CL fixes for Exposed cases, thus we will be possible to use "Expose=(Window, Worker)". This change works only for Expose attributes, because it is handled separately, and it would be a huge change if we work for general cases. Bug: 904326 Change-Id: I33bc09d96c1dd1afdd29850300add30687fa9d3b Reviewed-on: https://chromium-review.googlesource.com/c/1331292Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#608238}
-
Sergey Berezin authored
A previous luci-go roll was introduced in https://crrev.com/c/1333093 but that git_revision hash doesn't exist for all packages. Bug: 905218 Change-Id: Iad06836b7c1b6fa3c511eb7eaa70d52068d8d64b Reviewed-on: https://chromium-review.googlesource.com/c/1336909Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608237}
-
Bence Béky authored
Bug: 461981 Change-Id: I2e58d90f9f9e2a983286fbec9742234838fbbf50 Reviewed-on: https://chromium-review.googlesource.com/c/1335951 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608236}
-
Sadrul Habib Chowdhury authored
This reverts commit 68dbb3a4. Original commit message ======================= Instead of sending the presentation-feedback over a separate IPC, include it with the begin-frame messages. The presentation feedback can be requested for each frame. So this can reduce an extra IPC per frame for each client. TBR=flackr@chromium.org,boliu@chromium.org,tsepez@chromium.org,piman@chromium.org tbr'ing since this is a reland with a trivial build fix. Bug: 883592 Change-Id: Ia017b14f79eb06b247a9a75a395e4e1d4b51c1db Reviewed-on: https://chromium-review.googlesource.com/c/1336989Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#608235}
-
Zhuoyu Qian authored
Move: build/scripts/{ => core/css}/make_css_property_names.py build/scripts/{ => core/css}/templates/css_property_names.h.tmpl build/scripts/{ => core/css}/templates/css_property_names.cc.tmpl This CL has no behavior changes. Bug: 732657 Change-Id: I267ff9cf0824109aebb7c1f791172b481ae4e0fc Reviewed-on: https://chromium-review.googlesource.com/c/1334995Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ef71a5f047da..f66e5510327b git log ef71a5f047da..f66e5510327b --date=short --no-merges --format='%ad %ae %s' 2018-11-15 yyanagisawa@chromium.org autoninja: support -j100 and -tclean. Created with: gclient setdep -r src/third_party/depot_tools@f66e5510327b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I41516e4c6a5990999b112587a8b7c75bbdd1357a Reviewed-on: https://chromium-review.googlesource.com/c/1336652Reviewed-by:
-
David Black authored
Per change in spec, the Assistant caption bar should be 48dip tall. See bug for detailed spec. Bug: b:119498360 Change-Id: I40cd7cd44a37b9ca99710dad9311b929373b3797 Reviewed-on: https://chromium-review.googlesource.com/c/1336525Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#608232}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74096ec8f277..cd83dda45843 git log 74096ec8f277..cd83dda45843 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 hjd@google.com Unify on for (;;) Created with: gclient setdep -r src/third_party/perfetto@cd83dda45843 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7444b3208fa39e54a631954fe8bcd5a38f0bb917 Reviewed-on: https://chromium-review.googlesource.com/c/1336651Reviewed-by:
-
Tony de Luna authored
This cl moves network icon cache purging to a new observer that is owned by the unified system tray. Currently there are five subclasses of TrayNetworkStateObserver::Delegate. Every time we get a network list update the global network icon cache is purged. This means that for every update the cache is purged at least five times. With this cl TrayNetworkStateObserver::Delegate can still be used as a simple way of subscribing to all network events without excessive icon purging. Bug: 902409 Change-Id: I078ac8dbdee473fc285ee8e91f735c99524c74a7 Reviewed-on: https://chromium-review.googlesource.com/c/1334835 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
-
Shu Chen authored
are changed but also when the selection is changed. Bug: 898442 Change-Id: I927171f7ded54cad1626e367a33a900e90adc8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1319211 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
-
Shawn Gallea authored
Move input timestamps manager out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I65e8baba6d20b726cf69fed3b90286d6ea7cd756 Reviewed-on: https://chromium-review.googlesource.com/c/1318789 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608228}
-
James Hollyer authored
removed acceleration and rotation rate class from device motion data and put all the logic into device_acceleration and device_rotation_data class Change-Id: If54ad00321f4fe14be4468ed3d01291af4d6c783 Reviewed-on: https://chromium-review.googlesource.com/c/1320589Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608227}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ccad5e333472..1934b786149d git log ccad5e333472..1934b786149d --date=short --no-merges --format='%ad %ae %s' 2018-11-15 fjhenigman@chromium.org Refactor instancing tests. Created with: gclient setdep -r src/third_party/angle@1934b786149d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ibc369c9aa7e350c8a270e6cd369537a15d7b277a Reviewed-on: https://chromium-review.googlesource.com/c/1336653Reviewed-by:
-
David Black authored
Bug: b:119555990 Change-Id: I5c2e49fe96c4524db0fd07d2d826f9d5aaa0b48c Reviewed-on: https://chromium-review.googlesource.com/c/1335880Reviewed-by:
-
dpapad authored
Bug: 837381 Change-Id: I5421657d43646c768def7a5ccf235b9eb483e2e2 Reviewed-on: https://chromium-review.googlesource.com/c/1336548Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#608224}
-
Robbie McElrath authored
net::SerialWorker is a RefCountedThreadSafe object that also uses WeakPtrFactory to create WeakPtrs of itself. To run whatever work it's supposed to run, it PostTaskWithTraitsAndReply's to another sequence to do the work there, and then gets called back when the work is complete. The work callback holds a (refcounted) reference to the SerialWorker, and the reply callback is bound to a WeakPtr to ensure the SerialWorker will still be deleted if posting the reply fails. WeakPtr enforces that all dereferences to it, as well as its invalidation, must happen on the same sequence to avoid races. When the reply callback is being called, it dereferences the SerialWorker WeakPtr on the original sequence, which binds that WeakPtr to that sequence. It's possible for the SerialWorker’s owner to release it after the WeakPtr has been checked, but before the worker function has returned, in which case the worker function will have the last reference to the SerialWorker. In that case, when the worker function finally does return, it will delete the SerialWorker, which will delete its WeakPtrFactory, which will invalidate existing WeakPtrs. However, the WeakPtr was previously dereferenced on the SerialWorker sequence, and now it’s being invalidated on the worker sequence, which is invalid. To fix this, this CL makes SerialWorker a RefCountedDeleteOnSequence to ensure the deletion always happens in the right sequence. Bug: 882610 Change-Id: If738d3724384ffd5ac210130415bce7262932feb Reviewed-on: https://chromium-review.googlesource.com/c/1336066 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#608223}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a878e1c2fc6..ccb751a21b7d Created with: gclient setdep -r src-internal@ccb751a21b7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8f29523afd0cb4f75f942e28a15d93fb5a245df3 Reviewed-on: https://chromium-review.googlesource.com/c/1336850Reviewed-by:
-
Lei Zhang authored
They already start out empty by default. Change-Id: Iccfab99f6591753b91c08fbdc1d5edc13b1fa1c5 Reviewed-on: https://chromium-review.googlesource.com/c/1335280Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608221}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/44764000b49c..7d2aae3165a2 git log 44764000b49c..7d2aae3165a2 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d5f1489286b8..3fc6893c8b24 (1 commits) Created with: gclient setdep -r src/third_party/skia@7d2aae3165a2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ifa5267e17f2bf8e0bab205dc9e4e76d1cbcd2b14 Reviewed-on: https://chromium-review.googlesource.com/c/1336649Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/88c15c341d97..ece712e727b4 git log 88c15c341d97..ece712e727b4 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 pprabhu@chromium.org chromeos_config: Temporarily drop hwtests from clapper-release Created with: gclient setdep -r src/third_party/chromite@ece712e727b4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9b584177509c5cd7a92adfe6f3ae58d7e2b7ca79 Reviewed-on: https://chromium-review.googlesource.com/c/1336750Reviewed-by:
-
Eric Roman authored
Change-Id: I6d6704beaeec441a2848ce9c53e9faa6df79fdee Reviewed-on: https://chromium-review.googlesource.com/c/1336919Reviewed-by:
-
Sergey Ulanov authored
This reverts commit 41f8a81f. Reason for revert: broke browser_tests on chrome_os, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8900 Original change's description: > chromeos: refactors MultiUserWindowManager into two classes > > One lives in ash, the other in the browser. The one in ash is responsible > for the actual window management and animations, the one in the browser for > forwarding to the one in ash and caching state. I'm happy to rename these > classes in the future. > > BUG=756085,875111 > TEST=covered by test > > Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff > Reviewed-on: https://chromium-review.googlesource.com/c/1328567 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608022} TBR=sky@chromium.org,afakhry@chromium.org Change-Id: I23f7126a5ff8e897b7ad2ced79277392f771f2f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756085, 875111 Reviewed-on: https://chromium-review.googlesource.com/c/1336792Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608217}
-
Noel Gordon authored
FilesApp OWNERS should be consulted, and also help review changes, to the ChromeOS system modal select file dialog. Bug: 895703 Change-Id: I4258de9c2b3bfc7e37e68b546c9e16a1395572dc Reviewed-on: https://chromium-review.googlesource.com/c/1336952 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608216}
-
Lei Zhang authored
Not all code in the file needs to be visible to the outside. Also use the appropriate naming style for functions. Change-Id: I4f22df2932954b71ce65232a019cfcddd5fd408b Reviewed-on: https://chromium-review.googlesource.com/c/1336521Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608215}
-
Charlie Harrison authored
This CL: 1. Extracts logic for displaying lists of URLs (used by popup and redirect blocking UIs). 2. Removes a failure-case from url_formatter::FormatUrlForSecurityDisplay. This API should handle all cases, and other UI code does not fall back to using the raw URL string if FormatUrlForSecurityDisplay returns an empty string. Bug: None Change-Id: I6f610cb41b8fba85a0952bd1aae2419c23c66586 Reviewed-on: https://chromium-review.googlesource.com/c/1334414 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
Creates the DemoResources class, removing the nitty-gritty details of component loading from the global DemoSession instance. This will make it simpler to update the offline-enrolled mode to use the offline version of the Demo Mode Resources component. It will also allow us to check for the existence of Demo Mode resources without starting a a DemoSession, eg from OOBE. DemoResources avoids using the term "offline resources" except in the context of the preinstalled resources used in offline-enrolled Demo Mode. General Demo Mode resources will just be called "Demo Resources" or similar. A follow-up change will update calls to DemoSession::EnsureOfflineResourcesLoaded() to instead call a similar function on DemoResources. Bug: 904641 Change-Id: Ia931721511fac4efb9e796052bd760a87c952be9 Reviewed-on: https://chromium-review.googlesource.com/c/1333112 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608213}
-
Sunny Sachanandani authored
This is a reland of b44653f9 Original change's description: > viz: DCHECK that clients don't send empty frames > > The service rejects a CompostiorFrame if it has an empty render pass > list, or an empty output rect. Add a DCHECK to ensure that clients > don't send these. > > Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863 > Reviewed-on: https://chromium-review.googlesource.com/c/1335268 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608087} TBR=dcheng@chromium.org Change-Id: Ia29587d7033a01bd4679bffb8a89508db01b0545 Reviewed-on: https://chromium-review.googlesource.com/c/1336373 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608212}
-
Shawn Gallea authored
Move WaylandTouchDelegate out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I8fc2cb3d52c76bdcc4d52c70e63beeb6cd403894 Reviewed-on: https://chromium-review.googlesource.com/c/1318737 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
-
Nate Fischer authored
No change to logic. This adds metrics to track the scheme passed to loadUrl(). This also modifies our previous metric (tracking baseUrl() scheme) to distinguish between file:///android_asset/ URLs (and android_res) from other file:// URLs. This treats loadData() as "data:" scheme. This intentionally excludes loadDataWithBaseURL(). R=isherman@chromium.org, torne@chromium.org Bug: 901581 Test: run_webview_instrumentation_test_apk \ Test: --gtest_filter=AwContentsTest#testLoadUrlRecordsScheme* Change-Id: Ic09bf91a25ebeb7dd075337ae3e28e26e603c3ff Reviewed-on: https://chromium-review.googlesource.com/c/1334843Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608210}
-
Tarun Bansal authored
This CL adds logic for determining which URL to prefetch and records UMA around that. Note that navigation predictor is still running in dry-run mode, as in no prefetch is actually done. Change-Id: I620a3c10146f47b3bd2d8b042b54af0a5879fc90 Bug: 903945 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1333247Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608209}
-
khmel@chromium.org authored
This preserves suppress Play Store show state in case Chrome was restarted during the previous session and initial OptIn flow is currently active. TEST=Locally, simulating that case + unit test BUG=b:119069366 Change-Id: Ifc30bf538baf42d6b91a20d8263d90e7d8962db2 Reviewed-on: https://chromium-review.googlesource.com/c/1331829Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608208}
-
Yue Cen authored
Bug: 900736 Change-Id: I1413bbfb052850dc6ad2e9ca7137c40d2cd978d2 Reviewed-on: https://chromium-review.googlesource.com/c/1324369 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
-
