- 02 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31a694a309d3..7f2fceb9ed0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anthonyvd@google.com,grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: anthonyvd@google.com,grt@google.com Change-Id: I103b6ee9a8e083a35667eb612f0f22203ddd8402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445722Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813248}
-
Bo Liu authored
Essentially matches the implementation in chrome. Need to enable getting the view for readback from WindowAndroid, and supply either the SurfaceView or TextureView directly (parent view will not work since Magnifier has a separate implementation for SurfaceView). Then need to disable surface control when text selection is active. Add a new allow surface control as a SurfaceData state and then go through the same request mode code. Bug: 1132448 Change-Id: I6309b83623e07b4be1a8949b1c31a304da0c3222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444531 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813247}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/124ea2073720..af5911446cd0 2020-10-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-02 tcwang@google.com toolchain: Add workaround when parsing clang version. 2020-10-02 fdegros@chromium.org Remove user and group avfs 2020-10-02 rupertl@chromium.org Remove ARC++ unit tests 2020-10-02 saklein@chromium.org GetBuildDependency: Fix no sysroot case. 2020-10-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-01 moragues@google.com trogdor64: Add builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: If4d61c0aa9452a893013a330a2df3f3bf7b27eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813246}
-
Moe Ahmadi authored
- Removes the field trial config entry for NtpWebUIDesktop experiment. - Adjusts test expectations as needed. Feature is approved for launch in crbug.com/998352 Change-Id: I9df0ff6ed790283be85a52b928751b2c0901437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378731 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#813245}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010020800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/V6gjYXMRLJxHGHFBf1xdXOzgqXS9c8VnXY5Dm66uN6AC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/165769056,b/165878563,b/169896133 Tbr: media-app@grotations.appspotmail.com Change-Id: I18dffaa0865a09201c80829211fcd76ec2175680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446249Reviewed-by:
-
James Cook authored
This method returns a list of the ids of displayed notifications. Later CLs will use this for two things: - To re-synchronize lacros-chrome's cached view of existing notifications after a crash (see C++ NotificationPlatformBridge GetDisplayed() method). - To integration-test the MessageCenter crosapi. Bug: 1134389 Test: added to unit_tests Change-Id: Iad877a20216c813b72c265d1b23deb1cfeed1353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445849Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813243}
-
Gayane Petrosyan authored
Adding histograms to text fragment selector generation logic. Also adding a histogram that indicates if the origin of a link with text fragment is a known search engine. For finding out if a given url is a known search engine, I am separating template_url_prepopulate_data::GetEngineType and deps into a separate file to use it from blink/renderer/platform. Otherwise, template_url_prepopulate_data pulls deps that are also pulled by deps which somehow triggers AddressSanitizer: odr-violation(one definition rule) on some targets. See https://ci.chromium.org/p/chromium/builders/try/linux-libfuzzer-asan-rel/569669 Unit tests for histograms in in a followup. Change-Id: I9d496b883f32041b5bd612b0cf8e447cc79fa68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432674 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813242}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I3129dd962fb4d4ab5fe4872ee21f0704f94e3f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442831 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#813241}
-
Ewann authored
This CL closes the "Close All" confirmationActionSheet when the app is running on background. Bug: 1133304 Change-Id: I20ca7342ea74c14615379f97acdcf8ba02a67fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442532 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813240}
-
Philip Rogers authored
The value of clamped was never used and we can remove it to save some branching. Change-Id: I7f041ed5762782d0073a225e09285a6d99a5cdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445850 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813239}
-
adoneria authored
Bug: 1122196 Change-Id: Ic66ac3ce36019cf5936a5bdbf8d908b36bd00de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443641Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#813238}
-
Felipe Andrade authored
Fix comments in OS People Page, to avoid confusions about our Kerberos feature on ChromeOS, which only uses Kerberos tickets inside user sessions (logged on using GAIA accounts). Also, fixes HTML syntax on OS Icons file. These changes were made in preparation for upcoming changes to support Kerberos on MGS (see corresponding bug below). Bug: 983041 Change-Id: I8cac5703ef68aa1c640f390b1f85b899f78b1edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440586Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#813237}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bef393a5a340..935a915963e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I76c57cd529c79127357e0eb45f5ae7da863949c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446070Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7530bab30c12..527064f19fb0 2020-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 0c0ac2c6c458 to 7c07085ad1cc (1 revision) 2020-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7a78cc629cca to b588cd4df419 (4 revisions) 2020-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from c5c6265c026e to 14289452a832 (2 revisions) 2020-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5e947adaf26e to 375fee944c76 (2 revisions) 2020-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 615fbe6cbc78 to d91afd8de27a (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ibc4ce2347d92f9ca48d87f65510d7445a8e8e4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445714Reviewed-by:
-
Mikel Astiz authored
The histogram expired long ago so let's clean up the code. Fixed: 975436 Change-Id: Idff2ed49e4b4f1e11badd781ab88c3866a009916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440665 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Aga Wronska authored
The code using the message will land separately. Bug: 1126155 Change-Id: If2976b959538dd7dc88b75bcfa483619baedc274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444735Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#813233}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I3859df0551c6f20cf39e61af286b3a5b4571bdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446349Reviewed-by:
-
Charlie Hu authored
Most image policies can report multiple violations for a single cause(same image not following the rule) during layout, e.g. An unoptimized-lossless-image's bpp(byte per pixel) value can change multiple times if the image is being scaled in an animation. To avoid unnecessary duplicated reports being generated. This CL adds Hash method for DocumentPolicyViolationReport to uniquely identify each report and avoid the duplication by remembering these hash values in LocalDOMWindow and filter out reports that are in record. Bug: 924684, 926199 Change-Id: I785ad8b36ef372188da1b2cc4e25886e59c1e18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405646 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#813231}
-
Scott Violet authored
WEB_URL matches strings that don't contain a scheme. We should only use WEB_URL if the matched url has a sheme. To return a relative url results in using about:blank. BUG=1134608 TEST=none Change-Id: I1f4e6a5c3439ad0677aa7279dec316e839fcb61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445911Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813230}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_F7krCJQK2W - Diagnostics App (after) http://shortn/_Wg8IygL5Iu Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I0a50d48774599126d6a2f01494735fc305363aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438675 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813229}
-
Xiaohui Chen authored
This is a reland of 29736b94 Flaky tests are fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2442640 Original change's description: > ambient: handle suspend case better > > Previously ambient mode will trigger lockscreen on screen dimm and then > rely on lock screen idle to show screen saver. This works in some cases, > but in suspend case the time between screen dim and cpu suspend is too > short. Screen saver was not able to enguage. The reason we have the set > up is because the screen saver was sharing the same window constainer as > the lock screen, it cannot show before lock screen is ready. > > Now screen saver has its own window container, we changed the flow to > show ambient mode immediately when idle. This will prevent cpu suspend > because screen saver will take a wake lock if charging. Screen saver > will still lock the screen in the back if user reference indicated > lockscreen after wake. > > Bug: b:169442907 > Test: unitests and manual tests > Change-Id: I1a5df2c58c976bba492c709e0a61dd5a6314d084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435334 > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812397} Bug: b:169442907 Change-Id: Ifca93fcbae5264f41e879c2b708d7866ff1b04b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442384Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#813228}
-
Patrick Monette authored
The DCHECKs were added to generate crashes to help me solve a lifetime issue with service worker controllees, but I underestimated how often the issue happens and have had no crashes yet. Changing them to DumpWithoutCrashing will make it so that anyone on canary will be able to hit them. This CL is meant to be reverted as soon as enough crashes are received to debug the root issue. Bug: 1086944, 1088353 Change-Id: I50904f30ba8d23a5e5661edf8f1cf4d341e6dfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444370Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#813227}
-
Christos Froussios authored
The issue being monitored has not been resolved yet. Bug: 1130647 Change-Id: I1a366ca0142ddd06ad6337cc750b520008cf3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440534Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#813226}
-
Andrew Grieve authored
Goal here was to speed up sorting by having symbols mostly already sorted. Bug: None Change-Id: Ia2761bcc9839c0ef9115b65d4e66605fab740ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441288 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813225}
-
Aaron Leventhal authored
EnsureComputedStyle() cannot be used at this time, and the current method of cachine the results by calling it at an earlier safe time is unreliable if there are layout changes involving this node. Use a bit to cache whether an element IsHiddenViaStyle(). If an object is hidden via style and it's parent is not, then consider that node as targeted directly by hiding styles and therefore not used in the text alternative calculation. As a consequence of this bug, the code is simpler and more reliable, but it had to give up removing nodes from an aria-labelledby name when they are styled as hidden but were already styled as hidden from an ancestor. The ACCNAME spec does not make it clear that this actually has to happen, and the new behavior matches Firefox. Bug: 1133145 Change-Id: Ib6e0441d67167fd68f525698eb4874e5a894dec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440849 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813224}
-
Roman Sorokin authored
so it persists the reboot during autoupdate integration test. Looks like the test can't pass the command-line flag after the restart. So Chrome keep the information in the local state to disable HID detection screen on restart. Bug: 1127536 Change-Id: I5fe32479a585fa67b4534a42a3d61aa958e37470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426451 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#813223}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. The fix to the not-copy_constructible definition is... I assume a nop, but it doesn't seem harmful to change it anyway? Bug: 1134310 Change-Id: I6a40c714c6f9e393a984665c1a82e198d7a8fbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443403Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#813222}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4bfa82e48ed..935a915963e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibbc4fe573f8db666d48b8e6123f6acc5522f0466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445852Reviewed-by:
-
Alexander Surkov authored
No wildcards format is explicit one and doesn't hide any surprises, see for example https://chromium-review.googlesource.com/c/chromium/src/+/2305515 Bug: no Change-Id: Ifc537c505cbd6479549f8eff35eff8656b3805dd AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442139 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
The block-offset needs to include the space consumed in previous fragments, just like we already do for block-level children in CopyChildFragmentPosition(), or position querying DOM APIs (such as offsetTop) won't work correctly. Bug: 829028 Change-Id: Idc0d06ae6daf06013308dfca1e11f70d1b0f7b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445932Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#813219}
-
Anders Hartvoll Ruud authored
This was neglected, end therefore ends up as a null-string in the copy, causing crashes. Bug: 1134550 Change-Id: Ib2d5cf649e10d2d510417a43edd3189617092514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445470Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#813218}
-
Chris Harrelson authored
This can happen if the image is in a frame that is itself invisible, due to for example the <iframe> element owning the Frame being display:none. In such cases the documentElement has no layout. Bug: 1129979 Change-Id: Ic6557c936395ce539be96d255ba4f29a10b5790b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444436Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813217}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I1a6eeed1710070d1192e33a9a367b7ea55ad8589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443970 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813216}
-
Eric Orth authored
Bug: 1121785 Change-Id: Ib43754e00147e2800c2b2663c6ea0cc5ad2c0b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441378Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#813215}
-
Rayan Kanso authored
Bug: 1122646 Change-Id: I263f5348b05cca1b1604bdcede21a3c9249b8654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440868Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#813214}
-
Mark Mentovai authored
There’s no version change, this is still the hermetic Xcode 12.2b2 toolchain. The new package adds libcodedirectory.dylib, a new library that strip and other tools depend on. It needs to be included in the hermetic toolchain packages, otherwise, links that request stripping will produce errors such as: [9770/76120] LINK clang_x64/symupload FAILED: clang_x64/symupload clang_x64/symupload.dSYM/Contents/Info.plist clang_x64/symupload.dSYM/Contents/Resources/DWARF/symupload TOOL_VERSION=1601523428 ../../build/toolchain/mac/linker_driver.py -Wcrl,strippath,../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip ../../third_party/llvm-build/Release+Asserts/bin/clang++ -B ../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ -Wcrl,dsym,clang_x64 -Wcrl,dsymutilpath,../../tools/clang/dsymutil/bin/dsymutil -Wl,-fatal_warnings -stdlib=libc++ -arch x86_64 -Wl,-dead_strip -Wl,-no_data_in_code_info -Wl,-no_function_starts -nostdlib++ -isysroot ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.10.0 -Wl,-ObjC -Wcrl,strip,-x,-S -Werror -o "clang_x64/symupload" -Wl,-filelist,"clang_x64/symupload.rsp" -framework Foundation dyld: Library not loaded: @rpath/libcodedirectory.dylib Referenced from: /opt/s/w/ir/cache/builder/src/out/Release/../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip Reason: image not found Traceback (most recent call last): File "../../build/toolchain/mac/linker_driver.py", line 287, in <module> Main(sys.argv) File "../../build/toolchain/mac/linker_driver.py", line 103, in Main linker_driver_outputs += linker_driver_actions[name](args) File "../../build/toolchain/mac/linker_driver.py", line 137, in <lambda> lambda full_args: action(sub_arg[len(name):], full_args)) File "../../build/toolchain/mac/linker_driver.py", line 223, in RunStrip subprocess.check_call(strip_command) File "/opt/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip', '-x', '-S', 'clang_x64/symupload']' returned non-zero exit status -6 This package was built using the build/xcode_binaries.yaml proposed at https://chromium-review.googlesource.com/c/2445909/. Bug: 1134565 Change-Id: I66e8d1d34d678b3600b5b90b213a382e53133bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445949 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813213}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b7b4f25ef29..b33a7186e6ab 2020-10-02 danilchap@webrtc.org Support layer skipping in L2T2 scalability structure 2020-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9a738068..7d9183ce (813008:813111) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I733ecde2209defc21c06dc5a19ab76559108aedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445717Reviewed-by:
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I0c245a9c52d9dd582ba1e0e14d0dac81e2fc4ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443755 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I3befa68bf2f1091392fa46dec43660638189f637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443250 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
James Cook authored
It's flaky on Windows and Chrome OS. Tbr: lazyboy@chromium.org Bug: 1119807 Change-Id: I2daf1c86ca220afef0c48e204cf61a85db61eed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446189Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813209}
-
