- 03 Nov, 2020 40 commits
-
-
Rohit Agarwal authored
This CL removes the deprecated Profile#hasOffTheRecordProfile method which invoked Profile#hasPrimaryOTRProfile internally. The remaining callers of hasOffTheRecordProfile are updated to directly call hasPrimaryOTRProfile instead. The code requiring the check of primary OTR profile would rely on invoking the method Profile#hasPrimaryOTRProfile explicitly instead. Bug: 1060940 Change-Id: I0955789b0cdb7c3ea86eccb2840d35c0e10d79d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516222Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823486}
-
Gauthier Ambard authored
This CL makes sure that the documentURL is correctly updated, or is not updated when the user is reloading an error page with the new workflow. Bug: 1139303 Change-Id: I11d5f70eeb58077c0ed40f0b183c3f762f749ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514205 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#823485}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/037ccdfb..e0ff8ffa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I654c9d7be80e762e6e1c0ef0a52decba1532f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516001Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823484}
-
Marina Ciocea authored
Make the WatchTimeReporter accessible from the Blink component WebMediaPlayerMs, used in follow-up https://crrev.com/c/2513645 to report the duration of media streams. The WatchTimeReporter is placed in Blink common/ in order to be accessible from both //media/blink/ and Blink renderer/modules, and to be able to access the MediaMetricsProvider mojom, which cannot be accessed from Blink public/web. Bug: 1077707 Change-Id: Id1f52549b6f1e791ffd0e71f7a95f12eb1cc57f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401459Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#823483}
-
Alan Cutter authored
This CL adds a config parameter "only_for_new_users" which prevents installation of a default web app if the user profile has used Chrome already. This allows us to specifically target new users only for new default web app rollouts. Bug: 1145032 Change-Id: Id222d359b9bf9645e676de12ef9ea23039710a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515931 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#823482}
-
Anders Hartvoll Ruud authored
Similarly to how animation-play-state is ignored if play() is called using the Web Animations API, the animation-timeline property should probably be ignored if the timeline of a CSSAnimation has been replaced using the Animation.timeline attribute. Bug: 1074052 Change-Id: I5fcc16539e50ee2a6da6fe64c181f45086386e93 Fixed: 1141836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514210Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823481}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99a0aff93739..cde27a683736 2020-11-03 me@heardanieljames.com Add type to remoteObject when storing as global variable 2020-11-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ice1d23c8b87b42b07e09a7fd4435529dd9f5e667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516399Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823480}
-
Jan Scheffler authored
The cl in devtools-frontend: https://crrev.com/c/2514438 Bug: chromium:1143648 Change-Id: Ia03277779929705a72b463f0a40f28c32547b0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512901Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823479}
-
Austin Tankiang authored
Bug: 1137617 Change-Id: Ib1bd0259bbea79c6806a2de74684e839bb0662b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513316Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#823478}
-
Olivier Robin authored
This flag will be used until the widget can be compiled using the standard toolchain. Change-Id: I0d7cc9187711be1d8743ea5c29093b9cefaf30f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514418 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823477}
-
Austin Tankiang authored
The Linux files icon was changed to being a background-icon in the file list due to https://crbug.com/1075440, so its color needs to be specified in the SVG file itself. Fixed: 1145037 Change-Id: I9fc7da7a3e736da8df88e523fd76b170af9e524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515427Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#823476}
-
Luca Hunkeler authored
If a TextView containing a link (ClickableSpan) is specified as right/left content view, the onclick of the checkbox will not trigger while clicking the TextView. To make sure it does, we need to direclty specify the onclick on the sub view. Bug: b/170293718 Change-Id: Id5498b0617fd01a507b97c3377ad79aa3d67421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489646 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#823475}
-
Tim Song authored
We add metrics for PhoneHub notification actions by introducing' a new PHONE_HUB notification type. This way, metrics will be logged into existing histograms. Additionally, this CL also adds a new Ash.PhoneHub.NotificationCount histogram counting the number of active PhoneHub notifications. BUG=1138137,1106937 Change-Id: I4529eb6cc0d861ec9eb720e4eeac5c6d2d6257ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505728 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#823474}
-
Shik Chen authored
Guides FFmpeg to generate regular (non-fragmented) MP4 if the output is seekable. Bug: 1140852 Test: Pass camera.CCAUIRecordVideo and camera.CCAUIIntent Change-Id: Icc1e32c9160e4734360a35738479b47345a7ab95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513810Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823473}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e26606f95bf7..a77ad8657484 2020-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 47ad8b8f to c3b9f252 (386 revisions) 2020-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e0de282e678b to 959f41988a18 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I5a7ba1b075566fdaecf780e83c2f516b854d0a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516249Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604361545-eddf887b8e48f98791a455ee84436440e457a8ca.profdata to chrome-linux-master-1604382852-89adcc94b5376db481c405a47786acd9d71a0a15.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib465773801259741b293e0c10c6c456ce961217e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516171Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604361545-d42c7d02d03a39b634140e180e06bf71d35a67fd.profdata to chrome-mac-master-1604382852-9483a9470fa3ce55e504618f01ab71cbbe527541.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibba9723491036833ba0b18a31a07cbc7517713db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516169Reviewed-by:
-
Solomon Kinard authored
InitValue changed to InitFromValue. Bug: None Change-Id: I96fb88b03de83f6252c313c1ef0447552b75c61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506040 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823469}
-
rbpotter authored
Bug: 1132403 Change-Id: I76cd8b57066a9f4e22a1fff2f2ff7885d351e4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509994 Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823468}
-
Peter Kasting authored
Bug: 772945 Change-Id: I66a6b1904acd1981e673912d4b58972a15ec5e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516250 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823467}
-
Javier Ernesto Flores Robles authored
Bug: 1138720 Change-Id: I17222dc041ee418bff898bd5475873437f7dd449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513112 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#823466}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4e59f416fc9..99a0aff93739 2020-11-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08189ccfec952c123955f994f3b26c8208fbcf9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515794Reviewed-by:
-
sandromaggi authored
This adds UMA logging for common error scenarios in the onboarding fetcher: * Failure to get data * Failure to parse data * Unexpected data Bug: b/169109752 Change-Id: I1f718b9c8f07271db4819f2c3ecb2332c5241437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513596Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#823464}
-
Joel Hockey authored
Simplify some of the code by using AppendRelativePath() helper function. Bug: 1144138 Change-Id: I5d426bbb1111dd2cf1976793727b6adf30bbbdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512499Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823463}
-
Joel Hockey authored
This function will be used for wayland drag and drop when dragging items from crostini where the path needs to be translated. It is the reverse of ConvertFileSystemURLToPathInsideVM(). Bug: 1144138 Change-Id: Idb9e2eb1a5323a86f25ae2b08caf1971cfa9191d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513313 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces most usage of autofill::PasswordForm in the importer code and uses a new importer::ImportedPasswordForm struct instead. This is necessary, because PasswordForm is being moved to the //browser component, and thus is no longer accessible from other components like //common or //utility. Bug: 1067347 Change-Id: I3789dc48d85837b75162c7b58e5ef8908b6f99eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513220 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823461}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604318145-d42776d1d9d08b6fa8d7b373c065b46395fc90ba.profdata to chrome-win64-master-1604350611-23c1a5ed722901de0dc0263a6d25110372347a10.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If5b0101a793d15f92cbd183af4bdb70661f93caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515900Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1003fa794677..6d65c11720ff 2020-11-03 jophba@chromium.org Hotfix: fix standalone sender stringprintf include If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I43423ac3131466d0a45aa6d9bdee9b1827d2ead9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515562Reviewed-by:
-
Frank Tang authored
See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2511803 for the actual changes and the details of the data size changes. Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel Bug: 1138555,854201,927703 Change-Id: I8f1b6157f2f1c13c2864836b38e36a37b8c778bf Binary-Size: 40K ICU increase due to increase version of ICU. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474093 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#823458}
-
Meredith Lane authored
TBR=drott@chromium.org Bug: 1145019 Change-Id: Ieb1f6f2108b0ff731554d5a44774d5de6d124472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516060Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823457}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5f3f8a08b776..e26606f95bf7 2020-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0a374dce6653 to 71d2e1d23d49 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I9b71e942ea9e4f47233636e3f934252e0050cbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515368Reviewed-by:
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: Ie813762ce32bbebf26bf1f661ffacba67636ef92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508200 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#823455}
-
Peter Boström authored
Also replaces some overrides with simple setters of title, modality and close button. Bug: 1128500 Change-Id: I2829525532d1690656b97fc770b2b62324fe7c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511254 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#823454}
-
Matt Menke authored
Extensions, the only consumer of these modes, have been migrated off of the SpawnedTestServer, so we can remove them. Bug: 492672 Change-Id: I105e8f4314a356a27a890f24583ca2681bc99f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513788 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823453}
-
Trent Begin authored
This change removes the control buttons from the network diagnostics component and insteads moves them to the parent component in chrome://network. This allows the component to be used in the connectivity diagnostics app with slightly different control buttons. Bug: chromium:11406598 Change-Id: I9b941711b716958089b88da43aac7d21aa8f7c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499374 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#823452}
-
François Degros authored
The new ZIP mounter is not quite ready yet for M88. This reverts commit f3dc4bdb. BUG=chromium:912236 Change-Id: I20dfdc5042bb2dfbe4e89d88342b504b6ad03c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515380Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#823451}
-
Aaron Leventhal authored
This reverts commit a8f6993b. Reason for revert: https://crbug.com/1138496 Original change's description: > Simplify last known ignored code > > - Remove 2 member variables and 2 methods from AXObject, which were used > so that AXObject could calculate whether ignored changed. > - Remove repetitive code from AXObjectCacheImpl, whenever an > AXObject is created. > > Bug: None > Change-Id: Iad38383819dd1d165169fd302a717f3e2bacb2b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383813 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803250} TBR=dmazzoni@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1138496 Change-Id: Ida41dd255ca81e2669e54759c896acebd9503076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515659Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823450}
-
Yicheng Li authored
This behavior is approved in UI concept review. So we also remove the cancel button. Bug: b/156258540 Change-Id: I9604d15cb7db7f379c96c692d25bf51d14b2ca10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505443 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823449}
-
Xinghui Lu authored
The Safe Browsing check blocks the URL loader when the URL loader starts to process the response. We'd like to know how often that happens and how long does the Safe Browsing check block the URL loader. Metrics added in this CL: SafeBrowsing.BrowserThrottle.IsCheckCompletedOnProcessResponse SafeBrowsing.BrowserThrottle.TotalDelay Bug: 1144265 Change-Id: I7a14548170458e04fe9452647b347a84780819b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510742 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Thomas Lukaszewicz authored
Bug: 1099917 Change-Id: I66d7495b7c79d80501424c42432f447671442775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514805Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#823447}
-
