- 14 Mar, 2018 40 commits
-
-
Corentin Wallez authored
TBR=kbr@chromium.org TBR=sky@chromium.org BUG=chromium:815092 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib8f30c702e603c987e0c89203d8d7cd301f6ba77 Reviewed-on: https://chromium-review.googlesource.com/962933Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#543229}
-
https://chromium.googlesource.com/catapult.git/+log/fb4a44ab53c4..6c4a8ca2e9bc $ git log fb4a44ab5..6c4a8ca2e --date=short --no-merges --format='%ad %ae %s' 2018-03-14 dtu [telemetry] Add results label to benchmark_total_duration histogram. 2018-03-14 nednguyen Make psutil import error tolerable for py_utils.memory_debug module Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I54db2524f10f729810fd374d7b95e5ec98021952 Reviewed-on: https://chromium-review.googlesource.com/963479 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543228}
-
Yixin Wang authored
Revert "Add OnForwardProgressConfirmed() for QuicConnectionVisitorInterface and call it whenever an ACK increases the largest_acked value." This reverts commit be7cfa94. Reason for revert: CL accidentally includes changes from a separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/956929 Original change's description: > Add OnForwardProgressConfirmed() for QuicConnectionVisitorInterface and call it whenever an ACK increases the largest_acked value. > > The purpose of this is to have Chromium's QuicChromiumClientSession pass the MSG_CONFIRM flag to the next UDP sendto() call when OnForwardProgressConfirmed() is called for Linux platforms. MSG_CONFIRM is used to signal the Linux kernel of "forward progress" on that path to prevent the kernel from doing unnecessary probing. > More info: https://bugs.chromium.org/p/chromium/issues/detail?id=488402 > > This merges internal change 188887862. > > Bug:488402 > > Change-Id: I607f41d293aece5f496547dec7c4d5fd1b24ea5a > Reviewed-on: https://chromium-review.googlesource.com/961385 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543210} TBR=rch@chromium.org,sergeyu@chromium.org,wangyix@chromium.org Change-Id: Ic441da9cb36080ac42b2a442db5dc8431082f1d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 488402 Reviewed-on: https://chromium-review.googlesource.com/963621 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#543227}
-
Min Qin authored
Simply moving file locations, no functional change BUG=803135 Change-Id: I994b4080639c54a9f92fc18f726032d4fab159a0 Reviewed-on: https://chromium-review.googlesource.com/959602 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#543226}
-
Rob Buis authored
Fix errorprone ReferenceEquality warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/ReferenceEquality Bug: 802075 Change-Id: Icd9d0ccd0f625b1eef1d92d88600641b67a8587a Reviewed-on: https://chromium-review.googlesource.com/911609Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#543225}
-
Yunlian Jiang authored
We got some errors in link stage when using distributed thinlto renderer_blink_platform_impl.o.thinlto.o:renderer_blink_platform_impl.cc:vtable for content::DeviceSensorEventPump<blink::WebDeviceMotionListener>: warning: relocation refers to discarded section Removing the template instantiation statement fixes this issue. BUG=820514 TEST=emerge-samus chromeos-chrome Change-Id: I24a8221d576adac0495ff44c7d8d110aecc586fd Reviewed-on: https://chromium-review.googlesource.com/946681Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Cr-Commit-Position: refs/heads/master@{#543224}
-
Artur Khachatryan authored
Test ChromeDriverSiteIsolation.testCanClickOOPIF is failing for Chrome v66 on all desktop platforms. Disabling OOPIF test. Bug: chromedriver:2304 Change-Id: I7dbb623a96039981fce9c80cb5972c172a0096af Reviewed-on: https://chromium-review.googlesource.com/963478Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543223}
-
W. James MacLean authored
This CL adds a demo application to show off how an app might facilitate communication between a whitelisted extension and guest content in a <webview>. Bug: n/a Change-Id: Ic7d20958c2a36159b9da4b32ec0543945f593b54 Reviewed-on: https://chromium-review.googlesource.com/949522 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543222}
-
Matt Reynolds authored
BUG=749295 Change-Id: I916483dfc21b2523c99f8507917cf05ae42ca00a Reviewed-on: https://chromium-review.googlesource.com/961546Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#543221}
-
Aleks Totic authored
Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I505e2e4e01ffba761a4c4ea2c699f71b9f3ed639 Reviewed-on: https://chromium-review.googlesource.com/963496Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#543220}
-
Toni Barzic authored
Adds logic to display "persistent" error bubble (i.e. error bubble that remains shown if user clicks, scrolls, types outside of the bubble) that warns the user when a detachable base change / invalid detachable base is detected. The warning warns the user that the detachable base is different than he one they used last, and that they should proceed with caution as the base might be malicious. SigninScreenHandler is updated to observer ash::DetachableBaseHandler state (currently non-mash only), and notify the UI when the error message should be shown or hidden as the detachable base pairing status, and the focused user pod change. BUG=796300 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2813af6ac9473554509308194b3ae04331d013b9 Reviewed-on: https://chromium-review.googlesource.com/956802 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543219}
-
Abhishek Arya authored
Create a copy of input buffer as otherwise it will not catch a 1-byte overflow on write due to use of that byte for keeping options. R=rsesek@chromium.org Change-Id: I15f6695e27951d1079b4e9fca71c55dfd54af870 Reviewed-on: https://chromium-review.googlesource.com/963016 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543218}
-
Thomas Anderson authored
This reverts commit 375c6457. Reason for revert: Breaks Google Chrome Linux x64: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/28713 Original change's description: > components/proximity_auth: Make this component CrOS-only. > > This is true in practice. > > R=khorimoto@chromium.org, sky@chromium.org > > Bug: none > Test: none > Change-Id: I14ec85e9b4c34bc0ee94ebae2ca9b9d782c8e5f4 > Reviewed-on: https://chromium-review.googlesource.com/962863 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543214} TBR=jhawkins@chromium.org,sky@chromium.org,khorimoto@chromium.org Change-Id: Ie10b48da189c3a80900bac3693ed345c5df92258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/963584Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543217}
-
Toni Barzic authored
ash/detachable_base_handler/ now depends on upstart client to (re)start detachable base pairing status checks on start up, so the client should be available to ash. BUG=818057 TEST=No crash when starting Chrome with --enable-features=Mash Change-Id: Id2e89b9c0f2fca0e850a05ac20d9d14c616e7923 Reviewed-on: https://chromium-review.googlesource.com/963297Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543216}
-
Erik Luo authored
This modifies the 'i' note next to the queryObjects result array to describe how objects may not be collected if they are previewed until console.clear Screenshot: https://imgur.com/a/q03rG Bug: 815263 Change-Id: I872ca733fd4b3ae3f64487e6c969167c26119c62 Reviewed-on: https://chromium-review.googlesource.com/961556 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543215}
-
James Hawkins authored
This is true in practice. R=khorimoto@chromium.org, sky@chromium.org Bug: none Test: none Change-Id: I14ec85e9b4c34bc0ee94ebae2ca9b9d782c8e5f4 Reviewed-on: https://chromium-review.googlesource.com/962863Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#543214}
-
Peter Boström authored
This reverts commit f43dc781. Reason for revert: UX has decided against #757575 as it makes a lighter icon color as a stopgap between current (5A) and GoogleGrey700. GG700 is closer to 5A colors so trunk will go straight to GG700 as soon as I get updated favicons with that color sent to me. This revert is intended to be merged into M66. Original change's description: > Use Material Design colors for UI icons. > > This changes icons generated with use of SetImageFromVectorIcon or > DeriveDefaultIconColor to generate #757575 from a black related text > color. The use of alpha in SetImageFromVectorIcon is changed to result > in #9E9E9E for disabled icons when used to generate icons for black > text. > > Some of the favicons are changed to have a MD-blue icon as part of > WebUI branding. > > Bug: chromium:774563 > Change-Id: I978b1cba4d33a06e834f0ff7d74d3dbc6a305b57 > Reviewed-on: https://chromium-review.googlesource.com/752028 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539743} TBR=sky@chromium.org,blundell@chromium.org,estade@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:774563, chromium:820229 Change-Id: Ib43faee64803db2cfd9b35dee1ac1818b91ccc45 Reviewed-on: https://chromium-review.googlesource.com/963232 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#543213}
-
Thoren Paulson authored
Set the screen orientation for CastWebContentsActivity to landscape in the Android manifest. Bug: internal b/74443822 Test: CQ Change-Id: I90726b7ec7ac38f756459f246df7a3eb706f3b46 Reviewed-on: https://chromium-review.googlesource.com/963477Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#543212}
-
Demetrios Papadopoulos authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia98166dd4e2e59db2c4b0700ec4d0979f0149e18 Reviewed-on: https://chromium-review.googlesource.com/961362Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#543211}
-
Yixin Wang authored
Add OnForwardProgressConfirmed() for QuicConnectionVisitorInterface and call it whenever an ACK increases the largest_acked value. The purpose of this is to have Chromium's QuicChromiumClientSession pass the MSG_CONFIRM flag to the next UDP sendto() call when OnForwardProgressConfirmed() is called for Linux platforms. MSG_CONFIRM is used to signal the Linux kernel of "forward progress" on that path to prevent the kernel from doing unnecessary probing. More info: https://bugs.chromium.org/p/chromium/issues/detail?id=488402 This merges internal change 188887862. Bug:488402 Change-Id: I607f41d293aece5f496547dec7c4d5fd1b24ea5a Reviewed-on: https://chromium-review.googlesource.com/961385 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#543210}
-
Tarun Bansal authored
Compute DPR in the browser process and include it as a client hint (if the origin requested it) on main frame requests. Bug: 821954 Change-Id: I73a2017d426cb6d9403d41bc89e3107da44034b2 Reviewed-on: https://chromium-review.googlesource.com/963315Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543209}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8985aa3f68b..ddd9b6c95806 $ git log a8985aa3f..ddd9b6c95 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I01bf6e61030b2e484fb7cef72ab10947054d915e Reviewed-on: https://chromium-review.googlesource.com/963286 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543208}
-
Marijn Kruisselbrink authored
EncodedFormData::SizeInBytes doesn't support all possible types (in particular it DCHECKs on kDataPipe), so by swapping the order of checks we make sure things actually work correctly. On of several changes towards making uploading blobs with network service work. Bug: 821878 Change-Id: I64313bcc390756de6ad0be091d0ab32e9b78ae44 Reviewed-on: https://chromium-review.googlesource.com/962833Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543207}
-
Adam Langley authored
Change-Id: I58d9c9025e238c0ff6824f0e5b39e299a7a86272 Reviewed-on: https://chromium-review.googlesource.com/961789 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#543206}
-
Caleb Rouleau authored
This reverts commit e50412fb. Reason for revert: crbug.com/821999 enabled test now failing on chromeos Original change's description: > cros: Convert switch to feature for new overview ui. > > Convert to feature which is enabled by default. > > Test: manual > Bug: 821608 > Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616 > Reviewed-on: https://chromium-review.googlesource.com/961721 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543139} TBR=sky@chromium.org,sammiequon@chromium.org Change-Id: I92ce3f93cb88cef92e242fbbd6338cbdac528cdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821608 Reviewed-on: https://chromium-review.googlesource.com/962837Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#543205}
-
Zhiheng Vincent Li authored
Main interfaces added: 1. Add methods in CastContentWindow and CastContentWindow.Delegate for Cast Activity and WebApplication 2. Add methods in CastContentWindowAndroid for JNI calls between Java and C++ 3. Add some methods and intent types in CastWebContentComponent for calling between CastContentWindowAndroid and CastWebContentComponent, and between CastWebContentComponent and CastWebContentsFragment 4. Add some intent types for calling between CastWebContentComponent/CastWebContentsFragment and external activity. Design doc: go/cast-to-android Test: cast_shell_junit_tests browsertests Bug: b/65100261 b/72227153 b/72436346 b/72237087 b/72912957 b/72436104 b/72712171 Change-Id: I09056f6fe78341e545c5e1342640a4dfddff28f4 Reviewed-on: https://chromium-review.googlesource.com/940809 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543204}
-
Toni Barzic authored
I'm not up to date on this component :) While editing the file, adding jhawkins and jlklein Bug: None Change-Id: I900241c6348eb7ba4f8392a9d348a343f2266fe5 Reviewed-on: https://chromium-review.googlesource.com/963300Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543203}
-
Joel Einbinder authored
If the style of a node was changed right before a call to DOM.getBoundingBox, it might return stale metrics. Change-Id: I046ecd214c964935f5912ed6f570c9cc4552ad29 Reviewed-on: https://chromium-review.googlesource.com/963302Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543202}
-
Xianzhu Wang authored
For descendant->Parent() == ancestor_clip && descendant->LocalTransformSpace() == ancestor_transform we can return the clip rect of |descendant| directly to avoid the more complex logic. This also reduces the number of entries in the clip cache, which can speed-up cache lookup. Premilinary stats show that the fast path is used for about half of all calls to the function. Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8c390e17cbc7c5e225716e6e90ac8be4dfa615d8 Reviewed-on: https://chromium-review.googlesource.com/963012Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543201}
-
Menglu Huang authored
These two bots run iOS tests. ios-simulator is CQ bot. ios-simulator-full-configs is main waterfall bot. Expand the swarming pool size for it. Bug: 795980 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iad52add5c29c24a212ec69c8918dd8f809086e39 Reviewed-on: https://chromium-review.googlesource.com/961726Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#543200}
-
Evan Stade authored
0816757e fixed a real issue which might be the source of the flake here. Bug: 810302 Change-Id: I38630563e11944deec2dcd71dc89a01eabdfdd74 Reviewed-on: https://chromium-review.googlesource.com/957806Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#543199}
-
James Hawkins authored
This UI surface is non-CrOS only and the ScreenLock functionality is only function for CrOS, so this is essentially dead code. R=khorimoto@chromium.org Bug: none Test: none Change-Id: If612764c9e668c225d8d83062fe495186cbdeb61 Reviewed-on: https://chromium-review.googlesource.com/962667 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543198}
-
Miguel Casas authored
This CL adds two extra EDIDs (namely an eve and an HP z32x) for the edid_parser_fuzzer test. Bug: 821393 Change-Id: Ia3242cd6df142a789e074ddaa6b4df8162adbd5d Reviewed-on: https://chromium-review.googlesource.com/963222Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#543197}
-
Steven Bennetts authored
This includes a handful of minor layout fixes after close examination of the network settings UI. * Spacing issue introduced with paper button changes: https://chromium-review.googlesource.com/907856 * Alignment issue introdiced when fixing click targets: https://chromium-review.googlesource.com/952033 * ip-config JS console error causing details page to be incorrect initially (old issue, but probably exposed with recent refactoring) * Network security icon bug in detail page that has existed since 64 (no bug filed that I could find) Only the security icon bug impacts 66 and it's confusing but minor. Bug: 821733, 821720 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I877aeb93a232f6c656d73ac7c345f63e00cbf125 Reviewed-on: https://chromium-review.googlesource.com/963303Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543196}
-
Ian Vollick authored
In the following change I broke the size of the voice search icon https://chromium-review.googlesource.com/c/chromium/src/+/958221 The problem is that I reused a button class that automatically resized the icon to the wrong value. With this change, I've made it possible to customize this scale factor so that users of this button class can have larger or smaller icons as required. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icbf29e348ff0b507524532c2f58dfd4d8d82bb64 Reviewed-on: https://chromium-review.googlesource.com/962936Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543195}
-
Alexander Alekseev authored
This CL enables changing user type. If user_id token suggests that user type has changed (so that it is possible for Regular <-> Child transition only because of the API), |User| type will be updated immediately, |Profile| child flag will be changed in InitProfileUserPrefs(), and profile entry will be removed from profile_info cache to ensure cache is fully reinitialized. Bug: 811541 Change-Id: Icc0719d66058d951697937e9b36dcb4155b95908 Reviewed-on: https://chromium-review.googlesource.com/959743 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#543194}
-
Xianzhu Wang authored
Previously a transform was issued for SPv1 to translate the painting space from the current paint offset based space to the space in which WebPluginContainerImpl::FrameRect() resides. Now pass the translation into WebPluginContainerImpl::Paint() and output the translate as a paint command for SPv175. This might not be a long-term solutio. Need to refactor the coordinate system of EmbeddedContentView to simplify the logic. Bug: 821486 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I40837bbbdd5b09e6a0d585cb594165c4db48b881 Reviewed-on: https://chromium-review.googlesource.com/961861 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543193}
-
rbpotter authored
Since we now send a PDF from print preview, the offsets aren't computed in PrintRenderFrameHelper. They should be the printable area offsets, not the content area. The content area offsets reflect the margins set in Print Preview, which are no longer relevant since the generated PDF already includes these margins. Bug: 821485 Change-Id: I5ba009408bb7bb0251cdd85b3ed7b6e10e293826 Reviewed-on: https://chromium-review.googlesource.com/962878 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#543192}
-
https://chromium.googlesource.com/catapult.git/+log/b1242f4c6f85..fb4a44ab53c4 $ git log b1242f4c6..fb4a44ab5 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 perezju Reland "[Telemetry] Use correct WebView apk for --browser android-webview" 2018-03-12 dtu [pinpoint] Retry job.put() on ndb error. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iea0e198660e78e9447b37c141942edc46660c2c7 Reviewed-on: https://chromium-review.googlesource.com/962830Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543191}
-
James Cook authored
Generate synthetic clicks and dispatch them via the window service. Add the remote event dispatcher interface to a new "accessibility" capability, available only to trusted apps. Bug: 821471, 628665 Test: Use autoclick on multiple displays with different scale factors Change-Id: I61352a0849a96a2bc0ae14d0b8afcca051ba67e2 Reviewed-on: https://chromium-review.googlesource.com/961668Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543190}
-