- 18 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ed863a30a95..415642b766fa 2020-12-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b31cd871ad10 to 64c5d601f89b (7 revisions) 2020-12-18 bsalomon@google.com Fix alignment when getting slice in GrVkGpu for upload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Id0f0505c32aa57ee3827277b0f793131befc7bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838425}
-
David Maunder authored
Two bugs were discovered 1) If a Tab navigates to a new URL, the ShoppingPersistedTabData should be invalidated. Otherwise we will return ShoppingPersistedTabData for the previous URL. To achieve this an observer on onUrlUpdated is added to delete the saved ShoppingPersistedTabData and disassociate the object with the Tab via UserDataHost. We should also do this on a tab close. 2) An observable supplier was not registered for ShoppingPersistedTabData. This pattern is used to control turning saving of the PersistedTabData object (in this case ShoppingPersistedTabData) on and off. Bug: 1159657 Change-Id: I5ac0d914cb1f03e0bdc9efc7914458dc16877d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596435 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#838424}
-
Maggie Chen authored
With the command line switch "show_dc_layer_debug_borders", green debug borders will be displayed for the root damage rect. This damage rect does not include the damage from overlays except for some beginning overlay frames. Bug: 1117235 Change-Id: Ic7c13e7cdf5b0fd1f6c3ca958331f2a4b0ec47a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595975 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#838423}
-
Wanming Lin authored
Currently SetTimeout(..., 0) is clamped up to 1ms while which is not supposed to be in the spec. This CL is intended to fix the tests that become flaky with https://chromium-review.googlesource.com/c/chromium/src/+/2578703 Not all setTimeout 0 -> 1 in the web tests are strictly necessary, I only change the affected tests. Bug: 402694 Change-Id: Ie6e0ef0352146dec11f412fbea3999f37e895005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593716 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#838422}
-
Jeremy Roman authored
This appears to leak all mapped shared memory forever at present. Bug: None Change-Id: I67b44a7e1db5daa4885a1d6b1988fbaba30c3ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596999Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#838421}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 971e0b95. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I92f9c520205794c845057578e051e1bd2428f85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597545Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838420}
-
Liquan (Max) Gu authored
Context: Opening a PDF in Payment Handler UI is a use case that's too rare to support. This CL disallows this behaviours to avoid any PDF-related risks. Before this CL, the WebContents in desktop PaymentHandler UI could navigate to a pdf file. After the CL, the WebContents could not navigate to PDF file. Bug: 1159267 Change-Id: Ic682bbf8a9c75e40658f1e17e423cf77b0847386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595453Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#838419}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b778fd86daf8..43abbad0ebd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kmilka@google.com Change-Id: Id39724fa88a9df4d60edd661c97e2eb24a0abcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595226Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838418}
-
Aleks Totic authored
My very large table test used to be 50% slower in TablesNG compared to Legacy. 3576733 36.7g 950.3m 0.0 0.5 1:37.01 tables_ng 3577099 36.6g 847.5m 0.0 0.4 0:57.16 legacy The slowdownwas triggered by PrePaintTreeWalk taking much longer in TNG. This happened because in TNG rows were never skipped in PrePaintWalk. This was because ObjectRequiresPrePaint returned true in NG, false in Legacy. The object.bitfields_should_check_for_paint_invalidation_ flag was set in NG, not Legacy. The root cause was that LayotutBox::CachedLayoutResult was indiscriminatey calling ClearNeedsLayout. ClearNeedsLayout always calls SetShouldCheckForPaintInvalidation. If we only call ClearNeedsLayout if NeedsLayout is true, TablesNG performance is only 6% slower. 3853570 950.9m 0.0 0.5 1:03.50 content_shell NG 3853829 847.0m 2.6 0.4 0:57.33 content_shell Legacy Bug: 958381 Change-Id: Ic4cfb77f6a65a6e77824fe8e035860c8ed6d9218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594077Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#838417}
-
Toni Barzic authored
Adds a toast that's shown when the hardware camera privacy switch (which turns off the camera) gets toggled. A notification shown to the user if they try to use camera while the camera privacy switch is on. BUG=1159919 Change-Id: Ia1b3292dd064d05542cf41554346f3909d74a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597697 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838416}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.55. R=machenbach@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: Iab5bdde1ae888309424dcd5c0c0fb17df7767abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598217 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#838415}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ic38b9c87c73119accea204c075b1095a8c244ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596566 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#838414}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/74ebd7e6ceaa..6ed863a30a95 2020-12-18 johnstiles@google.com Rewrite faceforward/refract to work around Adreno driver bug. 2020-12-18 fmalita@chromium.org Reland "[svg] Absolute positioning support for text" 2020-12-18 adlai@google.com Yank out old reduceOpsTaskSplitting code 2020-12-18 ethannicholas@google.com Reland "Reland "Reland "Reland "Revert "Initial land of SkSL DSL.""""" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I6201ccd10da353c46dd39674df339165a1561d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597901Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49872c09220e..72f25b4b486d 2020-12-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8239d0a6d5c9cfe06674955ed06c183551315186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598158Reviewed-by:
-
David Bienvenu authored
Also fixes some cpplint errors. No functional changes. Bug: 1010217 Change-Id: I4127bf0b033c28658a3f19632e034618ad984e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597222Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8481473d..af6738a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0af899620de995f1298d179e892b8101e4148d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598177Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838410}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608216969-d8963b2867fbdeca37528114dc3700d4528ac121.profdata to chrome-win64-master-1608228003-e74739fcdefa7518b67623025a08d95b63f00b00.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0f091a4cdfe583c11c75fe3c7eac4a52161cdf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595223Reviewed-by:
-
Ian Barkley-Yeung authored
Improve the WebUI JS Error Reporting browsertest by confirming we are also getting good stacks with actual function names. Bug: chromium:1121816 Change-Id: I0106b71709a9a266cca5e2a02097ebbaf5e66318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598007 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#838408}
-
rajendrant authored
This CL records login to password entered site, and login to preloaded list of sites commonly user enter password. This information is maintained in SiteIsolation, and plumbed to LoginDetection code. Bug: 1159981 Change-Id: Ifabbd34383971e434e9af356b93017fc4b4f251a TBR: robertogden@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597184Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#838407}
-
Olivier Yiptong authored
This adds a "Select/Unselect All" method. The "Select All" functionality existed, however, it was implemented ad-hoc in a switch statement and did not support unselect-all. Furthermore, TableView's AddIndexToSelection was implemented with a complexity of up to O(n^2 * log n), depending on std::sort's implementation, and at least O(n^2). This implementation adds AddIndexRangeToSelection, which is effectively a bulk-insert operation. Furthermore, a std::set is now used to check for existence of an item in a selection, which makes this operation O(1) instead of O(n) previously. Change-Id: Iea272000fe5bf4a4cb69daaf187187bd4e90bd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594433Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#838406}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Ie8ad0a235d99c181c576afae9fe6a6ddd9c146dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598236Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838405}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f32743847402..31a6a84b0393 2020-12-18 rwkeane@google.com Internal change 2020-12-18 shawnq@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Icb17f3d03102478072d9026105e4a7d695a26606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597822Reviewed-by:
-
Kent Tamura authored
make_css_property_names.py supports multiple aliases. Before this CL, |<a resolved property id> + 1024| was an an alias. Since this CL, |<a resolved property id> + 1024 * n| is an alias where |n| is a natural number. This CL will be necessary for unprefixing -webkit-text-emphasis, which already has -epub-text-emphasis alias. This CL has no behavior changes for now. Bug: 666433 Change-Id: I6e620b55f07fde7542d1bd04fa25beaad8ee659e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596466Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#838403}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.122. R=estaab@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: Iaf964339e3251250cf9784e7d1529bbeda04b39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598216 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
David Bokan authored
This CL is the last of a series to convert DataItem from the deprecated base::Callback (and Bind) to [Once|Repeating]Callback. See the relation chain of CLs for the complete change. Now that all methods in DataItem have been converted to the appropriate modern types, we remove the "non-once" aliases and rename the "once" ones back to the original name. Bug: 1152268 Change-Id: Idc0ec68ff3d14d2557225207804f73e95976e079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595935 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc9b7694ce3d..0d23e521cc40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idde319a77b0b2cdd24fb7b211dffe7b3f70dba03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597879Reviewed-by:
-
Shakti Sahu authored
Summary card is shown on NTP after all other tutorials have been clicked or dismissed. Currently we use finch param to get the resources to create this card. A better solution is to get it from the server as a tutorial. The backend will filter it out on a GetTutorials() call. Bug: 1159249 Change-Id: I71f78826535a3d13fad41b027aa6e2c645ab3a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594442Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838399}
-
Hui Yingst authored
PdfViewPluginBase is the common base to share code between the two plugin implementations: OutOfProcessInstance and PdfViewWebPlugin. Since these two classes both inherit from PaintManager::Client, we can move this inheritance into PdfViewPluginBase instead. Bug: 1099020 Change-Id: I06f7b4d6a1b2aff12338bb5eca5d05dc31a221f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596829 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838398}
-
David Bokan authored
This CL is one of a series to convert DataItem from the deprecated base::Callback (and Bind) to [Once|Repeating]Callback. See the relation chain of CLs for the complete change. Convert DeleteAllItemsForExtension and its associate in LockScreenItemStorage to take a OnceClosure as a parameter. Bug: 1152268 Change-Id: I9eb6d9b76eef7c462ac7eb9ea1c21c6dae2eb6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595934 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Dale Curtis authored
Long ago our H264 parser didn't support SEI recovery points and there was concern that unverified SEI points may lead to leaking uninitialized memory from the system. Our parser now has support and the uninitialized memory concerns are just as relevant with a standard IDR. As such implement support for SEI recovery now. R=sandersd Bug: b/175647455 Change-Id: I305d3f3c6ce5979f35c430df027da62a9a336036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597804 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#838396}
-
David Bokan authored
This CL is one of a series to convert DataItem from the deprecated base::Callback (and Bind) to [Once|Repeating]Callback. See the relation chain of CLs for the complete change. LockScreenItemStorage uses the callback types from DataItem in its own interface so we convert these to the "once" variant added in a prior CL. Bug: 1152268 Change-Id: I52113e123285a16bb727c6643a60416f28f8faa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595637 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
David Bokan authored
All uses of the base::Callback aliases have now been removed. This CL is a simple no-op that removes them and renames the OnceCallback versions to the old name. Bug: 1152268 Change-Id: Idf8e9705ba6d1c37605ee3f7a865fe627ab31c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596072 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#838394}
-
Weizhong Xia authored
This is a quick fix for the wpt import from upstream: https://chromium-review.googlesource.com/c/chromium/src/+/2595735 Bug: 1159946 Change-Id: Ie72dd6135ab6b6d6f6505a93eda4a2a4c58e1f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597043 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/3159f65600d9..f32743847402 2020-12-18 rwkeane@google.com Internal change 2020-12-18 noreply@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I4b36cc4b18f79ab5c78da2dfd73311fde7bf2bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597166Reviewed-by:
-
David Bokan authored
All these callbacks are either immediately invoked or passed to NetworkConfigurationHandler and ShillThirdPartyVpnDriverClient which already are taking a OnceCallback. Bug: 1152268 Change-Id: I3ced6e4da98cadf05b5596e785cec2886063fcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596144Reviewed-by:
-
David Bokan authored
This CL is one of a series to convert DataItem from the deprecated base::Callback (and Bind) to [Once|Repeating]Callback. See the relation chain of CLs for the complete change. This CL converts EnsureCacheForExtensionLoaded to take a OnceClosure. This is necessary to further convert other parts of DataItem as we need to bind them as parameters to this method. Bug: 1152268 Change-Id: I5e2860cfee8bb76ca5bfe432e5612c4e1463f723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596138 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ic28a0ca69cd8f9312190698256502086e1aa22d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596898Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#838389}
-
Ana Salazar authored
When the user pins drive files pinned to holding space might be unavailable for offline use. This change pins drive files for offline access when the user pins them to the holding space. Bug: 1143034 Change-Id: If913bc09e34ebfdf182615d5f92dce850b28072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594275 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#838388}
-
Brian Sheedy authored
Enforces that the bugs associated with GPU test expectations are in a particular format. This prevents typos from making it in, such as "angler" instead of "angle". Also fixes found issues in the expectation files. Bug: 998329 Change-Id: I0e4534e9497f735838d90fa0d0631bd7c3cd4b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597713 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#838387}
-
Nancy Wang authored
This CL adds the FullRestoreInfo class, and FullRestore::Observer, to notify when the restore flag is changed. Modify ShouldRestore to add the account id as the parameter for multiple profiles. Add the unit test to test the RestoreFlagChanged callback when the restore flag is modified. Modify FullRestoreServiceTest to use the new interfaces BUG=1146900 Change-Id: Ic0f7e1bed0d86388035f4a6175122ce7971d92b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596730 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
