- 30 Jul, 2020 40 commits
-
-
Ewann authored
- Adds a new Context Menu with a "Copy" action. - Wraps the old implementation with a feature flag check. - Adds metrics for the new context menu and its action. Bug: 1093302 Change-Id: Ie94fa67e728cc3b6ba56ec0389df88ce8356b8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325612 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793065}
-
Yuki Shiino authored
Replaces the old-fashioned NULL with nullptr, which is more type-safe, in the android builds. Change-Id: I81d03371ffe48d89bb462cac35caefe40947fe57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327090 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#793064}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4bbc9d8ec4f..94cefeff50d2 2020-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dc8e77f0e521 to 08a3cc4cfbaa (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I82b2a465b0ba37b9839782bdbab2dc7bb5907112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328304Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793063}
-
Peter Kasting authored
* Update the visual state when getting added to the widget. Otherwise the state may be incorrect until the first time GetVisualState() is called for some other reason (e.g. the button is hovered). * Don't consider widgets "inactive" for this purpose if they can't be activated to begin with (e.g. menus). Bug: 1106631 Change-Id: I9238498d91e515b03b6c04bc22014e84aff7057c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325273 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793062}
-
Alex Rudenko authored
This CL implements calculation of authored sizes per CSS grid track by resolving repeat() functions in matching styles obtained from the style resolver. This implementation supports the basic and more common use case where grid templates are defined without using CSS variables. Frontend CL: https://crrev.com/c/2308543 Screenshot: https://i.imgur.com/EZky6gD.png Bug: 1105808 Change-Id: I13beb4a5455f86c8e2334dc9da929acc8217406a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308412 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793061}
-
Andrew Moylan authored
Per pkasting discussion in crrev.com/c/2318967, crrev.com/c/2328297 adds a DCHECK enforcing divisibility of the constructor arguments that makes this if() sure to be false. Replace with a DCHECK. Bug: none Change-Id: Iee2707ef7fa071f44c43c4fe02709a9f8829d4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328393Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793060}
-
Mitsuru Oshima authored
This also matches the meaning of the flag "only_draws_visible_content" in draw_property_utils.cc, i think. * Updated the WebContentsImpl browser tests to use larger web contents size so that the changed area is visible. * Expectation in LayerTreeHostTest is changed to 25,25, which is the size of the layer. 26,26 was due to the rounding error caused when scaling back and forth in SurfaceLayerImpl::GetEnclosingRectInTargetSpace. The visible rect does not have this issue, so changed to Size(25,25) * Keep the original logic when copy request is made. Bug: 1106412 Test: covered by unittests Change-Id: Iad2dbf2ca233d87436d48ec5658b1f3799cb3fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302774Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#793059}
-
Adam Rice authored
This reverts commit d21d27e7. Reason for revert: This test is failing on linux-blink-cors-rel and Linux Tests bots. For example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/92553 Original change's description: > Add DNS Probing and Canary Check for Isolated Prerender > > Adds DNS probing to Isolated Prerender which can be enabled by an > experiment. > > Also adds a canary check, similar to the now removed data reduction > proxy canary check, which removes the need to do probing before each > prefetched navigation. Canary checks vary by network and are cached in > the browser prefs, which is all done through the AvailabilityProber. > > Bug: 1109992 > Change-Id: If1c00e692a7ba8e214a4ce4a7360a63d5835bcc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324106 > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792906} TBR=tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,dullweber@chromium.org Change-Id: I3a7d3af8933c06eeb42b070b46266dd7d622dcf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328095Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#793058}
-
David Stevens authored
This change adds a |no_damage| flag to SharedQuadState that viz clients can use to indicate that the quad doesn't contribute damage to the render pass. Exo is updated to use this flag. The new flag is then used in SurfaceAggregator to expand the occluding damage optimization to apply to any quad which is explicitly marked as the only damaged quad in its render pass. Bug: 1082082 Change-Id: I75b01ad724c6f0227cc1076185f301237310bc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275283Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#793057}
-
Timothy Loh authored
For some DLC errors, we require the user to update their device / reboot before we can proceed with installation. There's no point in showing a retry button in these cases. Change-Id: Ic048d642bfe8cdeb4f46d050993aa04d2cd23278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327093 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#793056}
-
Xiaocheng Hu authored
Bug: 1110793,1078474, 932343, 1111008 Change-Id: I448faee6ea27cb70be5617d80585b02ec3641c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327281Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4a89ed360b5f..6a4141463b6b 2020-07-30 sadym@chromium.org Update Protocol Definitions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090802 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f5d9688dd56ce18f364cb3f10412328f274febc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328300Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1110873, 1107431 Change-Id: Ie6b181786d0e5757288902346d4321c6c0116f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327134Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/667e15d86eec..561209ae0786 2020-07-30 fancl@chromium.org auto-triage: Fix parsing revision info from row If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103372 Tbr: eseckler@google.com Change-Id: I51c50a7a16e781f201477e7b5c9b46aca465f53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328299Reviewed-by:
-
chrome://nearby-internalsJuliet Levesque authored
Add a tab that will eventually display contacts after triggering the ListContactPeople RPC, either by standard call or by force. See the following screenshot for display: https://screenshot.googleplex.com/euebXqfBwb5. The page will eventually be added as an observer of the NearbyShareContactManager. Bug: 1093634 Change-Id: I49d3b18a4164e99bab68e1dee5e1a431caa83e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305953 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793051}
-
Eugene But authored
This histogram is still useful and will be useful at least until Chrome for iOS switches from Breakpad to Crashpad. Bug: 1109942 Change-Id: Ia9e3eebd2fb6f813e40ddba91d1b08ecdb90d32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327082 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#793050}
-
Keith Lee authored
This is needed for assistive autocorrect feature on ChromeOS. See b/149796494. Bug: 1108170 Change-Id: I6a7269966d3aa200db382ea46b3f9084c9a87b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325300 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793049}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ida008f69a4fdf059f0adb438c817ef5f168e64f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327617Reviewed-by:
-
David Bertoni authored
Bug: 1093066 Change-Id: I5dc3c7c9771793825dfa8e6ea89dc94a253b0a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321949Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793047}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f73c4f9367e..29cb43d47b7a 2020-07-30 thestig@chromium.org Fix build with -Wc++11-narrowing. 2020-07-30 thestig@chromium.org Fix typos in FPDFStructTreeEmbedderTest. 2020-07-30 thestig@chromium.org Roll build/ a6687877a..d9dd0f9de (142 commits) 2020-07-30 thestig@chromium.org Roll tools/clang/ 6849229b3..6cbea33c9 (9 commits) 2020-07-29 tsepez@chromium.org Stop caching CXFA_LayoutProcessor in CXFA_FFDocView. 2020-07-29 thestig@chromium.org Roll third_party/skia/ 3a608e5bc..994ce8cf2 (26 commits; 1 trivial rolls) 2020-07-29 thestig@chromium.org Consistently put "Experimental API" comments at the top. 2020-07-29 thestig@chromium.org Tell git_cl.py to use "pdfium:" bug prefix in CL descriptions. 2020-07-29 thestig@chromium.org Roll third_party/skia/ 1e6460d55..3a608e5bc (582 commits) 2020-07-29 ehmaldonado@google.com Enable gn check for //samples:pdfium_test 2020-07-29 thestig@chromium.org Use pdfium::Contains() in a few more places. 2020-07-29 thestig@chromium.org Remove an unreachable condition in GetXFAEntryFromDocument(). 2020-07-29 tsepez@chromium.org Make CFWL_Widget::m_nEventKey be sequential uint64_t 2020-07-29 tsepez@chromium.org Remove CFWL_NoteDriver::ClearEventTargets(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I88eb282a2503ce90580e42b901dda840fb1dbfba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328039Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596049147-04f4413ea8a529a37f9708a4b92ad78989005413.profdata to chrome-win32-master-1596059895-59b56ccb13227cc029c0a7ad89a5c58f2984c9ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ie630024c8876da13f1e83f968f068af5eeab3d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328292Reviewed-by:
-
Andrew Moylan authored
For the purpose of clearing stale buckets, Log() was effectively treating events with timestamp > duration as though they effectively timestamp % duration. Added a test that catches this and implemented fix. Bug: 1111212 Change-Id: Idc19973ae1681cc06a96144c612ea3482f2cd5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328092Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Auto-Submit: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793044}
-
Olivier Robin authored
It can be very useful when developing features to access the sandboxes. This CL adds the possibility to dump the sandboxes to the Document directory, which is accessible via the finder. Change-Id: I0f760fdf59350dc85744048f374b8585392cc670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316365Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793043}
-
Manuel Rego Casasnovas authored
Change-Id: I9236dddb403c2511d118a3187edf8a75f6ca29bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327671Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#793042}
-
jongdeok.kim authored
before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=458990&signed_aid=9JrAtvUT-p1_HO2J7uz7ow==&inline=1 after : https://bugs.chromium.org/p/chromium/issues/attachment?aid=458991&signed_aid=0yyzmMZ4CZQSFMv7Dm-YMQ==&inline=1 Bug: 1110524 Change-Id: I49b433d51028527e69c0401a34d5c15d5a7acc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327357 Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#793041}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/398c654ce7be..a4bbc9d8ec4f 2020-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from c11a19145f1f to 03cf7c3eaeaf (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8fdebcd6063c5bd1985dd6c30e5d0eb269b007c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328294Reviewed-by:
-
Adam Rice authored
This reverts commit fd1c45a7. Reason for revert: Causing test AccessibilityActionBrowserTest.IncrementDecrementActions to fail. See for example https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19799. Original change's description: > Use PaintInvalidator to optimize AX bounding boxes > > Previously, any time there was a layout, the accessibility > serialization code would scan every AXObject to see if any > needed to update their bounding box. > > Instead, replace this with a mechanism that uses > PaintInvalidator to mark AXObjects that might have > dirty bounding boxes. > > Existing tests already provide some coverage; if you > comment out the code in paint_invalidator.cc, a > handful of browser tests fail. > > To provide even more coverage, a debug-only check > walks the entire tree and ensures that no nodes > have incorrect bounding boxes. If you try commenting > out the code in paint_invalidator.cc now, hundreds > of browser tests fail. This provides some good > confidence that it's working correctly. > > Finally, add a new blink perf test demonstrating a > simple scenario where this results in a dramatic > speedup, just by focusing links in a document with a > few thousand nodes. > > Bug: 1109081 > AX-Relnotes: makes accessibility less sluggish on very large web pages > > Change-Id: I51a89d0b37ff356c5443b324080acefe0e7f3fbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319411 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792949} TBR=dmazzoni@chromium.org,wangxianzhu@chromium.org,aboxhall@chromium.org,haraken@chromium.org,nektar@chromium.org Change-Id: I3f44fc1c97dbe1690b881cb233b46f060f49ca72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326560Reviewed-by:
-
Peter Kasting authored
This code can use TimeDelta::operator%() to express the same thing in a shorter way. Add a comment on one less-obvious block. This relies on the buckets exactly dividing the duration. Add DCHECKs and documentation to that end (it is already true in all users). Bug: none Change-Id: I67a6269de8fc4a56c716decd5d06008e680f7fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328297 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This is a follow-up of crrev.com/c/2299681 Bug: 839389 Change-Id: I190216d401f04cc56d1e3ae7501e6c57514c5920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326855 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#793037}
-
Peter Kotwicz authored
This CL updates KnownViolations based on changes to the internal version of KnownViolations.java BUG=2327468 Change-Id: I594cdc210dadcb05d2601476e0ccfbcef763073a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327829Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793036}
-
Peter Kotwicz authored
This CL: - Re-enables the "No synchronized method" errorprone check. Synchronized methods have been disabled in Chromium since 2012 (crbug.com/143971) The check was unintentionally disabled last year. - Replaces the synchronized methods in PseudoTab.java with synchronized blocks - Adds an exception in NoSynchronizedMethodCheck.java to handle overridden Android API synchronized methods like Exception#fillInStackTrace() BUG=1104558 Change-Id: I3a4531aef2e7c8cf714e946243e3cfea51c17ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294559 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change improves util::ranges::begin() and end() by adding constexpr support and making them prefer a member function over a free standing function. This serves to close the gap to std::ranges::begin() and std::ranges::end() as specified by the C++20 standard. Furthermore, special constexpr support is added for std::array, which otherwise only has constexpr support in C++17. Lastly, it moves the functions from the iterator.h to the ranges.h header, since in C++20 these functions are present in <ranges>, not <iterator>. Bug: 1071094 Change-Id: Id5f3b7ff83b3fb336286f4ed2d4fe8a6cfcf0b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325171Reviewed-by:
-
Ionel Popescu authored
This reverts commit 1f6fb0c5. Reason for revert: the CL has changed the behavior of webkit-appearance: none for -webkit-search-cancel-button and this may not be web interoperable due to its high usage[1]. [1]: https://chromestatus.com/metrics/feature/timeline/popularity/2314 Original change's description: > Update the x icon for input type=search > > This CL updates the icon for input type="search" to match the spec. > > Added several search appearance tests to validate the new UI. > > Bug: 1099643 > Change-Id: I4d44069443632f09ebbdbad6e6a670ad66a8736e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275947 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#784346} TBR=tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1099643, 1110844 Change-Id: Ie9c9634c1eecf93996118845a1511f45309669b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327755Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793033}
-
Mitsuru Oshima authored
This is no op and should be ignored for exo. Bug: 1107510 Change-Id: Ifeb961570f0c19850dd87a31037f79fb83b8737a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321061 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#793032}
-
Adam Rice authored
This reverts commit 18d1b898. Reason for revert: Test ConversionsUseCounterBrowsertest.ImpressionClicked_FeatureRecorded consistently failing on Linux Asan Lsan bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/80021 Original change's description: > Add UseCounters for Conversion Measurement API > > Adds Blink Usecounters for impression registration, conversion > registration, and a composite usecounter for both of those events. > These are necessary to measure the percentage of page loads using the > API, for running an origin trial. > > A new test harness is added in the chrome/ layer to verify that > metrics are recorded as expected. > > Bug: 1109079 > Change-Id: I2f70bb3a2eac60ff45a5654169b4db959fd1d3f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314843 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792856} TBR=thakis@chromium.org,japhet@chromium.org,csharrison@chromium.org,johnidel@chromium.org Change-Id: I93dc0b42b6684777dff0106300ef64d00366fd42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326796Reviewed-by:
-
Joel Hockey authored
Previous crrev.com/c/2318945 changed Terminal to have its own registration, but it did not correctly merge any existing pref values such as last_launch_time. Changed Registration to always move base::Value in for prefs_. Change-Id: I0774c07d0e5b9d3bdb4d5057a1996912339cf87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326552 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#793030}
-
Alexander Dunaev authored
This is a reland of df7ff136. The previous version caused flakiness in interactive_ui_tests, namely BookmarkBarViewTest22.CloseSourceBrowserDuringDrag. That test checks that closing the source window of the drag doesn't cause a crash. The issue was that the window (which implements WmDragHandler) is sometimes destroyed before the DnD client, while the latter had a raw pointer to the former to call its WmDragHandler implementation. Here I propose a safe way for the DnD client to call the WmDragHandler implementation. The interface now has a weak factory so callers that do not own the instance of the implementation are encouraged to hold the weak pointer. Also, the test itself has issues; it seems to be flaky by design (the order in which the window and the DnD client are destroyed is not guaranteed). I have filed an issue [1] for that. [1] https://crbug.com/1106379 Bug: 990756 Change-Id: I50517fb5e0d7fbb8f3863029d5296837dcd6bf05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299339 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#793029}
-
Ian Kilpatrick authored
In order to determine the correct size to resolve %-based relative top offsets against we need to determine if the available-size given to a flex-item is definite. Previously this worked as there was a bit on the LayoutBox which captured this information. This patch for NG flex-items allows for looking at the previous constraint space while outside of layout. Bug: 1108508 Change-Id: I3104b7afd4d96b707a8110eb2ed5d59d17129580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327838 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793028}
-
Joel Hockey authored
Linux files root does not currently show 'Open' in the action bar, or allow open-with for terminal since it is a VolumeEntry and is filtered out by util.isNativeEntry from being passed to getFileTakss. Using util.isFakeEntry now since VolumeEntry is ok to pass to getFileTasks. Bug: 1097715 Change-Id: Ib995fda32b9baa1cf2b79ac67ffd613d6da44aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327092 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#793027}
-
sauski authored
The security_page_tests currently test the page navigated to by the security_keys subpage. The target of this navigation is constant and similar behaviors are not tested elsewhere in settings. This CL changes the test to test the visibility of the link row, which does change depending on platform and flag state and has significant testing precedent. Bug: 1111027 Change-Id: I37814b531e4f174c8a9d46ec72f1c920b358d545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321413 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#793026}
-
