- 25 Nov, 2019 40 commits
-
-
Mikel Astiz authored
Prior to this patch, the two existing functions to build GUID-keyed maps were heavily coupled and there were fragile underlying assumptions that made it work (e.g. there were potentially entries in |guid_to_remote_node_map_| that didn't actually match any local GUID). Instead, let's centralize the matching logic into one single function, and adopt a unified map to represent the matches. This simplifies the code and enforces more strict invariants without the need for DCHECKs. Bug: 978430 Change-Id: Ieea0db8d43376e204b793dcc64b2dc84d521b289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929216 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#718580}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ibb7dafa9011c83fb40a268b7484984fe121cc934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929824Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718579}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I6300c4e09253c6d28cb48fcf05ac3697a5877516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930570Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718578}
-
Aya ElAttar authored
Moved the browsertests of safe browsing policies and content settings policies and all related stuff from policy_browsertests to separate files. Bug: 1002483 Change-Id: If7a659bb7256ef3593802bb12cc89735bd636cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929225 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718577}
-
Alex Danilo authored
Setting overflow-x:scroll forces a scroll bar to be shown. On the sub-menu, use overflow-x:auto always so the browser handles deciding when a scroll bar should be drawn. No new tests, covered by existing unit tests. Bug: 1001481 Change-Id: Icf84c0ea9a40b65383bcb7be23be84d2f0ee3a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933858Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718576}
-
David Roger authored
Dice migration is complete now. Bug: 777774 Change-Id: I3637199e6607db5a0f30e1760c66367e7a31eb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928704 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#718575}
-
Marc Treib authored
Bug: 975956 Change-Id: Ice65c1cabd5dab3ea8764a81dff137cb816b492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919141 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718574}
-
Noel Gordon authored
The icon are currently drawn cut-off in the 16px item-icon box. Assume they have a 0 0 20 20 viewBox. Add that to their SVG and scale down to 16px x 16px (width x height) to center them in the .item-icon box. Bug: 1028050, 955920 hange-Id: I8da467fd33d5c526f73772b26480b9dd46ec9bf6 Change-Id: I8da467fd33d5c526f73772b26480b9dd46ec9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934129Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL temporarliy disables web tests that will be impacted by the upcoming top-level await implementation in V8's REPL mode. There are two changes that require layout tests to be disabled: V8's implementation of top-level await: https://crrev.com/c/1900464. Removal of manual wrapping of async/await code in the DevTools fronted: https://crrev.com/c/1928927. Some of the web tests are disabled because V8 REPL mode *always* returns a promise, resulting in slightly different stack traces. These need to be rebaselined but are included in this CL to make reverts easier. Bug: chromium:1021921 Change-Id: If262b66b51168265f1582c9b5f5d85dcd92525ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930656Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#718572}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d493dead. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 38d64f34 "Make DecompressionStream error checking stricter" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If771aac5a5706595aed87ef1085497a22b6bfe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933476Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718571}
-
Henrique Ferreiro authored
WebSandboxSupport::GetFallbackFontForCharacter() and MatchFontByPostscriptNameOrFullFontName(), FontCache::GetFontForCharacter(), gfx::GetFallbackFontForChar(), and CachedFont::GetFallbackFontForChar() were relying on returning an empty filename inside their FallbackFontData out parameter or return value in the case of failure. This CL changes them to explicitly return a boolean value. Change-Id: I4d81caa9bd3a173d7c37cd871c6a9373c56bc157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926136 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718570}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e9b68f332a30..b1393d70e91a git log e9b68f332a30..b1393d70e91a --date=short --no-merges --format='%ad %ae %s' 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 45dde9ad6dde..85f3e93d13f3 (1 commits) Created with: gclient setdep -r src/third_party/angle@b1393d70e91a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: courtneygo@google.com Change-Id: Idddbb0876afe9fe564a3d3050dde5705ae69b049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718569}
-
Michael Ershov authored
The test was marked as flaky more then a year ago. The bug from the TODO is fixed and closed. And I was not able to reproduce the problem localy and via several runs on test servers. Bug: 877416, 787602 Change-Id: Iae0d816c94dedbfb0db779a7b492e7619eba1939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926480Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#718568}
-
Amy Huang authored
The warning was fixed upstream in d9957c7405b so we no longer need to disable the warning in top of tree clang. Change-Id: I27e8e7f13b28a27df6df7d6aae6e76c54be26100 Bug: 1026283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929866Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#718567}
-
Rune Lillesveen authored
Test relied on html parsing continuing before sheet in head was loaded. That is not the case with BlockHTMLParserOnStyleSheets enabled. Bug: 891767 Change-Id: Iec83d26fd55cd8e667ba7b321e7f89cca16597fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928784Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#718566}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/45dde9ad6dde..85f3e93d13f3 git log 45dde9ad6dde..85f3e93d13f3 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 mattst88@gmail.com Respect CMAKE_INSTALL_LIBDIR in installed CMake files (#3054) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@85f3e93d13f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I6dfbef591b840beaf0f80fde58ee16096a175edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934087Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |client_uuid_| from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I992c0edb537d5e76b5f0c1b499c68491f7bfd231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933843 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718564}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4584a9c2ccb9..afc52b0b26d7 git log 4584a9c2ccb9..afc52b0b26d7 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 bclayton@google.com Fix build: Do not return stack temporary. 2019-11-25 bclayton@google.com Fix chrome build: Use spaces (not tabs) in .gn files (2/2) 2019-11-25 bclayton@google.com Fix chrome build: Use spaces (not tabs) in .gn files 2019-11-22 chrisforbes@google.com Fix vkGetDescriptorSetLayoutSupport implementation 2019-11-22 srisser@google.com Log unsupported extensions used in pNext structs Created with: gclient setdep -r src/third_party/swiftshader@afc52b0b26d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/139528538,chromium:b/139528538,chromium:b/139528538,chromium:b/145007346,chromium:b/139528538 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9666a01bb3e8a4d7ceac42e2b6854753e30f083e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932034Reviewed-by:
-
Sergio Villar Senin authored
We can get rid of NaN by replacing the return value (double) with an Optional<double>. This allows us to remove several IsNull() or ValueOrUnresolved() calls as we can just use the Optional as a boolean. Last but not least, the NullValue() added in crrev.com/c/1928781 are no longer needed and thus were removed. Bug: 737867 Change-Id: I5aa530f58ab648d6dc486122d9a8f8c121f2d057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929218Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#718562}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b0b37898a3..cbc3e409299b Created with: gclient setdep -r src-internal@cbc3e409299b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: If806b4ad0d459532f29514adb7e3ed6a3e370682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718561}
-
Yao Xiao authored
Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/JdAQ6HNoZvk/xvDKF3GyDgAJ whatwg/html issue: https://github.com/whatwg/html/issues/3236 Bug: 539938 Change-Id: I0abeb1bb462806a65468b25cb30e5cb82f68cafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872306 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Eric Willigers authored
When using minimal-ui on Windows 10, the icons are now consistent with the native Windows 10 Back and Reload icon style. The main browser toolbar is unchanged. TBR=antrim@chromium.org Bug: 1026069 Change-Id: Ic243e22f08f4ce7467db1058e2fff948a0be854e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924180 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#718559}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I460a9d7fa5f9f0e0c25eee3a75b0813524ec937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932148 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#718558}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I41642b09c0fe8a24c9d32eb29b82f9c4a58fd698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932147 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ian Struiksma authored
For each input element, we grab the autofill information from the html element and log it. FormCache writes to 2 elements, and sometimes title is used on the page, so switching to use "autofill-information" instead Also, making the lack of this element a simple log line instead of a failure as it doesn't affect validation or execution of test. Bug: 984664 Change-Id: I934db1eb8d787a8fe799525bda14a33ee0cfa72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931656 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#718556}
-
Yuki Shiino authored
This patch implements the algorithm, plus introduces EffectiveOverloadItem for type safety and ease of access. Bug: 839389 Change-Id: I6e7bafc0f36336f26f699031df53d0f419a20927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932138 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4ec3efef499f..4706026ed847 git log 4ec3efef499f..4706026ed847 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 abennetts@google.com Wait for Polymer to be initialized before invoking it. 2019-11-25 fancl@chromium.org Dockerized dashboard testing & deploying Created with: gclient setdep -r src/third_party/catapult@4706026ed847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026356 Tbr: crouleau@chromium.org Change-Id: If19f69b9cf0c386d89bb7e816c2d0fe76d1956fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932031Reviewed-by:
-
Alexey Baskakov authored
Implement the following API to support user initiated installation from UI. - CanUserUninstallExternalApp - UninstallExternalAppByUser - WasExternalAppUninstalledByUser For example: it implements the scenario if a user uninstalls a default app ('default apps' are considered external apps). This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 901226 Change-Id: I13149af5cfce83a2e4aa2ee15c9dcc1c031b4717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933680 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#718553}
-
yu han authored
Previous to this CL, clicking on an inline element embedded in an anchor placed inside a <summary> tag will expand the <details> section instead of navigating to the anchor's href. However, when the anchor is placed outside of <summary>, it behaves correctly. The error is caused by DOMActivate event generated by the inline element. As DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the <summary>, and is handled there. Once DOMActivate is handled, the original click event stops propagating and terminates. This behavior, however, differs from when the anchor tag is placed outside of the summary. DOMActivate isn't handled, and the original click event keeps bubbling up till it's handled by the anchor. DOMActivate event is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event. However, since blink still has code that depends on it, replacing it is outside of the scope for this fix. Instead, this fix is for the anchor element to handle the DOMActivate event as it bubbles up. The anchor event handler checks the underlying event of DOMActivate and handles it if it's a click. I also looked at an alternative fix by trying to prevent the DOMActivate event from bubbling up. But calling event.stopPropagation() doesn't work as the EventDispatcher::DispatchEventPostProcess doesn't check this status. Bug: 538283 Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718552}
-
Yuki Shiino authored
IdlType.unwrap supports variadic={True,False} in addition to nullable and typedef. Bug: 839389 Change-Id: I2f2d2cb2a79e0c33f56ab9df4d322f778c756dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932137Reviewed-by: -
Colin Blundell authored
Helps to clarify what the //chrome dependencies in CaptivePortalBlockingPage actually are in starting to analyze strategy for sharing captive portal implementation with WebLayer. Bug: 1025059 Change-Id: Iaf27f63e4cb595e927c674a761c028fb56190ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929237Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718550}
-
Hitoshi Yoshida authored
'dict_' is commonly used in dictionary.py, but it's obvious the file focuses on dictionary classes. This CL drops the redundant common prefix. Plus, make it consistent, put 'dict_' prefix on 'member' in function names. This change makes it clear "dict_member" figures dictionary members from the scope of *public* functions. Bug: 839389 Change-Id: I0e8662c323c0dce5a4edfc70d39966434aebb6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933853Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#718549}
-
Yuki Shiino authored
Supports expression objects, which are constructible from web_idl.Exposure, and basic logical operations. Bug: 839389 Change-Id: I8d402a41cdd0f3fc185c8302578605f560af1472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930760Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8bfc516141d..9c0c92b2db86 git log d8bfc516141d..9c0c92b2db86 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4c7db77e0185..e9b68f332a30 (5 commits) Created with: gclient setdep -r src/third_party/skia@9c0c92b2db86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: Ie16b783d9e279050ad9d512f3f8089e07233f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933646Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fae2545ff9e..e1b0b37898a3 Created with: gclient setdep -r src-internal@e1b0b37898a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I8ddd2b16e8c62648e113cb57c552289cc2eddf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933645Reviewed-by:
-
Kenichi Ishibashi authored
To avoid unwanted diffs when we move these files into a different place. This CL also replaces direct use of SequenceChecker with SEQUENCE_CHECKER() macro as `git cl upload` suggested. Bug: N/A Change-Id: I7aa8a0d805783d2dd4e42cbd9e9c7b87a5010f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933675 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#718545}
-
Ramin Halavati authored
Size 25 is added to incognito icons (formerly 24 and 20) for better support of scale factor 125%. Bug: 997054 Change-Id: Ia1028f2262490d4aa6d78e69fa0e90638f993b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886330 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Adam Rice authored
Error the stream if the input to DecompressionStream is truncated, or there is junk after the end of the stream. This will help avoid accidental loss of data. Also add a thorough test of the behaviour when various fields of a compressed stream are corrupted. Also test that errors are correctly issued when the stream is truncated or has trailing junk. BUG=1014422 Change-Id: I8aceeafd279b75d4fea76d7edca19024856417c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928428Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#718543}
-
Yutaka Hirano authored
Files I'm familar with have been moved to /services/network, so I am no longer a good reviewer for changes on this directory. NOTRY=true Bug: None Change-Id: I8e4439486735dd319a2ef2ed63b316b997509f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933857Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#718542}
-
Emircan Uysaler authored
This CL would allow us to enable work that are behind feature flags. Bug: 1026011 Change-Id: Ifaa69e184811ffe0062cc10389b31e54fc8a76db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931657 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718541}
-
