- 08 Oct, 2019 40 commits
-
-
Moe Ahmadi authored
Replaces the lower_term column in the keyword search terms table which contains search term in lower case, with a new normalized_term column containing the search term in lower case with the whitespaces collapsed which will be used as a key to delete entries in addition to prefix search. Depending on whether a search is initiated from the omnibox or the web, the search term stored in this table may or may not have its whitespaces collapsed. Since both of the following searches result in the same zero-prefix suggestion, the new column can be used as a key to delete both entries. Omnibox search: https://www.google.com/search?q=WEEKLY+NEWS&oq=WEEKLY+++NEWS+&sourceid=chrome... Web search: https://www.google.com/search?q=WEEKLY+++NEWS+++&oq=WEEKLY+++NEWS+++&... Bug: 996516 Change-Id: I7ae5bd6a6992480b3e394499a9b94ca11d1fc8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832903 Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703869}
-
Khushal authored
We currently only do this to disable GMBs but allocating any texture greater than this size is not possible. R=fserb@chromium.org Change-Id: I9c453258eafe9ea963bf5bbe405b9ea623188b27 Bug: 952853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846476 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703868}
-
Lan Wei authored
Use testdriver Action API to automate wpt tests with two touch fingers, pointerevent_touch-action_two-finger_interaction.html. Bug: 606367 Change-Id: Ia5a0977b3bda9c506dae99c7bfe500fe2a887cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839017Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#703867}
-
inglorion authored
Previously, we used bitwise operations on booleans to keep track of whether we are 32-bit aligned. This code ran afoul of Clang's new -Wbool-operation and didn't implement the intended behavior. This change fixes the bug uncovered by the warning and implements the intended logic using boolean operations. Bug: 1011810 Change-Id: I4a7275a4e8da274115fa8ae85c90448c036200ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846481Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#703866}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1458d572f950..352808fa158d git log 1458d572f950..352808fa158d --date=short --no-merges --format='%ad %ae %s' 2019-10-08 ehmaldonado@chromium.org git-number: Make tests run on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@352808fa158d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009809 Change-Id: I78321c948fb61e27078b95230478c5b5f4467625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703865}
-
Austin Eng authored
Dawn is only supported on Windows 10 Bug: dawn:208 Change-Id: I13a643953601fe895bba4681bacac370f6724663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846040Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#703864}
-
Lei Zhang authored
The 64-bit test DLL added in https://crrev.com/702886 does not work on 32-bit bots. Switch to a 32-bit DLL and re-enable FileVersionInfoTest.NoVersionInfo on 32-bit bots. Bug: 1011439 Change-Id: Ib7553b5455bdb0195bd8e36d9167d8c249242ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842524 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#703863}
-
Andrew Grieve authored
Bug: 982762 Change-Id: I0bd114dff67bf1a1e8bf8868f13e1f96d5c8f79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837200 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703862}
-
Vladimir Levin authored
This patch adds a new use counter, kRenderSubtreeAttribute, to track usage of the feature. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I2d2d9e19a3853941b3fc002592f4b971db23f982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846569Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703861}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b4161d3c0d43..46b01401724c git log b4161d3c0d43..46b01401724c --date=short --no-merges --format='%ad %ae %s' 2019-10-08 saza@webrtc.org Update filter analyzer for multi channel 2019-10-08 daniel.l@hpcnt.com Fix build errors of RTCAudioDeviceTests 2019-10-08 mbonadei@webrtc.org Stop using goma for MSVC bots. 2019-10-08 notorca@gmail.com SetStreams API of RtpSender wrapped for iOS and Android 2019-10-08 ssilkin@webrtc.org Fix cropping in H264 decoder wrapper. 2019-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 977e7324..baa7b585 (703537:703669) 2019-10-08 phoglund@webrtc.org Add #COMPONENT to WebRTC. 2019-10-08 ilnik@webrtc.org Improve bitstream dumping logic to handle multiple SLs correctly Created with: gclient setdep -r src/third_party/webrtc@46b01401724c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1006238,chromium:None,chromium:977050,chromium:none Change-Id: I1db1fb4d421857a79735890b22bf689e582be38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847863Reviewed-by:
-
Elly Fong-Jones authored
This is now statically set for all dialogs at creation time. This does not affect the behavior of any existing dialog. It appears that ExtensionInstallDialogView intended to be draggable iff it had no parent set, but it had no logic to actually set its parent, so it was always draggable; this CL preserves that behavior. Bug: 1011446 Change-Id: Ia901e2fc6e540022e813caf34b9a7fffb4c2f610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846090Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703859}
-
W. James MacLean authored
When the last MimeHandlerViewFrameContainer has been removed from a manager, and it's serving an embedded MimeHandlerView (i.e. not a full page MimeHandlerView), delete the manager by removing it from the map. Bug: 1005992, 1004804 Change-Id: I445b13fd33ea029adbbb256cffb572d3078b1d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829652Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#703858}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/tracing to the recommended methods/types. Bug: 1007831 Change-Id: Id97b214aa5c8d9f143ff7b1d3bf506a2350db495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837812 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#703857}
-
Jonah Ryan-Davis authored
WebGL call to glShaderSource failing when a comment after a preprocessor directive contains any non-ascii characters. Bug: 940865 Change-Id: I57fb201ec88d73093776c7d200d62cc9e7ce2b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846073Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#703856}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ebf5965. With Chromium commits locally applied on WPT: c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." 3e138a8e "[LayoutNG] Fix line breaking when `font-size: 0`" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I13ecc0dba41898de00eac9d65fb96e35dbc7daaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847832Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703855}
-
Sergey Kipet authored
Since recently, Chrome started to fail while building for the Ozone/Wayland backend. The libgtkui::GtkEventLoopX11::GetInstance() symbol is now considered as undefined by the linker, if the target is configured to run on Wayland. CL fixes the link-time error by moving the X11-related code of the library (particularly, inside the gtk_ui.cc source file) under the newly introduced USE_GTK_EVENT_LOOP_X11 conditional compilation flag where checking on whether a target platform is Ozone/X11 is performed. Test: configure Chrome browser for running on Wayland and build the target. Bug: 1011277 Change-Id: I0236f92e05c2525cd72e2643ecd4772c059e27ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843972 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703854}
-
zhaoyangli authored
- Moved autofill form suggestion a11y identifiers to a new constant header and created a target for it in BUILD.gn file. So that EG2 tests can include only the constants target to access the constants, without pulling app related targets. - Changed influenced header imports. Bug: 917114, 987646 Change-Id: I23aa34730773fad82169ed4aecca827c74150ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842594 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703853}
-
Xiaocheng Hu authored
When animating a 'translate()' function with a <length-percentage> parameter, the current code incorrectly thinks this is not a length and does not include the length units into a LengthUnitsChecker. As a result, the animation is not properly invalidated when the relative length units in the parameter change value. This patch fixes the issue by including the length units in <length-percentage> parameters into the LengthUnitsChecker. Bug: 1004096 Change-Id: Ib869b42e99683ada69c6e3bb50a943f82f25bcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846041 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703852}
-
Jacob DeWitt authored
Per the WebXR spec, the viewer pose should have emulatedPosition = true when the headset only has 3DoF tracking - either by its default capabilities or due to temporary tracking loss. Fortunately, the GVR API exposes a "has 6DoF tracking" property that we can check. Bug: 1011105 Change-Id: I2a80322c76c708d686b1fa89a57bb7374bed0999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845992 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703851}
-
Ken MacKay authored
This reverts commit 51439d26. Merge-With: eureka-internal/321778 Bug: internal b/127963522 Bug: internal b/141138924 Change-Id: I192bd87c0e766aef66ed6b8c7004c026cde0fbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846314Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#703850}
-
Jeffrey Kardatzke authored
This removes the usage of Ozone directly in PlatformVideoFramePool via the associated util file. This will allow for unit testing of more code since the whole Ozone dependency will not be dragged into this code and we can mock out the GpuMemoryBufferFactory instead. Bug: 1007487 Test: Unit tests, video_decode_accelerator_test --use_vd, video_encode_accelerator_unittest and image_processor_test (same results as ToT for both), YT playback on nocturne Change-Id: Iabed106319ace56096a34189b9c8986a03d80653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827888Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#703849}
-
Siye Liu authored
We should call |TextInputClient::SetCompositionText| to update current composition state if styles in IME spans are changed since last edit session during same composition. Bug: 1006067 Change-Id: If87b4542447f07bd6c2f2378766e18fe4b695955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845933Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703848}
-
Caleb Raitto authored
Change-Id: I4ecf5fb92974d11d22f197adf3015ab4967b94fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846020Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#703847}
-
evliu authored
This CL contains the following changes: - Add a background image behind the caption preview text - Move the preview section to the top of the page - Remove the top padding of the preview section - Replace the opacity sliders with dropdowns Bug: 1009561 Change-Id: I659bccfbd5bac27f63afba0e4f899fb94a2e5d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831943Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#703846}
-
Lei Zhang authored
This is an adaptor to allow a caller to use base::Value instead of base::DictionaryValue to construct a dictionary value, and able to easily pass the value to a function that still expects const base::DictionaryValue&. This makes it easier to move away from base::DictionaryValue in smaller increments. Use it in one place to demonstrate it works. Do the same for list values with base::Value::AsListValue(). Bug: 646113 Change-Id: I9116525ef5a5a80d3752cdca1960d21b2288ff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838684Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703845}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f7b20a05decf..83c4c1c68dbf git log f7b20a05decf..83c4c1c68dbf --date=short --no-merges --format='%ad %ae %s' 2019-10-08 perezju@chromium.org [Telemetry] Set up intermediate_dir in GetRunOptions Created with: gclient setdep -r src/third_party/catapult@83c4c1c68dbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1012227 Change-Id: I93cb5c09953e191b1fb1f2885db994ff27808952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846941Reviewed-by:
-
sczs authored
UIAccessibilityPostNotification might trigger once the view has been niled. It is now crashing on iOS13 (Documentation doesn't say it can't be nil explicitly but a nil object is not an A11y element https://developer.apple.com/documentation/uikit/uiaccessibilitylayoutchangednotification) Bug: 989761 Change-Id: I04cb25c0cdbfc2655255b7b3bba78b258f2df458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844331 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#703843}
-
Lei Zhang authored
Modernize the code and fix lint errors. Change-Id: Id258594a62be1fc8467028fbbca008184174d314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843511Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703842}
-
Victor Fei authored
Implemented IAccessibleText::get_offsetAtPoint for IA2_COORDTYPE_SCREEN_RELATIVE with associated unittests get_offsetAtPoint invokes AXPlatformNodeDelegate:: GetInnerTextRangeBoundsRect to retrieve the bounds of each character of its text. If the input (x, y) in screen coordinate is inside one of the character bounds, we return the text offset of that character bounds. Additionally, NVDA also requires this API to be implemented in order for announcing text content on mouse over to work (crbug.com/1006277). API doc: https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_text.html#a9e6bcc4589b93498ecf84d9c8b5326a0 Bug: 996407 Change-Id: I9c91734b2defde495e0f4b64cbcd34be3b5d44c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832296Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703841}
-
Lan Wei authored
testActionsMultiTouchPoint is flaky, I change the test to wait 50 ms for the event handler to be executed before checking the length of the touch events. Bug: 1011225 Change-Id: I25b16f0c8d5a86959b9b9111c3dbe3ccb2d1ac75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846566Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#703840}
-
Robert Flack authored
sandboxed_zip_analyzer_unittest.cc uses test_utils.h which depends on browser mojom bindings. Add this dependency to resolve build errors. Bug: 1012304 Change-Id: I10b39b3b658eb07c253bf25dc60794fe784c9691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847876 Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703839}
-
Gayane Petrosyan authored
Bug: 1008813 Change-Id: I700da434baeecc626196b7e725adcf1262f558fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829943Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#703838}
-
Ken Rockot authored
This forces the Video Capture Service to run in the browser process on Windows 7 (or, theorectically, older unsupported versions of Windows). Bug: 992328 Change-Id: I89a9a724b656323bb0617dea0f31171ef8e29ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846559Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703837}
-
Chris Harrelson authored
Bug: 1008483 Change-Id: Ia3a312607d6c1b6785dc4982c305902e4eeb92b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838267Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703836}
-
Nasko Oskov authored
This CL adds some basic tests that verify process model and security expectations of WebUI. It adds basic bindings tests and a test for iframing same WebUI page. More tests will be added to this as work progresses on making WebUI be per frame and supporting site isolation. Bug: 713313 Change-Id: Ib680cf85dbfdee26d40896588edd4d7364332e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835014Reviewed-by:
-
John Delaney authored
This is a reland of abaf4c65 The original CL introdcued flakes in AdsPLMOBrowsertests. The test loaded the threshold + maximum noise to make the test deterministic. This caused a problem because we also waited for all of that data to be received. When the noise was small, the frame was unloaded before the rest of bytes were received, causing the test waiter to hang indefinitely. These waits were actually unnecessary, so tests were reordered to not use them. There was also a small issue in the change where we were recording the status without noise to the intervention type histograms, which are supposed to use the status with noise. The histogram name does not need to be versioned because this code path is not currently enabled. Original change's description: > Add fuzzing to network threshold for heavy ads > > This CL adds up to 1303 KB of uniform random noise to the network threshold > for the heavy ad intervention. This is to done to prevent frames from > learning cross-origin resource sizes in the clear. > > We add a second computed type metric to measure > the number of frames that we are missing due to the fuzzing. > > Bug: 1010619 > Change-Id: Ia48a4253beafcfbfdbdc689f2ae381dfe5a34c43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835166 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702994} Bug: 1010619 Change-Id: Ie22a1ca0cce402be63d39511e9901fbfba3024e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846313 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#703834}
-
Johannes Henkel authored
Adds a DevToolsSession::FinalizeMessage method which is called just before the message is put on the wire, converting the message to JSON if needed, and sticking it inside a Mojo object. Change-Id: Ie9005a79e3dabf65810ebd727a06460dcf79e9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846248Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703833}
-
danakj authored
This was setting the value to 0 after setting up the RenderWidget and applying the VisualProperties. That means that if the browser later tried to set the zoom factor to 0, RenderViewImpl would believe it was not being changed and not do anything. This prevented the browser from controlling the page zoom when there is a default zoom factor applied to all tabs, but it wants to change it back to the default zoom level. R=avi@chromium.org Bug: 1011366 Change-Id: I5d84d3f633bf860947481e05d3ec11d39302afbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845590Reviewed-by:
-
Ted Meyer authored
New UI allows the selection and viewing of events and properties for each media player open on the tab being inspected. This feature depends on enabling the InspectorMediaLogging flag to get any data. What's missing: - A timeline view for events - A right click menu on a media player to inspect it Design Doc: https://docs.google.com/document/d/1NMTjKc-Q99UDTS0QFoftVwhmzZTEh0fsHGQJ6I82IRY/edit#heading=h.vhj3t4rsmjte UX discussion: https://docs.google.com/document/d/1EKuv_KNFFIclJOEx6k70WMUOPgsXJs7DmMHNQayKSuI/edit?ts=5d7c04d2 Screenshots: https://files.tedm.io/dtss/5.png https://files.tedm.io/dtss/6.png Bug: 794255 Change-Id: Iff2d4f057168e7f20829ef4752f6dfcdea75a293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755008Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703831}
-
Ben Kelly authored
On some platforms the base path timestamp can be a few microseconds different from the file contained in the directory. Relax the DCHECK to permit +/- 10 microseconds difference. Bug: 1002892 Change-Id: Iebdc1685c5b3e48e674f938bd530a5247caef1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847732Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#703830}
-
