- 20 Oct, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f36d15c8..de50d966 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I68de58320d577288b4beb5a636145c874fb93b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486747Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818917}
-
David Roger authored
This CL changes the background color to match the profile picker, which in particular avoids conflicting with the autogenerated theme colors. Also update the color for the line separator to match the mocks. Screenshot: https://drive.google.com/file/d/1B0Yfy-us38ZRI0KHgCvozekOEcG_w3Q7/view?usp=sharing Mocks: https://screenshot.googleplex.com/8HMdtJasPYWktr7.png Bug: 1130945 Change-Id: I4969e0934669da767179bc96d96ab89c5a207d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485162 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#818916}
-
Fredrik Söderqvist authored
The <img> 'load' could end up being delivered before the reload() initiated by the srcset-helper.js script has taken place, so only perform the 'srcset' mutation when the scale factor has been set. This was likely caused by testRunner.setBackingScaleFactor() being changed to call its closure synchronously (which means the post-reload 'srcset' mutation would actually not cause a different image to be loaded). Fixed: 1104381 Change-Id: I390c5597645829876a1bfba9f1f2417d590aca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483829Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#818915}
-
Avi Drissman authored
Bug: none Change-Id: I4c5626a76b302c846a76dae70853d018af255bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486096 Commit-Queue: Kevin McNee <mcnee@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#818914}
-
Erik Staab authored
Also hold back browser_tests and web_tests for future steps. Bug: 1124829 Change-Id: I8a06ff377185298ee4d25a2ed6ee9fb917b4093b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482007Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#818913}
-
Yi Gu authored
Bug: None Change-Id: I2b41840e811a0141fae71ca0b82e7bfefd0cf2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485303Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818912}
-
Yuki Shiino authored
Unifies the interface template cache and operation template cache in V8PerIsolateData into a single v8::Template cache, which will be used to store any sort of v8::Template, e.g. IDL interface object's template, IDL namespace object's template, JS function's template, etc. This is a step to support IDL namespace. Bug: 839389 Change-Id: I4130c713665fcb8555ea188f2e582035468ade83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463092 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#818911}
-
Sébastien Séguin-Gagnon authored
Change-Id: I28d67c0f335681ed79a89b7a8718d1b7c864d1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485776 Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#818910}
-
Peter Kasting authored
Bug: 772945 Change-Id: I81e0523cd6397732bdbd3116724645a1c793f80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485300 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#818909}
-
Kevin McNee authored
This function is unused. Bug: None Change-Id: I70983782cfeda23f6175e6a29024c2dc1c58a273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485397Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#818908}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2f2ee2383761..429410096af9 2020-10-20 changhaohan@chromium.org Remove ComputedStyleGrouping UMA in M88 2020-10-20 alexrudenko@chromium.org Enable TypeScript for TimelineIRModel.js 2020-10-20 tvanderlippe@chromium.org Remove all definitions of usesObjectNotation 2020-10-20 alcastano@google.com Use Markdown for Mixed Content related messages in the Issue tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125465,chromium:1127956 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e9e8c918616608965b48fbdb2d04fe38a8d0493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818907}
-
Bartek Nowierski authored
Change-Id: I6cacd56a52213f0f1ff122fad84918c072a8fc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486005 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#818906}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/ed30357616a7..34a2680533d9 $ git log ed3035761..34a268053 --date=short --no-merges --format='%ad %ae %s' 2020-10-17 bnc Refactor QPACK encoder and decoder stream errors. 2020-10-17 bnc Remove spdy_endianness_util. 2020-10-16 bnc Move quiche_endian.h and quiche_endian_test.cc out of platform. 2020-10-16 wub Deflake FrontlineInfoRtt in gfe/gfe2/quic:end_to_end_test for IETF QUIC. 2020-10-16 ianswett Deprecate gfe2_reloadable_flag_quic_bbr_no_bytes_acked_in_startup_recovery false now that it's been rolled back. 2020-10-16 mattm Do QUIC Key Update when approaching AEAD Confidentiality Limit, and close connection if reached. 2020-10-16 wub Rename QuicBufferedPacketStore::ShouldBufferPacket to QuicBufferedPacketStore::ShouldNotBufferPacket. The function does the opposite of what its name suggests. 2020-10-16 wub In QuicConnection class, move stats_ to be above uber_received_packet_manager_, because the later is initialized from the former. In other words, if uber_received_packet_manager_'s constructor reads anything inside stats_ it might read garbage. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I2fe46ea57cde1e8f5daa03cb768c5c64f3dcb136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484951Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#818905}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603172634-0379c4f8f7d3cbe89c00f53d2913dcf6ff1ea486.profdata to chrome-linux-master-1603195140-c129f14cb6d511df5580572a9de378cf815e87d7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I96f81720aae6171cdf53234519793dafa967e67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487203Reviewed-by:
-
Tim van der Lippe authored
For the changes made in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484717 R=sigurds@chromium.org Bug: 1011811 Change-Id: Id4b5fdda3d81c024909e65de46afce4b312af4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484794 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818903}
-
sandromaggi authored
The |FocusElement| (action + web-action) is misnamed, it does not really "focus" the element as much as it just scrolls to it (somewhat setting the user's visual focus on it). On backend this action is called |ShowCast|, this renames it on client only. Bug: none Change-Id: Ie4629faf4e62fcfbe6f1c8072d9dd82550a233a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485108 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#818902}
-
Anders Hartvoll Ruud authored
Instead of having SelectorChecker::Match match the same selector twice, this CL proposes a way to deal with visited links via RuleSet. Whenever we add a rule to the RuleSet which contains :link or :visited, we effectively split the rule into two non-overlapping rules; one which applies to the regular style (kMatchLink) and one which applies to the visited style (kMatchVisited). The rules marked with kMatchVisited go in a separate list of visited dependent rules on the RuleSet. Then, when collecting matching rules, we try to match from this list only when kInsideVisitedLink. This way we can avoid paying any extra cost on every call to SelectorChecker::Match. Fixed: 1139464 Change-Id: I66f59acfbc0eb5e3225ab2b5be9ae572542bb8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485062Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#818901}
-
Sébastien Séguin-Gagnon authored
I'm the original creator of the folder and feature. I also landed the initial architecture CLs. Change-Id: Ie73382f1e9a611e853c231691400156e283f4ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485398 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#818900}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b03fa00934a..afa4d14527b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I12c742bce9b71da3579fb963014e6cc2a3653d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818899}
-
Olivier Robin authored
Scene UI is not initialized in safe mode. When exiting safe mode, initialize the UI of the sceneState before continuing the startup sequence. Bug: 1137310 Change-Id: I61c4a3faeed8d7728a8ecbb1b191e8621e72e4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476280 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#818898}
-
Ossama Mahmoud authored
Skip the unnecessary first screen of the Add Fingerprint flow during OOBE and Add Person flow. Bug: 1130482 Change-Id: Id3fd4063bdece9b50a55b4faa52db2a641a98cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467862Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818897}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603172634-987778035e1cace5841998f11e79079a8a8488cb.profdata to chrome-mac-master-1603195140-e7f1aee2c0a50a929699520496ae0e25b15e94bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id58807205d2e50ef2e8b91130175c38183a34b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487204Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/38688fcdba24..cd74dfa47721 2020-10-20 kjlubick@google.com [canvaskit] Add test harness for running all gms and getting output 2020-10-20 kjlubick@google.com [canvaskit] Make gm test wrapper not omit known pngs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: If53043bb48d9d6e1f70bc424f6cb48806c44feb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487141Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/749daf949871..edbb06059588 2020-10-20 jleconte@google.com Fix query when alert is stored with an empty project_id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1131908 Tbr: skyostil@google.com Change-Id: Ia5048f86116e975164dff80b0e3eb80e5847d184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487161Reviewed-by:
-
arthursonzogni authored
[android sheriff] Disable the test: NavigationControllerBrowserTest.EnsureFrameNavigationEntriesClearedOnMismatch It was previously disabled on Windows and ChromeOS, however it is flaky on every platforms: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydgsSBUZsYWtlImtjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BOYXZpZ2F0aW9uQ29udHJvbGxlckJyb3dzZXJUZXN0LkVuc3VyZUZyYW1lTmF2aWdhdGlvbkVudHJpZXNDbGVhcmVkT25NaXNtYXRjaAw TBR=nasko@chromium.org Bug: 765107 Change-Id: Id91c115fe53813dba1efd78f9bf54667260bc7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485165 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818893}
-
Yi Gu authored
This patch adds metrics to record when a prompt is timeout due to unresponsiveness. Currently prompt timeout is not handled. This patch adds necessary functionality to address that issue. Note that it only records when a single pending origin is present to avoid over-counting. If multiple origins are pending in the queue we cannot handle the failed request on a particular origin due to the lack of origin information. This issue is tracked via crbug.com/1138454. Bug: 1127397 Change-Id: I6f888261ec5ea433521d914f2498d20f100cee6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427560Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818892}
-
Boris Sazonov authored
Removes subclassing of ChromeActivityTestRule in SyncTestRule. This subclassing meant that every test using SyncTestRule would start ChromeActivity before starting the test. This was producing several issues: 1. It's hard and confusing to use SyncTestRule in tests that start other activity types: FRE tests, bookmark tests, settings tests. 2. It makes tests longer. 3. It might make tests flaky. Some tests need ChromeActivity to be started, so this CL adds a bunch of explicit ChromeTabbedActivityTestRule fields along with calls to startMainActivityOnBlankPage. This CL also fixes and cleans up FirstRunTest. Tests will be enabled in a separate CL (in case they're still flaky). Bug: 616456, 1135990 Change-Id: I5a3d4a27f051cdfc4df2d4dc12a27899084b91db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450291 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818891}
-
Alex Rudenko authored
Design doc: https://goo.gle/devtools-flex Bug: 1139945 Change-Id: I5506d17e453e2c36f632ebe580147882a1098d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485268Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818890}
-
Leo Lai authored
Previously we only check if attestation service is prepared with default ACA. We change to the check against either default or test ACA because this is how cryptohome implements TpmIsAttestationPrepared. Also, we explicitly check the status code returned by attestation service to make the problem flow more robust for future-proof reason. Note that this change doesn't introduce any effective behavioral change; this is because attesataion service always prepares enrollment with both ACA types, and the enrollment preparation table is always empty if the returned status is bad. Admittedly it will become a waste CL right after we switch to platform side attestation flow, which we are aiming at in the near future, but it might be still worth doing it for better history reading in the future because only checking default ACA is confusing. BUG=b:158955123 TEST=build ok. Change-Id: I341c8fc68b476805d700b97cd2fb6afadd30ffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466003 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818889}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I873c301e9b2870ddafd2bc13c19629534d10a914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487140Reviewed-by:
-
Andrei Pascovici authored
As part of enabling the flag described in the bug, I realize now that certain Android builds of Chrome use the gn flags listed in Test: which are broken. Bug: 1136105 Test: gn gen //content/test:test_support --check --args='v8_use_external_startup_data=false symbol_level=1 is_component_build=false' actually works with this, broken w/o Relax Cast v8_use_external_startup_data req. In preparation for turning it off on certain platforms Bug: 1136105 Test: on affected device Change-Id: I8cb9f60f45d0d3d8cdbcdf44df10185522932475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483204Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#818887}
-
Olga Sharonova authored
Reduce the frequency of dynamic memory allocations in MediaStreamComponent::AudioSourceProviderImpl::ProvideInput() which is running a on realtime audio thread. Bug: 1138927 Change-Id: I73853fd5dcd7e0ab4de42204e81c081d260a3413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485164 Commit-Queue: Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#818886}
-
Roman Sorokin authored
This is a reland of 0c9cf96c Original change's description: > oobe a11y: Add a test to verify profile switch during user login. > > Profile switches between signin and user during the login. Accessibility > manager should correctly switch the profile. > > Also reeanbled OobeSpokenFeedbackTest on MSAN. It's already filtered out > by chromeos.msan.browser_tests.oobe_(positive|negative).filter files. > > Bug: 1108996 > Change-Id: Ic586f7172e26bd965c42a9a566005fd872a69697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474696 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817861} Bug: 1108996, 1139530 Change-Id: Iee0384a2293f7d62853c22201171b786f8857fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485218 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818885}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a40f9a8. With Chromium commits locally applied on WPT: c31f15ed "WebMediaPlayerImpl: err if no A/V in ::OnMetadata" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1ac2c790dc70034ebc7a86356868250f0ee05ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486882Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818884}
-
Elizabeth Popova authored
Street name & house number should be parsed only when both are present. Change-Id: I17f2352588302da5d3c925780e5f344f13c8f5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480567 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#818883}
-
https://reviews.llvm.org/D84362Hans Wennborg authored
Bug: 1140409 Change-Id: I4b0c55fa46c877d4f08c5ffca33af899ef20d2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485222 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#818882}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6f794f1dc5d..5f6b5e4dbaf5 2020-10-20 chinglinyu@google.com traced_probes ftrace: use /sys/kernel/tracing on all platforms. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:147789115 Tbr: perfetto-bugs@google.com Change-Id: I1eddf3fb9d6b992be718318d170fa75375d0487f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485888Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Id3c4b7f8267ab17ebb2e86845b795b93f9299c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485889Reviewed-by:
-
Mohamed Heikal authored
prints a message in diagnose_bloat.py to help users upload a oneoff for sharing. Also updates the oneoff message in libsupersize/console.py to use the new urls for the viewer. Change-Id: I92d16460826488b4a55a9bb56d9200264ab0b476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485772 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#818879}
-
arthursonzogni authored
MHTML document shouldn't be mixed with non MHTML document. This was previously weirdly-blocked by blink. This is now moved to the browser process where a basic error page is being displayed instead. [1/3] of: https://docs.google.com/document/d/13jcj_mATRxKakPEGy72YYHZBTBkkNrAHzaNIIjVsC8I/edit Bug: 1139283 Change-Id: I3618468fdcd2e1e3ba2f6d34cc7391a5a381f0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479365 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818878}
-
