- 05 Dec, 2020 35 commits
-
-
Daniel Cheng authored
This reverts commit 2b2acd1c. Reason for revert: Root cause has been determined. Original change's description: > CHECKs to debug why LocalFrame is in an inconsistent detached state. > > A number of Android crashes have a non-detached LocalFrame but GetPage() > returns null. This CL adds a few CHECKs in IsProvisional(), which is one > place where this crash has been observed. It also adds a few CHECKs in > the FrameLifecycle state machine to make sure state isn't somehow being > rewound. > > Bug: 1154141 > Change-Id: I5b767ed3b7476a47a88831e40de1fceebb73e557 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567633 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832617} TBR=dcheng@chromium.org,fergal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1154141 Fixed: 1154583, 1154586, 1154676, 1154935 Change-Id: I53bc1544082baf6c91f99c18eb022f15c523ba5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575997Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833968}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /media. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=chcunningham@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: I50025fc53dd66d4c747b623a6c4fa8b9a9c0c068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575332 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#833967}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2008dd6e00cd..084721205176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056387 Tbr: sergeyu@google.com Change-Id: Ic110dc65bb73708e0f55603ef669e3b5d064a111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575823Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833966}
-
Josiah K authored
AX-Relnotes: N/A Fixed: 1155744 Change-Id: Ib0c63e0518b8f7fcfc5f467c76dd95d34430acf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574785 Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#833965}
-
Sergey Ulanov authored
TBR=davidben@chromium.org Bug: 1057921 Change-Id: I82cdabeecb65feb6283ed6c2028af18bdec727e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575893 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833964}
-
Jeffrey Kardatzke authored
Oversight, forgot to change this in the utils as well. BUG=b:153111783 TEST=DCHECK passes w/ protected content Change-Id: Id84b31888833ef9d8eff4d6e599cb651767c2dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575517 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#833963}
-
Aaron Krajeski authored
This is step one of a multistep process to move the paint_op_buffer from SkMatrix->SkM44. The steps are 1. Add setMatrix(SkM44) <- this step 2. Add concat(SkM44) 2a. Add helper functions to SkM44 to allow it to do stuff like this: https://source.chromium.org/chromium/chromium/src/+/master:cc/paint/display_item_list.cc;l=412?q=display_item_list&sq=package:chromium&ct=os 3. Change setMatrix(SkMatrix) to use the SkM44 function 4. Change concat(SkMatrix) to use the SkM44 function 5. Remove the early-outs for checking identity in the ::Serialize functions and see if they have perf impact. SkCanvas now supports this https://skia-review.googlesource.com/c/skia/+/338596 It's necessary for perspective transforms https://bugs.chromium.org/p/chromium/issues/detail?id=1140535 It needs to be serializable due to the record paint canvas. Bug: 1153330, 1140535, 1155544 Change-Id: I0920b848386e003b6a18e9332a4f400484b68349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562783Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833962}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d48f8afe510..b97d85b7ca18 2020-12-04 chrche@microsoft.com [Loc] Migrate protocol monitor tool to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I513e54ff6b0aaae78801c8284be2db9f952212d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833961}
-
Phillis Tang authored
Update desktop PWA install icon's In-Product Help to show the app's name in display text. Bug: 1149638 Change-Id: I1f2a7c201e2d2fda4533dcecb2a5f389b6d38f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572744 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#833960}
-
Xianzhu Wang authored
Previously we propagated the flag across frame boundary when setting the flag. If this happened when the frame was not throttled, then it was throttled, a full document lifecycle update would clear the ancestor flags in the owner frame, leaving the flag in the frame orphaned. Now propagate the flag across frame boundary for non-throttled frame just before paint regardless of whether the frame was throttled or not, to ensure the flag always correctly propagated to ancestors for paint. Bug: 1155220 Change-Id: Ic351e835d103522ed2b36332f2b4095215297389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573341 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#833959}
-
Fabian Henneke authored
Some third-party Autofill services launch authentication activities as part of their fill flow that cause ChromeActivity to enter the STOPPED lifecycle state. To allow the fill flow to succeed, the session must not be cancelled in that case even though onInteractabilityChanged is called for the current tab. Bug: 1150732 Change-Id: I43a63af798c0cd9824a5f9bc85532a2692f61684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571094Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833958}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: Idf24a0cbb84fa884b67aa217e2ecc2cc0885d0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575152 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: I6e88c4e333587614083ed8213533241a09ee63f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575446 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: Icc05e473bb85ee858781b0e40d20d727c8191a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574786 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: Id5ead0d99d5cb2656416086433c6151c14b540a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572897Reviewed-by:
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: I36cbfe48f61964797095aa07b0ee03a60fd39897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572642Reviewed-by:
-
Ryan Hansberry authored
Nearby Connections clients (e.g., Nearby Share) consume the Adapter methods to connect to or listen on RFCOMM services from the untrusted Nearby utility process. Only allow known UUIDs of these clients to be used with these methods. Bug: b:162975217, 1155668 Change-Id: I8b94dda97df0f694b37c22fa59adfacc17b5093f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573117Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#833952}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: I1d55e3df22e9b16427de44ba229a1ce05528c6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572997Reviewed-by:
-
Liquan (Max) Gu authored
Before the CL, CPRService did PaymentUiService.getContactSection().getSelectedItem(). This is not convenient for unit tests because the tests have to mock the contact section and the selected item. This CL changes it so CPRService accesses the selected contact by proxy of PaymentUiService. Bug: 1155582 Change-Id: I393f27594024cfb609ba99f212ac034c92a19b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575341 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833950}
-
Dan Sanders authored
Creation of ImageBitmaps from VideoFrames is implemented using a viz::RasterContextProvider in //media. Such a thing is available from Platform on the main thread, but not in workers. This CL exposes the underlying viz::RasterContextProvider from WebGraphicsContext3DProvider so that the //media code can be called using the SharedGpuContext context. Bug: 1148849 Change-Id: Ie69e84e423f7e6f4aca13b7b86bcf178b3e15958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570331 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
David Schinazi authored
This CL adds all information from connection close frames to netlog to facilitate debugging. R=renjietang@chromium.org Change-Id: Ia158f2e711aa455e30a790e80e1739b5707fc346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575696 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833948}
-
Kyle Williams authored
Resolve transient compiler errors when referencing functions do to missing COMPONENT_EXPORT annotations. BUG=b:174842932 TEST='autoninja -C ~/chromium/src/out_${SDK_BOARD}/Release chrome chrome_sandbox nacl_helper' Change-Id: I1867ff1703b1337910788967f5df02ae16be5dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574496Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#833947}
-
Jeffrey Kardatzke authored
This reverts commit 78556ccd. Reason for revert: Fixed crash Original change's description: > Revert "media: Fix crash when releasing decoder with ChromeOS CDM" > > This reverts commit 883c24e8. > > Reason for revert: Segfaults if not encrypted content > > Original change's description: > > media: Fix crash when releasing decoder with ChromeOS CDM > > > > When the VaapiVideoDecoder was released, if it was using the CdmContext > > it would have a callback associated with the CDM. Upon destruction of > > the decoder, that callback would be destroyed automatically which makes > > a call into the CDM. The CDM is being destructed on another thread, so > > there was a race and this could cause a crash. > > > > The fix is to maintain a CdmContextRef in the decoder which keeps the > > CDM alive until the decoder is destroyed. > > > > BUG=b:153111783 > > TEST=Page refresh 10 times in a row w/ CDM did not crash > > > > Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262 > > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833863} > > TBR=xhwang@chromium.org,jkardatzke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I11cd7d74a92bca26e51727ccbc494cc178008320 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:153111783 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575717 > Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Cr-Commit-Position: refs/heads/master@{#833914} TBR=xhwang@chromium.org,jkardatzke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Bug: b:153111783 Change-Id: I5776a90da74977ac1d6286a9d6148939175cff4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575718Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#833946}
-
Hiroshige Hayashizaki authored
Reflecting https://github.com/WICG/import-maps/pull/229 Bug: 848607, https://github.com/WICG/import-maps/issues/207 Change-Id: Id056b3fd27489ecdfe45456220fd1d8c01dc8d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570012 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833945}
-
Jeffrey Kardatzke authored
This doesn't fully fix VP9 decrypted decoding, but it makes the VP9Decoder changes cleaner than they were. It also adds a call that was missed in the accelerator for setting the crypto params if we seek back to clear content. This still has corruption on screen, especially if there's UI activity over the video. But still not sure how that matters. BUG=b:153111783,b:155509231 TEST=VP9 decrypt+decode works mostly Change-Id: Ib2ee90e6ce8fb6f2087c595e1a765e0481cc6249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567150 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
-
Ken Buchanan authored
Add IdpNetworkRequestManager, which controls state for network transactions between the browser and the Identity Provider. This change also adds the initial sequence for the permission-based flow. Bug: 1141125 Change-Id: I0e836c7a00543fcd239aff44a5ee6bbc13daced9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569373Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833943}
-
Jacques Newman authored
Basic implementation of NGGridLayoutAlgorithm::ComputeMinMaxSizes. Bug: 1045599 Change-Id: I0780fba7bc3384bead7ebc059f872e010751b45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569848 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833942}
-
Adam Ettenberger authored
third_party/blink/renderer/bindings/core/v8/dictionary.h is included by dom_rect.h, but this seems unnecessary since neither dom_rect.h or dom_rect.cc use blink::Dictionary or other structures defined in that header, so removing the include. Bug: none Change-Id: I9e55447a979e4cc0a16c187c88104c04eabfab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575049Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833941}
-
Yue Li authored
Since we only use the first result from search request, set the page size to 1 to reduce the delay. Bug: b/173239982 Test: None Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#833940}
-
Yue Li authored
Extend the expiry milestone of AutoSelet chrome flag which is still in use. Bug: None Test: Locally build and test Change-Id: I9f36f407f80812b5109db8297d4fb990817c54aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574075Reviewed-by:
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/download. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=shaktisahu@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ib95d998cea01e034527987da76662d47710783f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575375 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b37eb4854762..2008dd6e00cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139446,chromium:1144019,chromium:1152718,chromium:1153038 Tbr: sergeyu@google.com Change-Id: Ia95030153fed9f06ff749c922f9f1b02da5dec66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575443Reviewed-by:
-
Danyao Wang authored
The Payment Request API requires that show() be called with a transient user activation. This CL adds enforcement behind a runtime flag. Bug: 825270 Change-Id: I39782301f5c4aaed32a664d3803c9142747dc41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574781Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#833936}
-
minch authored
Bug: 1147245 Change-Id: I1927ea3fc3ddf88e62719fca4677407e64604cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564328Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#833935}
-
David Maunder authored
The display logic was written before the user ability to turn off price drops was introduced. The code needs to be updated to hide the price box (upon next render of the tab grid) if the feature is turned off. Turning the feature off means the SHOPPING_PERSISTED_TAB_DATA_FETCHER is null. Bug: 1155731 Change-Id: I734ffd3538ee62cbd5ea8314d7f6eb76a5931985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575419 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833934}
-
- 04 Dec, 2020 5 commits
-
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4324.9-1606733211-benchmark-89.0.4337.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4339.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7b75fe645b5d5d0d52bf6a87f372924f3f38dfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575841Reviewed-by:
-
adamta authored
Adds a feature flag to toggle between the existing NTP and the new, refactored one. Bug: 1114792 Change-Id: I605ccd3ace368bb2c6dc0683fe9a7af11f566cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575438 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#833932}
-
Carlos IL authored
The current explanation for the mixed form interstitial was ambiguous as to what "not completely secure" meant. This replaces the string with one that explicitly mentions an insecure form. Bug: 1153964 Change-Id: Ie07496b36cc26655fd1d7afcc01e5a32b864c41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575395 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833931}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fcbaead2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia363b8af10717a541e19844baf6214b4c3b42c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575856Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833930}
-
Sinan Sahin authored
Bug: 1134912 Change-Id: I8810edf6705672216d5ee92546045c4ae32f8c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572685 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#833929}
-
