GitLab

NaCl on Mac and Linux needs to create a shared memory object that it can
later make executable with mprotect.  Express this need in the interface it
uses.  Add a test that pages mapped from such an object can later be passed
to mprotect with PROT_EXEC.

This lays the groundwork for a later change that will sometimes use a
different method to allocate an object on Linux when it needs to be
executable.  On some Linux distributions, shm_open yields objects whose
mappings cannot be made executable.

BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= SharedMemory.AnonymousExecutable

R=mark@chromium.org,jam@chromium.org,amit@chromium.org,ben@chromium.org

Review URL: http://codereview.chromium.org/8585002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112570 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a histogram that measures the reasons why loads of
https://www.google.com fail in the hopes of getting some visibility into the
recent SSL search launch.

Since the users were navigating to a Google property in any case, and we would
have a log of that, this doesn't have any additional privacy impact.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8585038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112569 0039d316-1c4b-4281-b951-d872f2087c98

Fix TouchHandler to only respond to mouse events when explicitly requested.  By
default it should respond only to touch events.  As additional insurance (to
return the runtime behavior to exactly how it was before my change since we're
about to branch for M17), don't enable the use of TouchHandler unless we're
running with --touch-optimized-ui.

Also clean up a few touch NTP related things:
 - Remove unused copy of ToucHandler (probably legacy from previous login work) and reference to Grabber (which already doesn't exist in the tree).
 - Remove stale ntp4 script for running closure/lint.

BUG=106012
TEST=Manual - try dragging ntp page with the mouse, shouldn't move


Review URL: http://codereview.chromium.org/8775024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112568 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-on CL, in response to a code review comment at
http://codereview.chromium.org/8728020/ , that simplifies the
ProxyResolutionServiceProvider unittest to run its main loop at most once
rather than in a loop.

BUG=chromium-os:23241
TEST=Run unit test

Change-Id: I3e8a730679f430f1966073422626ebffbd1a03bf


Review URL: http://codereview.chromium.org/8764006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TEST=none


Review URL: http://codereview.chromium.org/8775023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112566 0039d316-1c4b-4281-b951-d872f2087c98

Change 8569018 used a #ifdef to conditionally decide which external
library to use for Crc calculation. It used OS_CHROMIUMOS to tell
if the build was targetted at Chromium OS.

However, it broke Chromium OS builds of the full Chromium tree in
some cases (heapcheck bots), and was reverted.

Since I really only want to change the library when building from
inside a custom ebuild in the Chromium OS build, it makes sense
to use a #define custom to that ebuild.

So, this change is the same as 8569018, except that is uses
COURGETTE_USE_CRC_LIB instead of OS_CHROMIUMOS.

BUG=8569018


Review URL: http://codereview.chromium.org/8763014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8758008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94112
TEST=Trigger the infobar asking the user whether they would like to allow desktop notifications from a site and verify that it uses the new icon instead of the old (Chrome product) icon.


Review URL: http://codereview.chromium.org/7742002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112563 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=106109
TEST=heapcheck bots

Review URL: http://codereview.chromium.org/8774019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112562 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8770010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112561 0039d316-1c4b-4281-b951-d872f2087c98

Changes DownloadRateMonitor logic to know to immediately fire CanPlayThrough
for media files with local sources, including local webcam streams. Renamed
the concept of "loaded" source to "local" source in the media pipeline for
clarity.

Also updated the DownloadRateMonitor logic slightly to lean toward optimism
in firing CanPlayThrough, including firing the event immediately for streaming
media.

BUG=105163
TEST=media_unittests,test_shell_tests, wjia's media stream test page works

Review URL: http://codereview.chromium.org/8661002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8757010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112559 0039d316-1c4b-4281-b951-d872f2087c98

IsVisible as it's no longer needed. This cl resulted in a ton of
changes, the majority are renames though.

BUG=102714
TEST=covered by tests

Review URL: http://codereview.chromium.org/8759017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112558 0039d316-1c4b-4281-b951-d872f2087c98

We need to wait for an HTTP/1.1 keep-alive response before we try to pipeline. Notably, this fixes wordpress.com and techcrunch.com.

Remember which hosts clearly support, or don't support pipelining. If pipelining is supported, skip the slow start. If it's not, fall back to HttpBasicStreams.

A site is judged not to support pipelining if we see an old HTTP version or encounter a socket error. A site does support pipelining if it successfully handles 3 requests. There's obviously room for improvement here, but this is a
start.

Related changes:
- In the spirit of CHECK() failing. Use CHECK(false) instead of NOTREACHED().
- HttpPipelinedHost is now an interface with a corresponding Impl. This is to help unit test HttpPipelinedHostPool.

BUG=None
TEST=net_unittests


Review URL: http://codereview.chromium.org/8586015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105814
TEST=


Review URL: http://codereview.chromium.org/8741001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112556 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=106104
TEST=vg bots stay green

Review URL: http://codereview.chromium.org/8773019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8762014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112554 0039d316-1c4b-4281-b951-d872f2087c98

Remove all cases of the old method signature (and related tests) and
use the new form.

BUG=104200


Review URL: http://codereview.chromium.org/8769016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112553 0039d316-1c4b-4281-b951-d872f2087c98

Kill all emulators before starting a test to be more robust on error.
Print error if a file fails to copy to the device.
Speed up emulator launch by 40%.
Increase emulator partition size to fix 'out of space on device' errors.
Log emulator launch time to help profile bot costs.
Run tests in verbose mode to assist with bot debugging.

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8769020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106061
TEST=browser tests should pass
Signed-off-by: Simon Que <sque@chromium.org>

R=oshima@chromium.org,satorux@chromium.org,nkostylev@chromium.org


Review URL: http://codereview.chromium.org/8773016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8762004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101992
TEST=existing

Review URL: http://codereview.chromium.org/8598022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112548 0039d316-1c4b-4281-b951-d872f2087c98

We're downloading code here, after all!
Review URL: http://codereview.chromium.org/8772015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112547 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=104980
TEST=None.


Review URL: http://codereview.chromium.org/8666013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112545 0039d316-1c4b-4281-b951-d872f2087c98

use_webkit_compositor is set.

BUG=none
TEST=none
R=piman@chromium.org


Review URL: http://codereview.chromium.org/8774012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112544 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=106067
TEST=valgrind bots should stay greener

Review URL: http://codereview.chromium.org/8770018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112543 0039d316-1c4b-4281-b951-d872f2087c98

This was less useful than I thought it would be because we
are purposely creating chromeHidden for web pages now, due
to the chrome.app API.

Also, move GetChromeHidden() to ChromeV8Context just because
it makes more sense to me there.

BUG=106014

Review URL: http://codereview.chromium.org/8761020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112540 0039d316-1c4b-4281-b951-d872f2087c98

TBR=piman@chromium.org

Review URL: http://codereview.chromium.org/8769018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98473

Review URL: http://codereview.chromium.org/8771001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112538 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary for gcc 4.4.3, see the comments on
http://codereview.chromium.org/8687014

BUG=94925
TEST=none
TBR=willchan

Review URL: http://codereview.chromium.org/8776012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112537 0039d316-1c4b-4281-b951-d872f2087c98

A change to the Calendar UI requires a minor modification to this test.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8757013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112536 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/8747022

BUG=97249
TEST=none


Review URL: http://codereview.chromium.org/8769011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112535 0039d316-1c4b-4281-b951-d872f2087c98

R=groby
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8743019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20156,chromium-os:22832
TEST=None


Review URL: http://codereview.chromium.org/8720006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112533 0039d316-1c4b-4281-b951-d872f2087c98

Add methods to NativePanel. Also provide dummy implementation for all platforms.

BUG=none
TEST=no test due to no new functionity

Review URL: http://codereview.chromium.org/8681025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=git status
TBR=isherman@chromium.org

Review URL: http://codereview.chromium.org/8772012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112530 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to support ongoing overflow panel work.

BUG=none
TEST=none since overflow is not enabled yet

Review URL: http://codereview.chromium.org/8762017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112529 0039d316-1c4b-4281-b951-d872f2087c98

Alt-L (print layer tree)

Added name in RenderWidgetHostViewAura

Made Window::SetName update the layer name.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112232

Review URL: http://codereview.chromium.org/8585007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112528 0039d316-1c4b-4281-b951-d872f2087c98

Do not call FixupUserInput as it was prepending unexpected prefixes (such as file://) to the search string and bypassing valid results.
Move the search string decomposition operation from the HQP into the IMUI.
In the final substring filtering use whitespace delineated terms rather than words.
Instead of bailing if we get a large results set (>500) filter it down to 500 by sorting by typed-count/visit-count/last-visit.
This means it's no longer necessary to bypass the HQP if there is only one character in the search term so get rid of the ExpandedInMemoryURLIndexTest.ShortCircuit unit test.

BUG=101301,103575
TEST=Added unit tests.
Review URL: http://codereview.chromium.org/8526010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112527 0039d316-1c4b-4281-b951-d872f2087c98

I had added a hack in http://codereview.chromium.org/196007 to mimic a
behavior of how rc.exe replaces \n with a newline.  Unfortunately, this
didn't make it possible to have legitimate uses of \n in a string.

Instead, remove all occurrences of \n in preparation of removing this hack.

BUG=105985

Review URL: http://codereview.chromium.org/8757009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112526 0039d316-1c4b-4281-b951-d872f2087c98