- 27 Oct, 2020 33 commits
-
-
Clark DuVall authored
Bug: 1137468 Change-Id: I7380b5e1de6cd1af7b7c9577c1972003c4d99384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500443Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821011}
-
Lei Zhang authored
- Use nullptr - Use std::make_unique() - Use auto - Use = default; - Use modern copyright notice - Stop using DISALLOW_COPY_AND_ASSIGN() Bug: 1010217 Change-Id: Ib3e5ec1715b33325f11f391bb749e3e014c1ba4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495978Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#821010}
-
Tommy Li authored
This CL adds a base::Feature flag that disables the HistoryQuickProvider InMemoryURLIndex's cache file. Instead, the index will be rebuilt on every startup from the History DB. That's not as disastrous as it sounds. It takes ~2.5x as long compared to the on-disk persisted cache, and doesn't block the UI. It's on the History DB thread. Details of experiment: go/chrome-omnibox-hqp-ablate-cache-file Change-Id: Idddca4c5621010f3415e61d8731b3009892c281e Bug: 750845, 1032679, 1141539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441044 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821009}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3b334b2b8e1a..740ae9f60b00 2020-10-26 johnkslang@users.noreply.github.com Merge pull request #2435 from amdrexu/feature If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I82a9fd127a13a33ca0ac3c954c0f91b4ce664929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821008}
-
Michael Checo authored
Bug: 1059779 Test: browser_tests --gtest_filter=ScanningUIBrowserTest.All Change-Id: Ia69f55232fc5e0065d646363798f545f6a1eeb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500421Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#821007}
-
Nate Chapin authored
Change-Id: I9647c6fa76a88a7d2c6f10a53436c203324d8dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500426 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821006}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b1635617. With Chromium commits locally applied on WPT: 6cca306f "webrtc wpt: add cleanup to insertable streams worker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Id099dd721f6136143279f5975e87b8426bd7bdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500322Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821005}
-
Kunihiko Sakamoto authored
This reverts commit 07c000ce. Reason for revert: use-of-uninitialized-value is detected in Linux MSan Tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25981 ==29008==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5580a100b292 in base::HangWatcher::GetTimeSinceLastCriticalMemoryPressureCrashKey() ./../../base/threading/hang_watcher.cc:268:7 Original change's description: > Fix thread checks in HangWatcher > > Remove the thread check that would never pass and make the variable > that is used by multiple threads thread safe. > > Bug: 1142155 > Change-Id: Iae33e15733eb78a47a664515e1abec671edbb64d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495579 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820817} TBR=fdoray@chromium.org,olivierli@chromium.org Change-Id: I463c2928c91878d396a0dd7ebb93b3c625e26a56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500385Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821004}
-
Yue Li authored
Bug: b/169453041 Test: Run TranslationResponseParserTest.* in chromeos_components_unittests Change-Id: I08315718f29b8785150fddc765552d73c88bab96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493434Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#821003}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8036d9953123..41c24933da1e 2020-10-26 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1bafdc3c45e7 to 57694c8dab3c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I733e16c9858e824a7de0ea8b133875473181001f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821002}
-
Allen Bauer authored
Bug: 938501, 1130078 Change-Id: I50e6c35c97b1d25250bb45d2341e49602e86c29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498829 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#821001}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id146b05a48c87e45f7dac4a7640140a36fc9ad75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821000}
-
Patrick Noland authored
Bug: 1139515 Change-Id: I0a34783a6a58581fcb64560c11ac5538db369553 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500427Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820999}
-
Evan Stade authored
LargeIconServiceImpl depends on FaviconService, but WebLayer doesn't have that service. So the relevant part of FaviconService, i.e. GetLargestRawFaviconForPageURL, is moved to a new interface, LargeFaviconProvider. (The FaviconServiceImpl implementation is unchanged.) Also, the needed parts of LargeIconServiceImpl are refactored out into their own file, large_icon_worker.{h,cc}, which LargeIconBridge accesses directly. Some Profile references are updated to BrowserContext{,Handle} in LargeIconBridge. For LargeIconBridge to get a LargeFaviconProvider from a BrowserContext, a factory method/getter is used. Embedders must set this factory method if they are to use LargeIconBridge. The next step will be to actually LargeIconBridge in shared code (not just in Chrome), and to add a LargeIconProvider implementation in WebLayer (which is a simple pass through to FaviconBackend). Bug: 1137625 Change-Id: Ib06dc2325cac8c6c4439c43d30c4a8f7073b08fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473578 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820998}
-
Shakti Sahu authored
This CL fixes two issues. 1 - The supported languages are converted from array to list at JNI boundary. 2 - The preferred language was always falling back to the default language from finch, which caused the language picker to never show up. So, in the new fix, the preferred language will be empty if the user hasn't set yet. However, showing the tutorial promos on the UI needs a language. For that language, we will use a default language from finch. Bug: 1142642 Change-Id: I3126b0d1bd815055ccda7a77903ca05cca72b75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500266 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820997}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/715ec351..d3c1cdc3 d3c1cdc Update IANA timezone db to 2020c TBR=jshin@chromium.org Bug: 1141065 Change-Id: I8ab1d6066c80202517fe1fe04a6c93d80f66bc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494029Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820996}
-
Ken Rockot authored
This replaces several uses of string or String16 with BigString or BigString16, respectively, in order to avoid hitting soft message size limits on messages which may carry especially large strings. Fixed: 1141991,1141994,1141998 Change-Id: I8d0b4a4c81adeeb22ea8069bebee6885bbec2a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496032Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#820995}
-
Ilia Samsonov authored
New baseline are from: https://test-results.appspot.com/data/layout_results/mac-arm64-rel-tests/530/blink_web_tests/layout-test-results/results.html Bug: 1130741 Change-Id: Iffdb02282f96d5d19bae35a6059d57cef8ac679c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491981Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#820994}
-
John Palmer authored
BUG=1138092, 1111135 Change-Id: I35366c90794f9e26917360464ec3553798073a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483719Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820993}
-
Kunihiko Sakamoto authored
This reverts commit 09372dbd. Reason for revert: TestSuiteTest.RunMockTests is consistently failing in Win 7 Tests x64 (1). https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/73194 Original change's description: > Roll ANGLE from b5ba693316fd to 5dafe107a36e (4 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/b5ba693316fd..5dafe107a36e > > 2020-10-26 jmadill@chromium.org Output nullptr pointer parameters correctly. > 2020-10-26 jmadill@chromium.org Re-enable crash testing in angle_unittests. > 2020-10-26 jmadill@chromium.org Fix uninitialize state in ProgramState. > 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 69f07da41b3b to abe2eff36f3c (3 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC geofflang@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: geofflang@google.com > Change-Id: Ib3d7352035280fa5353870f3a71267127938e34c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498848 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#820816} TBR=geofflang@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I650675ab45cdefbdb8e551215ceb4f77422615f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500961Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820992}
-
Xinghui Lu authored
Also fix a browser test failure caused by the EpMessageInInterstitials flag not explicitly disabled. Bug: 1130721 Change-Id: I31b06386e26eb94bb8de7d7ea9e6b39cc7788257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495714 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#820991}
-
Roman Arora authored
Remove the tab_search directory from .gitignore and custom gitignore file from tab_search_merge directory as part of source migration effort. Bug: 1134167 Change-Id: I3082094118a3b2622ca680d0f9c80b4650d1367d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498826Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#820990}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/306f03788f83..4f6c1bb4191b 2020-10-26 yuhengh@chromium.org Support testing WebUI in non-content area 2020-10-26 bsheedy@chromium.org [devil] Only raise exception if forwarder not killed 2020-10-26 brucedawson@chromium.org Reduce warning output in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789,chromium:1084931,chromium:1099917 Tbr: zhanliang@google.com Change-Id: I86592b8a568adde7aeb83b76943275c7ff9d93b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820989}
-
Boris Sazonov authored
The feature has been rolled out and the flag removed. Bug: None Change-Id: I0579819f0d079cb24363fcad5326349be098bc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489633Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#820988}
-
Nancy Wang authored
There are a few crash issues which could be related with reuse the destroyed window. The crash issues are hard to reproduce. This CL modifies the OnWindowDestroying function. Even if the app id is empty, still check the related structure, e.g. aura_window_to_app_window_, arc_tracker_, to remove the window from all related variables to remove the window. BUG=1128491 BUG=1126493 Change-Id: I842a79f3994b00af08b01c4095b890525655ea87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496102Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820987}
-
Xianzhu Wang authored
This at least ensures that we will update the paint properites for the composited overflow control layers in pre-CompositeAfterPaint to avoid stale properties on the layers. The test doesn't actually reproduce the bug because any test simpler than the bug case couldn't reproduce the bug as the update would be triggered in other code paths (any style change, layout change, etc.). Anyway this CL does fix the bug case. Bug: 1137603 Change-Id: I5cca970bcf8cda6085527f79a97f269c4e3e9986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500264Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820986}
-
Anne Lim authored
Rename EnableAutofillInfoBarAccountIndicationFooter flag to EnableAutofillPasswordInfoBarAccountIndicationFooter since it has been decided that the footer for Payments and Password InfoBars will have separate rollouts. Bug: 1135847 Change-Id: I24e61dd7315b869378bfd1857d70bea59aee6b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495967Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#820985}
-
Daniel Cheng authored
Replace both uses with base::UmaHistogramSparse, since neither metric is recorded in a hot code path. Bug: 1047547 Change-Id: I7237163b9918ef933756627f0191e756b8304f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499804 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#820984}
-
Christoph Schwering authored
This CL adds a type-safe set container for dense integers, following std::set's API. Currently, there are multiple use-cases in Autofill of the following two patterns to express sets of small, dense integers: Pattern 1: enum class E { A = 1, B = 2, C = 3, ... }; std::set<E> set; set.insert(B); Pattern 2: enum E { A = 1 << 0, B = 1 << 2, C = 1 << 3, ... }; uint32_t bitmask = 0; bitmask |= B; This CL's container combines the type-safety of the former pattern with the efficiency of the latter. Bug: 1007974 Change-Id: Ida9b9cec244119a27eca2c171b4fb2f52443d099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350423 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#820983}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84938ab95122..6dce2946f57c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1138554 Tbr: slightlyoff@google.com,avi@google.com Change-Id: I7909adee1ca66c3c203ef24f22afd38c90881597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499962Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820982}
-
Phillis Tang authored
Make sure web app tests on desktop do not unintentionally deploy OS hooks. A separate CL will handle chromeOS specific tests. Bug: 1124383 Change-Id: I3b5130cdf3754cd84267260d53dbf5ff12a6f59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399500 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820981}
-
Alexis Hetu authored
Some Android specific YUV related checks should no longer be necessary now that proper support exists in Skia for these cases. Bug: 985458 Change-Id: Ic53aeee278a7751fdfecc532b185bf4dc91fc892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500243Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820980}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/83e50af3e0bd..2837c9f0c416 2020-10-26 miu@chromium.org Add StringPrintf() wrapper utility. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3acac321cb930b632ff7ef973c439862aa319877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820979}
-
- 26 Oct, 2020 7 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/546b189d859d..6b0ecd8197ff 2020-10-26 kimanh@chromium.org Add linear memory inspector viewer component 2020-10-26 jalyn@microsoft.com Settings: Add reset button for shortcut editor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I412dac67caa4232e747896c5b092bde8ced3a148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820978}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aaea0d98fb64..36af02d2efd7 2020-10-26 kjlubick@google.com Add define to WASM GM build 2020-10-26 robertphillips@google.com Add additional GrThreadSafeCache test case 2020-10-26 herb@google.com add API for Op creation 2020-10-26 mtklein@google.com tweak build for msan swiftshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: jcgregorio@google.com Change-Id: I895e46f05bfecf42f382a1c34c1390a6ece64ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820977}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/d84ef00c9666..d15ae2bf593a $ git log d84ef00c9..d15ae2bf5 --date=short --no-merges --format='%ad %ae %s' 2020-10-23 bnc Move protocol flags out of platform so that they are included in QUICHE. 2020-10-23 mattm Move num_failed_authentication_packets_received to QuicConnectionStats and fix QuicConnectionTest.IntegrityLimitDoesNotApplyWithoutDecryptionKey 2020-10-23 vasilvv Replace QUIC_FALLTHROUGH_INTENDED with ABSL_FALLTHROUGH_INTENDED. 2020-10-23 wub If B2SL option is set in QUIC BBR2, when STARTUP exits due to loss, it will set the inflight_hi to the max of bdp and max_bytes_delivered_in_round. 2020-10-23 mattm Add QuicConfig::KeyUpdateSupportedRemotely getter. 2020-10-23 dschinazi Add code counts for building version negotiation packets 2020-10-23 dschinazi Remove unused QuicPacketCreator::SerializeVersionNegotiationPacket 2020-10-23 haoyuewang Reduce quic::ConnectionId size from 24 bytes to 16 bytes on 64 bit system. This reduces some memory usage of connection & session on the server side. 2020-10-23 mattm Add QuicFramer::PotentialPeerKeyUpdateAttemptCount() method. 2020-10-23 vasilvv Downgrade a QUIC_BUG to a warning. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic48658bba769f3090639334f314f09053f9db28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495402 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820976}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3a9e594e784e357b2690e74ab618b272a63e252f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499821Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820975}
-
Daniel Cheng authored
All uses have been migrated to use the //base helpers directly instead. Bug: 1047547 Change-Id: I3a293faba3d894dcf8af420e58159116bb518f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500001 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#820974}
-
Boris Sazonov authored
Adds MobileIdentityConsistency to testing/variations/fieldtrial_testing_config.json and adds explicit @DisableFeatures to the affected tests. Bug: 1128916, 1142467 Change-Id: I25afb6de05d2ce232f1006a8497884f9db18d52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489895 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#820973}
-
Andrew Xu authored
In RoundedImageView, we expect to get the size of the stored image via GetPreferredSize(). However, RoundedImageView may have its preferred size. As a result, CalculatePreferredSize() overridden by RoundedImageView is never called. It makes the area to paint the image bigger than the size of the image. Meanwhile, the canvas function to paint the image uses tiling flag as default. It is why a small image is tiled. This CL uses GetImageSize() in replace of GetPreferredSize(). The side effect is handled. Add DCHECK to verify. Bug: 1139498 Change-Id: Ia03c3366f22c8ce7d2c9326fd1097cab3e4ba563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499170 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820972}
-