- 14 Jan, 2021 40 commits
-
-
Alex Ilin authored
https://crrev.com/c/2615350 introduced a bug when deleting any profile that is not the lst in the list. The profile gets deleted, the list updates in background but the dialog stays open with info about the next profile in the list. The dialog should be explicitly closed from profile_card_menu.js Bug: 1063856 Change-Id: I1688b19300fd7dc89893393bac239ed7163de4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627520 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#843516}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33435f37. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I73cdb88443c5fe4695fbce26dc218a4426e17b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629287Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843515}
-
Laís Minchillo authored
Extend the duration of Android.WebView.AndroidX.ApiCall and WebView.ApiCall. These are core WebView API metrics, to be used both as a measure of success or to guide deprecation of unused methods. Bug: 1160898 Test: N/A Change-Id: I821d65343fbda189ff941df12493e2ae956541ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622372 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843514}
-
Ian Clelland authored
Change-Id: I7df7f963f11495bc28ebdcc739562a190e8fd3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627708 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#843513}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9e71e6a50f6b..81eee879ea6e 2021-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75a9ade2c15c7693e71c946b4deabbd4340c62de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843512}
-
Titouan Rigoudy authored
We were previously recording private network requests similarly for navigations and subresources. This CL merely splits these cases up into two different buckets that are measured independently. Navigation usecounters are slightly incorrect and will need more work to fix than can be achieved by branch point. Subresource usecounters on the other hand should be more accurate and let us evaluate compat risk of a subresource-only launch. Bug: chromium:1124358 Change-Id: I38e8b8d90b58316a400219e762c9d6d1d29451d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627421Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843511}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610571527-a7cc65d6e4dfa3bc4bfeaca916fdc0c69afa5118.profdata to chrome-win32-master-1610603782-7b9d002ed8792e03b1869b7e10210ec4783af8d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icbb2eaf7cae5e9b49b3cecea780d1e7a947ade04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626495Reviewed-by:
-
Caroline Rising authored
Bug: 1163938 Change-Id: I383d348d0e08aa42c4aabbfab38c3e8c7ad19331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622274Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#843509}
-
Jan Krcal authored
This CL fixes a bug with the back navigation in profile creation flow that triggers after the user chooses to sign in and then tries to navigate back to the main picker screen. The problem was with pushing LOAD_SIGNIN state on the history stack that was not removed when coming back from that step. This CL thus avoids pushing this state to history by directly triggering the switch in the native UI layout. This CL also fixes an unrelated minor issue that once call site to record page visits got accidentally removed. Bug: 1126913 Change-Id: I871473652cf6f632b5687f6b550f63d94f420766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623944 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As the second pre-work to convert the context menu IPC messages, this CL moves Impression struct and ConvertWebImpressionToImpression() method to blink. - Move impression.h/cc to blink/public/common/navigation. - Move impression_conversions.h/cc to blink/renderer/platform. Bug: 1093904 Change-Id: I6d14aa6b028b559f4ecc939c7d2de27ff65b26ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628767Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#843507}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ac263e38879..9fba07e606db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I2f3a5b689b2abb390dd102c3b2a69d1ed50e4392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628463Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843506}
-
Sergey Poromov authored
Until proper DLP reporting is ready we need to log when DLP blocks some user action to provide more transparency for the admins. Bug: 1166600 Change-Id: Iff4ae86bd3c172266723ef7e88290fa1fa47c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628291Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#843505}
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I9489867941a9db12954358d926c2b25f9c8b8617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628928 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#843504}
-
Monica Basta authored
Bug: 1162443 Change-Id: I13c22f9337a2fc8a1c8a7b2e7f61e06f29afeced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624655 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843503}
-
Caitlin Fischer authored
The study has ended, and there are notes in the server-side config and in crbug.com/1111809 that this study is no longer needed. Bug: 1126640, 1111809 Change-Id: I8806a5e6b2807cdd2644fe238a8f0df0597e7701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626512Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843502}
-
Antonio Sartori authored
A LocalFrame's PolicyContainer is the counterpart of the RenderFrameHost's PolicyContainerHost. There are LocalFrames without a corresponding RenderFrameHost, and there are RenderFrameHost (the speculative ones) without a PolicyContainerHost. Previously, in those cases, we were setting a LocalFrame's PolicyContainer to be nullptr. We were trying to handle accesses to a non-defined LocalFrame's PolicyContainer with single nullptr checks. However, a LocalFrame's PolicyContainer is needed every time a LocalFrame needs to handle security policies. It turn out this can happen in a myriad of cases. For example, SVG images included via the img tag (which are rendered using a fake LocalFrame) allow meta tags delivering security policies (although those policies effectively do nothing). Using nullptr checks to handle those cases everywhere is tedious and error prone. With this CL we adopt a similar approach as for the EmptyFrameClients. We always define a PolicyContainer for a LocalFrame, even if it has no RenderFrameHost. In this case, the PolicyContainer is an "empty" client: it is fully functional for Blink's purposes, but it treats all mojo messaging to its (non-existent) Browser counterpart as no-ops. Bug: 1158034,1130587 Change-Id: I18347b9a16c6c7d71931c1f34abda793e66a9324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594768Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#843501}
-
Jan Krcal authored
This CL makes the toolbar bg color in the sign-in flow react to theme changes (so that the button color stays in sync with the toolbar color). It also removes a few obsolete TODOs. Bug: 1126913 Change-Id: Ia01207d4544baed1587e7c1030e9319c553c9be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627160 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
methods OnPrimaryAccount(Set/Cleared) are deprecated. This cl changes components/gcm_driver/* code to use OnPrimaryAccountChanged() instead. This cl also removes OnPrimaryAccountSet method from IdentityManager. Bug: 1158855 Change-Id: I75210065dd113eeb3646c86136236fe2b54afebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611722 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843499}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610571527-cb84a3d10a676e72fe097e5f2fde0ba90e629978.profdata to chrome-win64-master-1610603782-06f69987beeafa2099bc1c1b61d54bb2fbf2a8d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie33f198c66734f2928d25977ae69ff11fb93f630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628658Reviewed-by:
-
Thomas Tellier authored
Bug: 1160230 Change-Id: I1eac02e8a68b83dbd0b4c1cc82b7d6e6ca33b05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627852Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#843497}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6f833b7f78c9..247f511f198f 2021-01-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 313ae9e87f37 to 904c5b9621da (2 revisions) Also rolling transitive DEPS: https://dawn.googlesource.com/tint from 313ae9e87f37 to 904c5b9621da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Iae6576912bb8106cbb4f05832517e3b81c4fc746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628376Reviewed-by:
-
Hiroki Kumazaki authored
Bug: 1159296 Change-Id: I0af37949004a85479d41b5e2929a735637264c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626620 Commit-Queue: Hiroki Kumazaki <kumagi@google.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#843495}
-
Tetsui Ohkubo authored
In order to support other compression formats in imageWriterPrivate, UnzipHelper is renamed to ZipExtractor and its arguments are split into ExtractionProperties, so that other extractor classes can easily take the same set of arguments. Also this CL simplifies the lifecycle of the class by managing it on its own. This refactoring is described in "Adding multiple compression format supports" section of the design doc. Design doc: http://go/tar-xz-cros-recovery TEST=manually verified that zip file flashing and normal file flashing are working in Recovery Utility TEST=ImageWriterOperationTest BUG=b:153027505 Change-Id: I505bd426b163500926d0acae5947f6c3f0531758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573963 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843494}
-
Dominic Battre authored
This is an attempt to fix flakes in a number of AutofillPrivateApiTests. The hypothesis is that the tests fail because the PersonalDataManager did not have a chance to start up. This means that data may be unavailable or that change notifications are pushed because the PDM finally starts but these may then confuse observers that look for specific signals. This also fixed AutofillPrivateApiTest.RemoveEntry which became stale as some code changes happened while the test was disabled. The parameter list of the callback handler was incorrect. If there are still fakes, please don't revert this CL but rather disable the tests again with a new bug report. Bug: 1162474,643097,1143312,1154856,988146 Change-Id: I06b9dc3db02daa2b5eb74aa354719e323a7d4ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628287 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843493}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/198dc345383e..b421774ae9c3 2021-01-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 451c64aa to fabc0b0b (518 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I61d4c6df7b13831d564fdf4daec1572761b41b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629028Reviewed-by:
-
Henrik Boström authored
These tests fail before running due to https://crbug.com/1166107. Running the tests on other platforms should be sufficient test coverage until we figure out what the problem is. TBR=guidou@chromium.org Bug: chromium:1166107 Change-Id: I49aeac8d2a43290eb3a23fd4aeb2f00f5c4379bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629308Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#843491}
-
Reilly Grant authored
This change re-enables BluetoothShellApiTest.ApiSanityCheck on macOS and Chrome OS. To fix the flake observed on macOS the resource bundle for extensions_browsertest now includes the Bluetooth strings. Without these strings if a Bluetooth device is discovered there will be a DCHECK failure because the string needed to localize the device is missing from the resource bundle used for tests. Bug: 711484, 1165955 Change-Id: I8636feaff5180fd536f254f841dab89b2d5cc3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628246 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#843490}
-
Mark Pearson authored
Because it's flaky. BUG=1163917 Change-Id: I18a3f815bb3111051500a2048bdbb9a9ac191979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625940 Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9ed69807418..9e71e6a50f6b 2021-01-14 jacktfranklin@chromium.org ESLint rule to ban interpolation within <style> tags 2021-01-14 jec@google.com Fix typo in What's New update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166108 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaab49cfe2d6ed3bc2da180cc1ff2492916fd79d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628462Reviewed-by:
-
Andy Paicu authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166602 Change-Id: I319bd450947624388df6e3c2539edc0bfdca59d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628292Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843487}
-
Rakina Zata Amni authored
Logging this metrics allows us to add a slow report trigger, so that we can analyze what happened on these navigations by seeing the traces. Bug: 1131832 Change-Id: I66ffecc05b0cfb16d59ae1652648bc87a4affb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592281 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843486}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0dfd5b48e14..1ac263e38879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I88d16b2cf9af89d56b388239c0b70e49e7c14013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628460Reviewed-by:
-
David Jean authored
And menu api, and one remaining status bar orientation related issue. Bug: 1131852 Change-Id: I74747b488608a6156d5f1ef15b8d6e52c1aa4741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621307 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#843484}
-
Jan Krcal authored
This CL adds logic for SAML sign-in flows. Whenever the gaia domain is left in the sign-in flow, it is treated as a SAML sign-in flow, the profile creation is finalized and the SAML signin continues in a new browser window. Bug: 1126913 Change-Id: I48cac367d45567ba7186eb7d4cfa05dc90a0f97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627426 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Delan Azabani authored
This patch updates four web platform tests involving CSS highlight painting order, which should help us rework our highlight paint code to comply with css-pseudo. • css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html • two manual tests, checking the relative painting order of ::selection and ::{grammar,spelling}-error overlays • added @contenteditable/@spellcheck/@lang to test element • added Selection#removeAllRanges call to work around API change • replaced the grammar test sentence with a more obvious example • rewrote most of the comments for clarity • css/css-pseudo/highlight-painting-order.html • new reftest, checking relative painting order of text, original shadows, ::selection background, and ::selection shadows • based on <https://bucket.daz.cat/work/igalia/0/3.html> • css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html • one manual test, one reftest, checking that text-shadow:none in ::selection suppresses all original shadows (even if multiple) • dropped because they are no longer compliant (highlight overlays have their own shadows, independent of the content’s shadows) Bug: 1147859 Change-Id: I29bab589e3924778d555d96537d010dc33ed003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843482}
-
Hiroki Nakagawa authored
In addition, this CL renames PrerenderHelper::IsPrerendering() to NoStatePrefetchHelper::IsPrefetching(). Bug: 1144577 Change-Id: I1e875f651c50f401c54c7cc8d60d0b508b8e9ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626671 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843481}
-
Takuto Ikuta authored
This is for https://crrev.com/c/2628816 Bug: 1157476 Change-Id: I764bbc39c7a607e483d025ad32eb1e8d41897ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628641Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843480}
-
Ulan Degenbaev authored
The global detached bytes include memory of unrelated frames and extensions. We need to track per-frame detached bytes and only report those in the same browsing context group. Bug: 1085129 Change-Id: I3a562f0b3d898abe7508c46046cbd574db43173a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628987Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843479}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0a1a981c032a0a6a91af2ce32bd4fd0c8d57d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627879Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843478}
-
Vidhan authored
AlternativeStateNameMap can only be accessed on the UI thread. In the current implementation, the logic to determine state votes using AlternativeStateNameMap does not run on the UI thread resulting in the crash. With this CL, the state votes are preprocessed before |DeterminePossibleFieldTypesForUpload| is called. Bug: 1111960 Change-Id: I470b7db684916c4c7fef35d2018af876992c0c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617792 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#843477}
-
