GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6d93e6c4293..06d17cd5d92e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC parastoog@google.com,futhark@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: parastoog@google.com,futhark@google.com
Change-Id: I60d9ceddbc4cad381931cf8f458c876e601152b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507538Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822262}

Change-Id: I60f4def267077064cbd55bdb43661f544905eeba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507889
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822261}

In some circumstances, |connectedScenes| can contain a scene with
no associated SceneController while cleaning up after the last OTR tab.

This CL ensures that when this happens, the nil controller isn't added
to the controller array.

(Root cause for this state is unclear; some comments are added here as
well to guide future investigations).

Bug: 1142782
Change-Id: I33617e6e2252a2124870430c2eefc2cb4158a28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506440
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#822260}

Bug: 478572
Bug: 871352
Bug: 1136367
Bug: 1136369
Bug: 1143392
Bug: 1143408
Bug: 1143424
Bug: angleproject:2930
Bug: angleproject:3111
Bug: angleproject:3481
Bug: angleproject:5259
Change-Id: I66f1b04fade96015e9ea3727a4185753dd528135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505734
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822259}

This also removes default arguments for PartitionOptions.

Bug: 11297512
Change-Id: I0a694f8b300a04a08fb21fd1191066556f21d03a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507432Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822258}

This reverts commit bd6beb55.

Reason for revert: Open comments on CL

Original change's description:
> [Autofill][States] Implemented StateNameMapUpdater
>
> StateNameMapUpdater is a helper class for StateNameMapUpdater
> that reads the data from the state data files and loads them to the
> map.
>
> Bug: 1111960
> Change-Id: I8add7215a1ec450e0a31ef999b2adfa6dade138b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471337
> Reviewed-by: Matthias Körber <koerber@google.com>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Commit-Queue: Vidhan Jain <vidhanj@google.com>
> Cr-Commit-Position: refs/heads/master@{#822187}

TBR=battre@chromium.org,koerber@google.com,schwering@google.com,vidhanj@google.com

Change-Id: I5a47671505371abfccfd5ba5ebbe43002e2db4f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1111960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507751Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Vidhan Jain <vidhanj@google.com>
Cr-Commit-Position: refs/heads/master@{#822257}

This is in preparation of removing <include src="assert.js"> and
flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js,
which in turn is necessary to auto-generate grd entries for
ui/webui/resources/js/.

Bug: 1143194
Change-Id: I575b56264674cc6faa903118d8305d6db20f6572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506108
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822256}

This CL records the error state of access token
fetch in the new EduCoexistence flow. The histogram
already exists and doesn't need to be defined.

Bug: 1140250
Change-Id: I2da00d0d01f273127aeb081737e00397fd19b735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490732Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822255}

This flag has been default-enabled for a long time and has been expired
for 11 milestones now.

Bug: 1110583
Change-Id: I72ae22ab084d6f8e096582301b3ac59824b95304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505600
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822254}

The network diagnostics mojo is now a separate html file instead of
being included directly. This allows the polymer 3 modulizes to
correctly convert the include into a module.

Bug: chromium:11406598
Change-Id: Idc4dc7c1a23b0a9897742289c311c07e0507fc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490349
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822253}

crrev.com/820094 recently disabled the test on macOS and Linux due to
flakes. The tests are now flaking on Windows due to crashes, not
timeouts.

TBR=jam@chromium.org

Bug: 1141263
Change-Id: Ie2913d30a138b8073811e3ee04774c473d893aaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507950Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822252}

Currently if a developer want to run a pixel test locally, they need to
append "--no-luci-auth" flag.
With this change, developer will not need to the flag when running test
locally. This makes the test easier to use as adding the flag is not
obvious.

Change-Id: I4cba13fba41a38099e714d0ab5e9e3ddc648d250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506139Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822251}

TBR=josiahk@google.com

Bug: 1139939
Change-Id: I4b173529cfebfaea9f5efd5f1c2ce621bc0cacac
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505806Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822250}

This CL is adding the code to dump memory usage for inner-structures
used by URLIndexPrivateData.

The purpose of this CL is to estimate the size/count of the pathological
cases and to see which inner strucutures required limits.

NOTE: This CL need to be reverted before the M88 branch point on Nov 12.

Bug: 1068883
Change-Id: I5c4709d7ce7b634aa2ccf5b40bc19d6bff2e77eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504278
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822249}

Metrics are very positive.

Bug: 1115577

Change-Id: Ib68e5fcf6248f02e5ebc665247116b410ab50c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488753Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822248}

This attempts to fix the failing
StartupPaintPreviewTest#testRemoveOnActionbarClick test.

Bug: 1143219
Change-Id: Icc93483d13d96c9331f1b26d5ff9f0ef748c0750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506886Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822247}

This CL makes the native window occlusion tracking code register
a global event hook for EVENT_OBJECT_SHOW/HIDE events. When we get one
of those events, check if the window class is either
"MultitaskingViewFrame" (alt tab) or "TaskListThumbnailWnd" (taskbar
preview). If either of these is shown, mark all non minimized root
windows as visible, so that their thumbnail will appear, and things
like YouTube videos will play in the thumbnail. When either of these
is hidden, recalculate occlusion.

The downside of this approach is that we will mark all Chrome root
windows as unoccluded when any app's thumbnail is shown from the
taskbar. I think it's worth doing this to fix the thumbnail regressions.
There can also be a bit of a delay before rendering resumes in the
thumbnails.

Bug: 1137110, 993776
Change-Id: I5528d612822517071dc06904f9093ee5ee9f9f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503815Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822246}

NOTRY=true

Change-Id: I4027f3889e876cb5450829d89dd8310459cb271b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508209
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822245}

For the Scroll-To feature, Mark elements need to be cleaned-up upon
tapping anywhere on the page rather than only when tapping on a marked
element directly.

Bug: 1143675
Change-Id: I5207e96c4b053fc19b90646840b4fa9d57997d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507394Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822244}

By setting its own SSN cookie and checking for it this test no longer
assumes that the cookie jar is empty at the start of its run and should
therefore become more robust against failures.

Because it's setting cookies with, potentially, the same name as other
tests this test will now also use a random value for added confidence
in its results.

Bug: 1143288
Change-Id: Ib256e6366caf4c2edf40637c8caf98955b97924d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505578
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822243}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/aba52f78e1ba..5ae623f592fc

2020-10-29 briannorris@chromium.org loman: realpath, not readlink
2020-10-29 yich@google.com auto_updater: Clear TPM owner when clobber stateful_partition
2020-10-29 chrome-bot@chromium.org Update config settings by config-updater.
2020-10-28 ahassani@chromium.org Revert "xbuddy: Do not rename update payloads to update.gz anymore"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I50e263b1935f68380d41cefaf862c6b8dfa22ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507535Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822242}

TestRunner manages a set of active main frames, and it confuses tests
if it keeps holding inactive main frames.
If we enable BF cache, deactivated main frames are not removed from the
set, and thus it regresses some tests.

This CL makes TestRunner handle the set on deactivating/reactivating
main frames.

Bug: 1136383, 1132180
Change-Id: I5a7376ce95004e8652f4645a56fd6a4d08fff1a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483727
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822241}

Bug: 1138620
Change-Id: I3b54fe58f68e2d99448840d13887cd8d7b548ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506397
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822240}

This CL populates the fields added in:
  https://chromium-review.googlesource.com/c/chromium/src/+/2486525

It will require changes in Android Browser Helper to actually put
those fields into Bundles we receive.

Change-Id: I55f6980f51702b768c46214d37496369a142b081
Bug: 1140345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506443
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822239}

TBR=tkent

Bug: 1143720
Change-Id: I0dcd91b76d6c04e6aeea6ef3ed1faa89f29d969c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507542Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Auto-Submit: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#822238}

Various crash-related tests were disabled because loading of debug
information on Windows 7 was too slow and caused timeouts. This was
caused by symbol_level=1 becoming more verbose (including line numbers
and source files) and dbghelp.dll on Windows 7 seems to be particularly
inefficient. This was fixed a while ago by getting the bots to default
to symbol_level=1. This is the second of two changes to re-enable the
tests that were disabled (the first change seems to have worked well).
The previous change was crrev.com/c/2500315.

Bug: 985255
Change-Id: Id59c14376bf056b501bdcec88c2677d00a7b394f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503196Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822237}

Currently only supports querying SelectToSpeakNavigationControl, though can be expanded to include other a11y features we want to expose in the future.

AX-Relnotes: N/A
Bug: 1142601
Change-Id: Icaa77ceb658750110a979846614b1f3c8aaf4f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504279
Commit-Queue: Joel Riley <joelriley@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822236}

Bug: 1106938
Change-Id: Ifbada6d7ef9552ffc0e7ee3a3429f30422c1eacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498838Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822235}

This conceptually splits Toolbar data and LocationBar data. In practice, they share several properties and a concrete implementation, but the two interfaces are now distinct.
This also removes getDisplaySearchTerms, which only ever returns null now.

Bug: 1142883

Change-Id: I6274c18cfeafaebf196afb0b92e3bdc56d3eada6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491013
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822234}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010290700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/8Q4xmmaYrnhc7cohh6-6mYy09ZY7fiz1y0LEgZ-Y0boC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/169360699,b/170440261,b/171418658,b/171436494,b/171942215
Tbr: media-app@grotations.appspotmail.com
Change-Id: I4f39724ecd0639623a3dd7f0b7d9e1c798d48a62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507532Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822233}

Registers an a WebUIControllerInterfaceBinder for SystemDataProvider.


Bug: 1128204
Change-Id: I4a35ec87d4e6e841a6d0e94eca7bfdb5f61cf832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496189
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822232}

Standalone & Trichrome WebView now unconditionally includes
LauncherActivity (defined in DeveloperUiLauncherManifest), and
conditionally set the enabled state to true/false based on GN args
(webview_devui_show_icon, which is configured by android_channel).

This is a step toward resolving https://crbug.com/1047824, although this
is not a complete solution since this doesn't change the monochrome
behavior.

Fixed: 1140741
Bug: 1047824
Test: aapt dump xmltree TrichromeWebViewGoogle.apk AndroidManifest.xml | grep -A 2 'LauncherActivity'
Test: Same for TrichromeWebViewGoogleBeta, TrichromeWebViewGoogleStable, SystemWebViewGoogle, SystemWebView
Test: adb shell pm enable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity
Test: adb shell pm disable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity
Change-Id: Id996965643a6fea31a34ebe39fb5b2b8ac5f5c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500435Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822231}

Change-Id: I84ce57f72aafe561e677def149316b16e3d37f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507258Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822230}

This CL was uploaded by git cl split.

R=peter@chromium.org

Bug: 1142671
Change-Id: Ic6195d837cd85a2b62b52d5bc27f24d59a996c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500704
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822229}

This change is behind the kReadLater flag and allows read later items to
sync cross device. This also adds a 'Reading List' option to
chrome://settings/syncSetup/advanced on Desktop when the flag is
enabled.

Bug: 1109316
Change-Id: I676a3ffaf565095eb02b95ea1d86577c60dc652f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504271
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822228}

For context please see crbug.com/1138535#c6. This CL brings back the
code in the ModelTypeProcessor implementations to actually compute the
counts, as well as the associated plumbing. Some differences between
this and the original code however:
- Most methods are made const.
- Previously ModelTypeController::Get*() was only called when the
state was different from NOT_RUNNING and the method had a DCHECK
for its ModelTypeControllerDelegate. ProfileSyncService doesn't check
for the state now, so an TypeEntityCount with 0 values is sent in case
the delegate is null.
- ProfileSyncService used to send count notifications individually for
each data type. They are now aggregated in a single batch. Since
calls for each type are async, this requires some smartness in
PSS::GetEntityCountsForDebugging().

Bug: 1138535
Change-Id: If29f64892dd0ad63300dfd099a991b4a118dbc38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505810
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822227}

Still recording the old histogram will allow an apple-to-apple comparison
with the data from the past.

Otherwise, it will be hard to distinguish the effect of a new feature VS
the effect of changing the trigger when we compare the data of the new
histogram with the data of the old histogram.

Bug: 1141737
Change-Id: Ia5af11ed644d8be403528728782f45dbb2684538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505595Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#822226}

This was enabled by finch. Now enable it by default.

Bug: 949839
Change-Id: Ib0f417bacde686d43193a58c1b3a9b0cc0c6b999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506570Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822225}

ClientAndroid and RuntimeManager are both owned by web contents. When
web contents is destroyed order of destruction of these components is not
guaranteed. So we can end up in the state where pointer to
RuntimeManager is not valid anymore. So instead of sending raw pointer
to Controller, we send WeakPtr and check its validity before calling
the method.

Bug: 1140959
Change-Id: I2b618bea04cc09dcc71cb90f4d166234e8704704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503554
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#822224}

We build raster queues for both pending layers and active layers when
checking IsReadyToActivate() in issuing signals. If there is no pending
tree from the TileManageClient, we can save the CPU time by skipping
IsReadyToActivate().

Bug: 880190
Change-Id: Iac2e162ffb1d462cd3a3168cfed7c22363013537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505115Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822223}