GitLab

NGPhysicalFragment needs special handling on the destruction
rather than being destroyed by WTF::RefCounted. However, existing
style of the destruction hook will be unavailable after unifying
base::RefCounted and WTF::RefCounted.

This CL adds a proper way to inject the destruction function of a
ref counted object. The destruction function will be injected to
base::RefCounted after the unification.

Bug: 763844
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If763525a55c4621abd711a16a531817528a42b69
Reviewed-on: https://chromium-review.googlesource.com/681955Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504365}

This CL removes the getter of the ref count value from
WTF::RefCountedBase, which is missing on base::RefCounted and will be
unavailable after these unification. And this also removes all usage of
the getter.

Bug: 763844
Change-Id: I3b91d16213a160c9c6a2bf1e4cea16598043c00e
Reviewed-on: https://chromium-review.googlesource.com/680618Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504364}

There are two branches currently:
- if at least one user has a maximized window, fade shelf to black
  and back. Note that this branch is broken, and instead all you see is
  a white flash, but this is easily fixed if need be.
- otherwise, set shelf to hidden and then let the user switch update the
  state from there.

If we remove both of these branches and just let the user switch change
the state of the shelf, the outcome is nearly indistinguishable.
Scratching the second bullet point above seems to have no discernible
effect. Scratching the first branch just means there will be no fade-to-
black, however the addition and removal of launcher icons is animated
regardless, so it still looks smooth. Additionally, the fade-to-black
doesn't work on the system tray (clock, avatar), and hasn't worked at
all for 4 months and no one noticed. In a sense, removing this branch is
an improvement because it removes a white flash.

Bug: 756085
Change-Id: If40c65e02035947709be31db466dea144ab0b462
Reviewed-on: https://chromium-review.googlesource.com/683035
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504363}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6f2b6f8f72ff..02e80da6090c

$ git log 6f2b6f8f7..02e80da60 --date=short --no-merges --format='%ad %ae %s'
2017-09-24 apodtele Tweak per-face LCD filtering controls.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

Change-Id: Ief384669998d1994f574fdf86229a05ec16f6426
Reviewed-on: https://chromium-review.googlesource.com/682176Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504362}

A bit of cleanup after a recent commit that added an unnecessary header
file.

Bug: 745732
Change-Id: I1a90f22c9301ab60a09ea2fec9020c5da431460b
Reviewed-on: https://chromium-review.googlesource.com/684177
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504361}

|Element*| objects.

Bug: 766448
Change-Id: I5c195095cc692f3cc3fd6d7fb68fbaf98ffc875e
Reviewed-on: https://chromium-review.googlesource.com/673146Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#504360}

- Replaces grey_typeText with grey_replaceText so that the test can be
  enabled in iOS11.
- Modifies the test so that the navigation buttons are not used to go to
  the previous editor field. The reason for that changes is that on iPhone
  5/5s, due to the size of the screen, the previous field may be under the
  scroll and therefore the "previous" navigation button is disabled.

Bug: 753098
Change-Id: I3343014e8374cea6bbfa3031a92f631ad7d9039d
Reviewed-on: https://chromium-review.googlesource.com/682341Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504359}

Suspected proximate cause of rare crashes during stylesheet loading.
There's not much we can do if these resources are failing to load, but this
at least stops the compression logic from crashing and makes Chrome behave
how it did before the addition of |is_gzipped|.

Bug: 749963
Change-Id: Ia9262dc4febbe8f9d81fdc555252a372e1d63820
Reviewed-on: https://chromium-review.googlesource.com/682642Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504358}

Missing traffic annotation added to
ServiceWorkerFetchDispatcher::MaybeStartNavigationPreloadWithURLLoader

Bug: 766239
Bug: 656607
Change-Id: I4df9cd4389cfe494fb34176f9efe005f76a24f73
Reviewed-on: https://chromium-review.googlesource.com/678498
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504357}

TBR=torne@chromium.org

Bug: 767180
Change-Id: I3ad4f6d1b67d19eb09f5dd489699031d629ff740
Reviewed-on: https://chromium-review.googlesource.com/684375Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504356}

Change-Id: I7b5950fbeb943479cb73569f0265fa1d999e951c
Reviewed-on: https://chromium-review.googlesource.com/684556Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504355}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/639e972bf15c..0b563bed301e

$ git log 639e972bf..0b563bed3 --date=short --no-merges --format='%ad %ae %s'
2017-09-26 nednguyen Roll snap-it to the latest version

Created with:
  roll-dep src/third_party/catapult
BUG=763119


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I96c44060e96843f8352d87872b0be5aea0602f46
Reviewed-on: https://chromium-review.googlesource.com/684554
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504354}

This isn't wanted for Harmony, and it looks a bit out of place even in the
non-Harmony version of this dialog.

Bug: 610428
Change-Id: I82429d8317d392eaf29803bd1870f1a07420dba1
Reviewed-on: https://chromium-review.googlesource.com/681837Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504353}

This reverts commit ed15e687.

Reason for revert: Tests should now fit within the allotted time.

Original change's description:
> Revert "[tools/perf] Re-enable meadia system health smoke tests"
> 
> This reverts commit 359bafda.
> 
> Reason for revert:
> 
> Seeing telemetry-perf bot failures.
> 
> Original change's description:
> > [tools/perf] Re-enable meadia system health smoke tests
> > 
> > These are running fine on bots now.
> > 
> > Bug: 726439
> > Change-Id: I97a5f9e85d873c685af14085f9534081fd3a5ee5
> > Reviewed-on: https://chromium-review.googlesource.com/655299
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#500564}
> 
> TBR=perezju@chromium.org,nednguyen@google.com
> 
> Change-Id: Ib3d38babf138c04ea32fa62cf257d20727593888
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 726439, 763379 
> Reviewed-on: https://chromium-review.googlesource.com/657917
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500594}

TBR=rogerm@chromium.org,perezju@chromium.org,nednguyen@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 726439, 763379
Change-Id: I309dfdd0f7b32bd4dc275904fc24ef1e251f8c85
Reviewed-on: https://chromium-review.googlesource.com/684024Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504352}

This enables the new Clear Browsing Data dialog by default for desktop.
privacy_page_test.js needs a small fix, so it doesn't break. 
I will change privacy_page_test.js to completely run on the new ui
in https://crrev.com/c/647713.

Bug: 725401
Change-Id: I8647e53bc93725c84cf45ada46123d84038c9a78
Reviewed-on: https://chromium-review.googlesource.com/647712Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504351}

This reverts commit 6569f043.

Reason for revert: Still fails on the bot for some reason, but passes on my local machine.

Original change's description:
> Re-enabling Firefox interop test.
> 
> The fix is now in the Firefox nightly; verified the test passes
> locally.
> 
> Depends on https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/3401.
> 
> R=​ehmaldonado@chromium.org
> 
> Bug: 751211
> Change-Id: I191db39747711b09a0c36e367e8e08fac0c53ea5
> Reviewed-on: https://chromium-review.googlesource.com/681701
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504331}

TBR=kjellander@chromium.org,phoglund@chromium.org,ehmaldonado@chromium.org

Change-Id: I75ad86884d347f7853d6c616dbf284fbe0729c11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 751211
Reviewed-on: https://chromium-review.googlesource.com/684313Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504350}

Previously it was propagated to Java. In this CL, it is used there as a
placeholder. Thumbnail fade-in works as before. The change is guarded
with a feature, which is enabled by default in Chrome Home.

Also ic_snippet_thumbnail_placeholder.xml background is changed from
default_primary color to modern_light_grey.

Render tests golden images changes:
-ArticleSnippetsTest.long_snippet_narrow.Nexus_5-19.png
-ArticleSnippetsTest.long_snippet.Nexus_5-19.png
Change thumbnail placeholder background color

-ArticleSnippetsTest.modern-long_snippet_narrow.Nexus_5-19.png
-ArticleSnippetsTest.modern-long_snippet.Nexus_5-19.png
Replace thumbnail placeholder with thumbnail dominant color

Bug: 754183
Change-Id: I732a56bd33c699c48472a6e3bfebbd01e273154f
Reviewed-on: https://chromium-review.googlesource.com/677444Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504349}

Unnecessary policy options removed from the sample, comments added.

Bug: 656607
Change-Id: I71123785e9a1d032908a1d0c42884c26cff15f20
Reviewed-on: https://chromium-review.googlesource.com/684018Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504348}

Use standard way to select tab.

Bug: None
Change-Id: I531a3e450d93c860b62f8896379e8097d7b1f622
Reviewed-on: https://chromium-review.googlesource.com/684438Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504347}

Using wpt-import in Chromium e8e9916c.
With Chromium commits locally applied on WPT:
e8e9916c "Trusted Types: First stab at TrustedScriptURL."


Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2434

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I809a86e7b89c8556f686725814f4272a104367b3
Reviewed-on: https://chromium-review.googlesource.com/684234
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504346}

Getting the previously freed object at "this" is only useful if the
corruption was found in the "dummy" field.  If in fact it is the
histogram name that has been damaged, we must look up the object from
the string's base address.

About 1/2 of the crashes are due to a corrupted string so this will
effectively double the number of data points to analyze.

Bug: 744734
Change-Id: I9a923b7c416330d906bf2373ced3df08874299aa
Reviewed-on: https://chromium-review.googlesource.com/683734Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504345}

This CL adds new methods to support restarting a MediaStreamVideoSource.
By default, sources continue to be nonrestartable, but the
MediaStreamVideoCapturerSource does implement the restart capability.

This is a preparatory CL to support MediaStreamTrack.applyConstraints(),
which requires the ability to change the video format of a video source.

Bug: 763319
Change-Id: I91b868326f1fcc52a8146612e4cd0429774f82e1
Reviewed-on: https://chromium-review.googlesource.com/675687
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504344}

This CL implements blob request body for bypassing to a service worker. When a request body exists, SWURLLoaderJob creates BlobHandle to forward a request to the service worker.

Bug: 764154
Change-Id: Ie432db242b643443b161a4c8ea8adbbc08169e15
Reviewed-on: https://chromium-review.googlesource.com/672103
Commit-Queue: Emi Morikawa <emim@google.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504343}

This stuff was a LOT of plumbing, all to eventually determine "is the
current tab an NTP?". That can be had MUCH simpler :)

Before:
SearchTabHelper (per-tab) has a SearchModel and updates that with the
"isNTP" state. The state for the active tab gets propagated via
SearchDelegate to BrowserInstantController's SearchModel instance.
InstantController listens for changes to that, and on non-NTP->NTP
transitions sends the "Instant info" (i.e. MV tiles and theme) to the
Instant process.

After:
InstantController watches for relevant navigations itself and just
checks the "isNTP" state directly. Several kilometers of plumbing are
removed, and there is much rejoicing.

Manually tested the following cases:
- Navigating regular page <-> remote NTP
- Navigating regular page <-> local NTP
- Navigating local NTP <-> remote NTP
All these for regular and forward/back navigations, and for Google and
third-party DSE.

Bug: 627747
Change-Id: Id55b1f28550b4aeee1e5472ac0e8eebd0ee0d65c
Reviewed-on: https://chromium-review.googlesource.com/678719Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504342}

Bug: 767004
Change-Id: I809d651345d4c5ae376c2967c58a11c5c1dd94b4
Reviewed-on: https://chromium-review.googlesource.com/674870
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504341}

This CL modifies PreconnectManager to use a host instead of full URL as
a key for active PreresolveInfo.

The CL also adds several DCHECKs to ensure that the PreconnectManager
uses only shortened GURLs (origins) to issue requests.

Bug: 699080
Change-Id: I9938de1fa5ad908c1df181b0cf88bac9691a9e06
Reviewed-on: https://chromium-review.googlesource.com/677455Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504340}

This reverts commit 9aa706c8.

Reason for revert: Mistakenly disabled on wrong configuration.

Original change's description:
> //tools/perf: Disable long running gmail story for memory_mobile
> 
> TBR=rnephew
> 
> Bug: 764924
> Change-Id: I1ca8db7fc360daf57f216c11c32470489f76928d
> Reviewed-on: https://chromium-review.googlesource.com/666060
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501778}

TBR=rnephew@chromium.org,martiniss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 764924
Change-Id: Id97802a417b6a7e1364f8a2cef48f7b1c056086c
Reviewed-on: https://chromium-review.googlesource.com/681354Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504339}

This patch splits the "ordinal value" logic[1] to a separate class,
ListItemOridinal, so that we can re-use the logic in LayoutNG.

The logic is mostly DOM operations that moving them out of layout is
reasonable from the layering perspective too.

It still relies on layout tree to provide the storage, and events for
insertions and deletions, since any elements with 'display: list-item'
can be list items.

[1] https://html.spec.whatwg.org/multipage/grouping-content.html#ordinal-value

Bug: 591099
Change-Id: Ia61ee764db83203ac8a4006cbab534b5ccf56606
Reviewed-on: https://chromium-review.googlesource.com/678415
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504338}

async_test can be executed out of order, which leads to flaky console
output. This CL splits the file to avoid the issue.

Bug: 705125
Change-Id: I3dda81b84e05a6c50e786030d1a883e085fb80a0
Reviewed-on: https://chromium-review.googlesource.com/677165Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504337}

It's no longer used and the same functionality can be accomplished
by adding variable defaults to the .gn default_args dict.

Bug: 768723
Change-Id: I5f6723c2831fb0a5c9eba24ba53b3152ed3c8352
Reviewed-on: https://chromium-review.googlesource.com/684175Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504336}

The button currently says the mode after view change, like "thumbnail
view". It is not clear if it's current mode or the other mode.
This was especially confusing when using screenreaders.

Bug: 755271
Change-Id: Ie305971a32224d6ea715df5ab0fc1e0dd6e2aa91
Reviewed-on: https://chromium-review.googlesource.com/684096Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504335}

Inside Editor.cpp expression |GetFrame().Selection()| used at many
call sites and can be replaced by shortnamed helper.

No changes in behavior.
No new tests.

Bug: 
Change-Id: I906eeea10e9e5e9a303c27a8fdc29b6e738eeaa8
Reviewed-on: https://chromium-review.googlesource.com/667378
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504334}

Given sample css as follows:
.foo::before {
	display: inline;
	content: attr(bar);
	color: red;
}

We can now parse the content of the .foo::before block.

We maintain whether or not the block to be parsed has ::{before,after}
in its prelude on CSSLazyParsingState

If the block's prelude has ::{before,after} and the properties in the 
block contain CSSPropertyContent, we update invalidation sets for 
that block and mark the CSSGlobalRuleSet as dirty. The document will 
then update the CSSGlobalRuleSet.  

Bug: 642722
Change-Id: Id6094fbb201b4eb3463ddd34dce32f09c4c1478b
Reviewed-on: https://chromium-review.googlesource.com/662084Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504333}

This patch separates the ability to supplement missing traits functions from
Complete*d*ContainerTypeOperations<T>. It turns out the upcoming changes
will require the ability to complete arbitrary ContainerTypeOperations
implementations, not just ContainerTypeOperations<T>.

BUG=715430

Change-Id: I49828fd8e8f68ff97eb5f5117e6bdf0351ddcc9b
Reviewed-on: https://chromium-review.googlesource.com/681534Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504332}

The fix is now in the Firefox nightly; verified the test passes
locally.

Depends on https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/3401.

R=ehmaldonado@chromium.org

Bug: 751211
Change-Id: I191db39747711b09a0c36e367e8e08fac0c53ea5
Reviewed-on: https://chromium-review.googlesource.com/681701Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504331}

* Capture the default thumbnail.
* Scroll down to first card.
* Scroll down to more button.

Bug: 761813
Change-Id: I168833ee7abb3519504eb6ec93465257ecaffc2c
Reviewed-on: https://chromium-review.googlesource.com/681476
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504330}

This CL makes WTF::Vector::erase() semantics identical to the
stl::vector::erase(), i.e. it accepts an iterator and returns an
iterator.
Rationals:
1) This semantics is expected by developers
2) Compatibility with std algorithms, e.g.
auto it = std::lower_bound(
    sorted_vector.begin(), sorted_vector.end(), item);
active_frequencies_.erase(it);
3) Allows to create template classes (e.g. algorithms) theat call
erase() and can operate with both WTF and std vectors.

The old version of WTF::Vector::erase() is renamed to

WTF: :Vector::eraseAtIndex()
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2677541d3ed188d89035c6a11a0312d5cd248080
Reviewed-on: https://chromium-review.googlesource.com/620649Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#504329}

Due to Chrome Home, we have multiple features, which are enabled
conditionally on Chrome Home. This was achieved by having helpers
checking both features. However, these helpers were not available
outside of the factory.

In this CL:

1) Move these helpers into a separate file |dependent_features.{h,cc}|

2) Use the moved helpers in snippets_internals

3) Disable ForeignSessionsProvider in Chrome Home

4) Add a comment to components/ntp_snippets/features.h to not depend
on these features directly.

Bug: 754260
Change-Id: Idf91f8a934c94048b0de1be459fe6004396e12a8
Reviewed-on: https://chromium-review.googlesource.com/681515Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504328}

When a run ended in a grapheme cluster consisting of a least two
characters, and this grapheme resulted in not being shaped with the
current font and needed fallback, then the full run from the beginning
was incorrectly rendered in the fallback font. This is because one state
transition between shaped and not shaped was not recognized, as the
last_change_position had been advanced too far.

To fix this, I clarified the shaping loop and moved the logic for
commiting glyphs and queueing characters for reshaping into separate
functions. When reaching the end of the glyph run, transitions between
shaped or unshaped are detected for the last grapheme cluster and added
to the ShapeResult or the reshaping queue accordingly.

       inspector-protocol/layout-fonts/prefix-fallback-multi-character-grapheme.js
       svg/text/combining-character-queries-expected.svg

Bug: 758380
Tests: EmojiZWJSequence in HarfBuzzShaperTest.cpp,
Change-Id: I95d536c488ac602cb4bdfd4e1ac4a729f92b1462
Reviewed-on: https://chromium-review.googlesource.com/657977
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504327}

It seems that after https://codereview.chromium.org/2566583002 it
isn't needed anymore.

No change in behavior.

Bug: 
Change-Id: I9676e8e98a8d289e84ac65c34614e0f3d18c2767
Reviewed-on: https://chromium-review.googlesource.com/590247Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#504326}