- 13 Apr, 2020 39 commits
-
-
Koji Ishii authored
This patch changes |NGPhysicalContainerFragment| constructor to move children from |NGContainerFragmentBuilder|, instead of calling |AddRef|. Children in |NGContainerFragmentBuilder| will not be used after it generated a fragment. We used to move, but changed to copy when the child list was changed to a flexible array in r603306 crrev.com/c/1298207. Change-Id: Iac77022c39835598b2257b24cf80e0f0f34f8a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145734 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#758472}
-
Hiroki Sato authored
This reverts commit a5301433. Reason for revert: betty-pi-arc-pi-android-pfq is continuously failing Bug: 1070126 Original change's description: > Manually roll chromite to pick up localhost vs VM fixes. > > Picks up a single change: > $ git log 97d7f0702..8ef1e6c0 --date=short --first-parent --format='%ad %ae %s' > 2020-04-06 bpastene@chromium.org device: Don't assume '--device=localhost' means VM. > > And updates chromeos/test_runner.py to not specify '--device=localhost' > when running VM tests. > > Bug: 1067800 > Change-Id: Id8af6b2cb1d8a082b71a6ac01cfe9522578a21b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145762 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758264} TBR=achuith@chromium.org,erikchen@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1067800 Change-Id: Ide5832c94b127d0ad360f66954bf2ce101b0933e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146409Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#758471}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32c61af49cdb..4b4efe4d6f1f git log 32c61af49cdb..4b4efe4d6f1f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c68dfaf3a529..cf2c8e6068c8 (6 commits) 2020-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e6f65d9265e7..9d2fd9c161ab (2 commits) Created with: gclient setdep -r src/third_party/skia@4b4efe4d6f1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ib78982c28a5341adc455189054b640399ebecd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758470}
-
Koji Ishii authored
To improve the performance of |NGFragmentItemsBuilder|: 1. This patch merges two vectors (items and offsets) to one. This is the same as r664158 <crrev.com/c/1633019> did to |NGContainerFragmentBuilder|. 2. This patch gives an inline size to the vector to reduce memory allocations. The allocations of these two vectors is hot in text-heavy benchmarks. This patch improves: * chapter-reflow by ~5%. * line-layout-repeat-append by ~15%. These tests are currently slower when FragmentItem is enabled. https://pinpoint-dot-chromeperf.appspot.com/job/11669b69e20000 Bug: 982194 Change-Id: I2c787438abc4c2484fe9ae432447ecd30ee4a0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142668 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758469}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fd593d5f0834..46572440189e git log fd593d5f0834..46572440189e --date=short --first-parent --format='%ad %ae %s' 2020-04-13 cepheus@frii.com Fix #2178: Allow specialization constants for texel offsets. Created with: gclient setdep -r src/third_party/glslang/src@46572440189e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I90292aabd43fc7e7db8c61611010c82c1d0b1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146857Reviewed-by:
-
edchin authored
This CL allows managed bookmarks to be shown if: 1) There are managed bookmarks from the ManagedBookmarkService, 2) The ManagedBookmarks feature flag is enabled. This flag allows for a server-side kill switch. Managed bookmarks are bookmarks that are set by an enterprise policy and are available in every device managed by that policy. This folder is a sibling of the Bookmarks Bar, Mobile bookmarks, and Other bookmarks. The managed bookmarks folder is not editable, nor any item within it. This CL disables swiping to delete and long press gesture for any item or folder that is not user-editable (which includes all descendants of the managed bookmarks folder). The edit/new folder toolbar is also hidden for folders that are not user-editable. Bug: 1065187 Change-Id: If63ee2673576dc8a838f05beb8b81fa301f22a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140953 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#758467}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3d6123e3. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2c3a9f2c8dcd6b478001fea85045e0f68965a93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144709Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758466}
-
Julie Jeongeun Kim authored
This CL updates how to handle negative values for baseFrequency on <feTurbulence>. As the spec[1] says, it should leave it unsupported, which means it's treated as if they hadn't been specified when rendering. [1]https://drafts.fxtf.org/filter-effects/#element-attrdef-feturbulence-basefrequency Bug: 1068863 Change-Id: I6799cb26b6997f1b4d7afc9f5222a209064a30b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141485Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#758465}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6dfc55454671..32c61af49cdb git log 6dfc55454671..32c61af49cdb --date=short --first-parent --format='%ad %ae %s' 2020-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6de7d4c5..94450aa9 (332 commits) Created with: gclient setdep -r src/third_party/skia@32c61af49cdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ic70ad721d6cb7a3393fe9e95350b6ee0dc7da64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146855Reviewed-by:
-
Rakesh Soma authored
Change-Id: Ib1a6fe5130e16718252af1c92db3d5987261b729 Bug: 1070045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146210 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#758463}
-
Yuki Shiino authored
If an interface doesn't support indexed properties, lets V8 indexed interceptor fallback to named interceptor. Bug: 839389 Change-Id: I039a7ce6a199380479855307e7cb9bd7cf005888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145383Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758462}
-
Koji Ishii authored
This patch changes |NGFragmentItems| to flexible array, saving the overhead of |Vector| and possible unused capacity. Bug: 982194 Change-Id: I824ab7cfba8e707a2e8d41e2d54cbd85dee6f111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142888Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3f138576af56..6124b5308bbe git log 3f138576af56..6124b5308bbe --date=short --first-parent --format='%ad %ae %s' 2020-04-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6124b5308bbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34dc3242bf1934a17cefacae533cd41672b93b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146854Reviewed-by:
-
Johann authored
Use HeapMojoRemote wrapper so that Oilpan will GC the object. Bug: chromium:1049056 Change-Id: If487b9dd2ff48464691c300198efe6134d7aeba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143023 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#758459}
-
John Z Wu authored
This will help with manual testing in the shell app Change-Id: Ie331c62e08a1d1aeab9a5d9122df134a6aa29769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145683 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#758458}
-
Tsuyoshi Horo authored
This syscall is required by CRYPTO_BUFFER of BoringSSL. Bug: 1050158 Change-Id: I3b14a263c81ab614005a8f879e64bf4b3634ad76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143884Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#758457}
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: I4d1e6054ce940d975710d8114f2f193304b554c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134236Reviewed-by:
-
John Z Wu authored
Change-Id: Iad60ec64d0633faac2083f5cdf9dfa67fc52ff0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143862 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL adds a build target chrome/browser/tab:java and a dummy class file to get the build working. This will be used to keep the build green while a 2-side patch https://crrev.com/c/2102998 lands. The build target doesn't affect any upstream builds for now. Will be used for the downstream build only, and updated immediately to be a real target for the upstream. TBR=twellington@chromium.org Bug: 995903 Change-Id: I2941cc0066edc083981ee3e386a7225618a3789f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146406Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#758454}
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: I711a0c7f3676e6a423152ad02175ab7adb9260a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139815Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia096be5c18301a05b5e770649c5a86a9881d485a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146850Reviewed-by:
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: I902200e328a800ec23a4c34ce7896b5d25122b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132791Reviewed-by:
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: Id52422ad244199d802c3c66afe480646e1672d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127112Reviewed-by:
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: I6ddf9f7e91c6a01bab7eed59d5d4f9b990636e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142231Reviewed-by:
-
Yuki Shiino authored
Fixes the bindings generator not to expose IDL constructs by default, i.e. exposes only when [Exposed] is applied. No user visible behavior change. Change-Id: I3f16ff87afbf66c12e258bcd2c7f146e8afa4e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145735Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I3124b3c0363e25b9e7bc1573665897dae898633f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146790Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758447}
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: Id46a74411f7053437297e6857530aaa5f351efca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135687Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I497af4ab58c53f37825374e4423897f4b2c842e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142889Reviewed-by:
-
Kenichi Ishibashi authored
These methods are wrappers of corresponding methods defined in ServiceWorkerStorage. Bug: 1055677 Change-Id: I9acefbd627af1f9b495b9e47815bb109d07dc711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141813 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#758444}
-
Wanming Lin authored
This CL upstreams most device orientation tests to WPT. - Moves device orientation tests from web_tests/device_orientation/, web_tests/http/tests/security/powerfuFeatureRestrictions/, to web_tests/external/wpt/orientation-event with some necessary updates to adapt to WPT test framework. - Retains two page-visibility.html tests as which could not be automated in WPT at present and adds two similar manual tests there to keep test coverage sufficient. - Leaves existing tests as is, further improvement (e.g. remove duplicate tests, use EventWatcher, etc.) will be arranged in a follow-up. - Updates test paths in some profiles. Bug: 816462 Change-Id: I1b91168c5362fc6e059b2529dd4a1d8119f5dad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135059 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758443}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I802b01943d6c6a5a178c40f516ac367d43981c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145424 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Christian Biesinger authored
Change-Id: I5dbd39bf616354d715968b591912abbb427d5954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146214 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#758441}
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: I97258536ef73d8b714cd1ccbba6ab2fc20b7d23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132193Reviewed-by:
-
Koji Ishii authored
This patch removes unused function |NGBoxFragmentPainter:: PaintLineBoxItem|. This became unused when r731835 crrev.com/c/1994556 switched line box painter to |PaintBlockFlowContents|. Bug: 982194 Change-Id: I51f9f1661f2462c6faba55e646c251e9992ecc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143889 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I20ca170b3536309e887f97a50710e075cd1caaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142669 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Igor Makarov authored
- added .style.yapf file - reformat *.py files Bug: 1051750 Change-Id: I8288aa519ff5a4634728b16005d46377a7a2cdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141988Reviewed-by:
-
Timothy Gu authored
This reverts commit 103ac117. It appears that we were overly optimistic. There can be intermediate states where Element::GetIdAttribute() is called from Element::UpdateId(), which violates the DCHECK() put into place in the reverted commit. Original change's description: > Filter out empty ID in attribute changed callback > > Per spec [1], empty ID attributes must be treated identically as > nonexistent. This CL implements these steps faithfully, and results in > DocumentFragment::getElementById() always returning nullptr when the > empty string is given, thus fixing bug 1068580. > > Additionally, previously Document::getElementById() explicitly returned > nullptr when the empty string or the null string is given. The empty > string handling is no longer necessary after this CL, and thus removed. > (The null string handling is still necessary for internal C++ code that > relies on the short-circuiting behavior). > > [1]: https://dom.spec.whatwg.org/#concept-id > > Change-Id: Ia65024efef9e5ef54d9db233590a17b372282ed1 > Fixed: 1068580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140054 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757310} Fixed: 1069728 Change-Id: I70b2fd8d14456ec0b063cb18e5982384bd1285bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146924Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I95db56fa113354486742149024cd34173364eb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142074Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Ia981b9a58c02eff74658022b67e9113ee04fa9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146925Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758434}
-
- 12 Apr, 2020 1 commit
-
-
Anthony Fandrianto authored
Currently, a CIPD staging directory is populated by copying specified `sources` into it, and producing a .yaml manifest which reflects the copied files. This change refactors the template to invoke a pytho script to do the above instead of in GN, using the `yaml` library to write the file data in the proper format. Also make the license filepath explicitly passed through sources. Renames "archive" -> "package" and "manifest" -> "package definition" to be consistent with CIPD semantics (crbug.com/1042819#c8). Finally, have the script emit a depfile for all files tracked by the .yaml manifest. This refactor is desirable, as we want to create CIPD packages with more complicated rules than simply "copy and include these files" (see crrev.com/c/1925446, which extends the functionality of the template to allow for the inclusion of directories). Wriiting yamls with a library reduces the error-proneness of trying to recreate yaml's format in pure GN. Also, emitting a depfile ensure that we track and rebuild if the CIPD package is modified. Currently the potential danger of this change is limited in scope to fuchsia, as they are the only users of the template. I've checked locally that the produced CIPD packages for fuchsia are identical prior to this change. Bug: fuchsia:41443 Change-Id: If1b27d6a8fbbffdf767aaa4230bf7b527a553170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135186 Commit-Queue: Anthony Fandrianto <atyfto@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#758433}
-
