- 02 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/094f8e6f0c43..daabea6ba6c0 git log 094f8e6f0c43..daabea6ba6c0 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 thestig@chromium.org Use FX_AllocUninit() in FxAllocAllocator. 2020-04-02 thestig@chromium.org Mass rename "nameTree" variables. 2020-04-01 thestig@chromium.org Fix insertions into empty name trees. 2020-04-01 thestig@chromium.org Parse pdfium_tests's feature string in TestRunner. 2020-04-01 asweintraub@google.com Change for loops to use const refs where possible. Created with: gclient setdep -r src/third_party/pdfium@daabea6ba6c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie789a46175358410baad7265b6f6c48f8af3f2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756061}
-
Trent Begin authored
NetworkHealth now gathers a subeset the underlying network device's properties. Bug: chromium:1057739 Test: unit_tests --gtest_filter=NetworkHealthTest.* Change-Id: I69a9be3226ce515a049708357978e9d313e84c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133162 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756060}
-
Tom Anderson authored
BUG=1002674 Change-Id: Idf223f1193cbe1dde07901f5e28f1422b464cf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098159 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756059}
-
Jonah Chin authored
This change introduces the TextureBacking interface that will be used on PaintImage. This CL simply introduces the cc interface. Follow up changes will introduce the blink-side implementation. This is being done as part of the OOPR-Canvas2D project. For more info about the project see the tracking bug here: crbug.com/1018894 Bug: 1031050 Change-Id: I844c441bea308507a541fd3e131159f7c1d16b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131216Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756058}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/33cc65df59f1..cafccfd0e563 git log 33cc65df59f1..cafccfd0e563 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 michael.liao@microsoft.com [Elements - Styles Pane]: Adding SR announcement when adding a class successfully using '.cls' button Created with: gclient setdep -r src/third_party/devtools-frontend/src@cafccfd0e563 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066163 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2f7984d68c034fba4004ccd84b089231a9cdfa9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756057}
-
Istiaque Ahmed authored
This CL also makes its member to be stack allocated base::Value instead of dynamic allocated one. Bug: None Test: Minor cleanup, no behavior changes expected. Change-Id: I6b97497c43e7c37b6dd5481049834c3b54b9b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133207 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756056}
-
Paul Moy authored
Instead of having every unit test duplicate the code for creating its own RemoteCommandJob, move this code inside the test fixture so the logic is only needed a single time. This also lets the fixture's methods access the job without specifically being passed the job as an argument. Bug: chromium:1066251 Change-Id: I2d31ba0b77246d16ee41cad6e4b0e154c716d1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131326Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756055}
-
evliu authored
This CL contains the renderer-side changes for the Live Caption feature. The design document can be found at: go/chrome-live-caption. Bug: 1065563 Change-Id: I8a50e2afe4b13cc88b122a18e23c2275ace527d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127419Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#756054}
-
Hesen Zhang authored
This reverts commit 0a948617. Reason for revert: Issue 1067443: Step "snapshot_unittests" failing on 1 builder(s) Original change's description: > Add EDU login flow: CSS fixes > > Address comments to UI implementation - update margins and logo size. > New screenshots: > http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI > > Bug: 1054798 > Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756012} TBR=xiyuan@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Change-Id: I81184b3bf1adf68915934cd353f9617b58268265 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135023Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756053}
-
Alex Danilo authored
Bug: 960277 Tests: browser_tests --gtest_filter="*openQuickViewMhtml*" Change-Id: I8be8483e6b5dd6e3e99701bfc14551262c782090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131822Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756052}
-
Timothy Loh authored
This CL wires up the toggle in settings for controlling printer access from Plugin VM to a new pref plugin_vm.printers_allowed. When this or the PrintingEnabled policy is set to false, the CUPS proxy will return a 401 forbidden error to every request. Bug: 950431 Change-Id: I14c395b53ea11bcb9c438266e36aa21e6fcd85b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120110 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#756051}
-
Meredith Lane authored
This reverts commit 402af855. Reason for revert: Causes blink_web_tests to deterministically fail on Linux, first failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87941 Original change's description: > Remove more passing WPT tests > > Remove more tests that are passing consistently. > > BUG=626703 > > Change-Id: I65d54aebe19c4ee6aa5177eb63318ed3810d428c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127514 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755829} TBR=dtapuska@chromium.org,robertma@chromium.org Change-Id: I06631b9d4e4a4f21eb7d27600398343a661078e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 626703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134747Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756050}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/486655782f8b..f175adffa9d2 git log 486655782f8b..f175adffa9d2 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 rharrison@google.com Add flag to control if we build with -Werror (#1032) Created with: gclient setdep -r src/third_party/shaderc/src@f175adffa9d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I99d2e11b152896bc312e181888848feca760a189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756049}
-
Nathan Zabriskie authored
To support RasterImplementation on the shared main thread context we need to remove all references to ContextGL on that context. This CL prepares to fully disable ContextGL() on the shared context. A follow up CL will change |support_gles2_interface| = false which will actually disable it. New requisite API's should be added to RasterInterface instead of GLES2Interface. During the transition to OOPR canvas we will support RasterImplementationGLES but that class will be deprecated once we fully transition to RasterImplementation at which point ContextGL and GRContext will no longer be accessible on the shared main thread context. Bug: 1018898 Change-Id: I85b2bc50c937d715a248a0c451278624f8d3e7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116782Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756048}
-
Pete Lavallee authored
Next step for implementing use of the Windows.Devices.Geolocation WinRT API, this CL: - Adds check in NewSystemLocationProvider in location_provider_winrt. If winrt geolocation api access is disallowed, based on windows location privacy settings, nullptr is returned, allowing a network_location_provider to be created instead. - Falling back to the network_location_provider prevents users from having a poor experience when the winrt geolocation api provider is enabled and the windows location settings are set to disallowed. To allow the location_provider_winrt to function correctly users would need to go to the windows location settings and allow the right set of permissions, disrupting the user's activity. Falling back to the current provider implementation allows for access to more accurate location information, from attached devices, when os location access is allowed and the same experience as pre-feature otherwise. Bug: 968883 Change-Id: Ibced39692831eb066fb59113d7aa9e1734245394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132287Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Peter Lavallee <pelavall@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756047}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to percentage-margins-001.html. Bug: 1063749 Change-Id: Ifc02d816b56a10af310a367c4e2fc9c5b933e15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134166 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756046}
-
Elly Fong-Jones authored
These two properties are tricky to understand and it's not clear when or how to use them. Try to rectify this. Bug: 1057758 Change-Id: I857e429cacd865b2eae6b3c6803785faabbcf92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134697 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756045}
-
Christian Biesinger authored
Currently, IntrinsicSize() returns both the intrinsic size and the aspect ratio. This patch splits the aspect ratio part out, in preparation for implementing the CSS aspect-ratio property. R=ikilpatrick@chromium.org Bug: 1045668 Change-Id: I7d41ee4556a98122c2c4e6b4e875e20442ed7aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130684 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756044}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0774188da4bb..c05b610125a0 git log 0774188da4bb..c05b610125a0 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 capn@google.com Fix GN build 2020-04-02 bclayton@google.com Reactor: Fix remove_if brokenness 2020-04-02 capn@google.com Remove the sw::Color<> class 2020-04-02 bclayton@google.com Change for loops to use const refs, per performance-for-range-copy clang-tidy. Created with: gclient setdep -r src/third_party/swiftshader@c05b610125a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I59cb2fcb9719a718c33f707d9b71ac5e9152c18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756043}
-
James Cook authored
Test that if a child account attempts to enable an extension then the parent permission dialog opens. This is a unit test because there are existing browser tests that exercise the JS/C++ communication for the management API. Bug: 1059999 Test: added to unit_tests Change-Id: I7604d4805f23637a3eb862b1b3a5874f7fcbbb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129032 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#756042}
-
Samuel Huang authored
This CL fixes how org.chromium.base.FileUtils.getExtension() treats periods in paths. Also add test for getExtension(). Bug: 1067272, 1066730 Change-Id: I07d85727da90d508d69aa8a6ef026aabbdf19aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134577 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#756041}
-
Lei Zhang authored
Change-Id: I2aca9cbdd3df2efd0e2a5c9316cc121f345ce06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133230Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756040}
-
zhaoyangli authored
This test suite sometimes hits 1hr and makes ios-simulator-noncq builder fail with timeout. This change makes the suite run in 2 shards and will accelerate the suite. Bug: 1046369 Change-Id: I1b8a8c99cfd1c78fdc88750d2952a335c8951ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129228Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#756039}
-
Aaron Krajeski authored
We currently test toblob, but only on the main thread. It looks as though we can be at the mercy of the scheduler here, so it would be worthwhile to at least keep track of it. See: crbug.com/1053477 Bug: 1065481 Change-Id: I42ee1f9ae20dbedea45952e7a79ada10d7f9b19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124971Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756038}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1f2ca5baeb7d1cb29e5c203cf106199d1d084feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756037}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to percentage-heights-012.html. Bug: 1063749 Change-Id: I8eb11207d1645bb4931f380dda29bddc4fae4879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133988 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756036}
-
Livvie Lin authored
Use the same OWNERS as ios/chrome/browser/interstitials, since that code will be moved in to this component. Bug: 1064382 Change-Id: I8a1aaee104b951edb052b5ce202e70cfd9654ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133208Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756035}
-
Sadrul Habib Chowdhury authored
The events-metrics passed down from the main-thread should only be handled after the main-thread updates become active (i.e. after the pending-tree becomes active). So instead of pushing down the metrics directly to LayerTreeHostImpl, push it down to the pending LayerTreeImpl. BUG=1059282 Change-Id: I572bafaea213e5121504bf2f2bc6875f2af04587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134857Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#756034}
-
Peter Wen authored
Previously, turbine ran annotation processors, javac ran them, and errorprone also ran them. This CL reuses the files that were generated when turbine ran annotation processors so that javac and errorprone no longer ran annotation processors. Saves 4.6s on Base Java Signature Change (153.6s -> 149.0s). More importantly unlocks javac sharding (since javac now depends on turbine). Bug: 906803 Change-Id: Ia8d7218587244d2f5908a5555a13dff3ed781507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133870 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756033}
-
Greg Guterman authored
Different configs for branches are handled by the git branches themselves, so branch-specific config keys are not needed. Bug: 1062141 Change-Id: I82832cda02ab798afb77fb26d973f001c53c4bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133078Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#756032}
-
Tim Song authored
This reverts commit c939527d. Reason for revert: regressed crbug.com/1065739 Original change's description: > Fixed Bubbles not tracking the NativeTheme of their anchoring Widget > > Currently child windows do not track the themes of their anchoring > widget. This can lead to theme mismatches in spawned bubbles (in > particular icons relying on native theme colors in the profile menu > for linux themes). > > This change follows on from a previous change that fixes the issue > for ThemeProviders in Bubbles. Follow up CLs should address the > issue for the more general case of widgets tracking the themes of > the Widgets that spawned them (see https://crbug.com/948859). > > Bug: 1057962 > Change-Id: Ie3a71208cb920e8bced6a8bb2f42968bad46f403 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121075 > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753398} TBR=pkasting@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057962 Change-Id: I16a9cae400f47ba2f5172637b8aefaea74050b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131214Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756031}
-
David Bertoni authored
One of the tests in this suite is flaky, so this CL splits them up into two different C++ test fixtures, in case the flaky one needs to be disabled. It's currently flaking at about 0.1% in the worst case, so hopefully, this won't affect too many builds. Bug: 1056853 Change-Id: Id7bb0342cbb0b67b61f3bea01fc38601f80ec3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128466Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756030}
-
Bruce Dawson authored
When SystemSessionAnalyzerTest.ValidateEvents fails we just know that FAILED was returned which is too vague. This adds more specific error codes to zero in on the problem. Bug: 968440 Change-Id: I50b4667536ed5082e6f2f9f91b25384dbe80b526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132785Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#756029}
-
John Z Wu authored
- This avoids rebuilding the same sources for the framework and test. - Created a stub implementation of ios_web_view::InitializeGlobalState to avoid multiple AtExitManagers in unit tests. Change-Id: Ia1a839f2be06d8a9e2974d2e8edb9cf399e849cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121035 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#756028}
-
Jeffrey Cohen authored
Bug: 1036023 Change-Id: I0a764b488a5c52245ee1e7e7e76e48c63e8f879e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129896Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756027}
-
Matthew Jones authored
This reverts commit 5644e0dd. Reason for revert: Causing crashes in multiwindow. Original change's description: > Remove TabImpl and #getActivity from ReaderModeInfoBar > > Instead of accessing the ReaderModeManager via Tab and ChromeActivity, > a reference to the manager is passed to the native infobar when it is > created and pulled back up to java when needed. This also allowed for > the removal of the GetTab native method. > > Bug: 952703 > Change-Id: Iaacbbda08e28d013538d44c9b985020c175de1be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122471 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Auto-Submit: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754230} TBR=mdjones@chromium.org,wychen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 952703, 1067178, 1067134 Change-Id: Icf33e494eaeff4e3d0b6617aa0a5eb4222c41a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134859Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756026}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If some c++ code called the route '/search', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route SEARCH, which is shared with browser routes to a more distinguishable name OS_SEARCH. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: I9f87f1d3d289c4dc31847cbab4c83e90cb47c16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128092 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756025}
-
Ahmed Mehfooz authored
Bug: 1066914 Change-Id: I9b9b0251f296a196271c715792d1c4da0c2120db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134928Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756024}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de6fa1ef2946..04c1b445019e git log de6fa1ef2946..04c1b445019e --date=short --first-parent --format='%ad %ae %s' 2020-04-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b2379606..b0ab5b8b (755766:755896) Created with: gclient setdep -r src/third_party/webrtc@04c1b445019e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie3572603b991cca5d489ac390868663081d391a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134946Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756023}
-
Jeffrey Cohen authored
screenshot with new icon https://hsv.googleplex.com/6487380976467968 Bug: 1067090 Change-Id: I8eac773b990d99cf45855d37d526b3a7df7ab8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134578Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756022}
-