- 25 Jun, 2020 40 commits
-
-
Marc Treib authored
This introduces the histogram PasswordManager.MoveUIDismissalReason, similar to the existing ones for Save/Update. Like the Save one, it is also split by PasswordAccountStorageUserState. Bug: 1063852 Change-Id: I06a7c4e6522362a37b6092964f151eafd2f5d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263815 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#782732}
-
Kevin Babbitt authored
This CL was split off from crrev.com/c/2253198. Convert the following properties to use StyleColor instead of Color in preparation for making system color keywords compute to themselves: border-*-color outline-color column-rule-color -webkit-text-emphasis-color -webkit-text-fill-color -webkit-text-stroke-color -internal-visited-text-emphasis-color -internal-visited-text-fill-color -internal-visited-text-stroke-color Bug: 1081945 Change-Id: I138545a294403019c2adfc6e292d2d18b0d8b0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261190 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#782731}
-
Evan Stade authored
Bug: 1066263 Change-Id: I4d59865d6595132896afc7c5db9fbd71d2d8a18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268213 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#782730}
-
Steven Bennetts authored
Bug: 1093135 Change-Id: Icaad5228194d5e55616f009c837df4ccfe7fca43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267745 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782729}
-
Samuel Huang authored
Previously we added a script write_ssargs.py to write .ssargs files for SuperSize. To simplify things, this CL removes the script, and use GN write_file() command instead. As a result .ssargs files are created on "gn gen", instead of during build. Bug: 1040645 Change-Id: I147480817d1c3036780d5496cc30fd2d4c8b9fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267337 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#782728}
-
Mohamed Amir Yosef authored
Bug: 1030649 Change-Id: Ie023fa418634466ad9bb40d659c02b8562840c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249743 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
James Cook authored
To be used as owners for foo_lacros.{h|cc} files. Bug: none Change-Id: I6ec44e8de77659ffc4c2e47094a4af0e526b4a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268178 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782726}
-
Bo Liu authored
There is legitimate case where a quad area can be larger than the limits of int32_t (see bug). Go over all calls to gfx::Size::GetArea under viz. Handle overflow / underflow where it makes sense. Or keeping calling GetArea where a crash makes sense. Then remove the deserialization check that quad size does not overflow. Bug: 1067654 Change-Id: I00e11a753a299bc22a70a1b1891d6d5e348a0d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254531Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782725}
-
Guillaume Jenkins authored
Adds an experimental setting in the debug section that sets values for a few select policies when enabled. This is needed for manual testing of the policy infrastructure. The following policies are set: - AutofillCreditCardEnabled: NO - ChromeVariations: 2 - DefaultPopupsSetting: 2 - DefaultSearchProviderEnabled: YES - DefaultSearchProviderSearchURL: http://www.google.com/?q={searchTerms} - DefaultSearchProviderKeyword: google - PasswordManagerEnabled: NO Change-Id: I736df2215b0f0e47e90571698774a024fc8e828c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261223 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782724}
-
Sinan Sahin authored
Currently, native pages aren't animated during browser controls height change animations. We change the margins to account for the change in browser controls for these surfaces. This CL adds browser controls animations for the NTP. As changing the margins in every animation frame would cause a relayout and be expensive, we use the translationY property to animate the page. The margins are applied only once at the start or end of the animation. Bug: 1075640 Change-Id: Ia376d3130f9c89210b64dec9c682138f08357f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261108Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#782723}
-
John Delaney authored
What: Do not run the SF filter in DryRun mode on pages where the content setting is set to allow. How: Delete the ongoing activation throttle for the navigation when we receive an explicit disabled activation state. Currently we ignore disabled activation states when we receive them, as normally the SF filter is running in DryRun mode anyway. Change-Id: Ibc5202ec5f68bd284987cdd4d5dfa0e8de0708a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218371Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782722}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30f774ef87bc..0bfbd890c3e2 2020-06-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib38063528ec32219a345554e62bc1e4b1b4fc884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782721}
-
Patrick Noland authored
TBR=yusufo@chromium.org, yuezhanggg@chromium.org Bug: 1094998 Change-Id: I46bf61c10ea915eeff94ba58bf4f9aa501d3087d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268204Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782720}
-
Hesen Zhang authored
Bug: 1066556 Change-Id: Iefc809b03e76f6ccf579a9d1dec77118d4690fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261897 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782719}
-
My Nguyen authored
This is preparation step to add tap/click ability to accept suggestion. Bug: 1098057 Change-Id: Ided9d81d99ca33b6d95a649b7545e238c0f4c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257657Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782718}
-
Sammie Quon authored
This reverts commit a84e8b68. Reason for revert: UI review thumbs down this change. We sent a rebuttal, but i will first revert before branch. If we get permission then its ok to punt to M86. Original change's description: > wm: Add display settings shortcut in context menu. > > Details/mocks are linked in the linked bug. > > Test: manual > Bug: 1095140 > Change-Id: Ic8dc25d686355b80dc5f537eda67836e6c97f172 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225978 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778590} TBR=xiyuan@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1095140 Change-Id: I1d065a7d798e73a6151282d58d0843101d019ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268120Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#782717}
-
Johannes Henkel authored
Change-Id: I2e817334fb9b8988dacbd21b531090dd4574359d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265353Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#782716}
-
Stephen McGruer authored
Bug: 1095643 Change-Id: Ibbe7862d6ded259612c795c9933d3b2a7bd7aef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264861 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#782715}
-
Ahmed Mehfooz authored
Bug: 1084664 Change-Id: If89bc49be2d03710fe29d87675dbed3851dd84c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209396Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782714}
-
Varun Khaneja authored
Fixed: 1089438,1097931,1097932,1097933,1097934,1097936 Change-Id: I470985b8b3f26d183a5924ef377ee6e3e83a9e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261952 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Himanshu Jaju authored
Implements the HTTP APIs for Tachyon Express to send and receive messages between devices. Tachyon would be used as the signaling channel for webrtc messages in Chrome Sharing. The actual mojo implementation and tying it to the utility process is upcoming in the next CL. Bug: 1082305 Change-Id: I62e1c3a2deb8a6ef376e474b5ce353a3cb863232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250061 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#782712}
-
George Burgess IV authored
The intended fix for this is https://reviews.llvm.org/D77421, which is now a part of both the CrOS and Chromium toolchains. Removing this should now be safe. Bug: 1062006 Change-Id: I1557aa18898966c14aafd53b64027e61b0afb5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267452Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#782711}
-
Andrew Grieve authored
E.g.: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/884 Regressed in 71bd025e Bug: 1078460 Change-Id: I6b265fa7f542964c685bf18556f112ac491cbc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268399Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#782710}
-
John Delaney authored
What: Create a PageTimingSender for frames that abort their initial navigation with a doc.write to render content. This is done by observing document element without a committed load. Why: This behavior has been seen numerous times in the wild causing, where PLM byte metrics are not catching the majority of network usage by the page. In a number of instances, there are video players loaded inside of these frames causing most network bytes to be unattributed to the PageLoad. This also affects the HeavyAdIntervention, which uses PLM measurements to trigger unloading. How: For these types of loads, we will not send paint timing, render data, or metadata updates to the browser process. There is currently a lack of understanding regarding paint timing in frames like this. There is also no browser process machinery to merge timing updates in frames that do not have loads (as we cannot get a navigation start offset). It is unclear the effect that this change will have overall on metrics. Anecdotally, it is not expected to not produce a significant change due to being a fairly nuanced edge case. Bug: 914893 Change-Id: Ic696e693e11f2d7cdcd8c97e9418a55d7bf4b2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822218Reviewed-by:
-
Chris Mumford authored
Disabling flaky test: DemoSetupArcSupportedTest.ShowOfflineSetupOptionOnNetworkList Bug: 1099402 Change-Id: I5f8dc26198f3e6fb0e3a7f4f0da4c69e2f93a5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268297Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#782708}
-
Sammie Quon authored
This is a heavy animation as it basically calls into UpdateResize which resizes both windows (or one window and overview). Also, changes the animation to use a runner which is synced with the compositor. Test: none, will update tast-tests Bug: 1047495 Change-Id: Ic29eb0dd831e7bbc5115268f8c09718b6fc82796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254820Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#782707}
-
Swapnil authored
ExtensionInstallEventLogManagerWrapper class observes the pref that indicates whether to log events for extensions. If the event logging is enabled, it creates an |ExtensionInstallEventLogManager|. ExtensionInstallEventLoggingEnabled policy is added which allows the user to opt in or out of event based reporting. Bug: 1092840 Change-Id: I98659c9092b4e3c1c8d9fbab612c72477dd8a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249779Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#782706}
-
Dana Fried authored
Only occurs when the "enable new badges" flag is enabled. Bug: 1098731 Change-Id: I75bb992c7f4d50c7c2bdac506782133e86a95fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264253 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782705}
-
Andres Calderon Jaramillo authored
Fixes for reland (see changes since PS1): 1) PlatformVideoFramePool used DmabufVideoFramePool::GetDmabufId() to track video frames in use, but this is no longer applicable since now the video frames are GpuMemoryBuffer-backed (instead of dma-buf-backed). Therefore, we use the GpuMemoryBuffer ID instead. 2) Because PlatformVideoFramePool now uses GpuMemoryBuffer IDs, the unit tests are adapted to use GpuMemoryBuffer VideoFrames. We use FakeGpuMemoryBuffer for this purpose. However, it was necessary to adapt FakeGpuMemoryBuffer to handle more buffer formats. Instead of adding special cases for the new formats, we use VideoFrame's static methods to make FakeGpuMemoryBuffer more general. 3) V4L2WritableBufferRef::QueueDMABuf() is adapted to handle GpuMemoryBuffer video frames. 4) We allow creating a V4L2ImageProcessorBackend that uses GpuMemoryBuffer video frames for output. This is needed to avoid problems in kukui (and likely other MediaTek devices). Original change description: > In the newly introduced VideoDecoder, we create a native buffer for > video decoding on demand in the PlatformVideoFramePool. This buffer > eventually makes it to the MailboxVideoFrameConverter in order to > produce a SharedImage for the client. > > This CL ensures that the NativePixmap created in the > PlatformVideoFramePool can be re-used in the > MailboxVideoFrameConverter. Before this CL, we would call > CreateNativePixmapFromHandle() unnecessarily when creating the > SharedImage for a buffer. That's because we didn't propagate the > GpuMemoryBufferId correctly from the PlatformVideoFramePool to the > MailboxVideoFrameConverter and the check in [1] would fail. As a > result, we would end up creating an additional DRM framebuffer which > is unnecessary because the allocation in the PlatformVideoFramePool > would have already created one. Thus, the video.MemCheck.h264_hw > test would fail because of having created too many objects. > > To propagate the GpuMemoryBufferId correctly, we create a > GpuMemoryBuffer VideoFrame in the PlatformVideoFramePool (instead of a > dma-buf VideoFrame). That way, when MailboxVideoFrameConverter calls > CreateGpuMemoryBufferHandle(), it gets a GpuMemoryBufferHandle with > the same ID that PlatformVideoFramePool gets. Additionally, we make > MailboxVideoFrameConverter use kPlatformVideoFramePoolClientId since > that identifies the namespace of the GpuMemoryBufferIds in question. > > Note that for SCANOUT_VDA_WRITE buffers (which we use for video > decoding), we end up creating a ClientNativePixmapOpaque when creating > a GpuMemoryBufferImplNativePixmap. This is problematic because a > ClientNativePixmapOpaque doesn't let us query the stride and we need > to know it in order to create a GpuMemoryBuffer VideoFrame. Therefore, > GpuMemoryBufferImplNativePixmap::stride() is changed so that it's not > necessary to have a gfx::ClientNativePixmap to query the stride. > Instead, we query the underlying NativePixmapHandle directly. > > For that same reason, we must introduce a workaround in the > VideoFrameValidator: when we get a GMB VideoFrame, we cannot map it > directly because ClientNativePixmapOpaque doesn't allow us to. > Therefore, we extract the dma-buf FDs and use the regular dma-buf > mapping path. > > [1] https://cs.chromium.org/chromium/src/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc?l=152&rcl=d96e9f16ae852ec9dbd15bf17df3d440402413bb > > Bug: 1091450, 1093644 > Test: video.MemCheck.h264_hw_switch, video.DecodeAccelVD.h264 on eve > Change-Id: I3d60efa362b66bd2f01139296d4ed756c8777ef8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233534 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780504} Bug: 1091450, 1093644, 1097755, b:159589162 Test: video_decode_accelerator_tests --use_vd on kevin/kukui w/ DCHECKs Change-Id: Id12e318adee090b6969748e7df33070b80a0c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258252 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#782704}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: I0a40c29081459e3308e07f17c22968ac9f913c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267412Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#782703}
-
Xiaocheng Hu authored
In previous study, we found out that: - The "failure" mode of this intervention breaks icon fonts massively - Icon fonts generally define almost all of their glyphs in Private Use Area, while non-icon fonts don't use PUA that much Hence, this patch adds a heuristic to decide whether a font is an icon font by checking its PUA usage, and use that as a hint to decide whether AlignFontDisplayAutoTimeoutWithLCPGoal should move a font into the failure display period. As a result: - Non-icon fonts that don't finish loading fast enough after navigation will end up with fallback - Icon fonts will have the same behavior as before Bug: 1065508 Change-Id: I54e52e714a74c17b647d8b072d2f634660e56627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261898Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#782702}
-
Mirko Bonadei authored
This is a reland of 5906c258 This CL adds .def files for release builds (and changes the generator script to generate them at roll time). The issue was that release component builds (is_debug=false) were trying to link symbols that were not available in release mode .obj files. Original change's description: > Abseil component build (default symbols visibility). > > This CL introduces an Abseil component on which all Chromium Abseil > clients will have to depend on. > > Abseil doesn't export symbols explicitly, so for the moment Chromium > exports all of them when is_component_build=true. On Android, Linux and > Mac -fvisibility=default is used while on Windows a .def file is > generated at Abseil roll time. > > Bug: 1046390 > Change-Id: I1697eb9e0179cee01badcf1b687acd94160e5f6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174434 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781225} Bug: 1046390 Change-Id: Ieb48ec9eff6d08a0770c4b22521536bb29a76121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264062 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782701}
-
Rachel Wong authored
This CL addresses a bug where suggested_content_info_view_ might still be visible if assistant_privacy_info_view_ exists, due to its SetVisibility not being explicitly configured. Bug: 1079169 Change-Id: Ifacc5291da2a09af6a6620ae0ed5693dacdc4c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259421 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 1098711 Change-Id: I410ca6745c858286a5b828464049c5168ed32bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268262Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782699}
-
Andre Le authored
BUG=1093614 Change-Id: Ie5a368ff723970b10527d9249f6bc490d7ba1b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261852Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#782698}
-
dpapad authored
Shows a dummy (empty) new toolbar UI element when --enable-features=PDFViewerUpdate is specified. Decided to use a completely new element, since it will significantly diverge from the existing UI (sidenav button, different zoom controls + buttons, overflow menu) Bug: 1098124 Change-Id: I03db34b48d5e6d1f4aed051ff8ec10dfc7b50a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258966Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#782697}
-
Alex Ilin authored
The reauth dialog communicates with Gaia in background, and then in foreground. Some UI interactions are blocked until the first navigation to the Gaia reauth endpoint is completed. This CL adds two duration histograms that will help us understand delays that users may experience in the reauth dialog. Bug: 1045515 Change-Id: Ibc7ddfee24b2ff0b7c3e8f591c76dc341cd0df54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266554 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Design doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing Before change screenshot: https://drive.google.com/a/google.com/file/d/15sHXrBgFOUAT5p2gccLHfIyP5ELYRsXV/view?usp=sharing After change screnshots: https://drive.google.com/drive/folders/1UBj97q3vl5fYCFwtNUjju6Z_fJcwKIEd?usp=sharing Change-Id: Ic2f5c19562a010bbce9fbf8e313a9fe6f9181745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880994 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#782695}
-
Mila Green authored
Bug: 1020650 Change-Id: I269a3b5edf8c66f5c91dda8ddab33794b9827bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268219Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1098414 Change-Id: I52c4554448f932c73148b7f52ddb04cc14ba7081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268400 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#782693}
-
